Re: [VOTE] Release Apache Maven 4.0.0-alpha-5

[Petr Široký]

+1 (non-binding)

Smoke tested on Linux with JDK 19 and 20 (EA build) and looks good.


--- Original Message ---
On Wednesday, March 15th, 2023 at 18:14, Guillaume Nodet  
wrote:


> 
> 
> Hey
> 
> We solved 26 issues:
> 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12352862=12316922
> 
> Staging repository:
> https://repository.apache.org/content/repositories/maven-1890
> 
> Dev dist directory:
> https://dist.apache.org/repos/dist/dev/maven/maven-4/4.0.0-alpha-5/
> 
> Staged site:
> https://maven.apache.org/ref/4-LATEST/
> 
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Please review and vote !
> 
> Cheers,
> Guillaume Nodet

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

MCOMPILER-391 - request for review (using dependency management for annotationProcessorPaths)

[Petr Široký]

Hello everyone,

some time ago I started looking into 
https://issues.apache.org/jira/browse/MCOMPILER-391 - which basically requests 
that maven-compiler-plugin and its 'annotationProcessorPaths' configuration 
should follow dependencyManagement (if specified), instead of requiring 
explicit versions to be set for each path.

I am proposing a solution as part of 
https://github.com/apache/maven-compiler-plugin/pull/180 and I would like to 
ask if someone could take a look and review those changes. There are some 
potential downsides listed in the PR as inline comments and those are 
definitely up for discussion.

I definitely don't want to forcefully push the PR or anything, but it has been 
there for two weeks now and I believe the feature is important enough to get 
some more attention and possibly more discussion.

Thanks,
Petr

Re: [VOTE] Release Apache Maven Surefire/Failsafe Plugin version 3.0.0

[Petr Široký]

+1 (non-binding)

Tested on several projects on Linux with JDK 19. No issue found.


--- Original Message ---
On Saturday, March 11th, 2023 at 10:08, Slawomir Jaranowski 
 wrote:


> 
> 
> Hi,
> 
> We solved 6 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12352998
> 
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project %3D SUREFIRE AND 
> resolution %3D Unresolved ORDER BY key DESC
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1886/
> https://repository.apache.org/content/repositories/maven-1886/org/apache/maven/surefire/surefire/3.0.0/surefire-3.0.0-source-release.zip
> 
> Source release checksum(s):
> surefire-3.0.0-source-release.zip - SHA-512 :
> 230fc6edc85d4c2f868c1044d545f07ec1435aed320959262c1fc855b5ef80dbd2f1f20dc6c6137664028d6049f950d75d10f8abe5f2f8f506c946459621c043
> 
> Staging site:
> https://maven.apache.org/surefire-archives/surefire-LATEST/
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for at least 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> --
> Sławomir Jaranowski

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven version 3.8.8

[Petr Široký]

+1 (non-binding)

Tested using several projects on Linux with JDK 17 and 19. No issue found.

--- Original Message ---
On Wednesday, March 8th, 2023 at 16:12, Michael Osipov  
wrote:


> 
> 
> Hi,
> 
> We solved 17 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12352869
> 
> There are still hundreds of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project %3D MNG AND resolution %3D 
> Unresolved
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1884/
> 
> Dev dist directory:
> https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.8/
> 
> Source release checksums:
> apache-maven-3.8.8-src.zip sha512:
> 4723b1d6fdc39603b6453944fe0bf7bb5d2e4e50904aa977b28238d225d33bb3b44c5935dec5b7ac2a8f7acdd0d1cc01da25020163255f273a9937753cb117c4
> apache-maven-3.8.8-src.tar.gz sha512:
> b65419c7e991460aeeab70645009148e9e8b8eb00be80d9cfd60e8a9941e057a6df1f0c3b9f2f2921a6d2b5d0d21563345f0f217c2a097e1ee3a30cd773aa2db
> 
> Binary release checksums:
> apache-maven-3.8.8-bin.zip sha512:
> aa7d431c07714c410e53502b630f91fc22d2664d5974a413471a2bd4fca9c31f98fbc397d613b7c3e31d3615a9f18487867975b1332462baf7d6ca58ef3628f9
> apache-maven-3.8.8-bin.tar.gz sha512:
> 332088670d14fa9ff346e6858ca0acca304666596fec86eea89253bd496d3c90deae2be5091be199f48e09d46cec817c6419d5161fb4ee37871503f472765d00
> 
> Draft for release notes:
> https://github.com/apache/maven-site/pull/395
> 
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open until 2023-03-14T12:00Z
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release maven-compiler-plugin 3.11.0

[Petr Široký]

I am not seeing that directory in the tag, nor in the source release zip.

When I run

git clone g...@github.com:apache/maven-compiler-plugin.git --branch 
maven-compiler-plugin-3.11.0 && find maven-compiler-plugin -name 
"*MCOMPILER-517*"

It does not return anything.

I am not sure where is it coming from in your case.


Petr

--- Original Message ---
On Wednesday, February 15th, 2023 at 12:46, Olivier Lamy  
wrote:


> 
> 
> So it looks this directory is not part of source release zip? whereas
> it's in the tag?
> 
> wget 
> https://repository.apache.org/content/repositories/maven-1873/org/apache/maven/plugins/maven-compiler-plugin/3.11.0/maven-compiler-plugin-3.11.0-source-release.zip
> && unzip -l maven-compiler-plugin-3.11.0-source-release.zip | grep
> MCOMPILER-517-install-not-recompile
> nothing
> 
> I didn’t check the rest of the source-release.zip vs the tag but this
> doesn’t look similar at least for this directory.
> I just wonder if there are other differences?
> 
> 
> 
> 
> 
> On Wed, 15 Feb 2023 at 21:36, Petr Široký petr.sir...@proton.me.invalid wrote:
> 
> > The failed IT is 'src/it/MCOMPILER-517-install-not-recompile', which I am 
> > not seeing in the git repo 
> > (https://github.com/apache/maven-compiler-plugin/tree/maven-compiler-plugin-3.11.0/src/it).
> >  Is it possible you have this IT only locally (and thus not re-formatted 
> > yet)?
> > 
> > Thanks,
> > Petr
> > 
> > --- Original Message ---
> > On Wednesday, February 15th, 2023 at 12:18, Olivier Lamy ol...@apache.org 
> > wrote:
> > 
> > > +1
> > > Any idea why building from the tag I got this issue:
> > > https://gist.github.com/olamy/4c5ef44755f2d99f96c533de1121dce1
> > > whereas building from the source.zip it's fine?
> > > 
> > > On Tue, 14 Feb 2023 at 18:51, Guillaume Nodet gno...@apache.org wrote:
> > > 
> > > > Hi,
> > > > I'd like to release Apache Maven Compiler Plugin 3.11.0
> > > > 
> > > > 7 issues fixed
> > > > https://issues.apache.org/jira/projects/MCOMPILER/versions/12351444
> > > > 
> > > > draft github release notes (sadly only for people with write access as 
> > > > it's
> > > > a draft:() :
> > > > https://github.com/apache/maven-compiler-plugin/releases/tag/untagged-0ec6b3d056333c4a2ed0
> > > > 
> > > > staging repo 
> > > > https://repository.apache.org/content/repositories/maven-1873/
> > > > artifacts here
> > > > https://repository.apache.org/content/repositories/maven-1873/org/apache/maven/plugins/maven-compiler-plugin/3.11.0/
> > > > 
> > > > staging site
> > > > https://maven.apache.org/plugins-archives/maven-compiler-plugin-LATEST/
> > > > 
> > > > Vote open for 72H
> > > > 
> > > > --
> > > > 
> > > > Guillaume Nodet
> > > 
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
> > 
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release maven-compiler-plugin 3.11.0

[Petr Široký]

The failed IT is 'src/it/MCOMPILER-517-install-not-recompile', which I am not 
seeing in the git repo 
(https://github.com/apache/maven-compiler-plugin/tree/maven-compiler-plugin-3.11.0/src/it).
 Is it possible you have this IT only locally (and thus not re-formatted yet)?

Thanks,
Petr

--- Original Message ---
On Wednesday, February 15th, 2023 at 12:18, Olivier Lamy  
wrote:


> 
> 
> +1
> Any idea why building from the tag I got this issue:
> https://gist.github.com/olamy/4c5ef44755f2d99f96c533de1121dce1
> whereas building from the source.zip it's fine?
> 
> 
> 
> 
> 
> On Tue, 14 Feb 2023 at 18:51, Guillaume Nodet gno...@apache.org wrote:
> 
> > Hi,
> > I'd like to release Apache Maven Compiler Plugin 3.11.0
> > 
> > 7 issues fixed
> > https://issues.apache.org/jira/projects/MCOMPILER/versions/12351444
> > 
> > draft github release notes (sadly only for people with write access as it's
> > a draft:() :
> > https://github.com/apache/maven-compiler-plugin/releases/tag/untagged-0ec6b3d056333c4a2ed0
> > 
> > staging repo https://repository.apache.org/content/repositories/maven-1873/
> > artifacts here
> > https://repository.apache.org/content/repositories/maven-1873/org/apache/maven/plugins/maven-compiler-plugin/3.11.0/
> > 
> > staging site
> > https://maven.apache.org/plugins-archives/maven-compiler-plugin-LATEST/
> > 
> > Vote open for 72H
> > 
> > --
> > 
> > Guillaume Nodet
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release maven-compiler-plugin 3.11.0

[Petr Široký]

+1 (non-binding)

Tested on several projects (on Linux and JDK 19.0.2). No issue found.

Petr

--- Original Message ---
On Tuesday, February 14th, 2023 at 09:51, Guillaume Nodet  
wrote:


> 
> 
> Hi,
> I'd like to release Apache Maven Compiler Plugin 3.11.0
> 
> 7 issues fixed
> https://issues.apache.org/jira/projects/MCOMPILER/versions/12351444
> 
> draft github release notes (sadly only for people with write access as it's
> a draft:() :
> https://github.com/apache/maven-compiler-plugin/releases/tag/untagged-0ec6b3d056333c4a2ed0
> 
> 
> staging repo https://repository.apache.org/content/repositories/maven-1873/
> artifacts here
> https://repository.apache.org/content/repositories/maven-1873/org/apache/maven/plugins/maven-compiler-plugin/3.11.0/
> 
> staging site
> https://maven.apache.org/plugins-archives/maven-compiler-plugin-LATEST/
> 
> Vote open for 72H
> 
> 
> --
> 
> Guillaume Nodet

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Bug report - maven shade plugin - transitive dependencies of provided dependency included in uber-jar

[Petr Široký]

Hello,

I took a quick look at the reproducing project you linked 
(https://github.com/cerveada/shade-plugin-issue) and I think the reason for the 
behavior you are seeing is the content of  section in the 
bundle/pom.xml:


  

  org.apache.spark
  spark-core_2.12
  2.4.8
  provided


  org.apache.spark
  spark-parent_2.12
  2.4.8
  pom
  import

  
 

You are specifying a provided scope for spark-core_2.12, and at the same time 
changing the scope for some of its transitive dependencies when importing the 
dependencyManagement from the spark-parent_2.12 POM.

You should be able to see the resulting dependency tree (with scopes) by 
running 'mvn dependency:3.5.0:tree'. If I remove the spark-parent_2.12 from the 
 section, then I am seeing the result you are probably 
expecting - everything is provided and the shaded jar is basically empty.

I believe this is the current expected behavior when it comes to 
scopes/dependencyManagement in Maven. You would probably need to override the 
scope for all of the transitive dependencies as well, or remove the 
spark-parent_2.12 import.


Thanks,
Petr

--- Original Message ---
On Wednesday, February 8th, 2023 at 14:13, Adam Cervenka (ZA) 
 wrote:


> 
> 
> Hello,
> 
> I would like to report a bug.
> 
> I declared a dependency as provided, but the shade plugin still includes its 
> transitive dependencies in the uber-jar.
> 
> To demonstrate the issue, I created following repository:
> https://github.com/cerveada/shade-plugin-issue
> 
> Using the poms and instructions in the repo it should be easy to replicate 
> the issue.
> 
> Thanks,
> Adam Cervenka
> 
> Absa Bank Limited is a subsidiary of Absa Group Limited and is an Authorised 
> Financial Services Provider and Registered Credit Provider, registration 
> number: NCRCP7.
> 
> Absa Bank Limited provides services to Absa Group Limited and its 
> subsidiaries.
> 
> Absa is committed to complying with applicable data privacy laws and to 
> safeguarding the privacy and security of the personal information it collects 
> and processes, in respect of all current and prospective clients. To 
> understand more about how we collect, store, and process your personal 
> information, please view our privacy statement at absa.co.za
> 
> This e-mail and any attachments are confidential and intended solely for the 
> addressee and may also be privileged or exempt from disclosure under 
> applicable law. If you are not the addressee, or have received this e-mail in 
> error, please notify the sender immediately, delete it from your system and 
> do not copy, disclose or otherwise act upon any part of this e-mail or its 
> attachments. Internet communications are not guaranteed to be secure or 
> virus-free. We do not accept responsibility for any loss arising from 
> unauthorised access to, or interference with, any Internet communications by 
> any third party, or from the transmission of any viruses. We may monitor 
> replies to this e-mail for operational or business reasons. Any opinion or 
> other information in this e-mail or its attachments that does not relate to 
> our business is personal to the sender and we do not endorse it.

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven 3.9.0

[Petr Široký]

+1 (non-binding)

Tested on several projects (both small and big) and found no functional issue.

The only thing I noticed is that 3.9.0 is a bit "slower" than 3.8.7. The 
following numbers are from a very big project - Quarkus, which has ~1k modules 
(https://github.com/quarkusio/quarkus), running on Linux x64 and JDK 19.0.1:

Maven cmd  Maven 3.8.7 Maven 3.9.0
==
clean  3.5s3.5s
validate   02:27min03:08min
validate -T8   28s 35s
install -DskipTests07:40min08:39min
install -DskipTests -T802:21min02:41min

Note: I did ran 'mvn clean' before every execution to remove any artifacts from 
previous builds. The numbers are an average over 3 runs.

On small(er) projects, with far less modules, the difference is of course much 
less noticeable, or even non-existing.

I haven't (yet) looked deeper into the reasons behind this. I don't think this 
would be a blocker for the release, but it would be nice to figure out what is 
the cause.

Thanks,
Petr


--- Original Message ---
On Tuesday, January 31st, 2023 at 11:37, Tamás Cservenák  
wrote:


> 
> 
> Howdy,
> 
> We solved 95 issues:
> https://issues.apache.org/jira/issues/?jql=project %3D MNG AND fixVersion %3D 
> 3.9.0
> 
> There are still some open issues left in JIRA:
> https://issues.apache.org/jira/issues/?filter=-5=project %3D MNG AND 
> resolution %3D Unresolved order by priority DESC%2Cupdated DESC
> 
> Staging repository:
> https://repository.apache.org/content/repositories/maven-1862/
> 
> Staged site:
> https://maven.apache.org/ref/3-LATEST/
> 
> SHA512 release checksum(s):
> 1ea149f4e48bc7b34d554aef86f948eca7df4e7874e30caf449f3708e4f8487c71a5e5c072a05f17c60406176ebeeaf56b5f895090c7346f8238e2da06cf6ecd
> apache-maven-3.9.0-bin.tar.gz
> 
> 564fe44bfa9c7ad3e2703cbbac59d43a11fa39e4e68875d3d1584d0a0b7b77a1352da246b875c4c15d11ceb6b4dd9a0ce7dd7a48695725dce594f34325c9c605
> apache-maven-3.9.0-bin.zip
> 
> c9c89d49aa577223b1358f7391859535be031201eab502e0620522ceb66f2b42f6f8361764d6d627b66f6ae8c61cfe85cb51f7fb734aadd0427f10e43d5a1753
> apache-maven-3.9.0-src.tar.gz
> 
> 68b1a3cde17a42814ea28499e0c3f5cb98c343cebdfb96b52ba5acc6c2c6bac4f99dcf93177840bbc4d2b32668f73315f678ba0fef211b422303a751690a139c
> apache-maven-3.9.0-src.zip
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for at least 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> Thanks
> T

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Daemon 0.9.0

[Petr Široký]

+1 (non-binding)

Tested on several projects on Linux with JDK 19. No issue found.

The URL 
https://github.com/apache/maven-mvnd/releases/tag/untagged-7cae83258923acd48d99 
is giving me 404 though.


--- Original Message ---
On Wednesday, January 25th, 2023 at 10:10, Guillaume Nodet  
wrote:


> 
> 
> I've staged a candidate release at
> https://dist.apache.org/repos/dist/dev/maven/mvnd/0.9.0/
> 
> Note that this release is based on Maven 3.8.7.
> The release notes are available at
> 
> https://github.com/apache/maven-mvnd/releases/tag/untagged-7cae83258923acd48d99
> 
> Please review and vote !
> 
> Note that I'm planning a 0.10.0 release based on Maven 3.9.0 once it's out
> and a 1.0.0-m2 once 4.0.0-alpha-4 is out.
> 
> --
> 
> Guillaume Nodet

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Upcoming Maven Enforcer 3.2.0 release

[Petr Široký]

Hello,

great stuff! Looking forward to that release.

I gave the latest 3.2.0-SNAPSHOT (26697b16) a quick try with Quarkus repo 
(https://github.com/quarkusio/quarkus), since the project is pretty big (more 
than 1k sub-modules) and it also uses enforcer quite extensively (multiple 
executions). The current enforcer version is 3.0.0-M3, since there were 
multiple bugs in 3.1.0 which I think prevented the upgrade.

Here are my findings:
 - 'mvn validate' still succeeds, there are no enforcer errors. This is I think 
good. I obviously did not check if every rule of every module is being 
executed, but I did a quick comparison in few modules and everything _seems_ to 
be in order.

 - what seems to be very positive is the improvement in execution time. I 
compared a sequential and parallel runs, and also mvnd run (using JDK 17 + 
Maven 3.8.7 / Maven Deamon 0.8.2):

1) Sequential run:
  $ mvn validate -Dversion.enforcer.plugin=3.0.0-M3
  === Took ~140s

  $ mvn validate -Dversion.enforcer.plugin=3.2.0-SNAPSHOT
  === Took ~35s


2) Parallel run (with 8 threads):
  $ mvn validate -T8 -Dversion.enforcer.plugin=3.0.0-M3
  === Took ~30s

  $ mvn validate -T8 -Dversion.enforcer.plugin=3.2.0-SNAPSHOT
  === Took ~10s


3) Maven deamon run (with 8 threads and multiple executions to let the daemon 
"warm-up"):
  $ mvnd validate -T8 -Dversion.enforcer.plugin=3.0.0-M3
  === Took ~80s
  $ mvnd validate -T8 -Dversion.enforcer.plugin=3.2.0-SNAPSHOT
  === Took ~8s

Note: I don't quite understand why the Maven daemon run with version 3.0.0-M3 
is so much slower comparing to the non-daemon run (80s vs 35s). I would have to 
investigate further, so let's ignore those numbers for now I guess.

Are we expecting this kind of improvement? Or could this be somehow caused by 
e.g. mistakenly not executing some of the rules? I would need to again dig 
deeper, but before that it would be good to know if this is maybe something we 
are expecting.

Thanks,
Petr


--- Original Message ---
On Friday, January 20th, 2023 at 19:09, Slawomir Jaranowski 
 wrote:


> 
> 
> Hi,
> 
> I'm going to release the next version of Maven Enforcer plugin and build in
> rules.
> Probably in next week - about 24-26 of January
> 
> Prepared release note:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317520=12351838
> 
> The most important:
> - New Enforcer API - https://issues.apache.org/jira/browse/MENFORCER-455
> - Get rid of maven-dependency-tree dependency -
> https://issues.apache.org/jira/browse/MENFORCER-435
> - Verify working with Maven 4 -
> https://issues.apache.org/jira/browse/MENFORCER-447
> 
> I will appreciate any tests on your projects.
> If something else should be added please let me know.
> 
> --
> Sławomir Jaranowski

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [maven-compiler-plugin] Helping with implementing new features / bug fixes

[Petr Široký]

Hello again,

I created a JIRA for that change: 
https://issues.apache.org/jira/browse/MCOMPILER-522 and then a new PR:
https://github.com/apache/maven-compiler-plugin/pull/169.

These are basically the changes Tamas did in the original PR 
(https://github.com/apache/maven-compiler-plugin/pull/151), plus some minor 
changes and one more IT (we discussed the issue with Tamas on that PR and he 
suggested for someone to "take over", so that's the reason I created a new PR).

Andrzej Jarmoniuk (who did similar changes in other plugins) did review and 
approve the PR (many thanks for that!). It would be great if anyone from the 
Maven team would be able to take a look as well.

Thanks,
Petr

--- Original Message ---
On Wednesday, January 18th, 2023 at 18:50, Slawomir Jaranowski 
 wrote:


> 
> 
> Hi,
> 
> Petr thanks for your contributions.
> 
> I think that first we should finish "Move away from legacy maven-compat",
> for me it is a blocker for next issues.
> https://github.com/apache/maven-compiler-plugin/pull/151
> We need the issue for the above PR :-)
> 
> Next we can try to resolve the mentioned issues.
> 
> Simply please create PR with a proposition ... if nobody responds with a
> review you can ping on dev list.
> 
> 
> 
> 
> wt., 17 sty 2023 o 23:41 Petr Široký petr.sir...@proton.me.invalid
> 
> napisał(a):
> 
> > Hello everyone,
> > 
> > I recently started contributing with small changes to some of the Maven
> > projects (mainly enforcer and IT repo) and I am now looking where I could
> > help further.
> > 
> > One of the areas that caught my eye is the maven-compiler-plugin and
> > specifically the annotationProcessorPaths feature. It seems there are quite
> > a few open JIRAs with feature requests and bugs. From what I could find:
> > - https://issues.apache.org/jira/browse/MCOMPILER-391
> > 
> > - https://issues.apache.org/jira/browse/MCOMPILER-395
> > 
> > - https://issues.apache.org/jira/browse/MCOMPILER-503
> > 
> > - https://issues.apache.org/jira/browse/MCOMPILER-496
> > 
> > - https://issues.apache.org/jira/browse/MCOMPILER-264
> > 
> > At first I would like to take a look at MCOMPILER-391, which is requesting
> > that the dependencies under annotationProcessorPaths use
> >  to resolve a proper version (instead of requiring
> > users to explicitly specify the version as part of the
> > annotationProcessorPaths entry). I remember I had to fight with this one
> > before as well as a user.
> > 
> > Would that (MCOMPILER-391) be a good place to start, or are there any
> > blocker issues / concerns which are the reason this feature have not been
> > yet implemented?
> > 
> > Also, would there be anyone specifically interested in maybe reviewing the
> > proposed changes? Or should I just open the PRs and someone will eventually
> > take a look?
> > 
> > Thanks,
> > Petr
> 
> 
> 
> 
> --
> Sławomir Jaranowski

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[maven-compiler-plugin] Helping with implementing new features / bug fixes

[Petr Široký]

Hello everyone,

I recently started contributing with small changes to some of the Maven 
projects (mainly enforcer and IT repo) and I am now looking where I could help 
further.

One of the areas that caught my eye is the maven-compiler-plugin and 
specifically the annotationProcessorPaths feature. It seems there are quite a 
few open JIRAs with feature requests and bugs. From what I could find:
- https://issues.apache.org/jira/browse/MCOMPILER-391

- https://issues.apache.org/jira/browse/MCOMPILER-395

- https://issues.apache.org/jira/browse/MCOMPILER-503

- https://issues.apache.org/jira/browse/MCOMPILER-496

- https://issues.apache.org/jira/browse/MCOMPILER-264

At first I would like to take a look at MCOMPILER-391, which is requesting that 
the dependencies under annotationProcessorPaths use  to 
resolve a proper version (instead of requiring users to explicitly specify the 
version as part of the annotationProcessorPaths entry). I remember I had to 
fight with this one before as well as a user.

Would that (MCOMPILER-391) be a good place to start, or are there any blocker 
issues / concerns which are the reason this feature have not been yet 
implemented?

Also, would there be anyone specifically interested in maybe reviewing the 
proposed changes? Or should I just open the PRs and someone will eventually 
take a look?

Thanks,
Petr

Re: [VOTE] Release Maven Surefire version 3.0.0-M8

[Petr Široký]

+1 (non-binding). Tested with several projects on Linux. No issue found.



--- Original Message ---
On Saturday, January 7th, 2023 at 14:07, Michael Osipov  
wrote:


> 
> 
> Hi,
> 
> We solved 18 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12351809
> 
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project %3D SUREFIRE AND 
> resolution %3D Unresolved
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1846/
> https://repository.apache.org/content/repositories/maven-1846/org/apache/maven/surefire/surefire/3.0.0-M8/surefire-3.0.0-M8-source-release.zip
> 
> Source release checksum(s):
> surefire-3.0.0-M8-source-release.zip
> sha512:
> d2a533fc8c89f92c40b20c104beb8da69a45683821cb5432e99e2d12b469067659b117e140ddf66e8ba71f12b1af7aa07207d279289957a52940162ce27599ba
> 
> Staging site:
> https://maven.apache.org/surefire-archives/surefire-LATEST/
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven version 3.8.7

[Petr Široký]

+1 (non-binding)

Tested with several projects, ranging from small single-module ones to some 
with hundreds of sub-modules. No issue found.




--- Original Message ---
On Saturday, December 24th, 2022 at 21:20, Michael Osipov  
wrote:


> 
> 
> Hi,
> 
> We solved 19 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12352690
> 
> There are still hundreds of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project %3D MNG AND resolution %3D 
> Unresolved
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1839/
> 
> Dev dist directory:
> https://dist.apache.org/repos/dist/dev/maven/maven-3/3.8.7/
> 
> Source release checksums:
> apache-maven-3.8.7-src.zip sha512:
> 7c5bbdfbd85711d11f93254208978b47e4dcf010f94a1b9f549c3040507d751dff10d99c5f3af5fa92fd44b4261fc950d69eac345736f62007416e1350319891
> apache-maven-3.8.7-src.tar.gz sha512:
> 99dc6a44811d945d2d9a9e88b32abde5a82e4a8fa202ff217a5e3106d7fc532f347cff01331f6c2c0d86b2cf67fc0d0ee609d0c7d39b352a9422b990e49a81eb
> 
> Binary release checksums:
> apache-maven-3.8.7-bin.zip sha512:
> c687fcdc3890bcf0f9f9dbc42ceded21dc80f0dcc5541c28912a99224694793f6e437998e46b5939bd314178865263c62a069c6c6f15d1d0541eea75748c46fd
> apache-maven-3.8.7-bin.tar.gz sha512:
> 21c2be0a180a326353e8f6d12289f74bc7cd53080305f05358936f3a1b6dd4d91203f4cc799e81761cf5c53c5bbe9dcc13bdb27ec8f57ecf21b2f9ceec3c8d27
> 
> Draft for release notes:
> https://github.com/apache/maven-site/pull/356
> 
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open until 2022-12-30T20:00Z
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven 4.0.0-alpha-3

[Petr Široký]

Hello everyone,

I have tried to build a sample project locally using Maven 4.0.0-alpha-3 and I 
am seeing one difference / inconsistency with the behavior of empty 
 tag in settings.xml file, when comparing to Maven 3.8.6.
My settings.xml file looks like this:

http://maven.apache.org/SETTINGS/1.0.0;
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
  xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
  http://maven.apache.org/xsd/settings-1.0.0.xsd;>
  


When I run a build with Maven 3.8.6, everything works as I would expect and by 
the "~/.m2/repository" is chosen.

However, if I build with Maven 4.0.0-alpha-3, it chooses the current working 
directly as the root directory for the local repository. So I end-up with 
directories like "aopalliance", "avalon-framework", etc., next to the pom.xml.

If I remove the empty element  from the settings.xml, then 
".m2/repository" is chosen and it works same as in Maven 3.x.


My question is: is this the expected behavior / intended change in Maven 4.x? I 
haven't found any mention of this, but I figured I would ask before filing 
issues in JIRA.

Thanks,
Petr



--- Original Message ---
On Monday, December 12th, 2022 at 14:19, Guillaume Nodet  
wrote:


> 
> 
> I've staged a release candidate at:
> https://repository.apache.org/content/repositories/maven-1835
> 
> Source distributions:
> https://dist.apache.org/repos/dist/dev/maven/maven-4/4.0.0-alpha-3/source/
> 
> Binaries are available at:
> 
> https://dist.apache.org/repos/dist/dev/maven/maven-4/4.0.0-alpha-3/binaries/
> 
> https://repository.apache.org/content/repositories/maven-1835/org/apache/maven/apache-maven/4.0.0-alpha-3/
> 
> Release notes:
> 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12352443
> https://github.com/apache/maven/milestone/1?closed=1
> 
> Github release:
> https://github.com/apache/maven/releases/tag/maven-4.0.0-alpha-3
> 
> Please review and vote !
> 
> --
> 
> Guillaume Nodet

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven 3.5.2

[Petr Široký]

+1 (non-binding)

Tested with OracleJDK 1.8.0_144 on several large multi-module projects. No
issue found.

Petr

On Fri, Oct 20, 2017 at 9:46 PM Arnaud Héritier  wrote:

> +1 for me too
> Used it with no issue (but my usages are limited)
>
> On Fri, Oct 20, 2017 at 8:34 PM, Robert Scholte 
> wrote:
>
> > +1
> >
> >
> > On Wed, 18 Oct 2017 12:50:43 +0200, Stephen Connolly <
> > stephen.alan.conno...@gmail.com> wrote:
> >
> > Hi,
> >>
> >> We solved 26 issues:
> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?versi
> >> on=12338964=Text=12316922
> >>
> >> There are 357 issues left in JIRA for Maven core:
> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%
> >> 20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%
> >> 20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> >>
> >> Staging repo:
> >> https://repository.apache.org/content/repositories/maven-1373/
> >>
> >> The distributable binaries and sources can be found here:
> >> https://repository.apache.org/content/repositories/maven-137
> >> 3/org/apache/maven/apache-maven/3.5.2/
> >>
> >> Specifically the zip, tarball and source archives can be found here:
> >> https://repository.apache.org/content/repositories/maven-137
> >> 3/org/apache/maven/apache-maven/3.5.2/apache-maven-3.5.2-bin.zip
> >> https://repository.apache.org/content/repositories/maven-137
> >> 3/org/apache/maven/apache-maven/3.5.2/apache-maven-3.5.2-bin.tar.gz
> >> https://repository.apache.org/content/repositories/maven-137
> >> 3/org/apache/maven/apache-maven/3.5.2/apache-maven-3.5.2-src.zip
> >> https://repository.apache.org/content/repositories/maven-137
> >> 3/org/apache/maven/apache-maven/3.5.2/apache-maven-3.5.2-src.tar.gz
> >>
> >> Source release checksum(s):
> >> apache-maven-3.5.2-src.tar.gz sha1: 97d6d7b18485b7906dd7f313cdd411
> >> 91d16dde46
> >> apache-maven-3.5.2-src.zip: sha1: dc8caa5cdacb400943d2491a020f74
> >> 2a518e8f08
> >>
> >> Git tag:
> >> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit
> >> ;h=138edd61fd100ec658bfa2d307c43b76940a5d7d
> >>
> >> Staging site:
> >> https://maven.apache.org/components/ref/3-LATEST/
> >>
> >> Vote open for 72 hours.
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> Thanks,
> >>
> >> Stephen.
> >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >
>
>
> --
> -
> Arnaud Héritier
> http://aheritier.net
> Mail/GTalk: aheritier AT gmail DOT com
> Twitter/Skype : aheritier
>

Re: [VOTE] Release Apache Maven 3.5.1

[Petr Široký]

I was able to easily fix our plugin by e.g. replacing
"Thread.currentThread().getContextClassLoader()" with
"this.getClass().getClassLoader()" (in the Mojo class) to get the plugin
classloader.

I don't know though if the "Thread.currentThread().getContextClassLoader()"
is just misuse on our side or if it's something that more plugins may rely
on.

Petr


On Thu, Sep 14, 2017 at 2:42 PM Petr Široký <siroky.p...@gmail.com> wrote:

> Argh, I forgot to link the plugin source:
> https://github.com/kiegroup/droolsjbpm-integration/tree/7.3.0.Final/kie-maven-plugin
>
> On Thu, Sep 14, 2017 at 2:41 PM Petr Široký <siroky.p...@gmail.com> wrote:
>
>> Hello,
>>
>> I am seeing a (probably) similar issue with our custom plugin.
>>
>> See the reproducer:
>> https://github.com/psiroky/reproducers/tree/mvn351-kie-maven-plugin (works
>> fine with maven 3.5.0, but fails with NPE with the RC of maven 3.5.1).
>>
>> I am not yet sure if the plugin is just doing something it's not supposed
>> to, or if this is a regression in maven itself. I'll will take a deeper
>> look.
>>
>> Petr
>>
>>
>> On Thu, Sep 14, 2017 at 1:53 PM Stephen Connolly <
>> stephen.alan.conno...@gmail.com> wrote:
>>
>>> On 14 September 2017 at 04:43, Mark Derricutt <m...@talios.com> wrote:
>>>
>>> > > +2 non-binding from Mark!
>>> >
>>> > I was discussing this with a coworker and he made the comment that if
>>> this
>>> > change could break Mojos, maybe it shouldn't be in a point release -
>>> whats
>>> > the policy on changes that may potentially break existing plugins?
>>> >
>>>
>>> Well we need to assess the issue. Right now I don't even have a
>>> description
>>> of what went wrong. Any chance you could provide a replication... or mail
>>> me directly if you cannot share it publically and I may be able to
>>> produce
>>> a minimal reproduction from it.
>>>
>>> If this breaks a mojo that was doing something wrong in the first place,
>>> well that will not stop 3.5.1... OTOH if this exposes a bug in the issue
>>> "fixed" then I'd likely revert and respin.
>>>
>>> We really need a reproducer first.
>>>
>>>
>>> >
>>> > --
>>> > "Great artists are extremely selfish and arrogant things" — Steven
>>> Wilson,
>>> > Porcupine Tree
>>> >
>>> > On Thu, Sep 14, 2017 at 10:29 AM, Mark Derricutt <m...@talios.com>
>>> wrote:
>>> >
>>> > > On 14 Sep 2017, at 10:26, Mark Derricutt wrote:
>>> > >
>>> > > Calling -2 for vote if not too late.
>>> > >
>>> > > Actually - looking at the commit diff, I see in our code we did have
>>> > > true for the jasmine-maven-plugin which we
>>> don't
>>> > > actually need. Removing that from the mojo definition and running my
>>> > build
>>> > > with the staged 3.5.1 release and everything builds fine.
>>> > >
>>> > > +2 non-binding from Mark!
>>> > >
>>> > > Mark
>>> > > --
>>> > >
>>> > > "The ease with which a change can be implemented has no relevance at
>>> all
>>> > > to whether it is the right change for the (Java) Platform for all
>>> time."
>>> > —
>>> > > Mark Reinhold.
>>> > >
>>> > > Mark Derricutt
>>> > > http://www.theoryinpractice.net
>>> > > http://www.chaliceofblood.net
>>> > > http://plus.google.com/+MarkDerricutt
>>> > > http://twitter.com/talios
>>> > > http://facebook.com/mderricutt
>>> > >
>>> >
>>>
>>

Re: [VOTE] Release Apache Maven 3.5.1

[Petr Široký]

Argh, I forgot to link the plugin source:
https://github.com/kiegroup/droolsjbpm-integration/tree/7.3.0.Final/kie-maven-plugin

On Thu, Sep 14, 2017 at 2:41 PM Petr Široký <siroky.p...@gmail.com> wrote:

> Hello,
>
> I am seeing a (probably) similar issue with our custom plugin.
>
> See the reproducer:
> https://github.com/psiroky/reproducers/tree/mvn351-kie-maven-plugin (works
> fine with maven 3.5.0, but fails with NPE with the RC of maven 3.5.1).
>
> I am not yet sure if the plugin is just doing something it's not supposed
> to, or if this is a regression in maven itself. I'll will take a deeper
> look.
>
> Petr
>
>
> On Thu, Sep 14, 2017 at 1:53 PM Stephen Connolly <
> stephen.alan.conno...@gmail.com> wrote:
>
>> On 14 September 2017 at 04:43, Mark Derricutt <m...@talios.com> wrote:
>>
>> > > +2 non-binding from Mark!
>> >
>> > I was discussing this with a coworker and he made the comment that if
>> this
>> > change could break Mojos, maybe it shouldn't be in a point release -
>> whats
>> > the policy on changes that may potentially break existing plugins?
>> >
>>
>> Well we need to assess the issue. Right now I don't even have a
>> description
>> of what went wrong. Any chance you could provide a replication... or mail
>> me directly if you cannot share it publically and I may be able to produce
>> a minimal reproduction from it.
>>
>> If this breaks a mojo that was doing something wrong in the first place,
>> well that will not stop 3.5.1... OTOH if this exposes a bug in the issue
>> "fixed" then I'd likely revert and respin.
>>
>> We really need a reproducer first.
>>
>>
>> >
>> > --
>> > "Great artists are extremely selfish and arrogant things" — Steven
>> Wilson,
>> > Porcupine Tree
>> >
>> > On Thu, Sep 14, 2017 at 10:29 AM, Mark Derricutt <m...@talios.com>
>> wrote:
>> >
>> > > On 14 Sep 2017, at 10:26, Mark Derricutt wrote:
>> > >
>> > > Calling -2 for vote if not too late.
>> > >
>> > > Actually - looking at the commit diff, I see in our code we did have
>> > > true for the jasmine-maven-plugin which we
>> don't
>> > > actually need. Removing that from the mojo definition and running my
>> > build
>> > > with the staged 3.5.1 release and everything builds fine.
>> > >
>> > > +2 non-binding from Mark!
>> > >
>> > > Mark
>> > > --
>> > >
>> > > "The ease with which a change can be implemented has no relevance at
>> all
>> > > to whether it is the right change for the (Java) Platform for all
>> time."
>> > —
>> > > Mark Reinhold.
>> > >
>> > > Mark Derricutt
>> > > http://www.theoryinpractice.net
>> > > http://www.chaliceofblood.net
>> > > http://plus.google.com/+MarkDerricutt
>> > > http://twitter.com/talios
>> > > http://facebook.com/mderricutt
>> > >
>> >
>>
>

Re: [VOTE] Release Apache Maven 3.5.1

[Petr Široký]

Hello,

I am seeing a (probably) similar issue with our custom plugin.

See the reproducer:
https://github.com/psiroky/reproducers/tree/mvn351-kie-maven-plugin (works
fine with maven 3.5.0, but fails with NPE with the RC of maven 3.5.1).

I am not yet sure if the plugin is just doing something it's not supposed
to, or if this is a regression in maven itself. I'll will take a deeper
look.

Petr

On Thu, Sep 14, 2017 at 1:53 PM Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

> On 14 September 2017 at 04:43, Mark Derricutt  wrote:
>
> > > +2 non-binding from Mark!
> >
> > I was discussing this with a coworker and he made the comment that if
> this
> > change could break Mojos, maybe it shouldn't be in a point release -
> whats
> > the policy on changes that may potentially break existing plugins?
> >
>
> Well we need to assess the issue. Right now I don't even have a description
> of what went wrong. Any chance you could provide a replication... or mail
> me directly if you cannot share it publically and I may be able to produce
> a minimal reproduction from it.
>
> If this breaks a mojo that was doing something wrong in the first place,
> well that will not stop 3.5.1... OTOH if this exposes a bug in the issue
> "fixed" then I'd likely revert and respin.
>
> We really need a reproducer first.
>
>
> >
> > --
> > "Great artists are extremely selfish and arrogant things" — Steven
> Wilson,
> > Porcupine Tree
> >
> > On Thu, Sep 14, 2017 at 10:29 AM, Mark Derricutt 
> wrote:
> >
> > > On 14 Sep 2017, at 10:26, Mark Derricutt wrote:
> > >
> > > Calling -2 for vote if not too late.
> > >
> > > Actually - looking at the commit diff, I see in our code we did have
> > > true for the jasmine-maven-plugin which we
> don't
> > > actually need. Removing that from the mojo definition and running my
> > build
> > > with the staged 3.5.1 release and everything builds fine.
> > >
> > > +2 non-binding from Mark!
> > >
> > > Mark
> > > --
> > >
> > > "The ease with which a change can be implemented has no relevance at
> all
> > > to whether it is the right change for the (Java) Platform for all
> time."
> > —
> > > Mark Reinhold.
> > >
> > > Mark Derricutt
> > > http://www.theoryinpractice.net
> > > http://www.chaliceofblood.net
> > > http://plus.google.com/+MarkDerricutt
> > > http://twitter.com/talios
> > > http://facebook.com/mderricutt
> > >
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

[Petr Široký]

+1 non-binding. Tested on several projects with thousands of tests (both
surefire and failsafe ones). No issue found.

Env:
Fedora 25
Oracle JDK 8
Maven 3.5.0.

Petr


On Thu, Sep 14, 2017 at 8:00 AM Tibor Digana  wrote:

> (again from my Apache mail account)
> Pls participate in the vote and test.
>
> On Thu, Sep 14, 2017 at 7:59 AM, Tibor Digana  >
> wrote:
>
> > Pls participate in the vote and test.
> >
> > On Mon, Sep 11, 2017 at 5:33 AM, Tibor Digana <
> tibor.dig...@googlemail.com
> > > wrote:
> >
> >> Hi,
> >>
> >> We solved 24 issues:
> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
> >> ctId=12317927=12340297
> >>
> >> There are 101 issues left in JIRA:
> >> https://issues.apache.org/jira/i#issues/?jql=project+%3D+
> >> SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> >>
> >> Staging repo:
> >> https://repository.apache.org/content/repositories/maven-1366/
> >> https://repository.apache.org/content/repositories/maven-136
> >> 6/org/apache/maven/surefire/surefire/2.20.1/surefire-2.20.
> >> 1-source-release.zip
> >>
> >> Source release checksum(s):
> >> maven-surefire-plugin-2.20.1-site-source.zip sha1:
> >> 4187a7932268c7ad467973254d87584085e305c1
> >>
> >> Staging site:
> >> http://maven.apache.org/surefire-archives/surefire-LATEST/
> >>
> >> Guide to testing staged releases:
> >> http://maven.apache.org/guides/development/guide-testing-releases.html
> >>
> >> Vote open for 72 hours.
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> --
> >> Cheers
> >> Tibor
> >>
> >
> >
> >
> > --
> > Cheers
> > Tibor
> >
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 3

[Petr Široký]

+1 (non-binding)

Tested on Fedora 25 + JDK 8u121 + Maven 3.5.0 with several large projects.
No issue found.

@Tibor, thanks for fixing all the issues I found previously!

Petr

On Sat, Apr 8, 2017 at 12:53 PM Tibor Digana  wrote:

> Hi,
>
> We solved 70 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12334636
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1330/
>
> https://repository.apache.org/content/repositories/maven-1330/org/apache/maven/surefire/surefire/2.20/surefire-2.20-source-release.zip
>
> Source release checksum(s):
> surefire-2.20-source-release.zip sha1:
> fda994228c52dcb581d8ce6d4664f84a29d78797
>
> Git tag:
>
> https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=8c786523414018099b54a0868ae1bc3d64847411
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers,
> Tibor
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 2

[Petr Široký]

Just tested with local build from f4f78c9f155 (2.20-SNAPSHOT). Several
large projects, no additional issue found.

Petr

On Sat, Apr 8, 2017 at 12:28 AM Tibor Digana <tibor.dig...@googlemail.com>
wrote:

> The CI build will finish after 3 hours.
> Then the SNAPSHOT version will be in Maven Central.
>
> On Fri, Apr 7, 2017 at 11:40 PM, Dan Tran <dant...@gmail.com> wrote:
>
> > is 2.20-SNAPSHOT up to date? that is only quick way I can test
> >
> > Thanks
> >
> > -D
> >
> > On Fri, Apr 7, 2017 at 2:03 PM, Tibor Digana <
> tibor.dig...@googlemail.com>
> > wrote:
> >
> > > @Petr
> > > Both issues are fixed now. Would you please verify this version from
> > > master? I tested on my side.
> > >
> > > On Fri, Apr 7, 2017 at 3:42 PM, Petr Široký <siroky.p...@gmail.com>
> > wrote:
> > >
> > > > I'try to take a look. However, I have no prior experience with jUnit
> or
> > > > surefire sources, so it might take a while until I have something.
> > > >
> > > > Thanks,
> > > > Petr
> > > >
> > > > On Fri, Apr 7, 2017 at 2:22 PM Tibor Digana <
> > tibor.dig...@googlemail.com
> > > >
> > > > wrote:
> > > >
> > > > > Good point. The PING chcking should be disabled when JMX observes
> > debug
> > > > > mode.
> > > > > See implementation in JUnit sources. The same is there.
> > > > > Can you open pull request with a fix?
> > > > >
> > > > > On Fri, Apr 7, 2017 at 11:06 AM, Petr Široký <
> siroky.p...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Hello,
> > > > > >
> > > > > > thanks for the fast turnaround.
> > > > > >
> > > > > > I am afraid I've hit another issue (or maybe misconfiguration?).
> I
> > > was
> > > > > > trying to use -Dmaven.surefire.debug in the following project:
> > > > > > https://github.com/psiroky/surefire-2.20-debug-reproducer
> > > > > >
> > > > > > $ mvn clean install -s settings.xml -Dmaven.surefire.debug
> > > > > >
> > > > > > The surefire stops the execution and waits for the remote
> > connection
> > > on
> > > > > the
> > > > > > default port 5005. However, I see this warning:
> > > > > > [WARNING] Corrupted stdin stream in forked JVM 2. See the dump
> file
> > > > > > /home/psiroky/tmp/surefire-2.20-debug/target/surefire-
> > > > > > reports/2017-04-07T11-00-40_341-jvmRun2.dumpstream
> > > > > >
> > > > > > Also, once I disconnect the remote debugger, the build fails with
> > > > > > "ExecutionException The forked VM terminated without properly
> > saying
> > > > > > goodbye. VM crash or System.exit called?"
> > > > > > See the full build.log in the above git repo. I've also included
> > the
> > > > > > '.dumpstream' file.
> > > > > >
> > > > > > Petr
> > > > > >
> > > > > >
> > > > > > On Thu, Apr 6, 2017 at 7:56 AM Tibor Digana <
> > tibordig...@apache.org>
> > > > > > wrote:
> > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > We solved 68 issues:
> > > > > > >
> > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > > > > projectId=12317927=12334636
> > > > > > >
> > > > > > > There are still a couple of issues left in JIRA:
> > > > > > >
> > > > > > > https://issues.apache.org/jira/i#issues/?jql=project+%
> > > > > > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> > > > > > >
> > > > > > > Staging repo:
> > > > > > > https://repository.apache.org/content/repositories/maven-1329/
> > > > > > >
> > > > > > > https://repository.apache.org/content/repositories/maven-
> > > > > >
> > > > > 1329/org/apache/maven/surefire/surefire/2.20/
> > > > surefire-2.20-source-release.
> > > > > > zip
> > > > > > >
> > > > > > > Source release checksum(s):
> > > > > > > surefire-2.20-source-release.zip sha1:
> > > > > > > d76d172588f6ab1ada16db9155b464ffeefffc9b
> > > > > > >
> > > > > > > Git tag:
> > > > > > >
> > > > > > >
> > > > > https://git-wip-us.apache.org/repos/asf?p=maven-surefire.
> > > git;a=commit;h=
> > > > > > b5cbc6b2822e9eb60c703d46f1d2ed82126909ed
> > > > > > >
> > > > > > > Staging site:
> > > > > > > http://maven.apache.org/surefire-archives/surefire-LATEST/
> > > > > > >
> > > > > > > Guide to testing staged releases:
> > > > > > > http://maven.apache.org/guides/development/guide-
> > > > testing-releases.html
> > > > > > >
> > > > > > > Vote open for 72 hours.
> > > > > > >
> > > > > > > [ ] +1
> > > > > > > [ ] +0
> > > > > > > [ ] -1
> > > > > > >
> > > > > > > Cheers,
> > > > > > > Tibor
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Cheers
> > > > > Tibor
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Cheers
> > > Tibor
> > >
> >
>
>
>
> --
> Cheers
> Tibor
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 2

[Petr Široký]

I'try to take a look. However, I have no prior experience with jUnit or
surefire sources, so it might take a while until I have something.

Thanks,
Petr

On Fri, Apr 7, 2017 at 2:22 PM Tibor Digana <tibor.dig...@googlemail.com>
wrote:

> Good point. The PING chcking should be disabled when JMX observes debug
> mode.
> See implementation in JUnit sources. The same is there.
> Can you open pull request with a fix?
>
> On Fri, Apr 7, 2017 at 11:06 AM, Petr Široký <siroky.p...@gmail.com>
> wrote:
>
> > Hello,
> >
> > thanks for the fast turnaround.
> >
> > I am afraid I've hit another issue (or maybe misconfiguration?). I was
> > trying to use -Dmaven.surefire.debug in the following project:
> > https://github.com/psiroky/surefire-2.20-debug-reproducer
> >
> > $ mvn clean install -s settings.xml -Dmaven.surefire.debug
> >
> > The surefire stops the execution and waits for the remote connection on
> the
> > default port 5005. However, I see this warning:
> > [WARNING] Corrupted stdin stream in forked JVM 2. See the dump file
> > /home/psiroky/tmp/surefire-2.20-debug/target/surefire-
> > reports/2017-04-07T11-00-40_341-jvmRun2.dumpstream
> >
> > Also, once I disconnect the remote debugger, the build fails with
> > "ExecutionException The forked VM terminated without properly saying
> > goodbye. VM crash or System.exit called?"
> > See the full build.log in the above git repo. I've also included the
> > '.dumpstream' file.
> >
> > Petr
> >
> >
> > On Thu, Apr 6, 2017 at 7:56 AM Tibor Digana <tibordig...@apache.org>
> > wrote:
> >
> > > Hi,
> > >
> > > We solved 68 issues:
> > >
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12317927=12334636
> > >
> > > There are still a couple of issues left in JIRA:
> > >
> > > https://issues.apache.org/jira/i#issues/?jql=project+%
> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> > >
> > > Staging repo:
> > > https://repository.apache.org/content/repositories/maven-1329/
> > >
> > > https://repository.apache.org/content/repositories/maven-
> >
> 1329/org/apache/maven/surefire/surefire/2.20/surefire-2.20-source-release.
> > zip
> > >
> > > Source release checksum(s):
> > > surefire-2.20-source-release.zip sha1:
> > > d76d172588f6ab1ada16db9155b464ffeefffc9b
> > >
> > > Git tag:
> > >
> > >
> https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=
> > b5cbc6b2822e9eb60c703d46f1d2ed82126909ed
> > >
> > > Staging site:
> > > http://maven.apache.org/surefire-archives/surefire-LATEST/
> > >
> > > Guide to testing staged releases:
> > > http://maven.apache.org/guides/development/guide-testing-releases.html
> > >
> > > Vote open for 72 hours.
> > >
> > > [ ] +1
> > > [ ] +0
> > > [ ] -1
> > >
> > > Cheers,
> > > Tibor
> > >
> >
>
>
>
> --
> Cheers
> Tibor
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 2

[Petr Široký]

One more difference (bug?) I found:

When I do:

final URL parentUrl = this.getClass().getResource("/");
System.out.println(parentUrl);

the output is
'file:/home/psiroky/tmp/surefire-2.20-debug/target/test-classes//' -- note
the duplicated slash at the end.

I've done the same with 2.19.1 and the output is correct there --
file:/home/psiroky/tmp/surefire-2.20-debug/target/test-classes/

I believe, technically, the path is still valid, it's just that the tests
are not expecting the duplicated slash and string comparison is failing on
that.

Petr

On Fri, Apr 7, 2017 at 11:06 AM Petr Široký <siroky.p...@gmail.com> wrote:

> Hello,
>
> thanks for the fast turnaround.
>
> I am afraid I've hit another issue (or maybe misconfiguration?). I was
> trying to use -Dmaven.surefire.debug in the following project:
> https://github.com/psiroky/surefire-2.20-debug-reproducer
>
> $ mvn clean install -s settings.xml -Dmaven.surefire.debug
>
> The surefire stops the execution and waits for the remote connection on
> the default port 5005. However, I see this warning:
> [WARNING] Corrupted stdin stream in forked JVM 2. See the dump file
> /home/psiroky/tmp/surefire-2.20-debug/target/surefire-reports/2017-04-07T11-00-40_341-jvmRun2.dumpstream
>
> Also, once I disconnect the remote debugger, the build fails with
> "ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?"
> See the full build.log in the above git repo. I've also included the
> '.dumpstream' file.
>
> Petr
>
>
> On Thu, Apr 6, 2017 at 7:56 AM Tibor Digana <tibordig...@apache.org>
> wrote:
>
> Hi,
>
> We solved 68 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12334636
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1329/
>
> https://repository.apache.org/content/repositories/maven-1329/org/apache/maven/surefire/surefire/2.20/surefire-2.20-source-release.zip
>
> Source release checksum(s):
> surefire-2.20-source-release.zip sha1:
> d76d172588f6ab1ada16db9155b464ffeefffc9b
>
> Git tag:
>
> https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=b5cbc6b2822e9eb60c703d46f1d2ed82126909ed
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers,
> Tibor
>
>

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 2

[Petr Široký]

Hello,

thanks for the fast turnaround.

I am afraid I've hit another issue (or maybe misconfiguration?). I was
trying to use -Dmaven.surefire.debug in the following project:
https://github.com/psiroky/surefire-2.20-debug-reproducer

$ mvn clean install -s settings.xml -Dmaven.surefire.debug

The surefire stops the execution and waits for the remote connection on the
default port 5005. However, I see this warning:
[WARNING] Corrupted stdin stream in forked JVM 2. See the dump file
/home/psiroky/tmp/surefire-2.20-debug/target/surefire-reports/2017-04-07T11-00-40_341-jvmRun2.dumpstream

Also, once I disconnect the remote debugger, the build fails with
"ExecutionException The forked VM terminated without properly saying
goodbye. VM crash or System.exit called?"
See the full build.log in the above git repo. I've also included the
'.dumpstream' file.

Petr


On Thu, Apr 6, 2017 at 7:56 AM Tibor Digana  wrote:

> Hi,
>
> We solved 68 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12334636
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1329/
>
> https://repository.apache.org/content/repositories/maven-1329/org/apache/maven/surefire/surefire/2.20/surefire-2.20-source-release.zip
>
> Source release checksum(s):
> surefire-2.20-source-release.zip sha1:
> d76d172588f6ab1ada16db9155b464ffeefffc9b
>
> Git tag:
>
> https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=b5cbc6b2822e9eb60c703d46f1d2ed82126909ed
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers,
> Tibor
>

Re: surefire-2_20-slowdown-reproducer

[Petr Široký]

Hello Tibor,

I've just tried with a local build from the SUREFIRE-1354 branch and I can
confirm the issue is gone. I've executed 50 builds on the same config as
before.

Thanks,
Petr

On Wed, Apr 5, 2017 at 8:10 PM Tibor Digana <tibor.dig...@googlemail.com>
wrote:

> @Michael
> Hi Michael,
> A new branch was created
> SUREFIRE-1354.
>
> @Petr
> Please build the project
> mvn install -DskipTests
> and check it out in your project with version 2.20-SNAPSHOT.
> git clone -b SUREFIRE-1354 https://github.com/apache/maven-surefire
>
>
>
> On Wed, Apr 5, 2017 at 7:10 PM, Michael Osipov <micha...@apache.org>
> wrote:
>
> > Am 2017-04-05 um 19:02 schrieb Tibor Digana:
> >
> >> Yes, I will cancel it, and I will add few more fixes too.
> >>
> >
> > Good, tell me when you are ready. I will retest trunk before you prepare
> > the release.
> >
> > On Wed, Apr 5, 2017 at 7:01 PM, Michael Osipov <micha...@apache.org>
> >> wrote:
> >>
> >> Am 2017-04-05 um 17:20 schrieb Tibor Digana:
> >>>
> >>> I found the issue.
> >>>> In ForkedBooter we call
> >>>>
> >>>> encodeAndWriteToOutput( ( (char) BOOTERCODE_BYE ) + ",0,BYE!\n",
> >>>> originalOut );
> >>>>
> >>>> We expect the Maven process to respond.
> >>>> This happens but the listener which is expected to listen to BYE_ACK
> >>>> from
> >>>> Maven process is registered after this sending BYE and not before.
> >>>> Therefore this is concurrency issue.
> >>>>
> >>>>
> >>> +1. Are you going to cancel the vote?
> >>>
> >>> On Wed, Apr 5, 2017 at 12:31 PM, Petr Široký <siroky.p...@gmail.com>
> >>>
> >>>> wrote:
> >>>>
> >>>> I've just tried on Windwos 2012R2 + Maven 3.2.3 and RHEL 7.3 + Maven
> >>>>
> >>>>> 3.2.5.
> >>>>> The 30s wait is somehow intermittent. I can still reproduce on those
> >>>>> platforms, but it takes 10 or 15 tries. On Fedora 25 it happens
> almost
> >>>>> always (but I have seen it pass also there).
> >>>>>
> >>>>> On Wed, Apr 5, 2017 at 11:50 AM Tibor Digana <tibordig...@apache.org
> >
> >>>>> wrote:
> >>>>>
> >>>>> On my side okay (Maven 3.5.0 Win7).
> >>>>>
> >>>>>> I will check it out on Fedora and Ubuntu.
> >>>>>>
> >>>>>> mvn test
> >>>>>> [INFO] Scanning for projects...
> >>>>>> [INFO]
> >>>>>> [INFO]
> >>>>>> 
> >>>>>> 
> >>>>>> [INFO] Building surefire-2_20-slowdown-reproducer 1.0-SNAPSHOT
> >>>>>> [INFO]
> >>>>>> 
> >>>>>> 
> >>>>>> [INFO]
> >>>>>> [INFO] --- maven-resources-plugin:2.6:resources (default-resources)
> @
> >>>>>> surefire-2_20-slowdown-reproducer ---
> >>>>>> [WARNING] Using platform encoding (Cp1250 actually) to copy filtered
> >>>>>> resources, i.e. build is platform dependent!
> >>>>>> [INFO] skip non existing resourceDirectory
> >>>>>> d:\vcs\github\surefire-2_20-slowdown-reproducer\src\main\resources
> >>>>>> [INFO]
> >>>>>> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @
> >>>>>> surefire-2_20-slowdown-reproducer ---
> >>>>>> [INFO] Changes detected - recompiling the module!
> >>>>>> [WARNING] File encoding has not been set, using platform encoding
> >>>>>> Cp1250,
> >>>>>> i.e. build is platform dependent!
> >>>>>> [INFO] Compiling 1 source file to
> >>>>>> d:\vcs\github\surefire-2_20-slowdown-reproducer\target\classes
> >>>>>> [INFO]
> >>>>>> [INFO] --- maven-resources-plugin:2.6:testResources
> >>>>>>
> >>>>>> (default-testResources)
> >>>>>
> >>>>> @ surefire-2_20-slowdown-reproducer ---
> >>>>>> [WARNING] Using platform encoding (Cp1250 actually) to copy filtered
> >>>>

Re: surefire-2_20-slowdown-reproducer

[Petr Široký]

On Wed, Apr 5, 2017 at 1:13 PM Tibor Digana <tibor.dig...@googlemail.com>
wrote:

> What I see in the thread dump is
> that ForkedBooter sent event BOOTERCODE_BYE, waiting for BYE_ACK from
> master process in CommandReader.
>
> Are you able to dump native stream stdout/in of forked JVM?
>
Not sure I understand what this means. How would I dump the native stream?

>
> On Wed, Apr 5, 2017 at 12:31 PM, Petr Široký <siroky.p...@gmail.com>
> wrote:
>
> > I've just tried on Windwos 2012R2 + Maven 3.2.3 and RHEL 7.3 + Maven
> 3.2.5.
> > The 30s wait is somehow intermittent. I can still reproduce on those
> > platforms, but it takes 10 or 15 tries. On Fedora 25 it happens almost
> > always (but I have seen it pass also there).
> >
> > On Wed, Apr 5, 2017 at 11:50 AM Tibor Digana <tibordig...@apache.org>
> > wrote:
> >
> > > On my side okay (Maven 3.5.0 Win7).
> > > I will check it out on Fedora and Ubuntu.
> > >
> > > mvn test
> > > [INFO] Scanning for projects...
> > > [INFO]
> > > [INFO]
> > >
> 
> > > [INFO] Building surefire-2_20-slowdown-reproducer 1.0-SNAPSHOT
> > > [INFO]
> > >
> 
> > > [INFO]
> > > [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
> > > surefire-2_20-slowdown-reproducer ---
> > > [WARNING] Using platform encoding (Cp1250 actually) to copy filtered
> > > resources, i.e. build is platform dependent!
> > > [INFO] skip non existing resourceDirectory
> > > d:\vcs\github\surefire-2_20-slowdown-reproducer\src\main\resources
> > > [INFO]
> > > [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @
> > > surefire-2_20-slowdown-reproducer ---
> > > [INFO] Changes detected - recompiling the module!
> > > [WARNING] File encoding has not been set, using platform encoding
> Cp1250,
> > > i.e. build is platform dependent!
> > > [INFO] Compiling 1 source file to
> > > d:\vcs\github\surefire-2_20-slowdown-reproducer\target\classes
> > > [INFO]
> > > [INFO] --- maven-resources-plugin:2.6:testResources
> > (default-testResources)
> > > @ surefire-2_20-slowdown-reproducer ---
> > > [WARNING] Using platform encoding (Cp1250 actually) to copy filtered
> > > resources, i.e. build is platform dependent!
> > > [INFO] skip non existing resourceDirectory
> > > d:\vcs\github\surefire-2_20-slowdown-reproducer\src\test\resources
> > > [INFO]
> > > [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile)
> @
> > > surefire-2_20-slowdown-reproducer ---
> > > [INFO] Changes detected - recompiling the module!
> > > [WARNING] File encoding has not been set, using platform encoding
> Cp1250,
> > > i.e. build is platform dependent!
> > > [INFO] Compiling 2 source files to
> > > d:\vcs\github\surefire-2_20-slowdown-reproducer\target\test-classes
> > > [INFO]
> > > [INFO] --- maven-surefire-plugin:2.20:test (default-test) @
> > > surefire-2_20-slowdown-reproducer ---
> > > [INFO]
> > > [INFO] ---
> > > [INFO]  T E S T S
> > > [INFO] ---
> > > [INFO] Running org.test.AppTest
> > > [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
> > 0.01
> > > s - in org.test.AppTest
> > > [INFO]
> > > [INFO] Results:
> > > [INFO]
> > > [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> > > [INFO]
> > > [INFO]
> > >
> 
> > > [INFO] BUILD SUCCESS
> > > [INFO]
> > >
> 
> > > [INFO] Total time: 6.595 s
> > > [INFO] Finished at: 2017-04-05T11:48:06+02:00
> > > [INFO] Final Memory: 16M/212M
> > > [INFO]
> > >
> 
> > >
> > > On Wed, Apr 5, 2017 at 11:26 AM, Tibor Digana-2 [via Maven] <
> > > ml-node+s40175n5904641...@n5.nabble.com> wrote:
> > >
> > > > Discussion to Release Vote of Surefire 2.20.
> > > > Project to reproduce an issue
> > > > https://github.com/psiroky/surefire-2_20-slowdown-reproducer
> > > > Forked J

Re: surefire-2_20-slowdown-reproducer

[Petr Široký]

I've just tried on Windwos 2012R2 + Maven 3.2.3 and RHEL 7.3 + Maven 3.2.5.
The 30s wait is somehow intermittent. I can still reproduce on those
platforms, but it takes 10 or 15 tries. On Fedora 25 it happens almost
always (but I have seen it pass also there).

On Wed, Apr 5, 2017 at 11:50 AM Tibor Digana  wrote:

> On my side okay (Maven 3.5.0 Win7).
> I will check it out on Fedora and Ubuntu.
>
> mvn test
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
> 
> [INFO] Building surefire-2_20-slowdown-reproducer 1.0-SNAPSHOT
> [INFO]
> 
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
> surefire-2_20-slowdown-reproducer ---
> [WARNING] Using platform encoding (Cp1250 actually) to copy filtered
> resources, i.e. build is platform dependent!
> [INFO] skip non existing resourceDirectory
> d:\vcs\github\surefire-2_20-slowdown-reproducer\src\main\resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @
> surefire-2_20-slowdown-reproducer ---
> [INFO] Changes detected - recompiling the module!
> [WARNING] File encoding has not been set, using platform encoding Cp1250,
> i.e. build is platform dependent!
> [INFO] Compiling 1 source file to
> d:\vcs\github\surefire-2_20-slowdown-reproducer\target\classes
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources)
> @ surefire-2_20-slowdown-reproducer ---
> [WARNING] Using platform encoding (Cp1250 actually) to copy filtered
> resources, i.e. build is platform dependent!
> [INFO] skip non existing resourceDirectory
> d:\vcs\github\surefire-2_20-slowdown-reproducer\src\test\resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @
> surefire-2_20-slowdown-reproducer ---
> [INFO] Changes detected - recompiling the module!
> [WARNING] File encoding has not been set, using platform encoding Cp1250,
> i.e. build is platform dependent!
> [INFO] Compiling 2 source files to
> d:\vcs\github\surefire-2_20-slowdown-reproducer\target\test-classes
> [INFO]
> [INFO] --- maven-surefire-plugin:2.20:test (default-test) @
> surefire-2_20-slowdown-reproducer ---
> [INFO]
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> [INFO] Running org.test.AppTest
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01
> s - in org.test.AppTest
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
> 
> [INFO] BUILD SUCCESS
> [INFO]
> 
> [INFO] Total time: 6.595 s
> [INFO] Finished at: 2017-04-05T11:48:06+02:00
> [INFO] Final Memory: 16M/212M
> [INFO]
> 
>
> On Wed, Apr 5, 2017 at 11:26 AM, Tibor Digana-2 [via Maven] <
> ml-node+s40175n5904641...@n5.nabble.com> wrote:
>
> > Discussion to Release Vote of Surefire 2.20.
> > Project to reproduce an issue
> > https://github.com/psiroky/surefire-2_20-slowdown-reproducer
> > Forked JVM is waiting 30 seconds to die.
> >
> > I guess the JVM does not exit due to non-daemon threads.
> > Question is why we can see RMI Threads however no test is using RMI.
> >
> > --
> > Cheers
> > Tibor
> >
> >
> > --
> > If you reply to this email, your message will be added to the discussion
> > below:
> > http://maven.40175.n5.nabble.com/surefire-2-20-slowdown-
> > reproducer-tp5904641.html
> > To start a new topic under Maven Developers, email
> > ml-node+s40175n142166...@n5.nabble.com
> > To unsubscribe from Maven Developers, click here
> > <
> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code=142166=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==
> >
> > .
> > NAML
> > <
> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer=instant_html%21nabble%3Aemail.naml=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml
> >
> >
>
>
>
>
> --
> View this message in context:
> http://maven.40175.n5.nabble.com/surefire-2-20-slowdown-reproducer-tp5904641p5904652.html
> Sent from the Maven Developers mailing list archive at Nabble.com.

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20

[Petr Široký]

Hello,

I've tried with several projects and functionally, everything seems OK.

However, I noticed certain slowdown in case multiple forks are beings used
to run the tests. After some investigation, it seems one of the forked VMs
gets "stuck" for about 30s before it gets shutdown. So every surefire:test
or failsafe:test run results in 30s delay (if multiple forks were used).

I've created a simple reproducer -
https://github.com/psiroky/surefire-2_20-slowdown-reproducer . When running
"mvn clean test -s settings.xml" you can see the 30s waiting after the
tests were executed. The repo also contains thread dumps for both the main
Maven process and the surefire's ForkedBooter.

I am running on Fedora 25 + JDK 8u121. Tried with Maven 3.2.5 and the
staged 3.5.0.

Can someone confirm the above, or is just some quirk in my local env?

Thanks,
Petr

On Tue, Apr 4, 2017 at 10:13 PM Tibor Digana  wrote:

> Hi,
>
> We solved 65 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12334636
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1328/
>
> https://repository.apache.org/content/repositories/maven-1328/org/apache/maven/surefire/surefire/2.20/surefire-2.20-source-release.zip
>
> Source release checksum(s):
> surefire-2.20-source-release.zip sha1:
> 100e4074a819ed1f8aecb94ef2a71c3c818ec542
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor
>

Re: [VOTE] Release Apache Maven 3.5.0

[Petr Široký]

+1 (non-binding)

Tested on several big projects, with dozens of different plugins. No issue
found.

On Tue, Apr 4, 2017 at 12:14 AM Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

> Hi,
>
> We solved 86 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12336084=Text
>
> In there are 324 issues left in JIRA for Maven core:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1326
>
> The distributable binaries and sources for testing can be found here:
>
> https://repository.apache.org/content/repositories/maven-1326/org/apache/maven/apache-maven/3.5.0/
>
> Specifically the zip, tarball, and source archives can be found here:
>
> https://repository.apache.org/content/repositories/maven-1326/org/apache/maven/apache-maven/3.5.0/apache-maven-3.5.0-bin.zip
>
> https://repository.apache.org/content/repositories/maven-1326/org/apache/maven/apache-maven/3.5.0/apache-maven-3.5.0-bin.tar.gz
>
> https://repository.apache.org/content/repositories/maven-1326/org/apache/maven/apache-maven/3.5.0/apache-maven-3.5.0-src.zip
>
> https://repository.apache.org/content/repositories/maven-1326/org/apache/maven/apache-maven/3.5.0/apache-maven-3.5.0-src.tar.gz
>
> Source release checksum(s):
> apache-maven-3.5.0-src.tar.gz sha1:
> 1730812af1cdd77493e269b371ef8ac536230c15
> apache-maven-3.5.0-src.zip sha1: 40b18ca1d4e14a04a5b872c822f37f6578a17cb9
>
> Git tag:
>
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=ff8f5e7444045639af65f6095c62210b5713f426
>
> Staging site:
> https://maven.apache.org/components/ref/3-LATEST/
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
>
> Thanks,
> -Stephen
>

Re: [VOTE] Release Apache Maven 3.5.0-alpha-1

[Petr Široký]

Hello,

I've tested the 3.5.0-alpha-1 with several quite large projects (hundreds
of modules in total) and everything looks good.

+1 non-binding (hopefully I understood correctly I can do that)

Petr

On Fri, Feb 24, 2017 at 11:13 AM Stephen Connolly <
stephen.alan.conno...@gmail.com> wrote:

> https://issues.apache.org/jira/browse/MNG-6178 created
>
> On 23 February 2017 at 21:56, Christian Schulte  wrote:
>
> > Can we have this patch included? I wanted to commit this to master
> > yesterday when the build job succeeded. This is just pending the Jenkins
> > update to get the job succeed. I would just merge it to master now.
> >
> >  > shortlog;h=refs/heads/MNG-5889>
> >
> >  > 37b5f27080006883613800127d70e8233210555e>
> >
> > So that we do not need to re-open MNG-5889 or even create a new issue.
> > Otherwise
> >
> > +1
> >
> > No objections to get a release out.
> >
> > Regards,
> > --
> > Christian
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >
>