[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 closing, https://github.com/apache/maven/commit/66fc74d6296ea0a33f8a9712dc5ed5eb3affd529 provides more comprehensive adjustments for JSR-330 annotations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #116: Fix jsr-330 injection of DefaultArtifactDescriptorR...
Github user jdillon closed the pull request at: https://github.com/apache/maven/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 Igor's change is the more correct/ideal change to avoid future mismatch between plexus-annotation configuration and JSR-330 annotations. The problem is that plexus @Requirement injects directly to the field, but JSR-330 uses @Inject on the ctor, and the ctor impl ignores one of the parameters and doesn't fully setup the object properly. Its generally bad to have a mix of these annotations, as the lifecycle between plexus and jsr-330 is slightly different, but if you do mix them, you have to ensure that both means wire up the object correctly. My change simply fixes the bug, so that the versionRangeResolver component, which is required for the DefaultArtifactDescriptorReader impl to function properly actually gets set. My recommendation is you merge this change as its very simple and easy to comprehend (or at least I thought) and then consider merging Igor's change as this is more ideal for the future of the library. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 Igor already created https://issues.apache.org/jira/browse/MNG-6233 but if you really need another issue I can file one just to fix this specific problem. Seems a bit odd though that you want an IT to apply a clear coding mistake due to the ctor parameter being ignored and not setting the component causing NPE when used. :-( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 Hey folks can we get some movement on this and/or https://github.com/apache/maven/compare/MNG-6233_maven-resolver-provider-jsr330 ATM its broken, either of these fixes the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 @ifedorenko ftr I can close this, so but i'm confused about @michael-o comment that your change (I think that is what he meant) wasn't suitable for a patch release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 @ifedorenko can close this if you like, wasn't sure what you mean about "a JIRA either way". If we close this and go with your changes (which if you have that mostly done for merge soon is what I would suggest over this). For now I'm assuming you'll merge you changes and file a JIRA, but if you need a JIRA specifically about this bug I can file it if you need. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 @ifedorenko howdy, i'm fine to wait if you are gonna adjust to jsr330 that will be better generally for the project anyways IMO; i'm just trying to learn how to use the api and can live with this change locally for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 the plexus @Requirement injection is probably why this works at all in Maven, though w/o using maven-resolver-provider in a pure guice/sisu environment, this fails and causes NPE: ``` java.lang.NullPointerException at org.apache.maven.repository.internal.DefaultModelResolver.resolveModel (DefaultModelResolver.java:198) at org.apache.maven.model.building.DefaultModelBuilder.readParentExternally (DefaultModelBuilder.java:1051) at org.apache.maven.model.building.DefaultModelBuilder.readParent (DefaultModelBuilder.java:829) at org.apache.maven.model.building.DefaultModelBuilder.build (DefaultModelBuilder.java:331) at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom (DefaultArtifactDescriptorReader.java:321) at org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.readArtifactDescriptor (DefaultArtifactDescriptorReader.java:199) at org.eclipse.aether.internal.impl.DefaultDependencyCollector.resolveCachedArtifactDescriptor (DefaultDependencyCollector.java:544) at org.eclipse.aether.internal.impl.DefaultDependencyCollector.getArtifactDescriptorResult (DefaultDependencyCollector.java:528) at org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:418) at org.eclipse.aether.internal.impl.DefaultDependencyCollector.processDependency (DefaultDependencyCollector.java:372) at org.eclipse.aether.internal.impl.DefaultDependencyCollector.process (DefaultDependencyCollector.java:360) at org.eclipse.aether.internal.impl.DefaultDependencyCollector.collectDependencies (DefaultDependencyCollector.java:263) at org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies (DefaultRepositorySystem.java:325) ... ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request #116: Fix jsr-330 injection of DefaultArtifactDescriptorR...
GitHub user jdillon opened a pull request: https://github.com/apache/maven/pull/116 Fix jsr-330 injection of DefaultArtifactDescriptorReader ... which is not setting the VersionRangeResolver; cause NPE when use w/o plexus requirement injection You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdillon/maven DefaultArtifactDescriptorReader-injection-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/116.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #116 commit 0c3f3a42262c5692742abc73042a1deece0898e0 Author: Jason Dillon <ja...@planet57.com> Date: 2017-05-14T19:45:11Z Fix jsr-330 injection of DefaultArtifactDescriptorReader; which was not setting the VersionRangeResolver --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven issue #81: Hook up gossip as slf4j backend and implement customized co...
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/81 @jvanzyl I believe the output issues were sorted, but was still seeing some odd failures with what looked like resolution mismatches, downloading a version of one artifact but ending up with a slightly different version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: Hook up gossip as slf4j backend and implement ...
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-221441322 Updated gossip to 2.0.0 release which is now in central. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-221379335 Updated gossip to 2.0.0 which is now in com.planet57 namespace and I can make a release of it shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220746222 @michael-o yup, that is what is used internally by AnsiConsole.wrapOutputStream() to _help_ detect if it should strip sequences or not, but its not a proper public api to consume directly atm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220744680 @michael-o the jansi library has some limited support to detect tty when wrapping and potentially strip sequenced. I've pushed a change which makes the gossip listener aware of ansi by default and will escape by default when using > and in the case of -l I had to add a minor hack to force it to strip via system property. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220743522 @michael-o w/o making more of the embedder aware of potential colorization its not easy to do. I will push an example which should make > and -l work but it does involve adding a system property when the -l option is processed to strip out ansi. The slf4j logging configuration presently does not have any context of the cli options, so its hard to make it fully aware of the configuration w/o such hacks, or potentially augmenting the api to configure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...
Github user jdillon commented on a diff in the pull request: https://github.com/apache/maven/pull/81#discussion_r64118607 --- Diff: pom.xml --- @@ -282,6 +282,16 @@ 1.1.7 true + +org.sonatype.gossip +gossip-slf4j +1.9-SNAPSHOT --- End diff -- Yup, working on that; marked the PR as WIP until I can get this sorted out --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: Hook up gossip as slf4j backend and implement ...
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220737076 Pending a groupId update to get a release of gossip which has a few minor bug fixes to make the core-it-suite happy. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven pull request: Hook up gossip as slf4j backend and implement ...
GitHub user jdillon opened a pull request: https://github.com/apache/maven/pull/81 Hook up gossip as slf4j backend and implement customized color renderer Replaces slf4j-simple with gossip-slf4j ( https://github.com/jdillon/gossip ) and adds support for colorized output.  To enable colorized output: ``` MAVEN_OPTS="-Dmaven.logging=color" bin/mvn ``` or set in ~/.mavenrc Presently has to be passed in via MAVEN_OPTS as there is no context to access the -D flags early enough to configure the backend w/o more changes to the Slf4jConfiguration api. Default is presently plain, so users need to elect to use color explicitly as described above. Colorization is a subset of the color handling available in mvnsh, as this can only colorize log events, so anything going directly to output streams (like bits from surefire, etc) can not be colorized by this mechanism. Left the assembly conf/logging/* bits alone, as its not clear if other configurations are expecting this directory to exist or not, but likely should be cleaned up. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdillon/maven gossip-slf4j-backend Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven/pull/81.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #81 commit bedba47f7ac1275502ae0ab1ec9e2c291921674f Author: Jason Dillon <ja...@planet57.com> Date: 2016-05-16T19:34:21Z Hook up gossip as slf4j backend and implement customized color renderer --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: Allow includes and excludes to be read from fi...
Github user jdillon closed the pull request at: https://github.com/apache/maven-surefire/pull/7 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
maven-surefire pull request: Allow includes and excludes to be read from fi...
GitHub user jdillon opened a pull request: https://github.com/apache/maven-surefire/pull/7 Allow includes and excludes to be read from files You can merge this pull request into a Git repository by running: $ git pull https://github.com/sonatype/maven-surefire include-exclude-from-file Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-surefire/pull/7.patch commit f677821da575655aab4c0f9f93ca4815fdf2a2b7 Author: Jason Dillon ja...@planet57.com Date: 2012-11-08T18:19:39Z Allow includes and excludes to be read from files - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
