On Sun, Feb 23, 2020 at 10:21 AM Tibor Digana wrote:
>
> Alright! There is no question about yes or no to shade. The right answer is
> yes.
> We always do it and we have reason for that for 13 years.
> Why? Because of the gson project may risk the conflicts with surefire JVM
> and surefire
Catching a bit late but if it helps we can extract the needed parts from
johnzon and do a j6 friendly module, this would all stay apache so no legal
issue at all - or johnzon cna be forked if code is very localized if
preferred.
Le dim. 23 févr. 2020 à 21:52, Vladimir Sitnikov <
> Copyright problem in Google sources.
Are you going to copy gson sources to maven source code?
If you do that, you need to keep the copyright.
Are you going to take the jar and optionally shade it?
In that case you need to check if gson.jar is accompanied with NOTICE file.
If notice is there,
Alright! There is no question about yes or no to shade. The right answer is
yes.
We always do it and we have reason for that for 13 years.
Why? Because of the gson project may risk the conflicts with surefire JVM
and surefire transitive dependencies.
The same reason to shade Maven Shared Utils,
On Sun, Feb 23, 2020 at 9:34 AM Vladimir Sitnikov
wrote:
>
> >Why not using XML and built in java support?
>
> It is no longer built-in:
> https://www.oracle.com/technetwork/java/javase/11-relnote-issues-5012449.html#JDK-8190378
>
What was removed was badly architected data binding packages that
On Sun, Feb 23, 2020 at 9:03 AM Enrico Olivelli wrote:
>
> Elliotte,
> This is about surefire, we cannot pollute Java classpath of running tests.
> The library should be loaded with a special class loader, it would be more
> complex than writing a simple hard coded coder/decoder as we already
>Why not using XML and built in java support?
It is no longer built-in:
https://www.oracle.com/technetwork/java/javase/11-relnote-issues-5012449.html#JDK-8190378
Vladimir
Elliotte,
This is about surefire, we cannot pollute Java classpath of running tests.
The library should be loaded with a special class loader, it would be more
complex than writing a simple hard coded coder/decoder as we already have
in surefire
Enrico
Enrico
Il Dom 23 Feb 2020, 14:59 Elliotte
I would prefer not to add a shaded jar if it is not really needed.
Il Dom 23 Feb 2020, 11:57 Vladimir Sitnikov
ha scritto:
> > Here the GSON library is only one
>
> https://github.com/FasterXML/jackson-jr is 100KiB or so.
> Have you checked it?
>
This is very interesting
Jackson Databind
Why do you need to shade this at all? GSON should work just fine as a
normal library. Shading is a last resort that usually causes more
problems than it solves:
https://jlbp.dev/JLBP-18.html
On Sun, Feb 23, 2020 at 2:43 AM Tibor Digana wrote:
>
> I want to ask you if it is still legal to shade
> Here the GSON library is only one
https://github.com/FasterXML/jackson-jr is 100KiB or so.
Have you checked it?
Vladimir
Shade has option exclude rules if you wanted to slim down that side of it,
and still stick with Jackson.
Shading itself should alter the should or shouldn't aspect of
library/package linkage within a app/lib/service/plugin/solution. You're
guided by imports in Java-land - Apache license stuff
I want to use JSON because the data structures can be better transferred
over a channel, easier extend and the current algorithm can be removed.
The jackson is actually 3 libraries and very big to shade (few megabytes).
The MJson library is very old without long support.
Here the GSON library is
Tibor,
can you please explain better your intent ?
Is it about shading it into surefire booter ?
Enrico
Il giorno dom 23 feb 2020 alle ore 08:43 Tibor Digana
ha scritto:
>
> I want to ask you if it is still legal to shade packages in gson library.
> Although it contains the Apache 2.0 license
I want to ask you if it is still legal to shade packages in gson library.
Although it contains the Apache 2.0 license but it contains Copyright (C)
2010 Google Inc. as well, see:
https://github.com/google/gson/blob/master/gson/src/main/java/com/google/gson/stream/JsonReader.java
--
Cheers
15 matches
Mail list logo
