Re: Typed Error Handling in Mesos

2016-04-06 Thread Bernd Mathiske
+1 Another use case: https://github.com/mesosphere/marathon/commit/d616c05619753e398e882fa8d80e35e137775b30 https://issues.apache.org/jira/browse/MESOS-2522

Re: Making 'curl' a prerequisite for installing Mesos

2016-03-03 Thread Bernd Mathiske
+1 > On Mar 3, 2016, at 6:10 PM, Jie Yu wrote: > > Hi, > > I am proposing making 'curl' a prerequisite when installing Mesos. Currently, > we require 'libcurl' being present when installing Mesos > (http://mesos.apache.org/gettingstarted/ >

Re: [VOTE] Release Apache Mesos 0.27.1 (rc1)

2016-02-17 Thread Bernd Mathiske
+1 (binding) Test failures look a lot like with 0.27.0. Not clean, but nothing deemed too drastic yet. CentOS 7 plain: FetcherCacheHttpTest.HttpCachedSerialized flaky again, filed MESOS-4692 LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem known as flaky: MESOS-4674

Re: Mesos 0.27.0 release update

2016-01-25 Thread Bernd Mathiske
Hi Sarjeet, I hope we fixed this in upcoming 0.27: https://issues.apache.org/jira/browse/MESOS-4304 Bernd > On Jan 25, 2016, at 7:30 PM, Sarjeet Singh wrote: > > I ran into an issue when tried Mesos 0.26 version

Re: `F()` vs `F(void)`

2016-01-21 Thread Bernd Mathiske
High five! > On Jan 21, 2016, at 12:40 AM, Michael Park wrote: > > `void` parameters are no longer with us. > > https://github.com/apache/mesos/commit/93a5708294d6d66a5e1350a0bb1c8fe87605ee1d > https://github.com/apache/mesos/commit/05f9fb2fa66968f37418d28fc8cebd0770a54dca >

Re: Mesos build & testing environment instructions

2016-01-06 Thread Bernd Mathiske
+1. (Really exited about this prospect!) This kind of documentation is not necessarily for “testing” only. How can we expect certain features to run in production if they don’t pass the unit tests on a given platform? So I am in favor of the “let’s expand our existing install instructions”

Re: [VOTE] Release Apache Mesos 0.26.0 (rc4)

2015-12-10 Thread Bernd Mathiske
ome of the time. While it is rare in CI, it appeared in a > colleague's cluster for about a third of the tasks he was launching to > demonstrate how he ran into this. The fix is trivial and is in review. > > Thoughts? > > On Tue, Dec 8, 2015 at 7:01 AM, Bernd Mathiske <be...@mesosph

Re: [VOTE] Release Apache Mesos 0.26.0 (rc4)

2015-12-08 Thread Bernd Mathiske
+1 (binding) Ran make check, make distcheck, sudo bin/mesos-tests.sh, with SSL enabled and without on: Ubuntu 12.04, CentOS 7.1. Had 4 test failures with CentOS 7.1 for each configuration variant. All of the failed tests are known to be flaky, they have MESOS tickets, and they have been

Re: [VOTE] Release Apache Mesos 0.26.0 (rc3)

2015-12-07 Thread Bernd Mathiske
We found an issue with the v1 API, which is not completely on par with the legacy mesos.proto. Spinning RC4 shortly… > On Dec 7, 2015, at 10:48 AM, Bernd Mathiske <be...@mesosphere.io> wrote: > > +1 (binding) > > Ubuntu 14 (clean without SSL, a few known flaky tests w

How to write numbers in docs

2015-12-03 Thread Bernd Mathiske
Should numbers be written as digits (1) or as words (one) in markdown docs? When and how to decide? How to be consistent about this? Do you even care? Anyway, here is a proposal from Jörg to make this easy: https://reviews.apache.org/r/40292/ The proposal

Re: [VOTE] Release Apache Mesos 0.26.0 (rc3)

2015-12-02 Thread Bernd Mathiske
We are still working on that, but we do not regard "make distcheck" on Mac as blocker. Other opinions? > On Dec 2, 2015, at 2:27 PM, Alex Rukletsov wrote: > > `make check -j7` — OK > `make distcheck -j7` — fails, probably MESOS-3973 >

Re: [VOTE] Release Apache Mesos 0.26.0 (rc1)

2015-11-16 Thread Bernd Mathiske
All, while we are investigating this test failure, and holding the release back, additional feedback on how rc-1 is performing is still welcome. Bernd > On Nov 14, 2015, at 3:14 AM, Marco Massenzio wrote: > > -1 > (non-binding) > > Run on CentOS 7.1 > Builds and all

Re: Add JIRA ticket# to `TODO`s in comments

2015-11-09 Thread Bernd Mathiske
+1 on converting lots of TODOs into JIRAs with links to them in the TODOs. Questions with opinions: - Do we need to create extra tickets like “Edit TODO to mention ticket MESOS-XXX”? I suppose not. - Do we even need an RR for updating a TODO? I suppose yes. - Can we do several TODO updates at

Re: More Project Structure in JIRA

2015-11-09 Thread Bernd Mathiske
gt; >>>> 2015-10-19 16:09 GMT+08:00 Alexander Rojas <alexan...@mesosphere.io>: >>>> >>>>> +1 Yes please! >>>>> >>>>>> On 15 Oct 2015, at 10:11, Bernd Mathiske <be...@mesosphere.io> >>> wrote: >&g

Re: Mesos Style Guideline Adjustments

2015-11-09 Thread Bernd Mathiske
soft rule for >>>> comments >>>>>> is hard to enforce. I think what we can do is to encourage >>> contributors >>>> / >>>>>> committers to wrap comments in the most logical way—like the first >>>> comment >>

Re: Finish Oversubscription before 0.26.0?

2015-11-06 Thread Bernd Mathiske
twitter.com > <mailto:j...@twitter.com>> wrote: > I would say the MVP is done. Of course, there'll be some followup improvement > to the feature, and all the remaining issues are within that category. I am > fine resolving this epic. Any one has any objection? > > - Jie &

Re: Finish Oversubscription before 0.26.0?

2015-11-06 Thread Bernd Mathiske
Scratch that. We already announced this with Mesos 0.23. Only the epic never got closed. And we merely improved the feature since 0.23. So, no exciting new features in 0.26.0 AFAIK. > On Nov 6, 2015, at 11:16 AM, Bernd Mathiske <be...@mesosphere.io> wrote: > > Cool! So we n

Finish Oversubscription before 0.26.0?

2015-11-05 Thread Bernd Mathiske
All who worked on MESOS-354, What’s the status of the Oversubscription epic? Can we already call it a feature in 0.26? Shall we wait a few days to finish it? Will it slip into 0.27? I see only 6 unresolved tickets and lots of resolved ones here: https://issues.apache.org/jira/browse/MESOS-354

Re: Backticks in comments

2015-11-04 Thread Bernd Mathiske
+1 > On Nov 2, 2015, at 8:34 PM, Isabel Jimenez > wrote: > > +1 for backticks, same comment as Kapil, really nice to be able to make a > difference from string literals. > > On Mon, Nov 2, 2015 at 11:26 AM, Kapil Arya wrote: > >> +1 for

Re: RFC: license headers interfere with doxygen documentation (MESOS-3581)

2015-10-21 Thread Bernd Mathiske
phere.io> >> wrote: >> >>> +1 for (a). >>> >>> >>> — >>> *Joris Van Remoortere* >>> Mesosphere >>> >>> On Tue, Oct 20, 2015 at 3:02 PM, Benjamin Mahler < >>> benjamin.mah...@gmail.com> >>

Re: RFC: license headers interfere with doxygen documentation (MESOS-3581)

2015-10-21 Thread Bernd Mathiske
>>>> +1 for (a). >>>> >>>> >>>> — >>>> *Joris Van Remoortere* >>>> Mesosphere >>>> >>>> On Tue, Oct 20, 2015 at 3:02 PM, Benjamin Mahler < >>>> benjamin.mah...@gmail.com> >>>&g

Re: RFC: license headers interfere with doxygen documentation (MESOS-3581)

2015-10-20 Thread Bernd Mathiske
All, is changing every source code file prohibitive or not? > On Oct 20, 2015, at 10:01 AM, Benjamin Bannier > wrote: > > Hi, > > I would like to ask for input on how we plan to fix (both short- and > longterm) the interference of the license headers and

Towards Mesos release 0.26.0

2015-10-19 Thread Bernd Mathiske
Dear Mesos fans, this is the tracking ticket for the upcoming next Mesos release. https://issues.apache.org/jira/browse/MESOS-3758 Please read the ticket’s description for further instructions and tips on how to get features and other

Re: Community Sync Interval

2015-10-16 Thread Bernd Mathiske
+1 for bi-weekly and I have been assuming rotating times in the first place, as I suspect many others as well. (9am and 3pm are not very far apart. Probably better to go for 8am and 5pm or something like that.) > On Oct 16, 2015, at 11:08 AM, haosdent wrote: > > If we

More Project Structure in JIRA

2015-10-15 Thread Bernd Mathiske
Proposal: in extension of today’s limited two-level (epic, task) approach, make full use of expressive power already available in JIRA to provide more structure for larger projects to facilitate planning, tracking, and reporting. This will facilitate dynamically planning of sub-projects, which

Re: [VOTE] Release Apache Mesos 0.25.0 (rc2)

2015-10-08 Thread Bernd Mathiske
I have the exact same result as Greg. > On Oct 8, 2015, at 12:14 AM, Greg Mann wrote: > > Successfully built `sudo make distcheck` on CentOS 7.1 and Ubuntu 14.04 > with only expected test failures. On our Fedora 22 CI build, however, while > the tests are building the

Re: [VOTE] Release Apache Mesos 0.25.0 (rc2)

2015-10-08 Thread Bernd Mathiske
I suppose this makes my vote +1 binding, assuming the cherry-picking happens. > On Oct 8, 2015, at 3:37 PM, Bernd Mathiske <be...@mesosphere.io> wrote: > > I have the exact same result as Greg. > >> On Oct 8, 2015, at 12:14 AM, Greg Mann <g...@mesosphere.io> wr

Re: MesosCon EU Hackathon hot list?

2015-10-06 Thread Bernd Mathiske
Hi Soheila, I have worked on the fetcher cache, but I won’t be at MesosCon Europe. Nevertheless, I am interested in this problem area, so I want to support your effort, also after MesosCon. Bernd > On Oct 5, 2015, at 6:49 PM, Soheila Dehghanzadeh wrote: > > Hi Casey,

Re: Mesos Style Guideline Adjustments

2015-09-10 Thread Bernd Mathiske
t;>> >> https://github.com/apache/mesos/commit/f9c2604ea97b91f8a9ec3b2863317761679b1c86 >>> Also, based on the comments, it seems like we should allow 80 column >>> comments but omit the sweeping change. >>> Thanks, >>> MPark. >>> On Wed, Au

Re: [VOTE] Release Apache Mesos 0.24.0 (rc2)

2015-09-04 Thread Bernd Mathiske
+1 [binding] MacOS X (make check) CentOS 7 (make distcheck) Ubuntu 14.4 (make distcheck) > On Sep 3, 2015, at 11:47 PM, Niklas Nielsen wrote: > > +1 - tested on our CI > > On Tuesday, September 1, 2015, Vinod Kone >

Re: [VOTE] Release Apache Mesos 0.24.0 (rc2)

2015-09-04 Thread Bernd Mathiske
And also Ubuntu 13.10: [ FAILED ] ExamplesTest.PythonFramework, known flaky test, so still +1 > On Sep 4, 2015, at 9:11 PM, Bernd Mathiske <be...@mesosphere.io> wrote: > > +1 [binding] > > MacOS X (make check) > CentOS 7 (make distcheck) > Ubuntu 14.4 (make distche

Re: Lets stop using the CHECK macro in the test harness.

2015-08-15 Thread Bernd Mathiske
+1, but… If we are going to touch all our tests, then IMHO while at it we might as well make a jump forward to something better than the current local return void to abort tests in macros. If we used exceptions instead, it should be easy to catch those in a wrapper somewhere in the test

Re: Prepping for next release

2015-08-14 Thread Bernd Mathiske
I just committed it. Thanks, James! On Aug 13, 2015, at 9:53 PM, James DeFelice james.defel...@gmail.com wrote: Hi Vinod, Would *really* like to see https://issues.apache.org/jira/browse/MESOS-2841 in 0.24.0. Currently in review. Any chance that can make it in? On Wed, Aug 12,

Re: Mesos Style Guideline Adjustments

2015-08-12 Thread Bernd Mathiske
Like BenM, +1 on allowing 80 column comments -1 on sweeping changes; incremental changes when touching old comments will do IMHO Bernd On Aug 12, 2015, at 12:51 AM, Michael Park mcyp...@gmail.com wrote: Ben, thanks for your input! Another update on this topic: the patches around break

Re: Beware of ASSERT_* Placement

2015-07-28 Thread Bernd Mathiske
IMHO we would be better off with exception-based asserts, checks, and expects. Bernd On Jul 28, 2015, at 7:53 AM, Paul Brett pbr...@twitter.com.INVALID wrote: Michael I think Ben's suggestion of using Try is just what we want for common functions. In regards to ASSERTs, they can cause

Re: Doxygen / Javadoc changes

2015-07-10 Thread Bernd Mathiske
s/non-/ On Jul 10, 2015, at 2:27 AM, Benjamin Hindman b...@eecs.berkeley.edu wrote: We're only using non-javadoc comments for APIs, which are mostly in headers. We're still using // based C++ comments in implementations and places we don't want to be picked up via doxygen. On Thu, Jul 9,

Doxygen style for libprocess: JavaDoc vs. Triple-Slash (and others?)

2015-06-02 Thread Bernd Mathiske
Are you interested in what style is being proposed for documenting libprocess? (And subsequently, there is a good chance that more of Mesos source code may be enhanced in the same way.) If so, please check out my most recent comment in this ticket:

Re: [jira] [Closed] (MESOS-2780) Non-POD static variables

2015-06-01 Thread Bernd Mathiske
Sorry, did I say MESOS-2777? I meant MESOS-2779! On Jun 1, 2015, at 10:10 AM, Bernd Mathiske be...@mesosphere.io wrote: Fair enough. How about making the JIRA tickets easier to spot as different by making their summary at least a little bit different from each other? My impression

Re: [jira] [Closed] (MESOS-2780) Non-POD static variables

2015-06-01 Thread Bernd Mathiske
within the code base should be corrected. Should MESOS-2777 have a coverity report attached listing these defects? -- Paul On Fri, May 29, 2015 at 8:18 AM, Bernd Mathiske (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/MESOS-2780?page

How to reference images in /docs?

2015-05-19 Thread Bernd Mathiske
When adding/editing MD documentation in the “docs” folder of the Mesos workspace, I’d like to add some graphics. I have found two pre-existing approaches. 1. In mesos-architecture.md, we find: ![Mesos Architecture](http://mesos.apache.org/assets/img/documentation/architecture3.jpg) 2. In

Apache Mesos Committer Checklist

2015-05-08 Thread Bernd Mathiske
As mentioned at the community meeting at Twitter headquarters yesterday, a few of us have compiled a list that Apache Mesos committer candidates can use to gather material for their nomination. It is in no way binding. Just a collection of categories of achievements and behaviors that can be

Re: Review Request 33263: Extended SlaveTest.ShutdownUnregisteredExecutor test with a reason check.

2015-04-16 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33263/#review80332 --- Ship it! - Bernd Mathiske On April 16, 2015, 7:31 a.m., Andrey

Re: Changing Mesos Minimum Compiler Version

2015-04-13 Thread Bernd Mathiske
+1 On Apr 10, 2015, at 6:02 PM, Michael Park mcyp...@gmail.com wrote: +1 On 9 April 2015 at 17:33, Alexander Gallego agall...@concord.io wrote: This is amazing for native devs/frameworks. Sent from my iPhone On Apr 9, 2015, at 5:16 PM, Joris Van Remoortere jo...@mesosphere.io

Re: Review Request 30774: Fetcher Cache

2015-04-13 Thread Bernd Mathiske
On March 18, 2015, 11:05 a.m., Timothy Chen wrote: src/slave/containerizer/fetcher.cpp, line 491 https://reviews.apache.org/r/30774/diff/37/?file=897704#file897704line491 Why not just mock _fetch and do a barrier on it by giving it a promise in test? Bernd Mathiske wrote

Re: Changing Mesos Minimum Compiler Version

2015-04-13 Thread Bernd Mathiske
Yeah! +1 On Apr 10, 2015, at 6:02 PM, Michael Park mcyp...@gmail.com wrote: +1 On 9 April 2015 at 17:33, Alexander Gallego agall...@concord.io wrote: This is amazing for native devs/frameworks. Sent from my iPhone On Apr 9, 2015, at 5:16 PM, Joris Van Remoortere

Re: Review Request 30774: Fetcher Cache

2015-04-13 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review79838 --- On April 10, 2015, 4:33 a.m., Bernd Mathiske wrote

Re: Review Request 30774: Fetcher Cache

2015-04-13 Thread Bernd Mathiske
reservations and eviction disabling. - Eviction gets disabled for URIs that are currently in use, i.e. the related cache files are. We use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 29336: Recover docker containers that launched in containers.

2015-03-25 Thread Bernd Mathiske
- executorContainers - Bernd Mathiske On Jan. 16, 2015, 5:37 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29336

Re: Review Request 30218: Add version() to docker abstraction.

2015-03-25 Thread Bernd Mathiske
/#comment125942 It seems to me that you changed it to indefinite wait. - Bernd Mathiske On Jan. 23, 2015, 9:44 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30218

Re: Review Request 30774: Fetcher Cache

2015-03-24 Thread Bernd Mathiske
be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-22 Thread Bernd Mathiske
reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 32233: Replaced raw pointer by Owned pointer

2015-03-20 Thread Bernd Mathiske
://reviews.apache.org/r/32233/#comment125059 Can you please try again? Did you perhaps try this with an editor that uses TAB? You can use blanks to get the alignment you want, since we should replace TABs with blanks anyway. I downloaded your patch, appplied it and tried. It worked. - Bernd Mathiske

Re: Review Request 32233: Replaced raw pointer by Owned pointer

2015-03-20 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32233/#review77197 --- LGTM. Thanks! - Bernd Mathiske On March 20, 2015, 1:11 a.m

Re: Review Request 32233: Replaced raw pointer by Owned pointer

2015-03-20 Thread Bernd Mathiske
On March 20, 2015, 4:01 a.m., Bernd Mathiske wrote: LGTM. Thanks! Akanksha Agrawal wrote: Thank you! Could you please merge this? I'd love to, but I am not a committer. I see you have dedicated this review to Ben Mahler. He is a committer. I just wanted to help reviewing

Re: Review Request 30774: Fetcher Cache

2015-03-19 Thread Bernd Mathiske
/30774/#comment124786 The error case is handled right after line 711, which closes the branch for non-error. - Bernd Mathiske On March 17, 2015, 6:59 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail

Re: Review Request 30774: Fetcher Cache

2015-03-19 Thread Bernd Mathiske
, 2015, 6:59 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated March 17, 2015, 6:59 a.m

Re: Review Request 30774: Fetcher Cache

2015-03-19 Thread Bernd Mathiske
things like space reservations and eviction disabling. - Eviction gets disabled for URIs that are currently in use, i.e. the related cache files are. We use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-19 Thread Bernd Mathiske
use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 31986: Container ID is sent on each TaskStatus message back to the framework.

2015-03-19 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31986/#review77159 --- LGTM - Bernd Mathiske On March 13, 2015, 8:21 a.m., Alexander

Re: Review Request 30774: Fetcher Cache

2015-03-19 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review77057 --- On March 18, 2015, 11:43 p.m., Bernd Mathiske wrote

Re: Review Request 30774: Fetcher Cache

2015-03-19 Thread Bernd Mathiske
On Feb. 25, 2015, 10:56 a.m., Timothy Chen wrote: src/slave/containerizer/fetcher.cpp, line 528 https://reviews.apache.org/r/30774/diff/19/?file=875881#file875881line528 return size.error(); Bernd Mathiske wrote: That does not compile. Timothy Chen wrote: It doesn't

Re: Review Request 30774: Fetcher Cache

2015-03-19 Thread Bernd Mathiske
ref - return item This way no one needs to call reference(). Bernd Mathiske wrote: Renamed to getEntry(). I disagree with the plan to combine looking up entries and referencing them. I think this would make the code more error-prone, not less. It is too

Re: Review Request 30774: Fetcher Cache

2015-03-19 Thread Bernd Mathiske
On Feb. 24, 2015, 11:26 p.m., Timothy Chen wrote: docs/fetcher.md, line 68 https://reviews.apache.org/r/30774/diff/17/?file=872869#file872869line68 Not sure if putting the struct here is a good idea, as it's most likely going to be changed in the future. Bernd Mathiske wrote

Re: Review Request 30774: Fetcher Cache

2015-03-19 Thread Bernd Mathiske
if it failed log it there? Bernd Mathiske wrote: How would this be simpler and more readable? What is wrong with abstracting functions that are called only once? Doing so saves a comment / pulls what would have been a comment into code! Since we probably don't need a comment here, I'll

Re: Review Request 32233: Replaced raw pointer by Owned pointer

2015-03-19 Thread Bernd Mathiske
://reviews.apache.org/r/32233/#comment124839 dispatch(process.get(), ExternalContainerizerProcess::destroy, containerId); Testing done? - Bernd Mathiske On March 19, 2015, 6:47 a.m., Akanksha Agrawal wrote

Re: Review Request 30774: Fetcher Cache

2015-03-19 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review77025 --- On March 18, 2015, 11:43 p.m., Bernd Mathiske wrote

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

2015-03-18 Thread Bernd Mathiske
/32163/#comment124616 Also redundant. Looks good. Just small matters of taste marked in this review. First pass, have not looked at the tests yet. - Bernd Mathiske On March 18, 2015, 7:32 a.m., Alexander Rojas wrote

Re: Review Request 32233: Replaced raw pointer by Owned pointer

2015-03-18 Thread Bernd Mathiske
/external_containerizer.cpp https://reviews.apache.org/r/32233/#comment124776 1 param per line - Bernd Mathiske On March 18, 2015, 9:14 p.m., Akanksha Agrawal wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 30774: Fetcher Cache

2015-03-17 Thread Bernd Mathiske
use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-17 Thread Bernd Mathiske
reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 32108: Added manual make for readability training source code

2015-03-16 Thread Bernd Mathiske
. - Bernd Mathiske On March 16, 2015, 9:09 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32108/ --- (Updated

Review Request 32108: Added manual make for readability training source code

2015-03-16 Thread Bernd Mathiske
; make Thanks, Bernd Mathiske

Re: Review Request 30609: Added a function that reports file size, not following links.

2015-03-11 Thread Bernd Mathiske
c396c1d2d833b2f1721092fa35b23b5c3c3d99b3 Diff: https://reviews.apache.org/r/30609/diff/ Testing --- Wrote a simple test that creates a file and tests its size, and also checks if a non-existing file yields an error. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-11 Thread Bernd Mathiske
counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-11 Thread Bernd Mathiske
--- On March 7, 2015, 7:21 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated March 7, 2015

Re: Review Request 30774: Fetcher Cache

2015-03-11 Thread Bernd Mathiske
always want it to be required, I think we should make the sandbox a required field. Bernd Mathiske wrote: There was some discussion about whether this field should be required or not. The general idea here is that a task might be able to run without fetching anything into its sandbox

Re: Review Request 30774: Fetcher Cache

2015-03-11 Thread Bernd Mathiske
On March 2, 2015, 8:13 p.m., Timothy Chen wrote: src/slave/containerizer/fetcher.cpp, line 759 https://reviews.apache.org/r/30774/diff/25/?file=882228#file882228line759 If you're incrementing all the time just to count, why not just get the size from list? Bernd Mathiske wrote

Re: Review Request 30774: Fetcher Cache

2015-03-11 Thread Bernd Mathiske
in use, i.e. the related cache files are. We use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-11 Thread Bernd Mathiske
/#review75754 --- On March 7, 2015, 7:21 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774

Re: Review Request 30774: Fetcher Cache

2015-03-09 Thread Bernd Mathiske
. - Bernd --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review75700 --- On March 7, 2015, 7:21 a.m., Bernd Mathiske wrote

Re: Review Request 30774: Fetcher Cache

2015-03-07 Thread Bernd Mathiske
--- On March 6, 2015, 5:46 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774

Re: Review Request 30774: Fetcher Cache

2015-03-07 Thread Bernd Mathiske
fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-06 Thread Bernd Mathiske
in use, i.e. the related cache files are. We use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-06 Thread Bernd Mathiske
. To reply, visit: https://reviews.apache.org/r/30774/#review75491 --- On March 6, 2015, 5:46 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 30774: Fetcher Cache

2015-03-05 Thread Bernd Mathiske
/#review75266 --- On March 5, 2015, 3:15 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774

Re: Review Request 30774: Fetcher Cache

2015-03-05 Thread Bernd Mathiske
fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-04 Thread Bernd Mathiske
. - Eviction gets disabled for URIs that are currently in use, i.e. the related cache files are. We use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-03 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review74885 --- On March 3, 2015, 5:01 a.m., Bernd Mathiske wrote

Re: Review Request 30774: Fetcher Cache

2015-03-03 Thread Bernd Mathiske
attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-03 Thread Bernd Mathiske
attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-03 Thread Bernd Mathiske
. - Eviction gets disabled for URIs that are currently in use, i.e. the related cache files are. We use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-03 Thread Bernd Mathiske
attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-02 Thread Bernd Mathiske
space reservations and eviction disabling. - Eviction gets disabled for URIs that are currently in use, i.e. the related cache files are. We use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-01 Thread Bernd Mathiske
are. We use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-01 Thread Bernd Mathiske
be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-03-01 Thread Bernd Mathiske
attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30014: Enable the slave garbage collector to take the number of links into account.

2015-02-28 Thread Bernd Mathiske
then? Is this expected and handled well in therest of the code? src/slave/slave.cpp https://reviews.apache.org/r/30014/#comment121341 Won't this crash if we have set maxLinkUsage to Error in line 3645? . - Bernd Mathiske On Feb. 27, 2015, 2:48 p.m., Ritwik Yadav wrote

Re: Review Request 30606: Added net::contentLength() to query content-length field from HTTP header.

2015-02-28 Thread Bernd Mathiske
. Thanks, Bernd Mathiske

Re: Review Request 30792: Additonal use case for auto in C++ style guide: shared pointer creation.

2015-02-28 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30792/#review74419 --- On Feb. 10, 2015, 3:37 a.m., Bernd Mathiske wrote: --- This is an automatically

Re: Review Request 30014: Enable the slave garbage collector to take the number of links into account.

2015-02-27 Thread Bernd Mathiske
of the problem yet and so I would to see either more explanations based on system manuals or more evidence from testing or both. - Bernd Mathiske On Jan. 22, 2015, 1:35 p.m., Ritwik Yadav wrote: --- This is an automatically generated e-mail

  1   2   3   4   5   >