---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/#review56800
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 12, 2014, 1:08 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/#review56357
---
Ship it!
src/slave/main.cpp
On Oct. 10, 2014, 11:26 p.m., Till Toenshoff wrote:
src/slave/main.cpp, line 117
https://reviews.apache.org/r/26509/diff/5/?file=717907#file717907line117
Not yours but this would trigger a glog warning as it has not yet been
initialized. We should possibly check all runnables for
On Oct. 12, 2014, 6:56 p.m., Benjamin Hindman wrote:
src/slave/main.cpp, lines 126-127
https://reviews.apache.org/r/26509/diff/9/?file=718287#file718287line126
When we can use EXIT(1) please prefer it (see a few lines up for an
example). Looks like you can clean up the same from
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/
---
(Updated Oct. 12, 2014, 4:08 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/#review56362
---
Patch looks great!
Reviews applied: [26509]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/
---
(Updated Oct. 10, 2014, 6:04 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/#review56244
---
Bad patch!
Reviews applied: [26529, 26529]
Failed command: git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/#review56251
---
Ship it!
Barring that tiny style nit.
src/slave/main.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/
---
(Updated Oct. 10, 2014, 7:41 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/
---
(Updated Oct. 10, 2014, 7:43 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/
---
(Updated Oct. 10, 2014, 8:40 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/
---
(Updated Oct. 10, 2014, 8:46 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/#review56270
---
Bad patch!
Reviews applied: [26529]
Failed command: git apply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/
---
(Updated Oct. 10, 2014, 9:25 p.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/#review56274
---
Patch looks great!
Reviews applied: [26509]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/#review56024
---
src/slave/flags.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/
---
(Updated Oct. 9, 2014, 3:07 p.m.)
Review request for mesos and Niklas Nielsen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/#review56085
---
Bad patch!
Reviews applied: [26529, 26513]
Failed command: git
19 matches
Mail list logo
