Re: Add JIRA ticket# to `TODO`s in comments

+1 This also provides a way of removing TODO’s since they are traceable. If you look in the code, there are TODO’s which are no relevant anymore or probably cannot be understood from their actual context. > On 08 Nov 2015, at 05:50, Kapil Arya wrote: > > Folks, > > I

Re: Fetcher refactor proposal

+1 On Wed, Nov 11, 2015 at 1:57 AM, Jie Yu wrote: > Tom, I don't have immediate plan to replace CommandInfo::URI (with > executable/extract bits) with URI (in the doc), at least for now. The > existing Fetcher will still perform extraction, chown, etc. for now >

Re: Header include order

I remember discussing this issue a while ago on the mailing list [1]. There were two votes in favor from Benjamin Hindman and Benjamin Mahler, and no votes against it. There’s also an accepted Jira entry MESOS-2673 to add the ordering into our style guide. [1]

Re: Add JIRA ticket# to `TODO`s in comments

Kapil would you mind clarifying what is being proposed here? Folks are already free to include a reference to a ticket when writing a comment or a TODO, so is the suggestion here to require it for TODOs? Or to add a syntax for this? If it's the latter, what does the syntax achieve? On Wed, Nov

Re: Add JIRA ticket# to `TODO`s in comments

I think we should encourage people to follow this pattern, but not making this obligatory. I may be wrong, but I feel that sometimes we use `TODO`s as food for thought, not for something that should or will necessarily be implemented soon. A `TODO` may provide additional context to the

Re: Add JIRA ticket# to `TODO`s in comments

-1 for mandatory adding MESOS- to TODO. it makes it more cumbersome to add TODOs and, I fear, would discourage people from adding those. For example in a "chain", TODOs may be short-lived enough that adding a Jira would only add noise. I'm not even sure that (optionally) adding the Jira to

Re: Add JIRA ticket# to `TODO`s in comments

+1 for adding TODO(MESOS-) to the style guide as a soft requirement. I don't think it should be strictly required, since sometimes creating a JIRA ticket just doesn't make sense, but I do have the feeling that in *most* cases, our process would benefit from creating a JIRA at the moment a TODO

Re: Add JIRA ticket# to `TODO`s in comments

If we are going to track these TODOs on JIRA, I hope we add these as sub-tasks to the stories/epics and are not floating free. Which brings the question - how are epic completion timelines effected by these. -Jojy > On Nov 11, 2015, at 9:39 AM, Greg Mann wrote: > > +1 >

Re: Website update frequency

AFAIK, apply-reviews is used mainly by committers. Maybe some one can use to locally test a review chain of somebody else, but that is pretty rare. Regarding having apply-reviews to automatically push commits to the repo, we need to figure out the credentials delegation aspect. Ideally, it would

Re: Add JIRA ticket# to `TODO`s in comments

Hi Ben, On Wed, Nov 11, 2015 at 8:33 AM, Benjamin Mahler wrote: > Kapil would you mind clarifying what is being proposed here? Folks are > already free to include a reference to a ticket when writing a comment or a > TODO, so is the suggestion here to require it for

Re: Fetcher refactor proposal

+1 > On 11 Nov 2015, at 00:45, Jie Yu wrote: > > Hi, > > Fetcher was originally designed to fetch CommandInfo::URIs (e.g., executor > binary) for executors/tasks. A recent refactor (MESOS-336 > ) added caching support to >

Re: Add JIRA ticket# to `TODO`s in comments

+1, JIRA will include more discussion and we can close it when it has been improved. Da (Klaus), Ma (马达) | PMP® | Advisory Software Engineer Platform Symphony/DCOS Development & Support, STG, IBM GCG +86-10-8245 4084 | klaus1982...@gmail.com | http://k82.me On Wed, Nov 11, 2015 at 5:11 PM,

Sheperd wanted for new contributor

Hi, I'd like to work on MESOS-3307 "Configurable size of completed task / framework history" [1]. Can someone be the sheperd? I created accounts for jira and review with username "flx". I'd like to discuss my changes. There is already PR on github [2]. Thanks. Regards, Felix [1]: