Re: Adding "syntax=proto2" to Mesos public protobuf files

Thanks! I filed https://issues.apache.org/jira/browse/MESOS-6138. Is any committer willing to shepherd once I get a patch? On Wed, Sep 7, 2016 at 1:33 AM, Kevin Klues wrote: > I would promote doing the following as well if it doesn't break anything. >

Re: Adding "syntax=proto2" to Mesos public protobuf files

I would promote doing the following as well if it doesn't break anything. https://issues.apache.org/jira/browse/MESOS-5186 It would unblock tfmesos (a distributed tensorflow framework on Mesos) from working with an unmodified Mesos. On Wed, Sep 7, 2016 at 2:13 AM Greg Mann

Re: Adding "syntax=proto2" to Mesos public protobuf files

AFAICT, this shouldn't break anything, since by omitting the syntax specification we're effectively setting it to the default, "proto2". As a quick test, I added `syntax = "proto2";` to the top of mesos.proto, built Mesos, and then ran some tests - it seems to work fine! Greg On Tue, Sep 6,

Adding "syntax=proto2" to Mesos public protobuf files

Hi all, Does anyone see what could break if we add a line "syntax=proto2" to every public .proto files in Mesos codebase? Some of our internal project compiles against Mesos and we are manually adding this line because we also uses proto3 for internal files, and this is necessary for protoc to