Re: Review Request 15198: Added a flash service for UI alerts after redirects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15198/ --- (Updated Nov. 7, 2013, 11:28 p.m.) Review request for mesos. Bugs: MESOS-802

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

On Nov. 5, 2013, 10:08 p.m., Ben Mahler wrote: src/webui/master/static/js/services.js, lines 23-27 https://reviews.apache.org/r/15198/diff/2/?file=376995#file376995line23 Rather than a String or an Object, what if we only take an Object and allow the omission of title / bullets?

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15198/ --- (Updated Nov. 7, 2013, 11:31 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15198/#review28477 --- Ship it! Thanks Ross! - Ben Mahler On Nov. 7, 2013, 11:31 p.m.,

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15198/#review28299 --- Looks good, but how does this affect people who don't use flash?

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

On Nov. 6, 2013, 8:06 p.m., Brenden Matthews wrote: Looks good, but how does this affect people who don't use flash? I, for example, only use flash on an opt-in basis. I have it disabled by default unless I need to explicitly enable it. There's no actual Adobe Flash involved, and I

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

On Nov. 6, 2013, 8:06 p.m., Brenden Matthews wrote: Looks good, but how does this affect people who don't use flash? I, for example, only use flash on an opt-in basis. I have it disabled by default unless I need to explicitly enable it. Ross Allen wrote: There's no actual

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

On Nov. 4, 2013, 6:38 p.m., Ben Mahler wrote: src/webui/master/static/js/services.js, line 6 https://reviews.apache.org/r/15198/diff/2/?file=376995#file376995line6 Can we call this service alert? Since that seems to be the standard terminology for this kind of ui component, and

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

On Nov. 4, 2013, 6:38 p.m., Ben Mahler wrote: src/webui/master/static/js/services.js, line 6 https://reviews.apache.org/r/15198/diff/2/?file=376995#file376995line6 Can we call this service alert? Since that seems to be the standard terminology for this kind of ui component, and

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15198/#review28231 --- src/webui/master/static/js/services.js

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

On Nov. 5, 2013, 10:08 p.m., Ben Mahler wrote: src/webui/master/static/js/services.js, lines 23-27 https://reviews.apache.org/r/15198/diff/2/?file=376995#file376995line23 Rather than a String or an Object, what if we only take an Object and allow the omission of title / bullets?

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15198/ --- (Updated Nov. 2, 2013, 8:20 p.m.) Review request for mesos. Changes ---

Re: Review Request 15198: Added a flash service for UI alerts after redirects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15198/ --- (Updated Nov. 2, 2013, 8:41 p.m.) Review request for mesos. Repository: