elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1538838101
Hmmm, the patch has been merged, but the tests are failing: the positive
tests are OK, but the negative ones aren't.
Also the TLS protocol is not anymore supported by Java 8, I had to
[
https://issues.apache.org/jira/browse/DIRMINA-1122?focusedWorklogId=861065=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861065
]
ASF GitHub Bot logged work on DIRMINA-1122:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/DIRMINA-1122?focusedWorklogId=861070=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861070
]
ASF GitHub Bot logged work on DIRMINA-1122:
---
Author: ASF GitHub Bot
the-thing commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1538856723
Interesting. I can produce a patch quickly if I can recreate the failure. If
you could share some of the error logs or environment details it would be
helpful.
--
This is an automated
[
https://issues.apache.org/jira/browse/DIRMINA-1122?focusedWorklogId=861068=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861068
]
ASF GitHub Bot logged work on DIRMINA-1122:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/DIRMINA-1122?focusedWorklogId=861080=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861080
]
ASF GitHub Bot logged work on DIRMINA-1122:
---
Author: ASF GitHub Bot
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1539456424
Also tested something: using the **sniHostNames** instead of doing a
_peer.getHostString()_, changes nothing...
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/DIRMINA-1122?focusedWorklogId=861077=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861077
]
ASF GitHub Bot logged work on DIRMINA-1122:
---
Author: ASF GitHub Bot
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1539017831
FTR, here is a part of the logs I get when running the test with Java8:
```
javax.net.ssl|FINE|0F|CLIENT|2023-05-08 22:21:32.416
CEST|SSLExtensions.java:173|Ignore unavailable
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1539042180
Note that MINA 2.2.X don't have anymore a **PEER_ADDRESS** attribute, so we
have to go through the creation of a dedicated **SslFilter** class, which
extends the default **SslFilter** class.
[
https://issues.apache.org/jira/browse/DIRMINA-1122?focusedWorklogId=861081=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861081
]
ASF GitHub Bot logged work on DIRMINA-1122:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/DIRMINA-1122?focusedWorklogId=861078=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861078
]
ASF GitHub Bot logged work on DIRMINA-1122:
---
Author: ASF GitHub Bot
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1539039335
On the test, we use a custom SSLFilter which sets the peer:
```
protected SSLEngine createEngine(IoSession session,
InetSocketAddress addr) {
//Add your SNI
Jan Philipp created SSHD-1325:
-
Summary: Not useful sorting of signature algrithms?
Key: SSHD-1325
URL: https://issues.apache.org/jira/browse/SSHD-1325
Project: MINA SSHD
Issue Type: Bug
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1538929098
Actually, all the handshakes are passing, which make the *shouldFailXXX*
tests failing.
Here is the modified test class for MINA 2.2.X:
```
package org.apache.mina.filter.ssl;
the-thing commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1539019441
I applied the changes manually to 2.2.X. The peerAddress session attribute
has been removed, which was used to get the hostname for the SSL engine.
2.1.X -
16 matches
Mail list logo
