Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-16 Thread Dora Rajappan
  Thanks for explaining viewpool and viewstate. I will go through the code later and understand. I was wondering what happens when state saving method param is not set. I got your point it that the state saving algorithm is performed and when its not mentioned whether it state saving method is

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-16 Thread Leonardo Uribe
Hi If no state saving is set, the default is server. As I said before, the component tree and the calculated state are two different things and there is not any relationship. Really the separation of these two concepts and the introduction of a view pool as an effective way to keep memory usage

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-13 Thread Thomas Andraschko
Cool leo! Thanks for your effort :) 2013/12/13 Leonardo Uribe lu4...@gmail.com Hi Finally the code for View Pooling has been comitted. After some performance tests with the know demo application, it has been confirmed the following improvements: - A reduction of 25% of the transient

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-13 Thread Dora Rajappan
Not bad +1 for view pool.   When VIEW_POOL_ENABLED the param   org.apache.myfaces.NUMBER_OF_SEQUENTIAL_VIEWS_IN_SESSION is not considered and not required to set. org.apache.myfaces.NUMBER_OF_SEQUENTIAL_VIEWS_IN_SESSION is valid for state saving client/server.   Regards, Dora Rajappan. On

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-13 Thread Leonardo Uribe
Hi 2013/12/13 Dora Rajappan dorarajap...@yahoo.com Not bad +1 for view pool. When VIEW_POOL_ENABLED the param org.apache.myfaces.NUMBER_OF_SEQUENTIAL_VIEWS_IN_SESSIONhttp://myfaces.apache.org/core21/myfaces-impl/webconfig.html#org_apache_myfaces_NUMBER_OF_SEQUENTIAL_VIEWS_IN_SESSION is

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-13 Thread Dora Rajappan
  Hi Leonardo,    Thanks for explaining that the statemanagementstrategy is unaffected by the view pooling.  When views are not transient and view pool enabled with no state saving or serialisation enabled, the view pool processing remain the same and the state is saved in session.   Regards

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-13 Thread Leonardo Uribe
Hi ... When views are not transient and view pool enabled with no state saving or serialisation enabled ... I don't get anything about what you mean. But I understand that the topic of state management is really, really complex, and has been a misunderstood problem for years in the world of web

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-12 Thread Leonardo Uribe
Hi Finally the code for View Pooling has been comitted. After some performance tests with the know demo application, it has been confirmed the following improvements: - A reduction of 25% of the transient memory used, which means a lot less memory is used and it is used at a slower pace. It also

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-09 Thread Thomas Andraschko
Hi Leo, sounds fine! thanks :) 2013/12/9 Leonardo Uribe lu4...@gmail.com Hi I think we could add it as a parameter for f:view tag, for example call it oamEnableViewPool. The patch proposed uses already an attribute for disable the pool in some cases, but after doing some experiments

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-09 Thread Leonardo Uribe
Hi It seems we have an inconsistency between what was proposed to enable the view pool and the inclusion of the new parameter. At start we have this: org.apache.myfaces.VIEW_POOL_ENABLED (enable / disable for all pages in the app, by default false) But if we use an attribute in f:view like

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-08 Thread Thomas Andraschko
Hi Leo, a attribute for the viewroot sound greats. +1. How would you set this attribute then? Setting the attribute should only be required one time - so maybe a PhaseListener isn't the best place. Regards, Thomas 2013/12/7 Leonardo Uribe lu4...@gmail.com Hi Thomas What I can do is use an

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-08 Thread Leonardo Uribe
Hi I think we could add it as a parameter for f:view tag, for example call it oamEnableViewPool. The patch proposed uses already an attribute for disable the pool in some cases, but after doing some experiments (MYFACES-3831) I have found we need to change some parts of the algorithm.

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-07 Thread Thomas Andraschko
Leo, one question: Is it possible to mark a view as poolable via code? We configure all our views via typesafe view config from CODI/DS 2013/12/4 Thomas Andraschko andraschko.tho...@gmail.com Looks fine for me! 2013/12/3 Leonardo Uribe lu4...@gmail.com Hi I have been thinking about how

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-07 Thread Leonardo Uribe
Hi Thomas What I can do is use an attribute to mark the view as poolable or not poolable. The annotation code must be done outside core. regards, Leonardo 2013/12/7 Thomas Andraschko andraschko.tho...@gmail.com Leo, one question: Is it possible to mark a view as poolable via code? We

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-04 Thread Thomas Andraschko
Looks fine for me! 2013/12/3 Leonardo Uribe lu4...@gmail.com Hi I have been thinking about how to define the configuration for the view pool. The idea is add the following new web config parameters: org.apache.myfaces.VIEW_POOL_ENABLED (enable / disable for all pages in the app, by

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-12-03 Thread Leonardo Uribe
Hi I have been thinking about how to define the configuration for the view pool. The idea is add the following new web config parameters: org.apache.myfaces.VIEW_POOL_ENABLED (enable / disable for all pages in the app, by default false) org.apache.myfaces.VIEW_POOL_MAX_POOL_SIZE (the number of

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-11-25 Thread Martin Kočí
Hi, +1 for this feature in core 2.2. Regards, Kocicak 2013/11/24 Thomas Andraschko andraschko.tho...@gmail.com Perfect. Thanks for Info. So +1 from my side. 2013/11/24 Leonardo Uribe lu4...@gmail.com Hi 2013/11/24 Thomas Andraschko andraschko.tho...@gmail.com Hi Leo, By

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-11-24 Thread Leonardo Uribe
Hi Thomas 2013/11/23 Thomas Andraschko andraschko.tho...@gmail.com Hi Leo, all advantages and disadvantages are 100% fine for me but i don't like this one: - Third party libraries needs to be compatible with the technique. What changes are required for third party components? It is

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-11-24 Thread Thomas Andraschko
Hi Leo, By default all the code in UIComponentBase is already in place, so if all components extend from UIComponentBase everything will work just fine cool, perfect! What about Behaviors or ActionListeners like:

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-11-24 Thread Leonardo Uribe
Hi 2013/11/24 Thomas Andraschko andraschko.tho...@gmail.com Hi Leo, By default all the code in UIComponentBase is already in place, so if all components extend from UIComponentBase everything will work just fine cool, perfect! What about Behaviors or ActionListeners like:

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-11-24 Thread Thomas Andraschko
Perfect. Thanks for Info. So +1 from my side. 2013/11/24 Leonardo Uribe lu4...@gmail.com Hi 2013/11/24 Thomas Andraschko andraschko.tho...@gmail.com Hi Leo, By default all the code in UIComponentBase is already in place, so if all components extend from UIComponentBase everything will

[core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-11-23 Thread Leonardo Uribe
Hi Some time ago it was discussed under these topics: [core][proposal] JSF View Pooling (going beyond JSF Stateless Mode) http://markmail.org/message/54rb3aphc6txwzbr [core][discuss] Is it worth to include Stateless JSF / View Pooling concept into MyFaces?

Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x

2013-11-23 Thread Thomas Andraschko
Hi Leo, all advantages and disadvantages are 100% fine for me but i don't like this one: - Third party libraries needs to be compatible with the technique. What changes are required for third party components? Would it be possible that components are still 100% compatible with mojarra without