lofwyr14 merged pull request #1067:
URL: https://github.com/apache/myfaces-tobago/pull/1067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lofwyr14 opened a new pull request #1067:
URL: https://github.com/apache/myfaces-tobago/pull/1067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/TOBAGO-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Udo Schnurpfeil resolved TOBAGO-1222.
-
Resolution: Fixed
Generated code should use sorted items
://builds.apache.org/job/tobago-trunk/929/])
TOBAGO-1222: Generated code should use sorted items
- fixing order of the nodes inside a node to respect the XML schema (Revision
1433377)
Result = SUCCESS
lofwyr : http://svn.apache.org/viewvc/?view=revrev=1433377
Files :
*
/myfaces/tobago/trunk/tobago
://builds.apache.org/job/tobago-1.5.x/121/])
TOBAGO-1222: Generated code should use sorted items
- fixing order of the nodes inside a node to respect the XML schema (Revision
1433376)
Result = SUCCESS
lofwyr : http://svn.apache.org/viewvc/?view=revrev=1433376
Files :
*
/myfaces/tobago/branches
Udo Schnurpfeil created TOBAGO-1222:
---
Summary: Generated code should use sorted items
Key: TOBAGO-1222
URL: https://issues.apache.org/jira/browse/TOBAGO-1222
Project: MyFaces Tobago
Issue
://builds.apache.org/job/tobago-1.5.x/117/])
TOBAGO-1222: time component (tx:time) without number and lost focus then
print NaN (Revision 1417464)
TOBAGO-1222: time component (tx:time) without number and lost focus then print
NaN (Revision 1417459)
TOBAGO-1222: Generated code should use sorted items
to _ComponentUtils.getStringValue() is no longer necessary,
the generated code is a rather good match to the code currently in SVN,
with the exception of some whitespace and comments. My suggestion would
be to move the comments to the top of the file and commit the
regenerated files after checking that there are no other
)?
If the call to _ComponentUtils.getStringValue() is no longer necessary,
the generated code is a rather good match to the code currently in SVN,
with the exception of some whitespace and comments. My suggestion would
be to move the comments to the top of the file and commit the
regenerated files
contains the call to
_ComponentUtils.getStringValue(). Is there any reason why this method
is used for String values (and not for e.g. boolean or Object)?
If the call to _ComponentUtils.getStringValue() is no longer necessary,
the generated code is a rather good match to the code currently
L.S.,
I have added a patch for the code generator, allowing it to use
_ComponentUtils' methods whenever appropriate. There were still some
differences between the generated code and the code in the repository
after doing this. Almost all files are affected by the code generation
process
Do you have a link to the patch?
regards,
Martin
On 9/11/06, Gert Vanthienen [EMAIL PROTECTED] wrote:
L.S.,
I have added a patch for the code generator, allowing it to use
_ComponentUtils' methods whenever appropriate. There were still some
differences between the generated code
generator, allowing it to use
_ComponentUtils' methods whenever appropriate. There were still some
differences between the generated code and the code in the repository
after doing this. Almost all files are affected by the code generation
process in terms of whitespace usage, but there were also
L.S.,
A while ago, I have been doing a few things for the code generator
(MYFACES-1284 in JIRA) but at that time, it was suggested by Manfred to
wait with cleaning up all manual changes in the generated code blocks
until release 1.1.x was done. You're not doing anything wrong
;
is existing svn code
is generated code
Am I doing something wrong?
-Original Message-
From: Manfred Geiler [mailto:[EMAIL PROTECTED]
Sent: Thursday, September 07, 2006 4:11 AM
To: MyFaces Development
Subject: Re: GENERATED CODE BEGIN (do not modify!)
Dennis, Lance,
I am indeed
schrieb:
Dennis, Lance,
I am indeed of the opinion that is is NOT OK to modify this generated
code parts.
Code generation will get importance again when we do the 1.2 port.
And: Code generation is still important and convenient for coding new
tomahawk components. Well, nobody seems to use it by now
Dennis, Lance,
I am indeed of the opinion that is is NOT OK to modify this generated
code parts.
Code generation will get importance again when we do the 1.2 port.
And: Code generation is still important and convenient for coding new
tomahawk components. Well, nobody seems to use it by now
You mean a resources folder, right?
regards,
Martin
On 9/7/06, Manfred Geiler [EMAIL PROTECTED] wrote:
Dennis, Lance,
I am indeed of the opinion that is is NOT OK to modify this generated
code parts.
Code generation will get importance again when we do the 1.2 port.
And: Code generation
am indeed of the opinion that is is NOT OK to modify this generated
code parts.
Code generation will get importance again when we do the 1.2 port.
And: Code generation is still important and convenient for coding new
tomahawk components. Well, nobody seems to use it by now. Reason might
folder, right?
regards,
Martin
On 9/7/06, Manfred Geiler [EMAIL PROTECTED] wrote:
Dennis, Lance,
I am indeed of the opinion that is is NOT OK to modify this generated
code parts.
Code generation will get importance again when we do the 1.2 port.
And: Code generation is still important
I looked in
myfaces/tomahawk/core/src/main/java/org/apache/myfaces/component/html/ext
and it looks like most of these components have code modified inside the
generated code. And there are no .xml files in this directory. Do you
recommend to start putting the .xml files in the directory
In several of the myfaces components, there is code marked
GENERATED CODE BEGIN (do not modify!)
(in particular org.apache.myfaces.component.html.ext.HtmlPanelGroup)
How is this generated?
of undocumented cases where many of
us have done this, and for good reasons.
Dennis Byrne
-Original Message-
From: L Frohman [mailto:[EMAIL PROTECTED]
Sent: Tuesday, September 5, 2006 03:00 PM
To: ''MyFaces Development''
Subject: re: GENERATED CODE BEGIN (do not modify!)
In several of the myfaces
Thanks,
There is a codegenerator under build-tools under maven.
No documentation? (stupid question?)
-Original Message-
From: Dennis Byrne [mailto:[EMAIL PROTECTED]
Sent: Tuesday, September 05, 2006 12:11 PM
To: MyFaces Development
Subject: Re: GENERATED CODE BEGIN (do not modify
at these open tasks:
1. add code generation feature to tomahawk module
2. look for manually changed code parts that are now incompatible to
regeneration
i.e. generate code and do some svn diffing to find dangerous
generated code part modifications
3. revert and check in trivial (whitespace
Manfred Geiler schrieb:
Ok, I just spent a few minutes and found the old codegenerator on the attic.
Will try to integrate it into current maven structure.
Please stay tuned!
Thanks,
Manfred
Manfred, just a question, what was the scope of the old codegenerator,
does it generated
Werner,Look at the component classes. Everything between the BEGIN and END GENERATED CODE markers was generated by a Velocity template from the according component xml files.In a few minutes I will checkin the reborn codegenerator - stay tuned.
ManfredOn 4/13/06, Werner Punz [EMAIL PROTECTED
Manfred Geiler schrieb:
Werner,
Look at the component classes. Everything between the BEGIN and END
GENERATED CODE markers was generated by a Velocity template from the
according component xml files.
In a few minutes I will checkin the reborn codegenerator - stay tuned.
Ah superb, I
try it out with mvn compile -P regenerate-component-codePlease look at these open tasks:1. add code generation feature to tomahawk module
2. look for manually changed code parts that are now incompatible to regeneration i.e. generate code and do some svn diffing to find dangerous generated code part
On 4/13/06, Werner Punz [EMAIL PROTECTED] wrote:
Manfred Geiler schrieb: Werner, Look at the component classes. Everything between the BEGIN and END GENERATED CODE markers was generated by a Velocity template from the according component xml files.
In a few minutes I will checkin the reborn
On 4/13/06, Manfred Geiler [EMAIL PROTECTED] wrote:
In a few minutes I will checkin the reborn codegenerator - stay tuned.
Excellent! We can start working on facelet and shale support now.
children and to make t:panelGroup/ support the JSF 1.2 layout
atttribute (layout=block).
The solutions works for me, but I'm still puzzled by the comment
//-- GENERATED CODE BEGIN (do not modify!)
in HtmlPanelGroup. I do not see any code generation happening, so
modification to make s:fieldset/ render it'sown children and to make t:panelGroup/ support the JSF 1.2 layoutatttribute (layout=block).The solutions works for me, but I'm still puzzled by the comment
//-- GENERATED CODE BEGIN (do not modify!)in HtmlPanelGroup. I do not see
Manfred Geiler wrote:
...
The code generation for common component methods is currently out of
order. Sorry.
It was once used to generate all those boring getters, setters, state
saving stuff and the like from the according classname.xml file.
So, modifying code between those hint banners is
Ok, I just spent a few minutes and found the old codegenerator on the attic.Will try to integrate it into current maven structure.Please stay tuned!Thanks,Manfred
On 4/12/06, Gert Vanthienen [EMAIL PROTECTED] wrote:
Manfred Geiler wrote: ... The code generation for common component methods is
Hi all,
In the components, there are sections that are wrapped with GENERATED
CODE BEGIN and GENERATED CODE END. How are these generated? Reason I
ask is that there are new fields like forceId and escape that their
state is not being saved/restored.
Thanks in advance,
Travis
have to get the code from the prior-to-reorg SVN.On 11/22/05, Travis Reeder [EMAIL PROTECTED]
wrote:Hi all,In the components, there are sections that are wrapped with GENERATED
CODE BEGIN and GENERATED CODE END.How are these generated?Reason Iask is that there are new fields like forceId and escape
...
//-- GENERATED CODE BEGIN (do not modify!)
What is the deal with that? How is it being generated? Should I add
my code above this line?
Thanks,
sean
...
regards,
Martin
On Fri, 14 Jan 2005 15:50:54 -0500, Sean Schofield
[EMAIL PROTECTED] wrote:
In some of the code I see lines like ...
//-- GENERATED CODE BEGIN (do not modify!)
What is the deal with that? How is it being generated
In some of the code I see lines like ...
//-- GENERATED CODE BEGIN (do not modify!)
What is the deal with that? How is it being generated? Should I add
my code above this line?
Thanks,
sean
40 matches
Mail list logo
