Re: core, myfaces-builder-plugin: issues noticed

2008-06-04 Thread simon
On Mon, 2008-06-02 at 21:57 -0500, Leonardo Uribe wrote: Hi I have committed the changes. Thanks! Reading the email again, I forget to mention my opinion about change tagExcluded setting to ignore. In the plugin there are several levels of ignore (only two used in practice):

Re: core, myfaces-builder-plugin: issues noticed

2008-06-04 Thread Leonardo Uribe
On Wed, Jun 4, 2008 at 2:18 PM, simon [EMAIL PROTECTED] wrote: On Mon, 2008-06-02 at 21:57 -0500, Leonardo Uribe wrote: Hi I have committed the changes. Thanks! Reading the email again, I forget to mention my opinion about change tagExcluded setting to ignore. In the plugin

Re: core, myfaces-builder-plugin: issues noticed

2008-06-04 Thread Mike Kienenberger
On 6/4/08, Leonardo Uribe [EMAIL PROTECTED] wrote: * @JSFJspProperty name = message inheritedTag=true returnType = java.lang.String longDesc = alternate validation error message format string */ public class CSVValidator extends ValidatorBase Inheritance of properties for converters and

Re: core, myfaces-builder-plugin: issues noticed

2008-06-04 Thread Leonardo Uribe
On Wed, Jun 4, 2008 at 3:21 PM, Mike Kienenberger [EMAIL PROTECTED] wrote: On 6/4/08, Leonardo Uribe [EMAIL PROTECTED] wrote: * @JSFJspProperty name = message inheritedTag=true returnType = java.lang.String longDesc = alternate validation error message format string */ public class

Re: core, myfaces-builder-plugin: issues noticed

2008-06-04 Thread Mike Kienenberger
A practical use case for converter inheritance would be identical -- allowing custom converter per-instance messages properties. Since the JSF spec does not declare validator and converter classes final, assume that inheritance is possible and that properties will propagate. Again, if you are

Re: core, myfaces-builder-plugin: issues noticed

2008-06-04 Thread Leonardo Uribe
On Wed, Jun 4, 2008 at 3:49 PM, Mike Kienenberger [EMAIL PROTECTED] wrote: A practical use case for converter inheritance would be identical -- allowing custom converter per-instance messages properties. Since the JSF spec does not declare validator and converter classes final, assume that

Re: core, myfaces-builder-plugin: issues noticed

2008-06-02 Thread Leonardo Uribe
Hi I have checked if there is some related code and doing this: /** * Disable this property; although this class extends a base-class that * defines a read/write rendered property, this particular subclass * does not support setting it. Yes, this is broken OO design: direct * all

Re: core, myfaces-builder-plugin: issues noticed

2008-06-02 Thread Leonardo Uribe
Hi I have committed the changes. Reading the email again, I forget to mention my opinion about change tagExcluded setting to ignore. In the plugin there are several levels of ignore (only two used in practice): tagExcluded = true: generate the property with state saving and restoring code on

Re: core, myfaces-builder-plugin: issues noticed

2008-06-01 Thread simon
On Sat, 2008-05-31 at 16:45 -0500, Leonardo Uribe wrote: Hi On Sat, May 31, 2008 at 2:48 PM, simon [EMAIL PROTECTED] wrote: Hi, Here are some things I noticed when reviewing the tlddocs for core11-based-on-myfaces-builder. Tag

core, myfaces-builder-plugin: issues noticed

2008-05-31 Thread simon
Hi, Here are some things I noticed when reviewing the tlddocs for core11-based-on-myfaces-builder. Tag f:selectItems now has a rendered attribute, which it should not. Tag f:view has id, rendered and binding which it should not. Tag h:inputTextarea previously had datafld, datasrc, dataformatas.

Re: core, myfaces-builder-plugin: issues noticed

2008-05-31 Thread Leonardo Uribe
Hi On Sat, May 31, 2008 at 2:48 PM, simon [EMAIL PROTECTED] wrote: Hi, Here are some things I noticed when reviewing the tlddocs for core11-based-on-myfaces-builder. Tag f:selectItems now has a rendered attribute, which it should not. This problem is caused because the plugin enforces