HtmlCheckboxRendererBase with XHTML output bug?

Hi, I'm using current codebase with ADF Faces (open source donation) and with jspx (XHTML output). There is problem with HtmlCheckboxRendererBase, line 257, code is: writer.writeText(, null); // close input It renderes incorrect XHTML: input type=checkbox is not closed with / It can be

Is implementation of org.apache.myfaces.shared.renderkit.html.HtmlMessagesRendererBase$MessagesIterator correct?

Hello, I'm writing custom messages renderer and found strange (for me) behavior of MessagesIterator: JSF spec: globalOnly: Flag indicating whether only messages not associated with any specific component should be rendered. If not set, ALL messages will be rendered. Default value is “false”

[Trinidad] MessageFactory.BindingFacesMessage resolves parameters only once

_resolveBindings() { //if (_resolvedParameters == null) //{ _resolvedParameters = _getProcessedBindings(null, _parameters); //} } What do you think? Regards, Martin Koci

Re: [Trinidad] MessageFactory.BindingFacesMessage resolves parameters only once

https://issues.apache.org/jira/browse/TRINIDAD-28 Adam Winer píše v Pá 18. 05. 2007 v 10:55 -0700: Yeah, looks like a good fix. I doubt the optimization of caching here is buying us much of anything. -- Adam On 5/17/07, Martin Koci [EMAIL PROTECTED] wrote: Hi

[Trinidad] Auto-scroll feature with trinidad

Hi all, we discussed that topic already: http://www.mail-archive.com/[EMAIL PROTECTED]/msg01039.html New thoughts about that? Trinidad is out of incubator - we can find one solution for myfaces-impl tomahawk trinidad now. Regards, Martin

[Trinidad] upload file and UTF-8

Hello, there is a problem with utf-8 encoding and UploadRequestWrapper in method setCharacterEncoding. We are using UTF-8 to support Czech language (and others), but it doesnt work with file upload - it decodes request as in iso latin 1. (Following example can be unreadable in some email

[Trinidad] SimpleSelectOneRenderer.getSubmittedValue bug?

Hello, why has SimpleSelectOneRenderer such implementation of getSubmittedValue: Object submittedValue = super.getSubmittedValue(context, component, clientId); if (submittedValue == null)

[Trinidad] Selecting a row in tr:table with mouse click (rowSelection=singleClick)

Hello, currently tr:table supports selection of one row with attribute rowSelection=simple. For better user experience we want to select a row with clicking on table row. To achieve this I did four minor changes in trinidad code base: 1) support singleClick in decoding phase 2) render a

Re: [Trinidad] remove application view cache in Trinidad 2?

Max Starets píše v Út 01. 12. 2009 v 20:42 -0500: Gabrielle, I think the main advantage of using application view cache is that state saving/view root caching is done once for a particular page within an application (that only applies to pages displayed in response to a GET request).

Re: [Trinidad 2.0] introducing ProjectStage API

Hi, does trinidad reload both JSP and facelets views if org.apache.myfaces.trinidad.CHECK_FILE_MODIFICATION=true? For facelets based views there is a new JSF 2.0 param javax.faces.FACELETS_REFRESH_PERIOD (-1 = never reload, 0=always, 1,2, 3,.. - check interval) but it's relation to project stage

Re: [Trinidad 2.0] introducing ProjectStage API

of org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION is false, otherwise it is true. But this only sets the DEFAULT value. The user still can configure each parameter independently by putting it in web.xml. Regards Jakob Korherr 2009/12/2 Martin Koci martin.k...@aura.cz Hi

Re: Trinidad and JSF 2.0

Hi, regarding component.getAttributes() vs. bean.getProperty() performance: do you have info under which circumstances is that difference noticeable? I do some profiling on two apps: the first one is trinidad12/jsf12 based and the second is JSF2 based. In both cases I have same view but JSF2

Re: [Trinidad 2] Convert examples to facelets?

Hi, I think .xml is too generic - there are many .xml files but only one sort of them are facelets views. I recommend use of .view.xml (login.view.xml for example) - that suffix was discussed on 314 mailing list. With reserved .jsp (or .jspx) was view declaration clearly identified, with simple

[core] ClassLoaderResourceLoader.getLibraryVersion(String) performace

Hi, during profiling YourKitProfiler always marks org.apache.myfaces.resource.ClassLoaderResourceLoader.getLibraryVersion(String) as hotspot - that method always takes 30--50% CPU time per one request/response. Is it a known problem? I will provide more information later. Regards, Martin

Re: [core] ClassLoaderResourceLoader.getLibraryVersion(String) performace

. regards, Leonardo Uribe 2010/2/5 Martin Koci martin.k...@aura.cz Hi, during profiling YourKitProfiler always marks org.apache.myfaces.resource.ClassLoaderResourceLoader.getLibraryVersion(String) as hotspot - that method always takes 30--50% CPU time per

[core] Status of state saving implementation in current trunk

Hello, what is the current status of state saving implementation in myfaces core trunk? Is it a work in progress or should it work? For example I noticed that server state saving with facelets is completely broken (FaceletViewDeclarationLanguage calls stateMgr.saveView only for client state

Re: [core] Status of state saving implementation in current trunk

but both should work. regards, Leonardo Uribe 2010/2/8 Martin Koci martin.k...@aura.cz Hello, what is the current status of state saving implementation in myfaces core trunk? Is it a work in progress or should it work? For example I

[core] Code formatter setting for myfaces core (for Eclipse)

Hi, can you please point me to a description how to set code formatting which conforms check style rules? Or better - is there a public settings for eclipse formatter (it is a file named org.eclipse.jdt.core.prefs from .settings directory)? Thanks, Martin Kočí

Re: [core] Code formatter setting for myfaces core (for Eclipse)

2010/2/9 Martin Koci martin.k...@aura.cz Hi, can you please point me to a description how to set code formatting which conforms check style rules? Or better - is there a public settings for eclipse formatter (it is a file named

[core] converterId/validatorId and binding

Hi, there is probably a unclarity regarding cooperation of converterId/validatorId and binding attributes from f:converter and f:validator facelets tags. https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/converter.html says that converterId is not required, same for

Re: [VOTE] release for myfaces core 2.0.1

Hi, can you guys take a look at https://issues.apache.org/jira/browse/MYFACES-2753 before release 2.0.1? Thanks, Martin Kočí Werner Punz píše v Út 06. 07. 2010 v 18:07 +0200: Jepp there were a handful of showstoppers, most have been fixed (but not all) I am glad 2.0.1 did not make it out

ValidatorHandler and wire all attributes set to the Validator instance

Hi, javadoc for javax.faces.view.facelets.ValidatorHandler contains this sentence: Will wire all attributes set to the Validator instance created/fetched. Based on that one our developer tried this: f:validator binding=#{aValidator} property=#{expression} / Expected result was to put a value

Myfaces vs. mojarra restore view performance

Hi, our profiling results show that myfaces are significantly slower in restore view phase: com.sun.faces LifeCycle .. restoreView : 80 ms o.a.m.RestoreViewExecutor : 750ms! This result is perfectly reproducible in our case. I profile it on a application real application - I cannot post

Re: Myfaces vs. mojarra restore view performance

. total time. Thanks. Regards, Jan-Kees 2010/8/2 Martin Koci martin.k...@aura.cz Hi, our profiling results show that myfaces are significantly slower in restore view phase: com.sun.faces LifeCycle .. restoreView : 80

Re: Myfaces vs. mojarra restore view performance

https://issues.apache.org/jira/browse/MYFACES-2854 Martin Koci píše v Po 02. 08. 2010 v 22:20 +0200: Hi, quick results: yourkitprofiler marks as hot spot UiViewRoot.addComponentResource (3381 invocation count) - that method itself creates 5 710 511 invocations of AbstractIterator.next

Re: Myfaces vs. mojarra restore view performance

). Probably composite components should be cached in production stage? Regards, Martin Kočí Martin Koci píše v Po 02. 08. 2010 v 22:20 +0200: Hi, quick results: yourkitprofiler marks as hot spot UiViewRoot.addComponentResource (3381 invocation count) - that method itself creates 5 710 511

Re: Myfaces vs. mojarra restore view performance

Leonardo Uribe píše v St 04. 08. 2010 v 14:26 -0500: Hi 2010/8/4 Martin Koci martin.k...@aura.cz Hi, today's results: myfaces from trunk + patchs from MYFACES-2854 : ~80 ms in RestoreViewExecutor.exectute mojarra: ~70

Re: Myfaces vs. mojarra restore view performance

Hi, success! myfaces + MYFACES-2854-2.patch + MYFACES-2862 = ~ 70 ms in restore view phase. It was *750 ms* before. Thanks, Martin Kočí Leonardo Uribe píše v St 04. 08. 2010 v 22:09 -0500: Hi I implemented a proposal for this one on MYFACES-2854-2.patch using the suggestion proposed (do

Synchronizer token (double submit problem) status

Hi, what's the current status of implementation of synchronizer token in myfaces core? There is a specification issue planned for 2.1 [1]. Furthermore, if user wants to block HTML/DOM entirely what can he/she use? I know trinidad solution only and it has special javascript method

Re: evaluating JSR-303 @Size(max=) for input fields?

Hi, I tried it for my renderkit but unfortunately there is no (or I didn't find) solution for scenario, where value=#{bean.otherBean.constrainedProperty} and otherBean is null. In such case you can only obtain constrains from declared type, not from the real one. But for simpler cases where

EL method invocation performance

Hi, this problem is not in myfaces but affects performance especially in render response phase: EL 2.2 introduces method invocation but if you try use it like rendered=#{bean.getRendered(param)} there is an unpleasant surprise: both implementations of BeanELResolver (Glassfish, Tomcat) use this

Re: EL method invocation performance

? it caches the ExpressionFactory to avoid the search action by default. 2010/8/25 Martin Koci martin.k...@aura.cz Hi, this problem is not in myfaces but affects performance especially in render response phase: EL 2.2 introduces

Re: EL method invocation performance

Now I'm sure that it is an implementation problem: it was very suspicious that both Tomcat and Glassfish implementations have it - but Geronimo does not have this problem. Andy Schwartz píše v St 25. 08. 2010 v 11:38 -0400: On Wed, Aug 25, 2010 at 11:10 AM, Jakob Korherr jakob.korh...@gmail.com

Re: EL method invocation performance

and Tomcat developers about this ;) Regards, Jakob 2010/8/25 Ivan xhh...@gmail.com How about trying the el api published by Geronimo ? it caches the ExpressionFactory to avoid the search action by default. 2010/8/25 Martin Koci martin.k...@aura.cz Hi, this problem

_SelectItemsUtil._ValueConverter

Hi, what is the purpose of _SelectItemsUtil._ValueConverter in UISelectMany.validateValue(FacesContext, Object) ? Two weird things: 1) it wraps value into new String[] { value } 2) it calls UISelectMany.this.getConvertedValue and it leads to Rendered.getConvertedValue call I don't see sence

Re: _SelectItemsUtil._ValueConverter

[]. Is this clear for you or should I explain it in more detail? Regards, Jakob 2010/8/27 Martin Koci martin.k...@aura.cz Hi, what is the purpose of _SelectItemsUtil._ValueConverter in UISelectMany.validateValue(FacesContext, Object) ? Two

Re: [COMMUNITY] MyFaces += Martin Kočí

Hi, it's an honour for me, thanks for inviting me to this great community. Just for curiosity I found this: https://issues.apache.org/jira/browse/MYFACES-1171 - reported by me more than four years ago - time runs so fast! That reminds me: I started with JSF 0.4 EA - do you remember

submittedValue vs. Converter.getAsObject

Hi, maybe this is a stupid question but: From UIInput javadoc: ... decoded value of this component, usually but not necessarily a String, must be stored - but not yet converted - using setSubmittedValue() from UIInput.getConvertedValue: ... and the submitted value is a String, locate a

Re: [COMMUNITY] MyFaces += Martin Kočí

bedtime story :) Martin Koci píše v Út 07. 09. 2010 v 21:33 +0200: Hi, it's an honour for me, thanks for inviting me to this great community. Just for curiosity I found this: https://issues.apache.org/jira/browse/MYFACES-1171 - reported by me more than four years ago - time runs so fast

Re: submittedValue vs. Converter.getAsObject

, Martin Koci martin.kocicak.k...@gmail.com wrote: Hi, maybe this is a stupid question but: From UIInput javadoc: ... decoded value of this component, usually but not necessarily a String, must be stored - but not yet converted - using setSubmittedValue() from

FlashImpl : oam.Flash.RENDERMAP.TOKEN and number of Cookies

Hi, I'm not familiar with Flash implementation and Cookies (about Cookies I know only one thing: they exist) thus I ask first: I have many views = .xhtml files in structure like: 001/001.xhtml 002/002.xhtml .. firefox show that for each such view one cookie exists: oam.Flash.RENDERMAP.TOKEN

Re: FlashImpl : oam.Flash.RENDERMAP.TOKEN and number of Cookies

Probably we should use cookie.setPath(/); and reuse one cookie for all cases? Martin Koci píše v Čt 09. 09. 2010 v 22:39 +0200: Hi, I'm not familiar with Flash implementation and Cookies (about Cookies I know only one thing: they exist) thus I ask first: I have many views = .xhtml files

Re: _SelectItemsUtil._ValueConverter

file an issue in the JIRA. Thanks! Regards, Jakob 2010/8/27 Martin Koci martin.k...@aura.cz Hi, I understand that requirement but isn't it EL coercion task ? : https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=152 and from UISelectMany.validateValue

Re: Myfaces vs. mojarra restore view performance

Hi, please review https://issues.apache.org/jira/browse/MYFACES-2922 and apply if possible. Thanks, Kočičák Leonardo Uribe píše v Pá 06. 08. 2010 v 13:07 -0500: Hi 2010/8/6 Martin Koci martin.k...@aura.cz Hi, is it possible to cache inspected classes

Re: _SelectItemsUtil._ValueConverter

to use coercion. If it works well with enums, +1 on committing this patch. Regards, Jakob 2010/9/14 Martin Koci martin.kocicak.k...@gmail.com: Hi, please review https://issues.apache.org/jira/browse/MYFACES-2920 1) JavaDoc explicitly mentions EL coecion but not Converter: https

Re: [VOTE] release for myfaces core 2.0.2

+1 Regards, Kočičák Jakob Korherr píše v Út 21. 09. 2010 v 17:45 +0200: +1 Regards, Jakob 2010/9/21 Mark Struberg strub...@yahoo.de: +1 built from source went fine + rat is ok + signature check is ok. LieGrue, strub --- On Tue, 9/21/10, Gerhard

Re: submittedValue vs. Converter.getAsObject

Hi, I've just read Leonardo's post at jsr-314-open about this problem. FYI: I have finished prototype of JSF server side solution with non-String communication. It's based on custom renderkit and ResponseWriter implementation. I found only one major problem: this one discussed in this mail

[core] performance: disabling old technologies

Hi, since JSF 2.0 JSP support and managed-bean are deprecated. Since 1.2 same for javax.faces.el. For performace reasons I suggest find a way how disable following: 1) Managed Bean support (o.a.m.SUPPORT_MANAGED_BEANS=false) if this flag is false, myfaces will not install ManagedBeanResolver

Re: Myfaces vs. mojarra restore view performance

Hi, Leonardo, can you please review : https://issues.apache.org/jira/browse/MYFACES-2922 https://issues.apache.org/jira/browse/MYFACES-2862 and apply them if they are suitable? Thanks, Kočičák Martin Koci píše v Út 14. 09. 2010 v 23:05 +0200: Hi, please review https://issues.apache.org

[core] FacesEL vs. UEL vs. UEL 2.2

Hi, there is a disorder in Expression Lauguage names in myfaces core. Currently myfaces (method javax.faces.validator._ExternalSpecifications.isUnifiedELAvailable() for example) output a log: MyFaces Unified EL support enabled But this is a little misleading: there should be Unified EL 2.2

Re: EL method invocation performance

for details. Maybe we should put a warning about these two issues at http://wiki.apache.org/myfaces/HowToEnableEl22 ? Regards, Kocicak Martin Koci píše v St 25. 08. 2010 v 20:52 +0200: Hi, I'll try it but not today :) Optimization is my priority task for next few months and certainly I'll compare

[core] performance: TagAttributeImpl and composite component EL detection

Hi, a issue to consider in org.apache.myfaces.view.facelets.tag.TagAttributeImpl: Methods TagAttributeImpl.getMethodExpression and TagAttributeImpl.getValueExpression use CompositeComponentELUtils.isCompositeComponentXYZ methods to detect if current #{} contains cc expression. But consider

Re: [core] performance: TagAttributeImpl and composite component EL detection

in this area by better utilization of the improved tree walking api jsf2 provides. Werner Am 20.10.10 15:54, schrieb Martin Koci: Hi, a issue to consider

[core] performance: TagAttributeImpl part II: object allocations

Hi, another performance related problem in TagAttributeImpl: ValueExpression instances. Consider a facelets view with 3000 attributes. Then during buildView method TagAttributeImpl.getValueExpression allocates: 1) one instance of ValueExpression via ExpressionFactory.createValueExpression 2)

Re: [core] performance: TagAttributeImpl part II: object allocations

. Suggestions are welcome! Regards, Jakob 2010/10/21 Martin Koci martin.kocicak.k...@gmail.com: Hi, another performance related problem in TagAttributeImpl: ValueExpression instances

Re: EL method invocation performance

2010/10/19 Martin Koci martin.kocicak.k...@gmail.com Hi, some news about EL method invocations: 1) Geronimo EL API implementation has this problem too: https://issues.apache.org/jira/browse/GERONIMO-5657 2) UEL bug

[test] testNG and EL impl in myfaces-test

Hi, two questions: 1) 12 test cases in myfaces-api and myfaces-impl use @Test from org.testng.annotations, 56 test cases use @org.junit.Test. What is the primary test engine for myfaces? I'm trying to provide patch for MYFACES-2882 and UIViewRootTest uses TestNG: how to use

[core] UISelectItem(s) questions

Hi, following things are specified by spec, but maybe someone will know reasons: 1) why UISelectOne/Many classes don't have method like ListSelectItem getSelectItems currently each renderkit has own method with similar purpose but with different quality and bugs :) for example, myfaces have

[core] Improve error reporting and logging

Hi, the most wanted feature which our coders want is more consistent and human-readable error reporting and logging. Here is a example: If user specifies f:ajax without eventName for a component without defaultEventName, myfaces throw a execption: Now (myfaces 2.0.3): eventName could not be

Re: [core] Improve error reporting and logging

Hi, I will do it for Czech and Slovak: MYFACES-3014. Not very frequent languages, though - but 10 491 492 (CZ) + approx 5 mil (SK) inhabitants (samt Kindern und Rentnern) of Czech + Slovak Republic will appreciate it :) Werner Punz píše v Út 11. 01. 2011 v 15:13 +0100: Btw. I did some work

Re: [core] Improve error reporting and logging

about parent and path to component, phase id etc. Kočičák Werner Punz píše v Út 11. 01. 2011 v 15:12 +0100: ++1 Werner Am 10.01.11 20:06, schrieb Martin Koci: Hi, the most wanted feature which our coders want is more consistent and human-readable error reporting and logging

[core] ajax @this with non trivial component

Hi, if component is represented on client like: span id=clientId label id=clientId_label for=clientId_input a Label /label input id=clientId_input onchange=jsf.ajax.request(...execute: '@this' ...) /span what will be in HTTP reuqest? execute = clientId_input - but this is only

Re: [core] ajax @this with non trivial component

Hi Andy, thank you for explanation. Myfaces do only the first part: (1) This value will (or, well, should) be passed in as thefirst argument to jsf.ajax.request() but the second (2) and used as the replacement for @this targets. in not implemented yet:

Re: [VOTE] release for myfaces core 2.0.4

+1 Leonardo Uribe píše v St 09. 02. 2011 v 01:07 -0500: Hi, I was running the needed tasks to get the 2.0.4 release of Apache MyFaces core out. The artifacts passed all TCK tests. Please note that this vote concerns all of the following parts: 1. Maven artifact group

Re: [VOTE] Release of Extensions CDI (CODI) 0.9.3

+1 Regards, Martin Kočí Gerhard Petracek píše v Po 28. 02. 2011 v 14:22 +0100: Hi, I was running the needed tasks to get the 4th release of Apache MyFaces Extensions CDI (aka MyFaces CODI) out. The artifacts are deployed to Nexus [1] (and [2]). The release contains the following

Re: submittedValue vs. Converter.getAsObject

Uribe Martin Koci píše v Čt 23. 09. 2010 v 21:40 +0200: Hi, I've just read Leonardo's post at jsr-314-open about this problem. FYI: I have finished prototype of JSF server side solution with non-String communication. It's based on custom renderkit and ResponseWriter implementation. I

[core] performance: ELResolvers filtering

Hi, after few months I have time to do some performance optimalization for myfaces. This one is related to topic http://www.mail-archive.com/dev@myfaces.apache.org/msg49177.html Problem: how to disable ELResolver smartly? Adding a context-param for each is an overkill. But we have

Re: [core] performance: ELResolvers filtering

, 3/16/11, Martin Koci martin.kocicak.k...@gmail.com wrote: From: Martin Koci martin.kocicak.k...@gmail.com Subject: [core] performance: ELResolvers filtering To: dev@myfaces.apache.org Date: Wednesday, March 16, 2011, 10:29 AM Hi, after few months I have time to do some

Re: [core] performance: ELResolvers filtering

be achieved by filtering out the unwanted resolver with predicate and adding own in faces-config (and sort it to proper position in chain) Regards, Kočičák Martin Koci píše v St 16. 03. 2011 v 11:29 +0100: Hi, after few months I have time to do some performance optimalization for myfaces

[core] performance: an optimal ELResolvers chain for POJO-based apps

Hi, I'm optimizing render response on a large view (takes over 3 secs to render) and below you can see results of unsorted and unfiltered ELResolvers chain. The most important info is that BeanELResolver resolves property over 4x from 64000 invocations. The second place belongs to

Re: [core] performance: an optimal ELResolvers chain for POJO-based apps

the number for ImplicitObjectResolver, not for BeanELResolver. Regards, Kočičák Mark Struberg píše v Po 28. 03. 2011 v 19:57 +0100: your numbers imply that one uses JSF @ManagedBeans, isn't? LieGrue, strub --- On Mon, 3/28/11, Martin Koci martin.kocicak.k...@gmail.com wrote: From: Martin Koci

Re: [core] performance: an optimal ELResolvers chain for POJO-based apps

,sort,filter and transform. Then we can provide a lenient BeanELResolver implementation with behaviour: if base does not have the property returns null and allows next resolver to take charge of getValue. WDYT? Kočičák Martin Koci píše v Po 28. 03. 2011 v 20:50 +0200: Hi, I'm optimizing render

Re: [core] performance: ELResolvers filtering

://issues.apache.org/jira/browse/MYFACES-3104 MyFaces 2 with EL ? 2.2 in Websphere 7 regards, Leonardo Uribe 2011/3/17 Martin Koci martin.kocicak.k...@gmail.com This approach cannot filter two resolvers: 1. org.apache.myfaces.el.unified.resolver.FacesCompositeELResolver

Re: [VOTE] release for myfaces core 2.0.5

+1 Regards, Kočičák Leonardo Uribe píše v Út 05. 04. 2011 v 01:02 -0500: +1 2011/4/5 Leonardo Uribe lu4...@gmail.com Hi, I was running the needed tasks to get the 2.0.5 release of Apache MyFaces core out. The artifacts passed

[core] performance: performance hints

Hi, is it possible to introduce performance hints in myfaces-core? Hints similar to javax.faces.component.visit.VisitHint but related to performance improvements. Example: For dataTable like: a:dataTable a:column #{aExpression} it's completely unnecessary to save per-row state. Currently

Re: [core] performance: performance hints

Hi, Leonardo Uribe píše v Po 25. 04. 2011 v 12:45 +0200: Hi 2011/4/19 Martin Koci martin.kocicak.k...@gmail.com Hi, is it possible to introduce performance hints in myfaces-core? Hints similar to javax.faces.component.visit.VisitHint but related

Re: [core] tasks for release myfaces core 2.0.6 and 2.1.0-rc

Hi, I see one big issue: https://issues.apache.org/jira/browse/MYFACES-3117 That may require a change in server state management, so I suggest solve it before first 2.1 release Another one is a big performance improvement: https://issues.apache.org/jira/browse/MYFACES-3130 that needs discussion.

[core] performance: use indices instead of iterator (MYFACES-3130)

Hi, in current codebase, myfaces use mostly enhanced loop for iterating over chidren: for (UIComponent child: getChildren()) that creates new instance of iterator. After change to plain old indices: for (i = 0; i childCount; i++) child = getChildren().get(i); I achieved following results

Re: [core] performance: use indices instead of iterator (MYFACES-3130)

of List. On Tue, May 10, 2011 at 4:11 PM, Martin Koci martin.kocicak.k...@gmail.com wrote: Hi, in current codebase, myfaces use mostly enhanced loop for iterating over chidren: for (UIComponent child: getChildren()) that creates new instance of iterator. After change to plain

Re: [core] do not check for duplicate ids when saving view on production stage

+1 for specific parameter (in one project I build view dynamically from DB and want this ids check) Gerhard Petracek píše v St 11. 05. 2011 v 07:52 +0200: hi, i would combine it - +1 for a myfaces specific parameter which gets evaluated in case of project-stage production. regards,

[core] Can UIComponent.rendererType be ValueExpression ? (MYFACES-3136)

Hi, two questions : 1) can UIComponent.rendererType be ValueExpression? If yes, in which situation is useful to use it? 2) should be rendereType saved during state saving? Each component has setRendererType(com.foo.renderer) in constructor and/or VDL calls setRendererType() after calling

Re: [core] Can UIComponent.rendererType be ValueExpression ? (MYFACES-3136)

and rendererType I found nothing. Jakob Korherr píše v Pá 13. 05. 2011 v 16:11 +0200: Hi Martin, Have you checked the JSF 2.1 and 2.0 specs yet? Regards, Jakob 2011/5/13 Martin Koci martin.kocicak.k...@gmail.com: Hi, two questions : 1) can UIComponent.rendererType

Re: [core] Can UIComponent.rendererType be ValueExpression ? (MYFACES-3136)

, IceFaces) and search in their code for something like this? If you don't find anything there, then it should be pretty safe to remove the ValueExpression support from rendererType! Regards, Jakob 2011/5/13 Martin Koci martin.kocicak.k...@gmail.com: Hi, from spec: .. Because

Re: [core] Can UIComponent.rendererType be ValueExpression ? (MYFACES-3136)

to detect this component will be rendered in this lifecycle and cache renderer even for getClientId? stateManagement calls getClientId (checkIds) before component.encodeBegin. Can we use visitTree method for that? Kočičák regards, Leonardo 2011/5/13 Martin Koci martin.kocicak.k...@gmail.com

Re: [core] Can UIComponent.rendererType be ValueExpression ? (MYFACES-3136)

component with clientId from renderer1! Is that ok? Leonardo Uribe píše v Pá 13. 05. 2011 v 15:45 -0500: Hi 2011/5/13 Martin Koci martin.kocicak.k...@gmail.com: Leonardo Uribe píše v Pá 13. 05. 2011 v 14:59 -0500: Hi +1 to both changes. That means: replace StateHelper

Re: [myfaces] ideas and things to do

Gerhard Petracek píše v Út 17. 05. 2011 v 11:59 +0200: hi, imo we should prototype some jsf 2.2 features (at least in a branch). that would help the eg to specify some of the new features (like the window-id) easily and we can get the feedback of the whole community and we would have the

Re: [core] do not check for duplicate ids when saving view on production stage

. Regards, Jakob 2011/5/11 Martin Koci martin.kocicak.k...@gmail.com: +1 for specific parameter (in one project I build view dynamically from DB and want this ids check) Gerhard Petracek píše v St 11. 05. 2011 v 07:52 +0200: hi, i would combine it - +1 for a myfaces specific parameter

Re: [VOTE] release for myfaces core 2.1.0

+1 Leonardo Uribe píše v Út 24. 05. 2011 v 13:29 -0500: +1 2011/5/24 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.1.0 release of Apache MyFaces core out. The artifacts passed all TCK tests. Please note that this vote concerns all of the

[core] implicit object 'component' in rendered expression (myfaces and spec bug)

Hi, h:form h:panelGroup h:inputText id=testId rendered=#{component.id eq 'testId'} value=#{bean.value} / /h:panelGroup /h:form please notice the expression: rendered=#{component.id eq 'testId'} that is clearly

Re: [core] implicit object 'component' in rendered expression (myfaces and spec bug)

/JAVASERVERFACES_SPEC_PUBLIC but fix it on myfaces code. regards, Leonardo Uribe 2011/5/25 Martin Koci martin.kocicak.k...@gmail.com: Hi, h:form h:panelGroup h:inputText id=testId rendered=#{component.id eq 'testId

Re: [core] implicit object 'component' in rendered expression (myfaces and spec bug)

that the context is setup and torn down around each call to isRendered. -- Blake Sullivan On 5/25/11 11:27 AM, Martin Koci wrote: Hi, for spec I've created bug few days ago: http://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-1002 but I didn't realize how deep impact

Re: [core] implicit object 'component' in rendered expression (myfaces and spec bug)

Martin Koci píše v St 25. 05. 2011 v 22:12 +0200: Hi, there are such cases but not many of them: in myfaces code after quick search I guess about 10 such cases. The main is in UIComponentBase.encodeChildren and in RendererUtils.renderChild (well, there was, but I removed it incorrectly as part

Re: Clear Input Values

Hi, javax.faces.component.EditableValueHolder.resetValue() and/or listener like http://myfaces.apache.org/trinidad/trinidad-api/tagdoc/tr_resetActionListener.html does not solve it? Kočičák Mark Struberg píše v Po 30. 05. 2011 v 13:19 +0100: Sounds like a good idea. But shouldn't that be

[core] support implicit object 'component' in renderers where getRendersChildren is true

Hi, problem described in MYFACES-3157 applies for all cases where renderer reads property from child component. I think that only correct way in push child to EL before: child.pushComponentToEL() Object value = child.getValue(); String style = child.getStyle(); child.popComponentFromEL() Is

Re: [core] TagAttributeImpl part II: object allocations (cache ELExpressions)

. Additionally, use a volatile variable to store expressions. The patch adds a new web config param called org.apache.myfaces.CACHE_EL_EXPRESSIONS to enable/disable this feature. @Martin Koci: since you was the one proposing this optimization, it could be good if you can check if it is worth

[core] performance: avoid wrapped EL Expressions

Hi, as discussed here: http://markmail.org/message/kca64ojdvb6em367?q=[core]+performance: +TagAttributeImpl+part+II:+object+allocations#query:[core]%20performance %3A%20TagAttributeImpl%20part%20II%3A%20object%20allocations+page:1 +mid:kca64ojdvb6em367+state:results and here:

[core] EL improvements - summary

Hi, summary of ExpressionLanguage-related improvements (done or in progress) 1) ELResolvers sorting: https://cwiki.apache.org/MYFACES/elresolver-ordering.htm 2) EL Resolvers filtering: MYFACES-3075 3) Disable JSP (and javax.faces.el) support: MYFACES-3078 4) cache ELExpressions:

Re: [core] performance: avoid wrapped EL Expressions

Hi, the idea seems very good - but when is decided that expression does not uses some variable resolved by VariableResolver? TagAttributeImpl.getValue/MethodExpression methods are called in VDL.buildView - how is the check done? String parsing? Yes, I didn't look in the patch, its friday :)

Re: [core] performance: avoid wrapped EL Expressions

Hi, Leonardo Uribe píše v Pá 03. 06. 2011 v 15:38 -0500: Hi 2011/6/3 Martin Koci martin.kocicak.k...@gmail.com: Hi, the idea seems very good - but when is decided that expression does not uses some variable resolved by VariableResolver? Inside VariableMapperWrapper.resolveVariable

Re: [core] performance: avoid wrapped EL Expressions

Hi, what problem is it? I know about excessive rendered evaluation: JAVASERVERFACES_SPEC_PUBLIC-941. value at EditableValueHolder can be evaluated 2x during one request/response. If it is another problem, can you create a jira issue, please? Thanks, Kočičák Kito Mann píše v Pá 03. 06. 2011

  1   2   3   >