On May 11, 2012, at 12:03 AM, jler...@apache.org wrote:
Author: jleroux
Date: Thu May 10 22:03:33 2012
New Revision: 1336921
URL: http://svn.apache.org/viewvc?rev=1336921view=rev
Log:
A patch from Pierre Smits Help screens in Manufacturing
Ashish is already aware, Adrian noticed it. I guess, Ashish will not revert
but use the right corresponding level...
Jacques
PS: top posted because closing the thread
From: Adam Heath doo...@brainfood.com
On 05/10/2012 11:46 PM, ash...@apache.org wrote:
Author: ashish
Date: Fri May 11
I did not close the Jira, wrork will be - hopefully - continued there.
I committed because it's already a decent work, I mean the structure is ready,
I expect Pierre to fill it now...
Jacques
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
On May 11, 2012, at 12:03 AM,
Please feel free to fix and backport.
Jacques
From: Scott Gray scott.g...@hotwaxmedia.com
I know it's unrelated to this commit but that label for isDemoStore isn't accurate at all (and is potentially dangerous). That
field does nothing other than decide whether or not to display the demo
On May 11, 2012, at 8:14 AM, Jacques Le Roux wrote:
I did not close the Jira, wrork will be - hopefully - continued there.
I committed because it's already a decent work
You and I have definitely a different opinion of what is a decent work :-)
Jacopo
, I mean the structure is ready, I
From: Adam Heath doo...@brainfood.com
I've added 2 major(ish) new features recently.
* salt-based password hashing(with base64 encoding)
* key-encrypting-key(kek) support.
The salt-based psasword feature was written when JIRA was hacked
several years ago; JIRA is based on an old version of
[
https://issues.apache.org/jira/browse/OFBIZ-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273078#comment-13273078
]
Jacopo Cappellato commented on OFBIZ-4802:
--
Just to clarify that I didn't comment
Thanks a lot adrian for this detail. It's a good enhancement for
debugging mini-lang code
Nicolas
Le 08/05/2012 11:40, Adrian Crum a écrit :
No, the trace element would not have a message attribute or any
means of specifying what to log. It is only an /on/off switch. All of
the logging
Is it intended that we will eventually have a content, dataresource and file
for every screen in OFBiz and in multiple languages?
I think we need to find a better approach than this, the committers can't
maintain potentially thousands of help files and records. What about a wiki
that we could
I guess I should move this thread to dev:
Actually, just go to
https://demo-trunk.ofbiz.apache.org:8443/example/control/main and you will
see the Setup appearing in the menu :-))
but not in https://demo-trunk.ofbiz.apache.org:8443/partymgr/control/main
no biggy, but it is a bit strange
Thibault
Jacques,
Please remember that *everything* must be tested before committing to the
release branches, we can't claim that these branches are stable if it isn't
being done.
Many thanks
Scott
On 9/05/2012, at 11:24 AM, jone...@apache.org wrote:
Author: jonesde
Date: Tue May 8 23:24:16 2012
Ranjit Kumar Singh created OFBIZ-4873:
-
Summary: Error in CSV download
Key: OFBIZ-4873
URL: https://issues.apache.org/jira/browse/OFBIZ-4873
Project: OFBiz
Issue Type: Bug
[
https://issues.apache.org/jira/browse/OFBIZ-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ranjit Kumar Singh updated OFBIZ-4873:
--
Attachment: ScoopReport-6.csv
Download file having error
Error in
[
https://issues.apache.org/jira/browse/OFBIZ-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273098#comment-13273098
]
Ranjit Kumar Singh commented on OFBIZ-4873:
---
Here is the patch:
Index:
Hi Thibault,
Please refer ApplicationDecorator.
set field=layoutSettings.suppressTab value=ofbizsetup/!-- diseable ofbiz
setup by default --
Thanks Regards
--
Deepak Dixit
HotWax Media Pvt. Ltd.
www.hotwaxmedia.com
Contact :- +91-98267-54548
Skype :- deepakdixit
On May 11, 2012, at 12:27
This makes sense Scott! We could even link the help from wiki online for demos. The problem is we use Confluence and its export is
known to be flawed and not supported/mantained anymore.
I think it can be continued this way in the meantime. We would then have a corpus of help to incoporate in
Yes you are right, my fault, it's was not broken there
Jacques
From: Scott Gray scott.g...@hotwaxmedia.com
Jacques,
Please remember that *everything* must be tested before committing to the release branches, we can't claim that these branches are
stable if it isn't being done.
Many thanks
[
https://issues.apache.org/jira/browse/OFBIZ-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273111#comment-13273111
]
Jacques Le Roux commented on OFBIZ-4802:
Thanks for clarification Jacopo
On 5/11/2012 3:52 AM, Adam Heath wrote:
On 04/20/2012 07:53 AM, jaco...@apache.org wrote:
Author: jacopoc
Date: Fri Apr 20 12:53:35 2012
New Revision: 1328356
URL: http://svn.apache.org/viewvc?rev=1328356view=rev
Log:
The cache of parsed Groovy scripts was not thread safe; this issue,
in
Good shot ! Thanks !
set field=layoutSettings.suppressTab value=ofbizsetup global=true/
made it.
Should it be added to the example(+ext) components as well as any new
component ??
Since that line is not in the 'application' component, is it hardcoded
somewhere that it shouldn't show up for those
On May 11, 2012, at 9:55 AM, Jacques Le Roux wrote:
This makes sense Scott! We could even link the help from wiki online for
demos. The problem is we use Confluence and its export is known to be flawed
and not supported/mantained anymore.
That is not related to what Scott was saying: the
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
On May 11, 2012, at 9:55 AM, Jacques Le Roux wrote:
This makes sense Scott! We could even link the help from wiki online for
demos. The problem is we use Confluence and its export
is known to be flawed and not supported/mantained
On May 11, 2012, at 10:57 AM, Jacques Le Roux wrote:
How to handle i18n automatisation in Confluence?
I was simply saying that the content could be created by the community in
Confluence and then ready to be transformed (by a script) and then committed to
OFBiz when we will agree on an
Jacques,
please, we had it on wiki before, it was moved to ofbiz to have the help
in the version what it was for and not a general help. Further it makes
ofbiz depending on wiki and it does not have the multi language
capability
Yes it does use OFBiz content manager with content and
On 5/11/2012 9:57 AM, Jacques Le Roux wrote:
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
On May 11, 2012, at 9:55 AM, Jacques Le Roux wrote:
This makes sense Scott! We could even link the help from wiki
online for demos. The problem is we use Confluence and its export
is known
Interesting conversation... but I would like to clarify that what I was
suggesting was to use Confluence as the sandbox to prepare content (to simplify
the cooperation of the community and in parallel waiting for the discussion
about the best format to use to finalize).
Jacopo
On May 11,
Fixed in revision 1337092. Thanks Scott!
The add-error + check-errors element combination and interaction was
very confusing to me. In some places it is used as you described, and in
other places the add-error element was used to simply create a list of
messages. Plus, in the original code,
On May 11, 2012, at 4:52 AM, Adam Heath wrote:
This change is in the release branch. I'd like to know the real reason this
was changed in ofbiz, and then my fix applied to the branch.
I have backported a new version of my fix to 12.04 (in rev. 1337054) and 11.04
(in rev. 1337097); I didn't
Oops, I missed two lines while changing it back. Fixed in rev 1337103.
-Adrian
On 5/11/2012 10:56 AM, Adrian Crum wrote:
Fixed in revision 1337092. Thanks Scott!
The add-error + check-errors element combination and interaction
was very confusing to me. In some places it is used as you
On 5/11/2012 1:28 AM, Adam Heath wrote:
On 05/10/2012 06:58 PM, Adrian Crum wrote:
On 5/11/2012 12:45 AM, Adam Heath wrote:
On 05/10/2012 06:40 PM, Adrian Crum wrote:
I wanted to discuss this again.
Some time ago I modified my local copy of OFBiz to execute the the ant
run-install task
Hi Adam,
On May 11, 2012, at 7:05 AM, Adam Heath wrote:
On 05/10/2012 11:51 PM, ash...@apache.org wrote:
Author: ashish
Date: Fri May 11 04:51:55 2012
New Revision: 1337026
URL: http://svn.apache.org/viewvc?rev=1337026view=rev
Log:
Applied similar fix as we did on trunk r1300463.
On
[
https://issues.apache.org/jira/browse/OFBIZ-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273171#comment-13273171
]
Tom Burns commented on OFBIZ-4802:
--
Use title-style capitalization for section titles.
[
https://issues.apache.org/jira/browse/OFBIZ-4873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ranjit Kumar Singh updated OFBIZ-4873:
--
Description:
If sorting is enabled for at least one field in the list type
Awesome thanks for the quick response Adrian. I'll admit to not knowing much
about it but my understanding has always been that the method exits immediately
if an internal error is generated.
Regards
Scott
On 11/05/2012, at 10:27 PM, Adrian Crum wrote:
Oops, I missed two lines while
Adrian, can I proceed with the proposed change then?
Thanks,
Jacopo
On Apr 24, 2012, at 2:36 PM, Adrian Crum wrote:
I hadn't thought of that. Thanks for the tip!
-Adrian
On 4/24/2012 1:10 PM, Jacopo Cappellato wrote:
there are actually use cases (and good motivations) for both options
On 05/11/2012 12:40 AM, Jacopo Cappellato wrote:
Hi Adam,
please see inline:
On May 11, 2012, at 4:52 AM, Adam Heath wrote:
On 04/20/2012 07:53 AM, jaco...@apache.org wrote:
Author: jacopoc
Date: Fri Apr 20 12:53:35 2012
New Revision: 1328356
URL:
On May 11, 2012, at 3:53 PM, Adam Heath wrote:
Haven't yet looked at those urls, but just based on your description, the
only way to fix code that has broken locking is to wrap it in synchronized.
If you use non-locking techniques, the code being called might still be run
in parallel,
On May 11, 2012, at 3:53 PM, Adam Heath wrote:
The code above that I originally quoted is doing DCL.
You are wrong; the DCL (anti) pattern is:
if (sharedResource == null) {
synchronized(lock) {
sharedResource = new Resource();
}
}
what I did is completely different because
On 05/11/2012 08:53 AM, Adam Heath wrote:
On 05/11/2012 12:40 AM, Jacopo Cappellato wrote:
Hi Adam,
please see inline:
On May 11, 2012, at 4:52 AM, Adam Heath wrote:
On 04/20/2012 07:53 AM, jaco...@apache.org wrote:
Author: jacopoc
Date: Fri Apr 20 12:53:35 2012
New Revision: 1328356
URL:
On May 11, 2012, at 4:26 PM, Adam Heath wrote:
@@ -177,10 +184,18 @@ public class GroovyUtil {
Class? scriptClass = parsedScripts.get(script);
if (scriptClass == null) {
scriptClass = loadClass(script);
- if (Debug.verboseOn()) Debug.logVerbose(Caching Groovy script:
+ script, module);
-
On 05/11/2012 09:36 AM, Jacopo Cappellato wrote:
On May 11, 2012, at 4:26 PM, Adam Heath wrote:
@@ -177,10 +184,18 @@ public class GroovyUtil {
Class? scriptClass = parsedScripts.get(script);
if (scriptClass == null) {
scriptClass = loadClass(script);
- if (Debug.verboseOn())
On 05/11/2012 09:51 AM, Adam Heath wrote:
On 05/11/2012 09:36 AM, Jacopo Cappellato wrote:
On May 11, 2012, at 4:26 PM, Adam Heath wrote:
@@ -177,10 +184,18 @@ public class GroovyUtil {
Class? scriptClass = parsedScripts.get(script);
if (scriptClass == null) {
scriptClass =
[
https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273340#comment-13273340
]
Jacopo Cappellato commented on OFBIZ-4856:
--
Fixed in rev. 1337202
[
https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacopo Cappellato closed OFBIZ-4856.
webapp tempfiles is not successfully loaded because of
java.io.FileNotFoundException
Nobody care?
Jacques
From: Jacques Le Roux jacques.le.r...@les7arts.com
I have changed the files I have in my working copy (svn up to date). But there
is still something weird:
At http://ci.apache.org/projects/ofbiz/snapshots/
I read Nightly 10.04 Builds
There is not such thing in my
On May 11, 2012, at 4:51 PM, Adam Heath wrote:
==
result = parsedScripts.get(key)
if (result == null) {
syncyronized (parsedScripts) {
result = parsedScripts.get(key)
if (result == null) {
result = genResult()
parsedScripts.put(key, result)
}
}
}
return result
==
On 05/11/2012 10:30 AM, Jacopo Cappellato wrote:
On May 11, 2012, at 4:51 PM, Adam Heath wrote:
==
result = parsedScripts.get(key)
if (result == null) {
syncyronized (parsedScripts) {
result = parsedScripts.get(key)
if (result == null) {
result = genResult()
On May 11, 2012, at 5:38 PM, Adam Heath wrote:
On 05/11/2012 10:30 AM, Jacopo Cappellato wrote:
On May 11, 2012, at 4:51 PM, Adam Heath wrote:
==
result = parsedScripts.get(key)
if (result == null) {
syncyronized (parsedScripts) {
result = parsedScripts.get(key)
if (result == null)
On May 11, 2012, at 5:49 PM, Jacopo Cappellato wrote:
is the real issue there (i.e. the DCL anti pattern) because another thread
could acquire a lock on helper and initialize it;
oops; errata corrige:
is the real issue there (i.e. the DCL anti pattern) because another thread
could acquire
[
https://issues.apache.org/jira/browse/OFBIZ-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273395#comment-13273395
]
Tom Burns commented on OFBIZ-4802:
--
Pierre ,
The help patch has broken the demo-trunk
On 05/11/2012 10:49 AM, Jacopo Cappellato wrote:
On May 11, 2012, at 5:38 PM, Adam Heath wrote:
On 05/11/2012 10:30 AM, Jacopo Cappellato wrote:
On May 11, 2012, at 4:51 PM, Adam Heath wrote:
==
result = parsedScripts.get(key)
if (result == null) {
syncyronized (parsedScripts) {
On May 11, 2012, at 6:34 PM, Adam Heath wrote:
Inside the synchronized block of your example I see the equivalent of a
putIfAbsent method; so your code can be simplified in the equivalent version:
There is no putIfAbsent inside synchronized of any example I have given.
What I meant is
[
https://issues.apache.org/jira/browse/OFBIZ-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273428#comment-13273428
]
Pierre Smits commented on OFBIZ-4802:
-
The help files don't contain code. So that
[
https://issues.apache.org/jira/browse/OFBIZ-4871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wai resolved OFBIZ-4871.
Resolution: Not A Problem
Issue does not happen in rev 1337287. Must have been an incomplete commit when
I
Jacques,
I care. But I can't help you there.
Regards,
Pierre
2012/5/11 Jacques Le Roux jacques.le.r...@les7arts.com
Nobody care?
Jacques
From: Jacques Le Roux jacques.le.r...@les7arts.com
I have changed the files I have in my working copy (svn up to date). But
there is still
On May 11, 2012, at 6:34 PM, Adam Heath wrote:
There is no difference. The act of map.get() can be doing a *lot* of
separate, individual steps. Without any kind of
happens-before/happens-after on map.get(), the protected put/get in
the lock could interleave with the unprotected get.
Ok,
On 05/11/2012 12:30 PM, Jacopo Cappellato wrote:
On May 11, 2012, at 6:34 PM, Adam Heath wrote:
There is no difference. The act of map.get() can be doing a *lot* of
separate, individual steps. Without any kind of
happens-before/happens-after on map.get(), the protected put/get in
the
As I have discussed, I will be committing a series of separate
commits, that change findByPrimaryKey calls into findOne. I have run
the test cases on these changes, and everything compiles. However,
ofbiz does *not* have 100% coverage, no where close. Some of the
changes are inside groovy/ftl
On May 11, 2012, at 8:00 PM, Adam Heath wrote:
On 05/11/2012 12:30 PM, Jacopo Cappellato wrote:
On May 11, 2012, at 6:34 PM, Adam Heath wrote:
There is no difference. The act of map.get() can be doing a *lot* of
separate, individual steps. Without any kind of
On 05/11/2012 02:46 PM, Jacopo Cappellato wrote:
The UtilCache objects *are* thread-safe. You will not get any
internal corruption inside UtilCache. That is all that can be guaranteed.
What isn't thread safe, is that calling code may end up having
multiple instances for the same key, unless
[
https://issues.apache.org/jira/browse/OFBIZ-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273622#comment-13273622
]
Jacques Le Roux commented on OFBIZ-4856:
Jacopo,
If you get a chance, please
On 05/11/2012 05:25 AM, adri...@apache.org wrote:
Author: adrianc
Date: Fri May 11 10:25:33 2012
New Revision: 1337103
URL: http://svn.apache.org/viewvc?rev=1337103view=rev
Log:
Fixed broken Mini-languagecheck-errors element (second try).
Modified:
62 matches
Mail list logo
