Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-18 Thread Adam Heath
On 04/18/2012 02:57 AM, jaco...@apache.org wrote: Author: jacopoc Date: Wed Apr 18 07:57:46 2012 New Revision: 1327411 URL: http://svn.apache.org/viewvc?rev=1327411view=rev Log: Removed bin folder and moved its content to the tools folder: this was discussed extensively in the dev list

Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-18 Thread Adam Heath
On 04/18/2012 10:55 AM, Erwan de FERRIERES wrote: Le 18/04/2012 17:21, Adam Heath a écrit : On 04/18/2012 02:57 AM, jaco...@apache.org wrote: Author: jacopoc Date: Wed Apr 18 07:57:46 2012 New Revision: 1327411 URL: http://svn.apache.org/viewvc?rev=1327411view=rev Log: Removed bin folder

Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-18 Thread Adam Heath
On 04/18/2012 11:56 AM, Adrian Crum wrote: On 4/18/2012 5:43 PM, Adam Heath wrote: On 04/18/2012 10:55 AM, Erwan de FERRIERES wrote: Le 18/04/2012 17:21, Adam Heath a écrit : On 04/18/2012 02:57 AM, jaco...@apache.org wrote: Author: jacopoc Date: Wed Apr 18 07:57:46 2012 New Revision

Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-18 Thread Adam Heath
On 04/18/2012 12:20 PM, Adam Heath wrote: Things have changed in ofbiz, so that now it takes a *huge* amount of time. Some of that is related to a larger amount of code overflowing the cpu's L2 cache. Some of that is related to catalina startup, when it tries to seed the sessions randomness

Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-18 Thread Adam Heath
On 04/18/2012 12:28 PM, Jacopo Cappellato wrote: On Apr 18, 2012, at 7:20 PM, Adam Heath wrote: ps: I am going to switch if in ant *back* to javascript, *away* from ant-contrib. The latter is significantly slower when using a system installed ant. No please, don't do that. I've pointed

Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-18 Thread Adam Heath
On 04/18/2012 12:46 PM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 04/18/2012 12:28 PM, Jacopo Cappellato wrote: On Apr 18, 2012, at 7:20 PM, Adam Heath wrote: ps: I am going to switch if in ant *back* to javascript, *away* from ant-contrib. The latter is significantly

jackrabbit test cases failing?

2012-04-18 Thread Adam Heath
See attached file. ?xml version=1.0 encoding=UTF-8 ? testsuites testsuite errors=4 failures=0 hostname=adam-ofbiz-testing id=11 name=jcrtests package= tests=17 time=4.851 timestamp=2012-04-18T19:02:03 properties / testcase classname=org.ofbiz.jcr.test.JackrabbitTests

Re: SagePay Gateway: needs PCI with tokenization

2012-04-18 Thread Adam Heath
On 04/18/2012 03:28 PM, Brajesh Patel wrote: Hello All, I am looking into Sagepay related stuff: Currently we have Sagepay payment gateway integration in OOTB, We have requirement for PCI with tokenization in sage pay. I am thinking that we need to add 'SagepayPaymentMethod' entity,

Re: svn commit: r1327735 - in /ofbiz/trunk/framework/entity/src/org/ofbiz/entity: jdbc/SqlJdbcUtil.java model/ModelViewEntity.java

2012-04-19 Thread Adam Heath
On 04/18/2012 09:14 PM, Scott Gray wrote: Nice, I ran into a problem related to this very recently. Thanks for taking care of it. view-entity member-entity entity-name=Foo view-entity view-entity entity-name=Foo member-entity alias=A entity-name=Bar member-entity alias=B

Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-19 Thread Adam Heath
On 04/18/2012 11:33 PM, Jacopo Cappellato wrote: On Apr 18, 2012, at 7:37 PM, Adam Heath wrote: On 04/18/2012 12:28 PM, Jacopo Cappellato wrote: On Apr 18, 2012, at 7:20 PM, Adam Heath wrote: ps: I am going to switch if in ant *back* to javascript, *away* from ant-contrib. The latter

Re: svn commit: r1327835 - in /ofbiz/trunk/framework: jcr/src/org/ofbiz/jcr/test/JackrabbitTests.java widget/src/org/ofbiz/widget/WidgetWorker.java

2012-04-19 Thread Adam Heath
On 04/19/2012 12:58 AM, sascharodek...@apache.org wrote: Author: sascharodekamp Date: Thu Apr 19 05:58:29 2012 New Revision: 1327835 URL: http://svn.apache.org/viewvc?rev=1327835view=rev Log: Fix jackrabbit unit testing. Modified:

Re: HashCrypt is deprecated: is this an issue?

2012-04-19 Thread Adam Heath
On 04/19/2012 02:06 AM, Pierre Smits wrote: When building the trunk I get (amonst others) following notifications: classes: [javac16] Compiling 140 source files to /ci/ofbiz/framework/entity/build/classes [javac16]

Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-19 Thread Adam Heath
a SSD in your laptop Jacopo? Jacques From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On Apr 18, 2012, at 6:55 PM, Jacopo Cappellato wrote: On Apr 18, 2012, at 6:43 PM, Adam Heath wrote: It currently takes my desktop 1 hour to run a full test suite. clean, load-demo(30m), run-tests

recent HashCrypt changes, and using salt-based password hashing

2012-04-19 Thread Adam Heath
As some may have noticed, I recently changed the way ofbiz creates password hashes when it stores them in the database. Each time a new password is created, a bit of randomness is used, to create a random-length, random-content salt. This is placed at the beginning of the hashed password, stored

upcoming Delegator deprecations

2012-04-19 Thread Adam Heath
commit 6493e4845f2acab9ce3e1f92cdc7f5b62bb79a2f Author: Adam Heath doo...@brainfood.com Date: Sun Dec 5 18:32:01 2010 -0600 Deprecate GenericValue.getRelatedDummyPK(String). Still more api simplification. Fortunately, this is a very small change. It seems that this method

openid support

2012-04-19 Thread Adam Heath
I have a series of patches that enable ofbiz to be used as an openid *provider*. I used this to allow a wordpress site to delegate authentication to ofbiz(the company in question already had an ofbiz deployment hooked into their internal ldap, with phone/name synching; didn't want to duplicate

Re: svn commit: r1327866 - in /ofbiz/trunk: applications/accounting/data/ applications/content/data/ applications/humanres/data/ applications/marketing/data/ applications/order/data/ framework/example

2012-04-19 Thread Adam Heath
On 04/19/2012 03:43 AM, jaco...@apache.org wrote: Author: jacopoc Date: Thu Apr 19 08:43:54 2012 New Revision: 1327866 URL: http://svn.apache.org/viewvc?rev=1327866view=rev Log: Reverted rev. 1327736: with it it was impossible to log in with demo accounts. Ok, then the test cases suck.

Re: openid support

2012-04-19 Thread Adam Heath
On 04/19/2012 04:28 PM, Jacques Le Roux wrote: Hi Adam, The recent trend is to slim down OFBiz. This could be one of the Apache OFBiz Extras If someone needs it it pick up from there, et voilà There are multiple layers. framework/openid, which has the basic logic, but not any of the AX

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-19 Thread Adam Heath
are rather straight forward, just moving code around. When I finally get around to adding the new features, then there is a very definate chance of breaking stuff. Jacques From: Adam Heath doo...@brainfood.com As some may have noticed, I recently changed the way ofbiz creates password hashes when

Re: Opinions wanted on r1307895

2012-04-19 Thread Adam Heath
On 04/19/2012 04:41 PM, Jacques Le Roux wrote: Committed at revision: 1328122 Jacques This change would be needed for anything dealing with PAN(credit-card number for those not into the lingo). From: Jacques Le Roux jacques.le.r...@les7arts.com Nope, I'd not have raised a warning else ;o)

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-19 Thread Adam Heath
On 04/19/2012 04:49 PM, Adam Heath wrote: On 04/19/2012 04:28 PM, Jacques Le Roux wrote: Looking forward for https://issues.apache.org/jira/browse/OFBIZ-1151 https://issues.apache.org/jira/browse/OFBIZ-2729 https://issues.apache.org/jira/browse/OFBIZ-3006 2729 doesn't apply for what I am

Re: openid support

2012-04-19 Thread Adam Heath
On 04/19/2012 04:55 PM, Brett Palmer wrote: Adam, There was a previous thread on the subject of implementing other authentication and security models to support OpenId, LDAP, and other custom authentication needs. The subject of the thread was Alternatives to using UserLoginId as a primary

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-19 Thread Adam Heath
On 04/19/2012 06:13 PM, Scott Gray wrote: On 20/04/2012, at 9:49 AM, Adam Heath wrote: On 04/19/2012 04:28 PM, Jacques Le Roux wrote: Looking forward for https://issues.apache.org/jira/browse/OFBIZ-1151 https://issues.apache.org/jira/browse/OFBIZ-2729 https://issues.apache.org/jira

Re: openid support

2012-04-19 Thread Adam Heath
On 04/19/2012 10:39 PM, Sam Hamilton wrote: Hey Guys, We are soon going to need OAuth support to allow external users to log into OFBiz Ecommerce site, which I believe is similar in design to openid. Just wondering if you considered using Apache Shiro http://shiro.apache.org/ to help manage the

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-20 Thread Adam Heath
On 04/20/2012 12:53 AM, Pierre Smits wrote: Hi Adam, How would that be? That would be one per tenant in a multi-tenant setup? I can imagine in a multi-tenant setup with the db backend not on derby (as we all recommend) the upgrade/migration aspect can be enormous. Even more so in a HAFO-setup.

Re: openid support

2012-04-20 Thread Adam Heath
On 04/20/2012 01:32 AM, Jacques Le Roux wrote: Hi Sam, What proposes Adam is not exactly related. He proposes to introduce a way for OFBiz to be an OpenId server.. And yes we already discussed about using Shiro in OFBiz. But we also agreed recently to focus our efforts on the slim down action...

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-20 Thread Adam Heath
On 04/20/2012 09:56 AM, Pierre Smits wrote: Hi Adam, I can follow your reasoning. And it seems reasonable. But I would like to suggest to you to create a JIRA for this where patches are uploaded and can be tested in a separate ofbiz instantiation. This would then help with the creation of

Re: SagePay Gateway: needs PCI with tokenization

2012-04-20 Thread Adam Heath
On 04/20/2012 11:54 AM, Brajesh Patel wrote: Thanks Adam for your valuable comment, I found token related information for the sagepay from http://www.sagepay.com/token-system site as follows: Token System is a safe way of keeping card details without actually storing them. We store and

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-20 Thread Adam Heath
On 04/20/2012 12:13 PM, Jacques Le Roux wrote: Not sure you noticed but Builbot is no longer running http://ci.apache.org/waterfall?show_events=falsebranch=builder=ofbiz-trunkreload=none Yeah, noticed that buildbot wasn't emailing. Looking at that link, it appears that isis_ubuntu is offline.

Re: svn commit: r1328517 - /ofbiz/branches/release10.04/framework/base/config/test-containers.xml

2012-04-20 Thread Adam Heath
On 04/20/2012 04:33 PM, er...@apache.org wrote: Author: erwan Date: Fri Apr 20 21:33:02 2012 New Revision: 1328517 URL: http://svn.apache.org/viewvc?rev=1328517view=rev Log: OFBIZ-4828 R10.04 testports in use when testing in CI (Jenkins) Um, no, don't do this. Modified:

Re: svn commit: r1328517 - /ofbiz/branches/release10.04/framework/base/config/test-containers.xml

2012-04-20 Thread Adam Heath
On 04/20/2012 05:47 PM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 04/20/2012 04:33 PM, er...@apache.org wrote: Author: erwan Date: Fri Apr 20 21:33:02 2012 New Revision: 1328517 URL: http://svn.apache.org/viewvc?rev=1328517view=rev Log: OFBIZ-4828 R10.04 testports

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-26 Thread Adam Heath
On 04/22/2012 03:53 AM, Adrian Crum wrote: On 4/20/2012 9:00 PM, Adam Heath wrote: On 04/20/2012 12:13 PM, Jacques Le Roux wrote: Not sure you noticed but Builbot is no longer running http://ci.apache.org/waterfall?show_events=falsebranch=builder=ofbiz-trunkreload=none Yeah, noticed

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-26 Thread Adam Heath
On 04/23/2012 08:40 AM, Jacopo Cappellato wrote: Adrian, the issue you are experiencing is interesting and I had a look at it; I was only able to recreate the same failures by changing the timeouts in UtilCacheTests.java at line 302 and 308; instead of: cache.setExpireTime(100); // line

Re: framework/base tests failing

2012-04-26 Thread Adam Heath
On 04/24/2012 03:06 AM, Jacopo Cappellato wrote: This is really weird... I am wondering if there are issues caused by concurrent threads accessing the cache but the JUnit tests should be all executed in the same thread... so this should not be the case. The tests run in the foreground, yes,

kek(key-encrypting-key), PCI compliance

2012-05-02 Thread Adam Heath
I came in like a storm, but then got quiet for a short while. I'm back to announce that I just had a successful first-run load-demo, with key-encrypting-key working. I've got 28(or so) changes upto today. Splitting this last little bit will add another 10(I got sidetracked on making

Re: framework/base tests failing

2012-05-02 Thread Adam Heath
[trying to stop this thread a bit] If the root cause *is* a time-slice issue, the fix is to *not* increase the timeout. Dead stop. Changing the timeout will just cause it to again fail at some point in the future when computers get faster yet again. The correct fix is to make the timeout *not

Re: kek(key-encrypting-key), PCI compliance

2012-05-02 Thread Adam Heath
On 05/02/2012 04:48 PM, Jacques Le Roux wrote: This is really great news Adam, thanks for the effort! I still have a ton of testing to do; I need to clone some oldish-type ofbiz installs that have credit cards, apply my patch(s), then see what happens. How did you finally handle the length of

Re: entitymodel - entity-condition inside view-link - seems to work in trunk, any plans to fix it in 11.04?

2012-05-02 Thread Adam Heath
On 04/27/2012 02:50 AM, Jacques Le Roux wrote: Reverted, it did not compile, thanks to Amit Sharma who called me Sometimes it's not possible to backport a fix for a file bug; there can be lots of other dependant patches that are required, that are too unstable(or just not wanted) for a released

Re: framework/base tests failing

2012-05-02 Thread Adam Heath
On 05/02/2012 05:26 PM, Jacopo Cappellato wrote: On May 2, 2012, at 11:32 PM, Adam Heath wrote: If the root cause *is* a time-slice issue, the fix is to *not* increase the timeout. Dead stop. Changing the timeout will just cause it to again fail at some point in the future when computers

Re: entitymodel - entity-condition inside view-link - seems to work in trunk, any plans to fix it in 11.04?

2012-05-03 Thread Adam Heath
On 05/03/2012 12:56 AM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 04/27/2012 02:50 AM, Jacques Le Roux wrote: Reverted, it did not compile, thanks to Amit Sharma who called me Sometimes it's not possible to backport a fix for a file bug; there can be lots of other

Re: framework/base tests failing

2012-05-03 Thread Adam Heath
On 05/03/2012 04:44 AM, Adrian Crum wrote: I agree that it is a workaround and not a solution. The problem is, the tests fail 100% of the time on my development machine, and they fail intermittently on the ASF CI machine and our (1Tech) CI machine. So, the workaround is needed to get various

Re: DISCUSS: deprecating a TON of Delegator/GenericDelegator calls(huge)

2012-05-03 Thread Adam Heath
On 05/03/2012 10:44 AM, Jacopo Cappellato wrote: Hi Adam, On May 3, 2012, at 5:20 PM, Adam Heath wrote: So, I'm asking if I can commit these to both trunk and 12.04. If not, we'd have to wait even longer to fully remove these methods(at least another year). I didn't review your patch

(backporting kek) Re: svn commit: r1333619 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/crypto/Main.java

2012-05-04 Thread Adam Heath
On 05/04/2012 12:11 AM, Jacopo Cappellato wrote: Hi Adam, are you going to backport this (and other relevant commits) to the 12.04 branch as well? I plan to, yes, but I'm going to finish up the kek(key-encrypting-key) support first. I've got the code done, just need to do more testing.

Re: buildbot success in ASF Buildbot on ofbiz-trunk

2012-05-04 Thread Adam Heath
On 05/04/2012 11:21 AM, build...@apache.org wrote: The Buildbot has detected a restored build on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/2732 Are all these messages still just testing the new system?

Re: buildbot failure in ASF Buildbot on ofbiz-trunk

2012-05-04 Thread Adam Heath
On 05/04/2012 01:44 PM, build...@apache.org wrote: The Buildbot has detected a new failure on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/2737 Buildbot URL: http://ci.apache.org/ Buildslave for this

Re: buildbot failure in ASF Buildbot on ofbiz-trunk

2012-05-05 Thread Adam Heath
Well, why can't the queue be purged? -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. Scott Gray scott.g...@hotwaxmedia.com wrote: You'll probably find that it's just playing catch up and will get to the head soon enough. Regards Scott On 6/05/2012, at 1:22 AM, Adrian

Re: tenant problem in framework can somebody (Adam) help?

2012-05-07 Thread Adam Heath
I'll fix it when I get to work. ps: there are really no test cases for tenants? -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. Hans Bakker mailingl...@antwebsystems.com wrote: In the framework found the following problem: in GenericDelegator.java, line 226:

Re: tenant problem in framework can somebody (Adam) help?

2012-05-07 Thread Adam Heath
On 05/07/2012 09:18 AM, Adam Heath wrote: I'll fix it when I get to work. ps: there are really no test cases for tenants? ps: I have a plan for testing the tenant code. Do not start it by just 'cloning' the existing entitymodels for the tenant. That will take *way* to long. Instead, create

Re: tenant problem in framework can somebody (Adam) help?

2012-05-07 Thread Adam Heath
On 05/07/2012 02:46 PM, Pierre Smits wrote: Adam, Pleaase elaborate on what the unit test(s) should achieve? Creating new tenants and loading the tenant instantiation with demo data? Or? All of the above, anything, something. There are no automated test cases *at all* for tenant anything.

Re: tenant problem in framework can somebody (Adam) help?

2012-05-07 Thread Adam Heath
On 05/07/2012 03:40 PM, Pierre Smits wrote: Given that the tenants use the same codebase and only use a different delegator than main, you could say that performing unit tests as in a tenant delegator should get you the same results as doing them in the main delegator. But, then there would

Re: svn commit: r1335268 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityCrypto.java

2012-05-07 Thread Adam Heath
On 05/07/2012 04:27 PM, doo...@apache.org wrote: Author: doogie Date: Mon May 7 21:27:32 2012 New Revision: 1335268 URL: http://svn.apache.org/viewvc?rev=1335268view=rev Log: FEATURE: Key-encrypting-key(kek) support is now enabled. To enable support for this, run: java

old ofbiz versions

2012-05-08 Thread Adam Heath
I use git(-svn) to do my ofbiz work(as many here probably know). Currently, the svn is hosted on apache.org servers. When it was imported, the history was started fresh. This was done back in July, 2006. However, that wasn't good enough for me. I dug around and found references to the previous

Re: old ofbiz versions

2012-05-09 Thread Adam Heath
On 05/08/2012 11:18 PM, Jacopo Cappellato wrote: Hi Adam, I don't know if it is useful but for some time in its history (but I don't remember the years) the OFBiz project was hosted at dev.java.net,maybe the url was: https://ofbiz.dev.java.net/ dev.java.net doesn't exist either.

Re: OFBiz's first commit

2012-05-09 Thread Adam Heath
On 01/27/2011 02:11 PM, David E Jones wrote: The project was created on SourceForge.net on 13 May 2001. I don't know when the first commit was. The first preview release (still available on SourceForge) was ofbiz-2001.05.24.zip which, as the name implies, was released on 24 May 2001.

Re: OFBiz's first commit

2012-05-09 Thread Adam Heath
On 05/09/2012 06:43 PM, Adam Heath wrote: On 01/27/2011 02:11 PM, David E Jones wrote: The project was created on SourceForge.net on 13 May 2001. I don't know when the first commit was. The first preview release (still available on SourceForge) was ofbiz-2001.05.24.zip which, as the name

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-10 Thread Adam Heath
On 05/10/2012 11:05 AM, doo...@apache.org wrote: Author: doogie Date: Thu May 10 16:05:00 2012 New Revision: 1336768 URL: http://svn.apache.org/viewvc?rev=1336768view=rev Log: FIX: s/run-install/load-demo/ I'm surprised I actually had to do this. It implies that the scripts are not being

Re: svn commit: r1336772 - in /ofbiz/trunk/tools: mergefromtrunk.bat mergefromtrunk.sh

2012-05-10 Thread Adam Heath
On 05/10/2012 11:13 AM, doo...@apache.org wrote: Author: doogie Date: Thu May 10 16:13:23 2012 New Revision: 1336772 URL: http://svn.apache.org/viewvc?rev=1336772view=rev Log: FEATURE/OPTIMIZE: Copied these from the release12.04 branch(using svn copy). Having to manually add them to

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-10 Thread Adam Heath
On 05/10/2012 11:16 AM, Adrian Crum wrote: The scripts are helpful if you have a Subversion client that runs from the command line. Some of us use a graphical Subversion client - like Tortoise, or the Eclipse plugin. Which brings up another thought I had. Maybe converting these to a series of

backports(to 12.04) of my recent commits

2012-05-10 Thread Adam Heath
I've added 2 major(ish) new features recently. * salt-based password hashing(with base64 encoding) * key-encrypting-key(kek) support. The salt-based psasword feature was written when JIRA was hacked several years ago; JIRA is based on an old version of OfBiz, so this change could be considered a

Re: OFBiz multi-threading

2012-05-10 Thread Adam Heath
On 05/10/2012 06:40 PM, Adrian Crum wrote: I wanted to discuss this again. Some time ago I modified my local copy of OFBiz to execute the the ant run-install task faster by using multi-threaded entity creation and data loading. I don't remember what i was working on at the time, but I

Re: OFBiz multi-threading

2012-05-10 Thread Adam Heath
On 05/10/2012 06:58 PM, Adrian Crum wrote: On 5/11/2012 12:45 AM, Adam Heath wrote: On 05/10/2012 06:40 PM, Adrian Crum wrote: I wanted to discuss this again. Some time ago I modified my local copy of OFBiz to execute the the ant run-install task faster by using multi-threaded entity creation

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-10 Thread Adam Heath
On 04/20/2012 07:53 AM, jaco...@apache.org wrote: Author: jacopoc Date: Fri Apr 20 12:53:35 2012 New Revision: 1328356 URL: http://svn.apache.org/viewvc?rev=1328356view=rev Log: The cache of parsed Groovy scripts was not thread safe; this issue, in instances with several concurrent threads

Re: svn commit: r1337024 - in /ofbiz/trunk: applications/accounting/src/org/ofbiz/accounting/thirdparty/clearcommerce/ framework/base/src/org/ofbiz/base/util/ framework/webapp/src/org/ofbiz/webapp/eve

2012-05-10 Thread Adam Heath
On 05/10/2012 11:46 PM, ash...@apache.org wrote: Author: ashish Date: Fri May 11 04:46:26 2012 New Revision: 1337024 URL: http://svn.apache.org/viewvc?rev=1337024view=rev Log: Applied similar fix as we did on trunk r1300463. On production systems you can't suppress Debug.log( message by the use

Re: svn commit: r1337026 - in /ofbiz/branches/release11.04: applications/accounting/src/org/ofbiz/accounting/thirdparty/clearcommerce/ framework/webapp/src/org/ofbiz/webapp/event/ specialpurpose/shark

2012-05-10 Thread Adam Heath
On 05/10/2012 11:51 PM, ash...@apache.org wrote: Author: ashish Date: Fri May 11 04:51:55 2012 New Revision: 1337026 URL: http://svn.apache.org/viewvc?rev=1337026view=rev Log: Applied similar fix as we did on trunk r1300463. On production systems you can't suppress Debug.log( message by the use

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 12:40 AM, Jacopo Cappellato wrote: Hi Adam, please see inline: On May 11, 2012, at 4:52 AM, Adam Heath wrote: On 04/20/2012 07:53 AM, jaco...@apache.org wrote: Author: jacopoc Date: Fri Apr 20 12:53:35 2012 New Revision: 1328356 URL: http://svn.apache.org/viewvc?rev

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 08:53 AM, Adam Heath wrote: On 05/11/2012 12:40 AM, Jacopo Cappellato wrote: Hi Adam, please see inline: On May 11, 2012, at 4:52 AM, Adam Heath wrote: On 04/20/2012 07:53 AM, jaco...@apache.org wrote: Author: jacopoc Date: Fri Apr 20 12:53:35 2012 New Revision: 1328356 URL

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 09:36 AM, Jacopo Cappellato wrote: On May 11, 2012, at 4:26 PM, Adam Heath wrote: @@ -177,10 +184,18 @@ public class GroovyUtil { Class? scriptClass = parsedScripts.get(script); if (scriptClass == null) { scriptClass = loadClass(script); - if (Debug.verboseOn

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 09:51 AM, Adam Heath wrote: On 05/11/2012 09:36 AM, Jacopo Cappellato wrote: On May 11, 2012, at 4:26 PM, Adam Heath wrote: @@ -177,10 +184,18 @@ public class GroovyUtil { Class? scriptClass = parsedScripts.get(script); if (scriptClass == null) { scriptClass = loadClass

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 10:30 AM, Jacopo Cappellato wrote: On May 11, 2012, at 4:51 PM, Adam Heath wrote: == result = parsedScripts.get(key) if (result == null) { syncyronized (parsedScripts) { result = parsedScripts.get(key) if (result == null) { result = genResult

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 10:49 AM, Jacopo Cappellato wrote: On May 11, 2012, at 5:38 PM, Adam Heath wrote: On 05/11/2012 10:30 AM, Jacopo Cappellato wrote: On May 11, 2012, at 4:51 PM, Adam Heath wrote: == result = parsedScripts.get(key) if (result == null) { syncyronized (parsedScripts

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 12:30 PM, Jacopo Cappellato wrote: On May 11, 2012, at 6:34 PM, Adam Heath wrote: There is no difference. The act of map.get() can be doing a *lot* of separate, individual steps. Without any kind of happens-before/happens-after on map.get(), the protected put/get

Warning! In the next few hours, I will be committing findByPrimaryKey-findOne changes

2012-05-11 Thread Adam Heath
As I have discussed, I will be committing a series of separate commits, that change findByPrimaryKey calls into findOne. I have run the test cases on these changes, and everything compiles. However, ofbiz does *not* have 100% coverage, no where close. Some of the changes are inside groovy/ftl

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 02:46 PM, Jacopo Cappellato wrote: The UtilCache objects *are* thread-safe. You will not get any internal corruption inside UtilCache. That is all that can be guaranteed. What isn't thread safe, is that calling code may end up having multiple instances for the same key, unless

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-11 Thread Adam Heath
On 05/11/2012 05:25 AM, adri...@apache.org wrote: Author: adrianc Date: Fri May 11 10:25:33 2012 New Revision: 1337103 URL: http://svn.apache.org/viewvc?rev=1337103view=rev Log: Fixed broken Mini-languagecheck-errors element (second try). Modified:

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Adam Heath
provide the test report XML file please? -Adrian On 5/12/2012 3:59 AM, Adam Heath wrote: On 05/11/2012 05:25 AM, adri...@apache.org wrote: Author: adrianc Date: Fri May 11 10:25:33 2012 New Revision: 1337103 URL: http://svn.apache.org/viewvc?rev=1337103view=rev Log: Fixed broken Mini

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Adam Heath
On 05/12/2012 07:17 AM, Adrian Crum wrote: Okay, rev 1337518 gets the tests to pass, but it isn't a fix - it merely masks the real problem. I made the commit so others can continue with their work, and I will continue working on the real problem. Without going into too much detail, here is a

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 04:01 AM, Jacopo Cappellato wrote: On May 10, 2012, at 6:23 PM, Adam Heath wrote: On 05/10/2012 11:16 AM, Adrian Crum wrote: The scripts are helpful if you have a Subversion client that runs from the command line. Some of us use a graphical Subversion client - like Tortoise

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 05:15 AM, Jacques Le Roux wrote: +1 Though I'd like to keep revert.bat, it's easier to change path (and not forget) with new release than have to search in build.xml, not a big deal though... tools/ant-revert.xml: ./ant revert ./ant -f tools/ant-revert.xml revert both commands

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 03:36 PM, Jacques Le Roux wrote: I just meant it's easier to edit revert.bat than to seek for it in the build.xml when you have to update the path for a new release. Forget it, sometimes I'm too lazy :o) I mean the definition for the ant revert command should be in a separate

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 03:39 PM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 05/12/2012 04:01 AM, Jacopo Cappellato wrote: On May 10, 2012, at 6:23 PM, Adam Heath wrote: On 05/10/2012 11:16 AM, Adrian Crum wrote: The scripts are helpful if you have a Subversion client that runs

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 04:04 PM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 05/12/2012 03:36 PM, Jacques Le Roux wrote: I just meant it's easier to edit revert.bat than to seek for it in the build.xml when you have to update the path for a new release. Forget it, sometimes I'm too

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-12 Thread Adam Heath
On 05/12/2012 04:28 PM, Jacques Le Roux wrote: I'm sure you are both afraid of that, but in case you freithened people about DCL I wanted to say that since jdk 1.5 way of handling volatile it's now possible to safely use this pattern with Java

Re: Errors in screen while running findByAnd

2012-05-16 Thread Adam Heath
On 05/16/2012 11:30 AM, Adam Heath wrote: On 05/16/2012 11:18 AM, Adam Heath wrote: On 05/16/2012 11:05 AM, Adam Heath wrote: On 05/16/2012 06:41 AM, Jacopo Cappellato wrote: https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=Demo1002 This may be a stupid question

Re: Errors in screen while running findByAnd

2012-05-17 Thread Adam Heath
On 05/17/2012 10:56 AM, Jacopo Cappellato wrote: Looks good to me, are you going to attach it to the ticket I have created in the Freemarker bug tracker? I'll do it; what's the other bug#? Do we want to bump the severity?

Re: Errors in screen while running findByAnd

2012-05-17 Thread Adam Heath
On 05/17/2012 10:57 AM, Adam Heath wrote: On 05/17/2012 10:56 AM, Jacopo Cappellato wrote: Looks good to me, are you going to attach it to the ticket I have created in the Freemarker bug tracker? I'll do it; what's the other bug#? Do we want to bump the severity? I'm just waiting

Re: Errors in screen while running findByAnd

2012-05-17 Thread Adam Heath
On 05/17/2012 11:48 AM, Jacopo Cappellato wrote: wonderful I can't seem to attach files to that issue, maybe because I didn't originally file it. Could you see if you can attach both files? If you can, but I can't, then the sf tracker is really stupid.

Re: Errors in screen while running findByAnd

2012-05-17 Thread Adam Heath
On 05/17/2012 11:50 PM, Adam Heath wrote: On 05/17/2012 12:23 PM, Jacopo Cappellato wrote: file are attached; that bug tracker is really awful. This is all becoming very troubling. == example methods String a(String name, List list) {} String a(String name, Map map) {} String a(Object[] args

Re: svn commit: r714085 - in /ofbiz/trunk/debian: ./ rules

2008-11-17 Thread Adam Heath
Jacques Le Roux wrote: I guess Adam is doing a .deb package for OFBiz :o) Actually, several. I just recently split the package even further. Before, I had ofbiz and ofbiz-specialpurpose, as separate debs. Now, I have ofbiz-framework, ofbiz-applications, and ofbiz-specialpurpose, with an

Re: svn commit: r714085 - in /ofbiz/trunk/debian: ./ rules

2008-11-17 Thread Adam Heath
Adrian Crum wrote: Adam Heath wrote: I discovered that when I split application/framework, that there were exceptions printed at startup. It tries to load a bunch of freemarker transforms, but the classes don't exist for that; I'll fix that problem by using the META-INF/services framework

Re: OFBiz and postgres

2008-11-18 Thread Adam Heath
Adrian Crum wrote: Each installation is responsible for copying the required driver to the framework/entity/lib/jdbc folder. Once the debian packaging is completely done, this won't be a problem.

Re: OFBiz and postgres

2008-11-18 Thread Adam Heath
Jacques Le Roux wrote: As I understand it, it's a package for Debian. As Ubuntu uses Debian underneath it will work on Ubuntu too. I'm not a specialist but I saw some tools to migrate a package between Linux distribution. Not sure of the quality though, this will certainly improve in the

framework release, icky internal dep

2008-11-19 Thread Adam Heath
We've been working toward a framework release. The framework contains several webapps, all of which require you to log in. This is mostly ok, because the UserLogin table itself resides in framework. However, there is only a single login available, system, which has no password, and is disabled.

Re: framework release, icky internal dep

2008-11-20 Thread Adam Heath
BJ Freeman wrote: David sounds like you stating Linux or Unix rules. However the Windows version logs you in as administrator privileges so you can add software (vista). They don't force you to have a second login that is not an admin level. Er, the unix way is to give you enough rope to

Re: Security UI

2008-11-21 Thread Adam Heath
Bruno Busco wrote: Adrian, I would rather prefer having it renamed to CommonX. pentium +1.11127834856 /pentium

Re: request to add missing jdbc jars, at least postgres.jar

2008-11-24 Thread Adam Heath
Harmeet Bedi wrote: Maybe a good part way would be to support only popular opensource out of box. You have one - derby. The other 2 mains ones are postgres and mysql. We have the problem addressed on our end, that is not the concern. Was trying to see if we can generalize and reduce both our

Re: svn commit: r720158 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy

2008-11-25 Thread Adam Heath
[EMAIL PROTECTED] wrote: == --- ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy (original) +++

Re: svn commit: r720570 - in /ofbiz/trunk: applications/party/script/org/ofbiz/party/contact/PartyContactMechServices.xml applications/party/servicedef/services.xml framework/common/config/general.pro

2008-11-25 Thread Adam Heath
--- ofbiz/trunk/framework/common/config/general.properties (original) +++ ofbiz/trunk/framework/common/config/general.properties Tue Nov 25 11:40:33 2008 @@ -73,6 +73,9 @@ #--Fallback [true|false] determines whether you will allow a non secure connection if you are unable to get a secure

Re: svn commit: r720570 - in /ofbiz/trunk: applications/party/script/org/ofbiz/party/contact/PartyContactMechServices.xml applications/party/servicedef/services.xml framework/common/config/general.pro

2008-11-25 Thread Adam Heath
Adam Heath wrote: --- ofbiz/trunk/framework/common/config/general.properties (original) +++ ofbiz/trunk/framework/common/config/general.properties Tue Nov 25 11:40:33 2008 @@ -73,6 +73,9 @@ #--Fallback [true|false] determines whether you will allow a non secure connection if you

Re: svn commit: r720158 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy

2008-11-25 Thread Adam Heath
Jacques Le Roux wrote: Don't worry Adam, I already reverted in r720161 Thanks for your awareness :o) Ok, cool. I was looking at my mercurial mirror(1) of ofbiz, saw this change, then sent the email. Didn't see the later commit. ps: (1) is updated every 30 minutes from svn. 1:

Re: svn commit: r720158 - /ofbiz/trunk/framework/webtools/webapp/webtools/WEB-INF/actions/artifactinfo/ArtifactInfo.groovy

2008-11-26 Thread Adam Heath
Jacques Le Roux wrote: Hi Adam, I used to look into my email client svn folder. I would switch to your link : clearer, faster and annotated, the only thing I miss is the ability to search *into* commits, not only titles. Is there a mean to do that ? We are still new to mercurial; only been

  1   2   3   4   5   6   7   8   9   10   >