Re: Useless use of a constant in void context at Makefile.PL line 467

2003-10-28 Thread Carl Brewer
Stas Bekman wrote: Carl Brewer wrote: Stas Bekman wrote: So the offending line is: $string .= Apache::Test::install::nuke_Apache__test_target() if APACHE_TEST_INSTALL(); You lost the actual constant that it was complaining about ;) I should have looked closer. Any change if you

Re: Useless use of a constant in void context at Makefile.PL line 467

2003-10-28 Thread Stas Bekman
Carl Brewer wrote: [...] Also what happens if you change BEGIN { use constant APACHE_TEST_INSTALL = -e 'Apache-Test'; use lib './Apache-Test'; require 'install-pl' if APACHE_TEST_INSTALL; } to: BEGIN { use constant APACHE_TEST_INSTALL = -e 'Apache-Test'; I think this is the bit

Re: Useless use of a constant in void context at Makefile.PL line 467

2003-10-28 Thread Stas Bekman
It's now fixed in cvs. Apparently constants don't seem to work when moved into a different namespace. May be a bug in perl, may be that's how it should be. In any case, moving to lexical variable solves the problem. __ Stas Bekman

Re: Useless use of a constant in void context at Makefile.PL line 467

2003-10-28 Thread Carl Brewer
Stas Bekman wrote: It's now fixed in cvs. Apparently constants don't seem to work when moved into a different namespace. May be a bug in perl, may be that's how it should be. In any case, moving to lexical variable solves the problem. Magic, thanks Stas :) Carl

Re: Useless use of a constant in void context at Makefile.PL line 467

2003-10-17 Thread Stas Bekman
Carl Brewer wrote: Stas Bekman wrote: So the offending line is: $string .= Apache::Test::install::nuke_Apache__test_target() if APACHE_TEST_INSTALL(); You lost the actual constant that it was complaining about ;) I should have looked closer. Any change if you replace it with: if

Re: Useless use of a constant in void context at Makefile.PL line 467

2003-10-16 Thread Carl Brewer
Stas Bekman wrote: So the offending line is: $string .= Apache::Test::install::nuke_Apache__test_target() if APACHE_TEST_INSTALL(); You lost the actual constant that it was complaining about ;) I should have looked closer. Any change if you replace it with: if

Re: Useless use of a constant in void context at Makefile.PL line 467

2003-10-15 Thread Stas Bekman
Carl Brewer wrote: Stas Bekman wrote: Carl Brewer wrote: current CVS pull (as of this morning) I just pulled the very latest mp2 CVS down, and am still seeing this error : steel1: {167} perl Makefile.PL MP_APXS=/usr/local/apache2/bin/apxs Useless use of a constant in void context at

Re: Useless use of a constant in void context at Makefile.PL line 467

2003-09-30 Thread Carl Brewer
Stas Bekman wrote: Nothing has changed since the 1.99_10 release in the build sw. Do you get a different behavior if you try with 1.99_10? Also are you sure that the line is reported correctly? Try to verify that the reported line is correct: I'll have a play with this tonight when I get home