Any comments?
The final version of the diff is at [1] and I think it's correct. I'd
like to commit this today or tomorrow so any feedback is welcome.
Thanks,
Robert
[1]: https://reviews.apache.org/r/28751/
On Fri, Dec 5, 2014 at 12:01 AM, Robert Munteanu romb...@apache.org wrote:
I took a
[
https://issues.apache.org/jira/browse/SLING-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237716#comment-14237716
]
Antonio Sanso commented on SLING-3290:
--
just for the record. Solving SLING-4216
[
https://issues.apache.org/jira/browse/SLING-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237723#comment-14237723
]
Bertrand Delacretaz commented on SLING-4216:
This sounds like a good idea but
[
https://issues.apache.org/jira/browse/SLING-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237729#comment-14237729
]
Antonio Sanso commented on SLING-4216:
--
thanks [~bdelacretaz] you might find more
Hi Robert,
On Mon, Dec 8, 2014 at 10:45 AM, Robert Munteanu romb...@apache.org wrote:
...I'd
like to commit this today or tomorrow so any feedback is welcome
Looks good to me except the SLING-4217 patch is missing the
Adaption*.java classes.
Also, about the TODO - is it possible to remove
Hi
Am 04.12.2014 um 16:25 schrieb Bertrand Delacretaz bdelacre...@apache.org:
Hi,
On Thursday, December 4, 2014, Robert Munteanu rob...@lmn.ro wrote:
...
@RequiresAdapter(adaptable=Resource.class, adapter=MyClass.class)
...
This looks good to me, although it would be even more
[
https://issues.apache.org/jira/browse/SLING-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235373#comment-14235373
]
Robert Munteanu edited comment on SLING-4217 at 12/8/14 10:59 AM:
[
https://issues.apache.org/jira/browse/SLING-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-4217:
---
Attachment: (was: SLING-4217-1.diff)
Register OSGi services corresponding to available
Hi Bertrand,
On Mon, Dec 8, 2014 at 12:37 PM, Bertrand Delacretaz
bdelacre...@apache.org wrote:
Hi Robert,
On Mon, Dec 8, 2014 at 10:45 AM, Robert Munteanu romb...@apache.org wrote:
...I'd
like to commit this today or tomorrow so any feedback is welcome
Looks good to me except the
Konrad Windszus created SLING-4226:
--
Summary: Wrong wiring of the bundle Models Impl in the Models IT
Key: SLING-4226
URL: https://issues.apache.org/jira/browse/SLING-4226
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-4226:
---
Attachment: SLING-4226.patch
Wrong wiring of the bundle Models Impl in the Models IT
[
https://issues.apache.org/jira/browse/SLING-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-4226:
---
Description:
The Sling Models IT deploys a new version of Sling Models API and Sling Models
+1
I end up implementing path checks for sling filters a lot
./Roland
On 04 Dec 2014, at 08:46, Antonio Sanso asa...@adobe.com wrote:
hi *,
the current Sling Servlet Filter Support [0] allows to have scope dependent
filter (e.g. REQUEST, INCLUDE, FORWARD, ERROR, COMPONENT).
It would
Hi,
It already fell a number of times over code in sling, where threads are
created manually like this:
Thread t = new Thread(someRunnable);
t.start();
I understand, that this is convenient and solves the problem in most of the
cases. But I see these problems:
* In most cases noone takes care
fair enough Vikas,
as said I was also proposing BloomFilter.
At that stage I gave up” mainly due “synchronization issue” at startup.
Since the cache initialization was a separate thread I had to take care on
properly handle this situation and updating properly the bloomfilter.
With this new
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237825#comment-14237825
]
santiago garcía pimentel commented on SLING-4212:
-
while changing this I
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237825#comment-14237825
]
santiago garcía pimentel edited comment on SLING-4212 at 12/8/14 12:37 PM:
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237825#comment-14237825
]
santiago garcía pimentel edited comment on SLING-4212 at 12/8/14 12:36 PM:
Since the cache initialization was a separate thread I had to take care on
properly handle this situation and updating properly the bloomfilter.
Sorry for being a little slow to catch up. But, as far as I understood
the issue -- it is about that we need to load all vanity mappings
during
On Dec 8, 2014, at 1:40 PM, Vikas Saurabh vikas.saur...@gmail.com wrote:
Since the cache initialization was a separate thread I had to take care on
properly handle this situation and updating properly the bloomfilter.
Sorry for being a little slow to catch up. But, as far as I understood
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237836#comment-14237836
]
santiago garcía pimentel commented on SLING-4212:
-
[~kwin],
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237844#comment-14237844
]
Konrad Windszus commented on SLING-4212:
[~santiagozky]
Hi
Am 08.12.2014 um 12:41 schrieb Jörg Hoh jhoh...@googlemail.com:
Hi,
It already fell a number of times over code in sling, where threads are
created manually like this:
Thread t = new Thread(someRunnable);
t.start();
I understand, that this is convenient and solves the problem in
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
santiago garcía pimentel updated SLING-4212:
Attachment: resourcePath-API.patch
I'm attaching a new patch with the
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237866#comment-14237866
]
santiago garcía pimentel edited comment on SLING-4212 at 12/8/14 1:48 PM:
Felix Meschberger created SLING-4227:
Summary: [sightly] Rename RuntimeExtension.SCR_PROP_NAME
Key: SLING-4227
URL: https://issues.apache.org/jira/browse/SLING-4227
Project: Sling
Issue
[
https://issues.apache.org/jira/browse/SLING-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger updated SLING-4227:
-
Fix Version/s: (was: Scripting Sightly JS Use Provider 1.0.0)
[sightly] Rename
[
https://issues.apache.org/jira/browse/SLING-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger resolved SLING-4227.
--
Resolution: Fixed
Renamed property to NAME in Rev. 1643823
[sightly] Rename
[
https://issues.apache.org/jira/browse/SLING-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237896#comment-14237896
]
Carsten Ziegeler commented on SLING-4216:
-
I haven't fully thought this through,
[
https://issues.apache.org/jira/browse/SLING-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237909#comment-14237909
]
Antonio Sanso commented on SLING-4216:
--
[~cziegeler] this might also work.
IMHO
Bertrand Delacretaz created SLING-4228:
--
Summary: Multi-value sling:alias property test fails
(ResourceResolverTest)
Key: SLING-4228
URL: https://issues.apache.org/jira/browse/SLING-4228
[
https://issues.apache.org/jira/browse/SLING-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-4228:
---
Fix Version/s: Resource Resolver 1.1.10
Multi-value sling:alias property test fails
[
https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237944#comment-14237944
]
Bertrand Delacretaz commented on SLING-3844:
It looks like this broke the
[
https://issues.apache.org/jira/browse/SLING-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Sanso reassigned SLING-4228:
Assignee: Antonio Sanso
Multi-value sling:alias property test fails
[
https://issues.apache.org/jira/browse/SLING-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237948#comment-14237948
]
Antonio Sanso commented on SLING-4228:
--
thanks [~bdelacretaz] . Weirdly enough I did
[
https://issues.apache.org/jira/browse/SLING-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237957#comment-14237957
]
Bertrand Delacretaz commented on SLING-4228:
ok, it might be a combination
See https://builds.apache.org/job/sling-trunk-1.7/changes
See
https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1224/
[
https://issues.apache.org/jira/browse/SLING-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237982#comment-14237982
]
Antonio Sanso commented on SLING-4228:
--
adding Jenkins failure link
[
https://issues.apache.org/jira/browse/SLING-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237988#comment-14237988
]
Antonio Sanso commented on SLING-4228:
--
mystery unveiled . i was running sling with
[
https://issues.apache.org/jira/browse/SLING-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petria resolved SLING-4060.
--
Resolution: Fixed
Fix Version/s: Content Distribution 0.1.0
Create specific factories
[
https://issues.apache.org/jira/browse/SLING-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238011#comment-14238011
]
Marius Petria commented on SLING-4060:
--
Committed revision 1643847.
Create
[
https://issues.apache.org/jira/browse/SLING-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238016#comment-14238016
]
Antonio Sanso commented on SLING-4228:
--
this is probably the reason
[
https://issues.apache.org/jira/browse/SLING-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238020#comment-14238020
]
Carsten Ziegeler commented on SLING-4216:
-
Ok, I see - I agree that a bloom filter
Am 08.12.14 um 14:34 schrieb Felix Meschberger:
Hi
Am 08.12.2014 um 12:41 schrieb Jörg Hoh jhoh...@googlemail.com:
* In most cases noone takes care if these threads terminate at all; they
just run in an uncontrolled manner and terminate by chance. If these
threads are not started exactly
[
https://issues.apache.org/jira/browse/SLING-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-4164:
---
Assignee: Carsten Ziegeler
Order of children is not preserved for
[
https://issues.apache.org/jira/browse/SLING-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-4164:
Fix Version/s: Resource Resolver 1.1.10
Order of children is not preserved for
[
https://issues.apache.org/jira/browse/SLING-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-4164.
-
Resolution: Fixed
Thanks Levente, I've applied your patch
Order of children is not
[
https://issues.apache.org/jira/browse/SLING-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238031#comment-14238031
]
Antonio Sanso commented on SLING-4216:
--
I really think LRU an its own (e.g. without
[
https://issues.apache.org/jira/browse/SLING-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Sanso resolved SLING-4228.
--
Resolution: Fixed
fixed in rev. r1643852 (I have used a LinkedHashMap rather than a HashMap in
[
https://issues.apache.org/jira/browse/SLING-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238041#comment-14238041
]
Bertrand Delacretaz commented on SLING-4228:
Confirmed, the test passes on my
See https://builds.apache.org/job/sling-trunk-1.6/2842/
--
[...truncated 631 lines...]
A
testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/builder
AU
[
https://issues.apache.org/jira/browse/SLING-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238094#comment-14238094
]
Konrad Windszus commented on SLING-4226:
It works if I revert the dependency to
[
https://issues.apache.org/jira/browse/SLING-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-4226:
---
Description:
The Sling Models IT deploys a new version of Sling Models API and Sling Models
[
https://issues.apache.org/jira/browse/SLING-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238106#comment-14238106
]
Konrad Windszus commented on SLING-4226:
Even if we would go back to launchpad 7 I
See
https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1225/
See https://builds.apache.org/job/sling-trunk-1.7/1225/changes
Hi Felix
2014-12-08 14:34 GMT+01:00 Felix Meschberger fmesc...@adobe.com:
* The J2E programming model discourages the creation of threads; instead
one is supposed to use the threadpools of the application server. This is
important in appservers like Websphere AS, where the succesfull
Hi Jörg
Am 08.12.2014 um 22:31 schrieb Jörg Hoh jhoh...@googlemail.com:
Hi Felix
2014-12-08 14:34 GMT+01:00 Felix Meschberger fmesc...@adobe.com:
* The J2E programming model discourages the creation of threads; instead
one is supposed to use the threadpools of the application
See https://builds.apache.org/job/sling-trunk-1.6/2843/
--
[...truncated 186 lines...]
A
bundles/engine/src/main/java/org/apache/sling/engine/jmx/RequestProcessorMBean.java
AUbundles/engine/pom.xml
AUbundles/engine/README.txt
svn:
60 matches
Mail list logo
