Re: Request Parameter Themes

2014-02-20 Thread Alexander Klimetschek
On 19.02.2014, at 23:46, Felix Meschberger fmesc...@adobe.com wrote: Absolutely. There is a (presumably low level and simple) test case test_decode_query for this in [1] Cool. Although the test is using a=1b=2c=3, which wouldn't expose that issue. You might want to test something like

Re: Request Parameter Themes

2014-02-20 Thread Felix Meschberger
Good point. I have updated the test Regards Felix Am 20.02.2014 um 09:03 schrieb Alexander Klimetschek aklim...@adobe.com: On 19.02.2014, at 23:46, Felix Meschberger fmesc...@adobe.com wrote: Absolutely. There is a (presumably low level and simple) test case test_decode_query for this in

Re: Request Parameter Themes

2014-02-19 Thread Alexander Klimetschek
On 17.02.2014, at 07:19, Felix Meschberger fmesc...@adobe.com wrote: method and enance the API: RequestParameter: add String getName(); SlingHttpServletRequest: add ListRequestParameter getRequestParameterList(); +1 Looks great to me! Just to be sure - this allows to iterate

Re: Request Parameter Themes

2014-02-19 Thread Felix Meschberger
Hi Am 20.02.2014 um 08:31 schrieb Alexander Klimetschek aklim...@adobe.com: On 17.02.2014, at 07:19, Felix Meschberger fmesc...@adobe.com wrote: method and enance the API: RequestParameter: add String getName(); SlingHttpServletRequest: add ListRequestParameter

Re: Request Parameter Themes

2014-02-18 Thread Felix Meschberger
Hi I have updated my whiteboard according to these suggestions: * Added new API to the Sling API (and increased export versions) * Merged the parameter support back into the Engine bundle * Removed the parameters bundle WDYT ? Regards Felix Am 17.02.2014 um 16:19 schrieb Felix Meschberger

Re: Request Parameter Themes

2014-02-18 Thread Carsten Ziegeler
Lgtm, +1 Carsten 2014-02-18 9:45 GMT+01:00 Felix Meschberger fmesc...@adobe.com: Hi I have updated my whiteboard according to these suggestions: * Added new API to the Sling API (and increased export versions) * Merged the parameter support back into the Engine bundle * Removed the

Request Parameter Themes

2014-02-17 Thread Felix Meschberger
Hi all I have been working in my whiteboard extending Sling's request parameter support with the following goals: 1. Support both Servlet API 2 and Servlet API 3 which brings multipart/form-data support with additional API. 2. Support Sling's request parameter support for non-Sling servlets.

Re: Request Parameter Themes

2014-02-17 Thread Carsten Ziegeler
Hi, thanks - this looks good to me, especially as the performance impact should be neglectable. I'm not sure if we really should split this into a separate bundle for now - we can do it later if the need arises. So basically +1 Carsten 2014-02-17 10:35 GMT+01:00 Felix Meschberger

Re: Request Parameter Themes

2014-02-17 Thread Felix Meschberger
Hi You are right. And as we discussed off-line: Maybe we should make it really clean with the ListNamedRequestParameter getRequestParameterList() method and enance the API: RequestParameter: add String getName(); SlingHttpServletRequest: add ListRequestParameter