[jira] [Updated] (SLING-7051) Upgrade detection might fail due to file system inaccuracy

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-7051:

Affects Version/s: Launchpad Base 2.6.22

> Upgrade detection might fail due to file system inaccuracy
> --
>
> Key: SLING-7051
> URL: https://issues.apache.org/jira/browse/SLING-7051
> Project: Sling
>  Issue Type: Improvement
>  Components: Launchpad
>Affects Versions: Launchpad Base 2.6.22
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-7051) Upgrade detection might fail due to file system inaccuracy

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-7051:

Description: The upgrade detection is passed on compared file time stamps 
with a precise timestamp. If the file system has some inaccuracy it might 
happen that on a restart, the time stamp of a jar file is detected as newer 
compared to the previously precise stored timestamp. Which results in detecting 
the restart as an update. And this in turn starts the same cycle again.

> Upgrade detection might fail due to file system inaccuracy
> --
>
> Key: SLING-7051
> URL: https://issues.apache.org/jira/browse/SLING-7051
> Project: Sling
>  Issue Type: Improvement
>  Components: Launchpad
>Affects Versions: Launchpad Base 2.6.22
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>
> The upgrade detection is passed on compared file time stamps with a precise 
> timestamp. If the file system has some inaccuracy it might happen that on a 
> restart, the time stamp of a jar file is detected as newer compared to the 
> previously precise stored timestamp. Which results in detecting the restart 
> as an update. And this in turn starts the same cycle again.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7051) Upgrade detection might fail due to file system inaccuracy

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-7051:
---

 Summary: Upgrade detection might fail due to file system inaccuracy
 Key: SLING-7051
 URL: https://issues.apache.org/jira/browse/SLING-7051
 Project: Sling
  Issue Type: Improvement
  Components: Launchpad
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-7051) Upgrade detection might fail due to file system inaccuracy

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-7051.
-
   Resolution: Fixed
Fix Version/s: Launchpad Base 2.6.24

Fixed in rev 1805260 by simply writing the timestamp file again after a 
successful startup

> Upgrade detection might fail due to file system inaccuracy
> --
>
> Key: SLING-7051
> URL: https://issues.apache.org/jira/browse/SLING-7051
> Project: Sling
>  Issue Type: Improvement
>  Components: Launchpad
>Affects Versions: Launchpad Base 2.6.22
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Launchpad Base 2.6.24
>
>
> The upgrade detection is passed on compared file time stamps with a precise 
> timestamp. If the file system has some inaccuracy it might happen that on a 
> restart, the time stamp of a jar file is detected as newer compared to the 
> previously precise stored timestamp. Which results in detecting the restart 
> as an update. And this in turn starts the same cycle again.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-6984) Allow to disable service user

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130056#comment-16130056
 ] 

Bertrand Delacretaz commented on SLING-6984:


I have fixed the failing integration tests and removed SNAPSHOT dependencies, 
except the repoint.parser and jcr.repoinit modules that they test. They pass 
now, at 
https://builds.apache.org/view/S-Z/view/Sling/job/sling-bundles-extensions-repoinit-it-1.8/

> Allow to disable service user
> -
>
> Key: SLING-6984
> URL: https://issues.apache.org/jira/browse/SLING-6984
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Affects Versions: Repoinit Parser 1.1.0, Repoinit JCR 1.1.4
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>
> Currently the repoinit module does not support -removing- disabling service 
> users.
> Disbling -Removing- service user is required when one user is no longer 
> needed due to service user sharing among components.
> The syntax could be the one proposed by [~anchela]
> {code}
> disable service user  
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (SLING-7054) Slingstart artifacts with parametrized version not removed from the effective slingstart model

[JIRA]

 [ 
https://issues.apache.org/jira/browse/SLING-7054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomek Rękawek reassigned SLING-7054:


Assignee: Tomek Rękawek

> Slingstart artifacts with parametrized version not removed from the effective 
> slingstart model
> --
>
> Key: SLING-7054
> URL: https://issues.apache.org/jira/browse/SLING-7054
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Minor
> Fix For: Slingstart Maven Plugin 1.7.8
>
>
> Adding a following entry to the provisioning model:
> {noformat}
> [artifacts]
>   com.acme/my-model/1.0.0/slingstart
> {noformat}
> results in including the my-model to the current one. The slingfeature file 
> will be downloaded and merged. However, if we replace the version with a 
> variable:
> {noformat}
> [artifacts]
>   com.acme/my-model/${my.model.version}/slingstart
> {noformat}
> the slingstart will also download and include the my-model.jar file, not 
> useful here.
> It's a result of the lines 
> [345-356|https://github.com/apache/sling/blob/7e8a3a110a29b743d49ef799a7c7dec50a90bd96/tooling/maven/slingstart-maven-plugin/src/main/java/org/apache/sling/maven/slingstart/ModelPreprocessor.java#L345-L357]
>  in the {{ModelPreprocessor}}:
> {code}
> for(final org.apache.sling.provisioning.model.Artifact r 
> : removeList) {
> group.remove(r);
> final Feature localModelFeature = 
> rawModel.getFeature(feature.getName());
> if ( localModelFeature != null ) {
> final RunMode localRunMode = 
> localModelFeature.getRunMode(runMode.getNames());
> if ( localRunMode != null ) {
> final ArtifactGroup localAG = 
> localRunMode.getArtifactGroup(group.getStartLevel());
> if ( localAG != null ) {
> localAG.remove(r);
> }
> }
> }
> }
> {code}
> If the artifact is parametrized, it won't be removed from the localAG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-7053) deadlock in QuartzScheduler

[Stefan Egli (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli resolved SLING-7053.

Resolution: Duplicate
  Assignee: Stefan Egli

[~cziegeler], good point, it is (I had this deadlock still sitting around for a 
while and at that time SLING-7004 wasn't around yet). 

Closing this one as duplicate.

> deadlock in QuartzScheduler
> ---
>
> Key: SLING-7053
> URL: https://issues.apache.org/jira/browse/SLING-7053
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Commons Scheduler 2.6.2
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>
> The following deadlock has been witnessed (in 2.6.3-SNAPSHOT, so the line 
> numbers are a little bit skewed, also note that the thread names have been 
> generalized and thread 1's stack has been shortened):
> {noformat}
> Found one Java-level deadlock:
> =
> "thread 1":
>   waiting to lock monitor 0x7feae58d5118 (object 0x0007f4502a28, a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy),
>   which is held by "thread 2"
> "thread 2":
>   waiting to lock monitor 0x7feae58d4c48 (object 0x0007f46d6320, a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy),
>   which is held by "thread 1"
> Java stack information for the threads listed above:
> ===
> "thread 1":
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.unschedule(QuartzScheduler.java:584)
>   - waiting to lock <0x0007f4502a28> (a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy)
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.scheduleJob(QuartzScheduler.java:630)
>   - locked <0x0007f46d6320> (a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy)
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.schedule(QuartzScheduler.java:561)
>   at 
> org.apache.sling.commons.scheduler.impl.SchedulerServiceFactory.schedule(SchedulerServiceFactory.java:63)
> [...]
> "thread 2":
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.unschedule(QuartzScheduler.java:584)
>   - waiting to lock <0x0007f46d6320> (a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy)
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.scheduleJob(QuartzScheduler.java:630)
>   - locked <0x0007f4502a28> (a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy)
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.schedule(QuartzScheduler.java:561)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.scheduleJob(WhiteboardHandler.java:271)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.trySchedulePeriod(WhiteboardHandler.java:229)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.register(WhiteboardHandler.java:189)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.registerRunnable(WhiteboardHandler.java:146)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod.invokeMethod(BaseMethod.java:224)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod.access$500(BaseMethod.java:39)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod$Resolved.invoke(BaseMethod.java:617)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod.invoke(BaseMethod.java:501)
>   at 
> org.apache.felix.scr.impl.inject.BindMethod.invoke(BindMethod.java:655)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.doInvokeBindMethod(DependencyManager.java:1722)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.open(DependencyManager.java:1556)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:261)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:109)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:906)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:879)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.java:749)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager.enableInternal(AbstractComponentManager.java:675)
>   at 
> 

[jira] [Created] (SLING-7054) Slingstart artifacts with parametrized version not removed from the effective slingstart model

[JIRA]

Tomek Rękawek created SLING-7054:


 Summary: Slingstart artifacts with parametrized version not 
removed from the effective slingstart model
 Key: SLING-7054
 URL: https://issues.apache.org/jira/browse/SLING-7054
 Project: Sling
  Issue Type: Bug
  Components: Tooling
Reporter: Tomek Rękawek
Priority: Minor
 Fix For: Slingstart Maven Plugin 1.7.8


Adding a following entry to the provisioning model:

{noformat}
[artifacts]
  com.acme/my-model/1.0.0/slingstart
{noformat}

results in including the my-model to the current one. The slingfeature file 
will be downloaded and merged. However, if we replace the version with a 
variable:

{noformat}
[artifacts]
  com.acme/my-model/${my.model.version}/slingstart
{noformat}

the slingstart will also download and include the my-model.jar file, not useful 
here.

It's a result of the lines 
[345-356|https://github.com/apache/sling/blob/7e8a3a110a29b743d49ef799a7c7dec50a90bd96/tooling/maven/slingstart-maven-plugin/src/main/java/org/apache/sling/maven/slingstart/ModelPreprocessor.java#L345-L357]
 in the {{ModelPreprocessor}}:

{code}
for(final org.apache.sling.provisioning.model.Artifact r : 
removeList) {
group.remove(r);
final Feature localModelFeature = 
rawModel.getFeature(feature.getName());
if ( localModelFeature != null ) {
final RunMode localRunMode = 
localModelFeature.getRunMode(runMode.getNames());
if ( localRunMode != null ) {
final ArtifactGroup localAG = 
localRunMode.getArtifactGroup(group.getStartLevel());
if ( localAG != null ) {
localAG.remove(r);
}
}
}
}
{code}

If the artifact is parametrized, it won't be removed from the localAG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7053) deadlock in QuartzScheduler

[Stefan Egli (JIRA)]

Stefan Egli created SLING-7053:
--

 Summary: deadlock in QuartzScheduler
 Key: SLING-7053
 URL: https://issues.apache.org/jira/browse/SLING-7053
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Commons Scheduler 2.6.2
Reporter: Stefan Egli


The following deadlock has been witnessed (in 2.6.3-SNAPSHOT, so the line 
numbers are a little bit skewed, also note that the thread names have been 
generalized and thread 1's stack has been shortened):
{noformat}
Found one Java-level deadlock:
=
"thread 1":
  waiting to lock monitor 0x7feae58d5118 (object 0x0007f4502a28, a 
org.apache.sling.commons.scheduler.impl.SchedulerProxy),
  which is held by "thread 2"
"thread 2":
  waiting to lock monitor 0x7feae58d4c48 (object 0x0007f46d6320, a 
org.apache.sling.commons.scheduler.impl.SchedulerProxy),
  which is held by "thread 1"
Java stack information for the threads listed above:
===
"thread 1":
at 
org.apache.sling.commons.scheduler.impl.QuartzScheduler.unschedule(QuartzScheduler.java:584)
- waiting to lock <0x0007f4502a28> (a 
org.apache.sling.commons.scheduler.impl.SchedulerProxy)
at 
org.apache.sling.commons.scheduler.impl.QuartzScheduler.scheduleJob(QuartzScheduler.java:630)
- locked <0x0007f46d6320> (a 
org.apache.sling.commons.scheduler.impl.SchedulerProxy)
at 
org.apache.sling.commons.scheduler.impl.QuartzScheduler.schedule(QuartzScheduler.java:561)
at 
org.apache.sling.commons.scheduler.impl.SchedulerServiceFactory.schedule(SchedulerServiceFactory.java:63)
[...]
"thread 2":
at 
org.apache.sling.commons.scheduler.impl.QuartzScheduler.unschedule(QuartzScheduler.java:584)
- waiting to lock <0x0007f46d6320> (a 
org.apache.sling.commons.scheduler.impl.SchedulerProxy)
at 
org.apache.sling.commons.scheduler.impl.QuartzScheduler.scheduleJob(QuartzScheduler.java:630)
- locked <0x0007f4502a28> (a 
org.apache.sling.commons.scheduler.impl.SchedulerProxy)
at 
org.apache.sling.commons.scheduler.impl.QuartzScheduler.schedule(QuartzScheduler.java:561)
at 
org.apache.sling.commons.scheduler.impl.WhiteboardHandler.scheduleJob(WhiteboardHandler.java:271)
at 
org.apache.sling.commons.scheduler.impl.WhiteboardHandler.trySchedulePeriod(WhiteboardHandler.java:229)
at 
org.apache.sling.commons.scheduler.impl.WhiteboardHandler.register(WhiteboardHandler.java:189)
at 
org.apache.sling.commons.scheduler.impl.WhiteboardHandler.registerRunnable(WhiteboardHandler.java:146)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.apache.felix.scr.impl.inject.BaseMethod.invokeMethod(BaseMethod.java:224)
at 
org.apache.felix.scr.impl.inject.BaseMethod.access$500(BaseMethod.java:39)
at 
org.apache.felix.scr.impl.inject.BaseMethod$Resolved.invoke(BaseMethod.java:617)
at 
org.apache.felix.scr.impl.inject.BaseMethod.invoke(BaseMethod.java:501)
at 
org.apache.felix.scr.impl.inject.BindMethod.invoke(BindMethod.java:655)
at 
org.apache.felix.scr.impl.manager.DependencyManager.doInvokeBindMethod(DependencyManager.java:1722)
at 
org.apache.felix.scr.impl.manager.DependencyManager.open(DependencyManager.java:1556)
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:261)
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:109)
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:906)
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:879)
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.java:749)
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager.enableInternal(AbstractComponentManager.java:675)
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager.enable(AbstractComponentManager.java:430)
at 
org.apache.felix.scr.impl.manager.ConfigurableComponentHolder.enableComponents(ConfigurableComponentHolder.java:657)
- locked <0x0007f4e02ee8> (a java.lang.Object)
at 
org.apache.felix.scr.impl.BundleComponentActivator.initialEnable(BundleComponentActivator.java:341)
at 
org.apache.felix.scr.impl.Activator.loadComponents(Activator.java:390)
at 

[jira] [Commented] (SLING-7053) deadlock in QuartzScheduler

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130210#comment-16130210
 ] 

Carsten Ziegeler commented on SLING-7053:
-

[~egli] Isn't this a duplicate of SLING-7004?

> deadlock in QuartzScheduler
> ---
>
> Key: SLING-7053
> URL: https://issues.apache.org/jira/browse/SLING-7053
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Commons Scheduler 2.6.2
>Reporter: Stefan Egli
>
> The following deadlock has been witnessed (in 2.6.3-SNAPSHOT, so the line 
> numbers are a little bit skewed, also note that the thread names have been 
> generalized and thread 1's stack has been shortened):
> {noformat}
> Found one Java-level deadlock:
> =
> "thread 1":
>   waiting to lock monitor 0x7feae58d5118 (object 0x0007f4502a28, a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy),
>   which is held by "thread 2"
> "thread 2":
>   waiting to lock monitor 0x7feae58d4c48 (object 0x0007f46d6320, a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy),
>   which is held by "thread 1"
> Java stack information for the threads listed above:
> ===
> "thread 1":
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.unschedule(QuartzScheduler.java:584)
>   - waiting to lock <0x0007f4502a28> (a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy)
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.scheduleJob(QuartzScheduler.java:630)
>   - locked <0x0007f46d6320> (a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy)
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.schedule(QuartzScheduler.java:561)
>   at 
> org.apache.sling.commons.scheduler.impl.SchedulerServiceFactory.schedule(SchedulerServiceFactory.java:63)
> [...]
> "thread 2":
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.unschedule(QuartzScheduler.java:584)
>   - waiting to lock <0x0007f46d6320> (a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy)
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.scheduleJob(QuartzScheduler.java:630)
>   - locked <0x0007f4502a28> (a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy)
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.schedule(QuartzScheduler.java:561)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.scheduleJob(WhiteboardHandler.java:271)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.trySchedulePeriod(WhiteboardHandler.java:229)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.register(WhiteboardHandler.java:189)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.registerRunnable(WhiteboardHandler.java:146)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod.invokeMethod(BaseMethod.java:224)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod.access$500(BaseMethod.java:39)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod$Resolved.invoke(BaseMethod.java:617)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod.invoke(BaseMethod.java:501)
>   at 
> org.apache.felix.scr.impl.inject.BindMethod.invoke(BindMethod.java:655)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.doInvokeBindMethod(DependencyManager.java:1722)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.open(DependencyManager.java:1556)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:261)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:109)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:906)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:879)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.java:749)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager.enableInternal(AbstractComponentManager.java:675)
>   at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager.enable(AbstractComponentManager.java:430)
>   at 
> 

[jira] [Created] (SLING-7052) Update Bundles from Apache Felix to latest version

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-7052:
---

 Summary: Update Bundles from Apache Felix to latest version
 Key: SLING-7052
 URL: https://issues.apache.org/jira/browse/SLING-7052
 Project: Sling
  Issue Type: Improvement
  Components: Launchpad
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Launchpad Builder 10


[INFO]   org.apache.felix:org.apache.felix.configadmin ...
[INFO] 1.8.10 -> 18.16
[INFO]   org.apache.felix:org.apache.felix.http.jetty .. 3.4.2 -> 3.4.4
[INFO]   org.apache.felix:org.apache.felix.scr  2.0.8 -> 2.0.12




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[VOTE RESULT] Release Apache Sling Rewriter 1.2.2

[Carsten Ziegeler]

The vote passes with 5 binding +1 votes

Thanks
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Resolved] (SLING-7052) Update Bundles from Apache Felix to latest version

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-7052.
-
Resolution: Fixed

Updated in rev 1805267

> Update Bundles from Apache Felix to latest version
> --
>
> Key: SLING-7052
> URL: https://issues.apache.org/jira/browse/SLING-7052
> Project: Sling
>  Issue Type: Improvement
>  Components: Launchpad
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Launchpad Builder 10
>
>
> [INFO]   org.apache.felix:org.apache.felix.configadmin ...
> [INFO] 1.8.10 -> 18.16
> [INFO]   org.apache.felix:org.apache.felix.http.jetty .. 3.4.2 -> 
> 3.4.4
> [INFO]   org.apache.felix:org.apache.felix.scr  2.0.8 -> 
> 2.0.12



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130310#comment-16130310
 ] 

Robert Munteanu commented on SLING-7055:


Thanks for the patch [~mreutegg] . I would have only two comments:

* Bundles living under commons should have no dependency on Sling, so you could 
either remove the link to the Sling settings service or move the bundle to 
extensions
* The bundle uses guava, but in quite a limited manner. We try to avoid this 
dependency since it's quite heavyweight and problematic in terms of backwards 
compatibility. Could you remove that dependency?

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (SLING-7004) Deadlock at startup in Commons Scheduler

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-7004:
---

Assignee: Carsten Ziegeler

> Deadlock at startup in Commons Scheduler
> 
>
> Key: SLING-7004
> URL: https://issues.apache.org/jira/browse/SLING-7004
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Chetan Mehrotra
>Assignee: Carsten Ziegeler
> Fix For: Commons Scheduler 2.6.4
>
> Attachments: threaddump.log
>
>
> Saw following deadlock in one of the startups with 2.6.2 release. Logs 
> [attached|^threaddump.log]
> {noformat}
> Found one Java-level deadlock:
> =
> "Apache Sling Repository Startup Thread":
>   waiting to lock monitor 0x7f3eec6eb318 (object 0xe3f944e0, a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy),
>   which is held by "FelixStartLevel"
> "FelixStartLevel":
>   waiting to lock monitor 0x7f3e610de918 (object 0xe798fc58, a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy),
>   which is held by "Apache Sling Repository Startup Thread"
> Java stack information for the threads listed above:
> ===
> "Apache Sling Repository Startup Thread":
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.unschedule(QuartzScheduler.java:555)
>   - waiting to lock <0xe3f944e0> (a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy)
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.scheduleJob(QuartzScheduler.java:601)
>   - locked <0xe798fc58> (a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy)
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.schedule(QuartzScheduler.java:532)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.scheduleJob(WhiteboardHandler.java:271)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.trySchedulePeriod(WhiteboardHandler.java:229)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.register(WhiteboardHandler.java:189)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.registerRunnable(WhiteboardHandler.java:146)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod.invokeMethod(BaseMethod.java:224)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod.access$500(BaseMethod.java:39)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod$Resolved.invoke(BaseMethod.java:617)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod.invoke(BaseMethod.java:501)
>   at 
> org.apache.felix.scr.impl.inject.BindMethod.invoke(BindMethod.java:655)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.doInvokeBindMethod(DependencyManager.java:1722)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.invokeBindMethod(DependencyManager.java:1699)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.invokeBindMethod(SingleComponentManager.java:372)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:320)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:291)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1215)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1136)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.trackAdding(ServiceTracker.java:945)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:881)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1167)
>   at 
> org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:127)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4579)
>   at org.apache.felix.framework.Felix.registerService(Felix.java:3571)

[jira] [Resolved] (SLING-7004) Deadlock at startup in Commons Scheduler

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-7004.
-
Resolution: Fixed

Using single lock instead of more fine grained ones (rev 1805278)

> Deadlock at startup in Commons Scheduler
> 
>
> Key: SLING-7004
> URL: https://issues.apache.org/jira/browse/SLING-7004
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Chetan Mehrotra
>Assignee: Carsten Ziegeler
> Fix For: Commons Scheduler 2.6.4
>
> Attachments: threaddump.log
>
>
> Saw following deadlock in one of the startups with 2.6.2 release. Logs 
> [attached|^threaddump.log]
> {noformat}
> Found one Java-level deadlock:
> =
> "Apache Sling Repository Startup Thread":
>   waiting to lock monitor 0x7f3eec6eb318 (object 0xe3f944e0, a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy),
>   which is held by "FelixStartLevel"
> "FelixStartLevel":
>   waiting to lock monitor 0x7f3e610de918 (object 0xe798fc58, a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy),
>   which is held by "Apache Sling Repository Startup Thread"
> Java stack information for the threads listed above:
> ===
> "Apache Sling Repository Startup Thread":
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.unschedule(QuartzScheduler.java:555)
>   - waiting to lock <0xe3f944e0> (a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy)
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.scheduleJob(QuartzScheduler.java:601)
>   - locked <0xe798fc58> (a 
> org.apache.sling.commons.scheduler.impl.SchedulerProxy)
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.schedule(QuartzScheduler.java:532)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.scheduleJob(WhiteboardHandler.java:271)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.trySchedulePeriod(WhiteboardHandler.java:229)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.register(WhiteboardHandler.java:189)
>   at 
> org.apache.sling.commons.scheduler.impl.WhiteboardHandler.registerRunnable(WhiteboardHandler.java:146)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod.invokeMethod(BaseMethod.java:224)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod.access$500(BaseMethod.java:39)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod$Resolved.invoke(BaseMethod.java:617)
>   at 
> org.apache.felix.scr.impl.inject.BaseMethod.invoke(BaseMethod.java:501)
>   at 
> org.apache.felix.scr.impl.inject.BindMethod.invoke(BindMethod.java:655)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.doInvokeBindMethod(DependencyManager.java:1722)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.invokeBindMethod(DependencyManager.java:1699)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.invokeBindMethod(SingleComponentManager.java:372)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:320)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:291)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1215)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1136)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.trackAdding(ServiceTracker.java:945)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:881)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1167)
>   at 
> org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:127)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4579)
>   at 

[jira] [Updated] (SLING-7055) RRD4J metrics reporter

[Marcel Reutegger (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger updated SLING-7055:

Attachment: SLING-7055.patch

Attached proposed new module in [^SLING-7055.patch].

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Commons
>Reporter: Marcel Reutegger
>Priority: Minor
> Attachments: SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7055) RRD4J metrics reporter

[Marcel Reutegger (JIRA)]

Marcel Reutegger created SLING-7055:
---

 Summary: RRD4J metrics reporter
 Key: SLING-7055
 URL: https://issues.apache.org/jira/browse/SLING-7055
 Project: Sling
  Issue Type: New Feature
  Components: Commons
Reporter: Marcel Reutegger
Priority: Minor


SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
commons module which writes those metrics to a time series database on the 
local filesystem. The primary purpose is tracking metrics for diagnostics.

The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (SLING-7055) RRD4J metrics reporter

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-7055:
--

Assignee: Robert Munteanu

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Commons
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-7055) RRD4J metrics reporter

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-7055:
---
Component/s: (was: Commons)
 Extensions

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7056) Servlets are not removed from pending servlets list

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-7056:
---

 Summary: Servlets are not removed from pending servlets list
 Key: SLING-7056
 URL: https://issues.apache.org/jira/browse/SLING-7056
 Project: Sling
  Issue Type: Bug
  Components: Servlets
Affects Versions: Servlets Resolver 2.4.12
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Servlets Resolver 2.4.14


The unbindServlet method does not correctly remove an entry from 
pendingServlets - while pendingServlets contains PendingServlet objects it 
tries to remove a Service Reference



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7056) Servlets are not removed from pending servlets list

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130327#comment-16130327
 ] 

Carsten Ziegeler commented on SLING-7056:
-

Fixed in rev 1805279

> Servlets are not removed from pending servlets list
> ---
>
> Key: SLING-7056
> URL: https://issues.apache.org/jira/browse/SLING-7056
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Resolver 2.4.12
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.4.14
>
>
> The unbindServlet method does not correctly remove an entry from 
> pendingServlets - while pendingServlets contains PendingServlet objects it 
> tries to remove a Service Reference



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

[Marcel Reutegger (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130326#comment-16130326
 ] 

Marcel Reutegger commented on SLING-7055:
-

Thanks for the feedback.

bq. remove the link to the Sling settings

I'd love to remove that dependency, but at the same time I don't want to rely 
on the directory where the Java process was started. Is there a Sling property 
I could use as the base directory when Sling is present?

bq. The bundle uses guava, but in quite a limited manner. We try to avoid this 
dependency since it's quite heavyweight and problematic in terms of backwards 
compatibility. Could you remove that dependency?

Sure, will do and update the patch.

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (SLING-6519) Remove dependency to org.json

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reopened SLING-6519:

  Assignee: Robert Munteanu  (was: Konrad Windszus)

Unfortunately this seems to always fail when connecting in debug mode. I get an 
error which looks like

{noformat}java.lang.IllegalStateException: Expected a name but was BEGIN_OBJECT 
at line 1 column 3
at com.google.gson.stream.JsonReader.nextName(JsonReader.java:785)
at 
org.apache.sling.ide.osgi.impl.HttpOsgiClient.findSourceReferences(HttpOsgiClient.java:252)
at 
org.apache.sling.ide.osgi.impl.TracingOsgiClient.findSourceReferences(TracingOsgiClient.java:110)
at 
org.apache.sling.ide.eclipse.core.internal.JVMDebuggerConnection.connectInDebugMode(JVMDebuggerConnection.java:120)
at 
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.start(SlingLaunchpadBehaviour.java:123)
at 
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadLaunchConfigurationDelegate.launch(SlingLaunchpadLaunchConfigurationDelegate.java:45)
at 
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:885)
at 
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
at 
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:731)
at 
org.eclipse.wst.server.core.internal.Server.startImpl2(Server.java:3541)
at 
org.eclipse.wst.server.core.internal.Server.startImpl(Server.java:3477)
at 
org.eclipse.wst.server.core.internal.Server$StartJob.run(Server.java:367)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54){noformat}

I'll try and provided a test + fix shortly.

> Remove dependency to org.json
> -
>
> Key: SLING-6519
> URL: https://issues.apache.org/jira/browse/SLING-6519
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Reporter: Carsten Ziegeler
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6519-v01.patch
>
>
> Some IDE code is using org.json. We have to replace this. This is the list of 
> files using that code:
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONArray;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONException;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONObject;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONTokener;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
>  org.json.JSONArray;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
>  org.json.JSONObject;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
>  org.json.JSONTokener;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import
>  org.json.JSONArray;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import
>  org.json.JSONObject;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/ListChildrenCommand.java:import
>  org.json.JSONObject;



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (SLING-6519) Remove dependency to org.json

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130328#comment-16130328
 ] 

Robert Munteanu edited comment on SLING-6519 at 8/17/17 12:38 PM:
--

Unfortunately this seems to always fail when connecting in debug mode. I get an 
error which looks like

{noformat}java.lang.IllegalStateException: Expected a name but was BEGIN_OBJECT 
at line 1 column 3
at com.google.gson.stream.JsonReader.nextName(JsonReader.java:785)
at 
org.apache.sling.ide.osgi.impl.HttpOsgiClient.findSourceReferences(HttpOsgiClient.java:252)
at 
org.apache.sling.ide.osgi.impl.TracingOsgiClient.findSourceReferences(TracingOsgiClient.java:110)
at 
org.apache.sling.ide.eclipse.core.internal.JVMDebuggerConnection.connectInDebugMode(JVMDebuggerConnection.java:120)
at 
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.start(SlingLaunchpadBehaviour.java:123)
at 
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadLaunchConfigurationDelegate.launch(SlingLaunchpadLaunchConfigurationDelegate.java:45)
at 
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:885)
at 
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
at 
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:731)
at 
org.eclipse.wst.server.core.internal.Server.startImpl2(Server.java:3541)
at 
org.eclipse.wst.server.core.internal.Server.startImpl(Server.java:3477)
at 
org.eclipse.wst.server.core.internal.Server$StartJob.run(Server.java:367)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54){noformat}

I'll try and provide a test + fix shortly.

_Edit_: typo


was (Author: rombert):
Unfortunately this seems to always fail when connecting in debug mode. I get an 
error which looks like

{noformat}java.lang.IllegalStateException: Expected a name but was BEGIN_OBJECT 
at line 1 column 3
at com.google.gson.stream.JsonReader.nextName(JsonReader.java:785)
at 
org.apache.sling.ide.osgi.impl.HttpOsgiClient.findSourceReferences(HttpOsgiClient.java:252)
at 
org.apache.sling.ide.osgi.impl.TracingOsgiClient.findSourceReferences(TracingOsgiClient.java:110)
at 
org.apache.sling.ide.eclipse.core.internal.JVMDebuggerConnection.connectInDebugMode(JVMDebuggerConnection.java:120)
at 
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.start(SlingLaunchpadBehaviour.java:123)
at 
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadLaunchConfigurationDelegate.launch(SlingLaunchpadLaunchConfigurationDelegate.java:45)
at 
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:885)
at 
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:739)
at 
org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:731)
at 
org.eclipse.wst.server.core.internal.Server.startImpl2(Server.java:3541)
at 
org.eclipse.wst.server.core.internal.Server.startImpl(Server.java:3477)
at 
org.eclipse.wst.server.core.internal.Server$StartJob.run(Server.java:367)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54){noformat}

I'll try and provided a test + fix shortly.

> Remove dependency to org.json
> -
>
> Key: SLING-6519
> URL: https://issues.apache.org/jira/browse/SLING-6519
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Reporter: Carsten Ziegeler
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6519-v01.patch
>
>
> Some IDE code is using org.json. We have to replace this. This is the list of 
> files using that code:
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONArray;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONException;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONObject;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONTokener;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
>  org.json.JSONArray;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
>  org.json.JSONObject;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
>  org.json.JSONTokener;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import
>  

[jira] [Created] (SLING-7057) Add description to Distribution Trigger implementations

[Timothee Maret (JIRA)]

Timothee Maret created SLING-7057:
-

 Summary: Add description to Distribution Trigger implementations
 Key: SLING-7057
 URL: https://issues.apache.org/jira/browse/SLING-7057
 Project: Sling
  Issue Type: Improvement
  Components: Content Distribution
Affects Versions: Content Distribution Core 0.2.8
Reporter: Timothee Maret
 Fix For: Content Distribution Core 0.2.10


Multiple implementation of the {{DistributionTrigger}} interface are provided in

https://github.com/apache/sling/tree/trunk/contrib/extensions/distribution/core/src/main/java/org/apache/sling/distribution/trigger/impl

However none is documented. This issue is about adding a description to each of 
them, visible in the OSGi configuration console.

cc [~teofili]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7058) the stop command line option does not seem to work

[Ruben Reusser (JIRA)]

Ruben Reusser created SLING-7058:


 Summary: the stop command line option does not seem to work
 Key: SLING-7058
 URL: https://issues.apache.org/jira/browse/SLING-7058
 Project: Sling
  Issue Type: Bug
  Components: Launchpad
Reporter: Ruben Reusser
Priority: Minor


as per 
https://sling.apache.org/documentation/the-sling-engine/the-sling-launchpad.html#command-line-options
 a user should be able to stop a running sling instance by calling

{code:java}
java -jar sling-9.jar stop
{code}

Sling is supposed to write a file at startup with the chosen control port and 
the secret key at 
`$\{sling.home}/conf/controlport`

I do not see that file created nor does the above command work to stop a 
running sling instance. 




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7059) No wait time between two distribution attempts with File backed queue

[Timothee Maret (JIRA)]

Timothee Maret created SLING-7059:
-

 Summary: No wait time between two distribution attempts with File 
backed queue
 Key: SLING-7059
 URL: https://issues.apache.org/jira/browse/SLING-7059
 Project: Sling
  Issue Type: Bug
  Components: Content Distribution
Affects Versions: Content Distribution Core 0.2.8
Reporter: Timothee Maret


An agent configured with a File based queue provider will retry failing 
distribution without waiting between two tries. Adding a reasonable waiting 
time (5 or 10 sec) would avoid polluting the logs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7058) the stop command line option does not seem to work

[Ruben Reusser (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130354#comment-16130354
 ] 

Ruben Reusser commented on SLING-7058:
--

it seems this issue is due to the logic in 
https://github.com/apache/sling/blob/trunk/launchpad/base/src/main/java/org/apache/sling/launchpad/app/Main.java
 as it only initializes the ControlListener if the command start is passed to 
sling. This may of course be intentional

> the stop command line option does not seem to work
> --
>
> Key: SLING-7058
> URL: https://issues.apache.org/jira/browse/SLING-7058
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Reporter: Ruben Reusser
>Priority: Minor
>
> as per 
> https://sling.apache.org/documentation/the-sling-engine/the-sling-launchpad.html#command-line-options
>  a user should be able to stop a running sling instance by calling
> {code:java}
> java -jar sling-9.jar stop
> {code}
> Sling is supposed to write a file at startup with the chosen control port and 
> the secret key at 
> `$\{sling.home}/conf/controlport`
> I do not see that file created nor does the above command work to stop a 
> running sling instance. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-6519) Remove dependency to org.json

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-6519.

Resolution: Fixed
  Assignee: Konrad Windszus  (was: Robert Munteanu)

Changes applied in [r1805281|https://svn.apache.org/r1805281]. [~kwin] - if you 
see any further changes that need to be applied please let me know.

> Remove dependency to org.json
> -
>
> Key: SLING-6519
> URL: https://issues.apache.org/jira/browse/SLING-6519
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Reporter: Carsten Ziegeler
>Assignee: Konrad Windszus
>Priority: Blocker
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6519-v01.patch
>
>
> Some IDE code is using org.json. We have to replace this. This is the list of 
> files using that code:
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONArray;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONException;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONObject;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONTokener;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
>  org.json.JSONArray;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
>  org.json.JSONObject;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
>  org.json.JSONTokener;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import
>  org.json.JSONArray;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import
>  org.json.JSONObject;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/ListChildrenCommand.java:import
>  org.json.JSONObject;



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131728#comment-16131728
 ] 

Carsten Ziegeler commented on SLING-7055:
-

[~rombert] Lgtm, I think we should rename the package to have "impl" somewhere 
as this is our convention for private packages; then we can also remove the 
export package statement from the pom.

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: SLING-7055.patch, SLING-7055.patch, SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (SLING-7054) Slingstart artifacts with parametrized version not removed from the effective slingstart model

[JIRA]

 [ 
https://issues.apache.org/jira/browse/SLING-7054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomek Rękawek reassigned SLING-7054:


Assignee: (was: Tomek Rękawek)

> Slingstart artifacts with parametrized version not removed from the effective 
> slingstart model
> --
>
> Key: SLING-7054
> URL: https://issues.apache.org/jira/browse/SLING-7054
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Reporter: Tomek Rękawek
>Priority: Minor
> Fix For: Slingstart Maven Plugin 1.7.8
>
>
> Adding a following entry to the provisioning model:
> {noformat}
> [artifacts]
>   com.acme/my-model/1.0.0/slingstart
> {noformat}
> results in including the my-model to the current one. The slingfeature file 
> will be downloaded and merged. However, if we replace the version with a 
> variable:
> {noformat}
> [artifacts]
>   com.acme/my-model/${my.model.version}/slingstart
> {noformat}
> the slingstart will also download and include the my-model.jar file, not 
> useful here.
> It's a result of the lines 
> [345-356|https://github.com/apache/sling/blob/7e8a3a110a29b743d49ef799a7c7dec50a90bd96/tooling/maven/slingstart-maven-plugin/src/main/java/org/apache/sling/maven/slingstart/ModelPreprocessor.java#L345-L357]
>  in the {{ModelPreprocessor}}:
> {code}
> for(final org.apache.sling.provisioning.model.Artifact r 
> : removeList) {
> group.remove(r);
> final Feature localModelFeature = 
> rawModel.getFeature(feature.getName());
> if ( localModelFeature != null ) {
> final RunMode localRunMode = 
> localModelFeature.getRunMode(runMode.getNames());
> if ( localRunMode != null ) {
> final ArtifactGroup localAG = 
> localRunMode.getArtifactGroup(group.getStartLevel());
> if ( localAG != null ) {
> localAG.remove(r);
> }
> }
> }
> }
> {code}
> If the artifact is parametrized, it won't be removed from the localAG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7054) Slingstart artifacts with parametrized version not removed from the effective slingstart model

[JIRA]

[ 
https://issues.apache.org/jira/browse/SLING-7054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130373#comment-16130373
 ] 

Tomek Rękawek commented on SLING-7054:
--

//cc: [~cziegeler]

> Slingstart artifacts with parametrized version not removed from the effective 
> slingstart model
> --
>
> Key: SLING-7054
> URL: https://issues.apache.org/jira/browse/SLING-7054
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Minor
> Fix For: Slingstart Maven Plugin 1.7.8
>
>
> Adding a following entry to the provisioning model:
> {noformat}
> [artifacts]
>   com.acme/my-model/1.0.0/slingstart
> {noformat}
> results in including the my-model to the current one. The slingfeature file 
> will be downloaded and merged. However, if we replace the version with a 
> variable:
> {noformat}
> [artifacts]
>   com.acme/my-model/${my.model.version}/slingstart
> {noformat}
> the slingstart will also download and include the my-model.jar file, not 
> useful here.
> It's a result of the lines 
> [345-356|https://github.com/apache/sling/blob/7e8a3a110a29b743d49ef799a7c7dec50a90bd96/tooling/maven/slingstart-maven-plugin/src/main/java/org/apache/sling/maven/slingstart/ModelPreprocessor.java#L345-L357]
>  in the {{ModelPreprocessor}}:
> {code}
> for(final org.apache.sling.provisioning.model.Artifact r 
> : removeList) {
> group.remove(r);
> final Feature localModelFeature = 
> rawModel.getFeature(feature.getName());
> if ( localModelFeature != null ) {
> final RunMode localRunMode = 
> localModelFeature.getRunMode(runMode.getNames());
> if ( localRunMode != null ) {
> final ArtifactGroup localAG = 
> localRunMode.getArtifactGroup(group.getStartLevel());
> if ( localAG != null ) {
> localAG.remove(r);
> }
> }
> }
> }
> {code}
> If the artifact is parametrized, it won't be removed from the localAG.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (SLING-7055) RRD4J metrics reporter

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130469#comment-16130469
 ] 

Robert Munteanu edited comment on SLING-7055 at 8/17/17 2:23 PM:
-

> I'd love to remove that dependency, but at the same time I don't want to rely 
> on the directory where the Java process was started. Is there a Sling 
> property I could use as the base directory when Sling is present?

You could either:

* lookup the OSGi framework property named 'sling.home' using 
{{BundleContext#getProperty}}, or
* rely only on the configured value, and when configured using the provisioning 
model the path property can be set to {{$\{sling.home\}/metrics/metrics.rrd}}


was (Author: rombert):
> I'd love to remove that dependency, but at the same time I don't want to rely 
> on the directory where the Java process was started. Is there a Sling 
> property I could use as the base directory when Sling is present?

You could either:

* lookup the OSGi framework property named 'sling.home' using 
{{BundleContext#getProperty}}, or
* rely only on the configured value, and when configured using the provisioning 
model the path property can be set to {{${sling.home}/metrics/metrics.rrd}}

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130524#comment-16130524
 ] 

Carsten Ziegeler commented on SLING-7055:
-

Sorry I should have looked more closely, that's of course fine. However I hope 
that an absolute path works as well

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: SLING-7055.patch, SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-6519) Remove dependency to org.json

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130401#comment-16130401
 ] 

Robert Munteanu commented on SLING-6519:


Ignored test JSON file from rat checks in 
[r1805283|https://svn.apache.org/r1805283]

> Remove dependency to org.json
> -
>
> Key: SLING-6519
> URL: https://issues.apache.org/jira/browse/SLING-6519
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Reporter: Carsten Ziegeler
>Assignee: Konrad Windszus
>Priority: Blocker
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6519-v01.patch
>
>
> Some IDE code is using org.json. We have to replace this. This is the list of 
> files using that code:
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONArray;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONException;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONObject;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
>  org.json.JSONTokener;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
>  org.json.JSONArray;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
>  org.json.JSONObject;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
>  org.json.JSONTokener;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import
>  org.json.JSONArray;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import
>  org.json.JSONObject;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/ListChildrenCommand.java:import
>  org.json.JSONObject;



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-7060) Allow running a test only if a certain bundle is present at a certain version

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7060.

Resolution: Fixed

Fixed in [r1805287|https://svn.apache.org/r1805287]

> Allow running a test only if a certain bundle is present at a certain version
> -
>
> Key: SLING-7060
> URL: https://issues.apache.org/jira/browse/SLING-7060
> Project: Sling
>  Issue Type: New Feature
>  Components: Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Commons Testing 2.1.2
>
>
> Now that the launchpad is working with releases only, integration tests for 
> yet-unreleased versions should not run, as they would cause a test failure.
> We should add support to HttpTestBase for skipping tests based on the BSN and 
> version.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-7048) Add an integration test for scripted tag files

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7048.

Resolution: Fixed

Fix added in [r1805288|https://svn.apache.org/r1805288]

> Add an integration test for scripted tag files
> --
>
> Key: SLING-7048
> URL: https://issues.apache.org/jira/browse/SLING-7048
> Project: Sling
>  Issue Type: Test
>  Components: Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Launchpad Testing 9
>
>
> Test for the fix added in SLING-7044



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130469#comment-16130469
 ] 

Robert Munteanu commented on SLING-7055:


> I'd love to remove that dependency, but at the same time I don't want to rely 
> on the directory where the Java process was started. Is there a Sling 
> property I could use as the base directory when Sling is present?

You could either:

* lookup the OSGi framework property named 'sling.home' using 
{{BundleContext#getProperty}}, or
* rely only on the configured value, and when configured using the provisioning 
model the path property can be set to {{${sling.home}/metrics/metrics.rrd}}

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7060) Allow running a test only if a certain bundle is present at a certain version

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130493#comment-16130493
 ] 

Bertrand Delacretaz commented on SLING-7060:


I see that you have already implemented something - I was going to mention 
http://junit.sourceforge.net/javadoc/org/junit/Assume.html which can help for 
this

> Allow running a test only if a certain bundle is present at a certain version
> -
>
> Key: SLING-7060
> URL: https://issues.apache.org/jira/browse/SLING-7060
> Project: Sling
>  Issue Type: New Feature
>  Components: Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Commons Testing 2.1.2
>
>
> Now that the launchpad is working with releases only, integration tests for 
> yet-unreleased versions should not run, as they would cause a test failure.
> We should add support to HttpTestBase for skipping tests based on the BSN and 
> version.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-7056) Servlets are not removed from pending servlets list

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-7056.
-
Resolution: Fixed

> Servlets are not removed from pending servlets list
> ---
>
> Key: SLING-7056
> URL: https://issues.apache.org/jira/browse/SLING-7056
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Resolver 2.4.12
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.4.14
>
>
> The unbindServlet method does not correctly remove an entry from 
> pendingServlets - while pendingServlets contains PendingServlet objects it 
> tries to remove a Service Reference



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-6190) More gracefully deal with non existing natures during project import

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130396#comment-16130396
 ] 

Robert Munteanu commented on SLING-6190:


Added missing import in manifest in [r1805284|https://svn.apache.org/r1805284]

> More gracefully deal with non existing natures during project import
> 
>
> Key: SLING-6190
> URL: https://issues.apache.org/jira/browse/SLING-6190
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Fix For: Sling Eclipse IDE 1.2.0
>
>
> The project configurator from SLING-3100 fails in case a nature is not 
> available. E.g. with this stack trace in case JSDT is not available:
> {code}
> WARNING: org.eclipse.core.resources code=568 Problems encountered while 
> setting project description.
>   at 
> org.eclipse.core.internal.resources.Project.setDescription(Project.java:1255)
>   at 
> org.apache.sling.ide.eclipse.m2e.internal.ContentPackageProjectConfigurator.addNatures(ContentPackageProjectConfigurator.java:115)
>   at 
> org.apache.sling.ide.eclipse.m2e.internal.ContentPackageProjectConfigurator.access$1(ContentPackageProjectConfigurator.java:103)
>   at 
> org.apache.sling.ide.eclipse.m2e.internal.ContentPackageProjectConfigurator$WtpProjectConfigurer.configure(ContentPackageProjectConfigurator.java:139)
>   at 
> org.apache.sling.ide.eclipse.m2e.internal.ContentPackageProjectConfigurator.configure(ContentPackageProjectConfigurator.java:91)
>   at 
> org.eclipse.m2e.core.project.configurator.AbstractLifecycleMapping.configure(AbstractLifecycleMapping.java:120)
>   at 
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$3.call(ProjectConfigurationManager.java:501)
>   at 
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$3.call(ProjectConfigurationManager.java:1)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:176)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:151)
>   at 
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:494)
>   at 
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.configureNewMavenProjects(ProjectConfigurationManager.java:281)
>   at 
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$1.call(ProjectConfigurationManager.java:168)
>   at 
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$1.call(ProjectConfigurationManager.java:1)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:176)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:151)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:99)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1355)
>   at 
> org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.importProjects(ProjectConfigurationManager.java:136)
> ...
>   at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
>   WARNING: org.eclipse.core.resources code=35 Nature does not exist: 
> org.eclipse.wst.jsdt.core.jsNature.
> {code}
> We should deal more gracefully with missing natures (which are not enforced 
> at all by Sling IDE e.g. through required bundles)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-7055) RRD4J metrics reporter

[Marcel Reutegger (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger updated SLING-7055:

Attachment: SLING-7055.patch

Thanks, I went with the framework property. See updated patch.

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: SLING-7055.patch, SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

[Marcel Reutegger (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130517#comment-16130517
 ] 

Marcel Reutegger commented on SLING-7055:
-

The framework property is optional. The component also works without it. The 
description of the configuration attribute says:
{noformat}
@AttributeDefinition(
name = "Path",
description = "Path of the RRD file where metrics are stored. " 
+
"The path is resolved relative to the 'sling.home' " +
"path when available, otherwise relative to the current 
" +
"working directory."
)
String path() default "metrics/metrics.rrd";
{noformat}

If this is considered bad practice, then I would rather rely on the settings 
service and have the bundle in extensions.

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: SLING-7055.patch, SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130501#comment-16130501
 ] 

Carsten Ziegeler commented on SLING-7055:
-

Well relying on the framework property is basically the same as relying on the 
settings service :) You assume that this bundle runs in a Sling context.
I suggest to rely on configuration only

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: SLING-7055.patch, SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-5755) Complete Distribution documentation

[Timothee Maret (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130717#comment-16130717
 ] 

Timothee Maret commented on SLING-5755:
---

Done at {{r1805305}}, fixed/completed 
* request examples
* how to configure priority queues, binary-less distribution, retry strategy

> Complete Distribution documentation
> ---
>
> Key: SLING-5755
> URL: https://issues.apache.org/jira/browse/SLING-5755
> Project: Sling
>  Issue Type: Task
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.1.18
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Minor
> Fix For: Content Distribution Core 0.2.10
>
>
> I noticed that the Sling Distribution documentation at [0] could be completed 
> with details, notably the "Additional options" section. This issue tracks 
> completing the section.
> [0] 
> https://sling.apache.org/documentation/bundles/content-distribution.html#how-to-configure-error-queues



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-5755) Complete Distribution documentation

[Timothee Maret (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret resolved SLING-5755.
---
   Resolution: Fixed
Fix Version/s: Content Distribution Core 0.2.10

> Complete Distribution documentation
> ---
>
> Key: SLING-5755
> URL: https://issues.apache.org/jira/browse/SLING-5755
> Project: Sling
>  Issue Type: Task
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.1.18
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Minor
> Fix For: Content Distribution Core 0.2.10
>
>
> I noticed that the Sling Distribution documentation at [0] could be completed 
> with details, notably the "Additional options" section. This issue tracks 
> completing the section.
> [0] 
> https://sling.apache.org/documentation/bundles/content-distribution.html#how-to-configure-error-queues



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[RESULT] [VOTE] Release Apache Sling Launchpad Base 5.6.6-2.6.22

[Robert Munteanu]

Hi,

The vote has passed with the following result :

+1 (binding): Radu Cotescu, Karl Pauls, Daniel Klco, Carsten Ziegeler,
Robert Munteanu

I will copy this release to the Sling dist directory and promote the
artifacts to the central Maven repository.

Thanks,

Robert

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130735#comment-16130735
 ] 

Robert Munteanu commented on SLING-7055:


Patch LGTM. [~cziegeler], any other comments?

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: SLING-7055.patch, SLING-7055.patch, SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7060) Allow running a test only if a certain bundle is present at a certain version

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130743#comment-16130743
 ] 

Robert Munteanu commented on SLING-7060:


That would've been quite helpful, yes. However, the HttpTestBase class works 
with JUnit tests, so I can't use an assumption.

> Allow running a test only if a certain bundle is present at a certain version
> -
>
> Key: SLING-7060
> URL: https://issues.apache.org/jira/browse/SLING-7060
> Project: Sling
>  Issue Type: New Feature
>  Components: Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Commons Testing 2.1.2
>
>
> Now that the launchpad is working with releases only, integration tests for 
> yet-unreleased versions should not run, as they would cause a test failure.
> We should add support to HttpTestBase for skipping tests based on the BSN and 
> version.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-7055) RRD4J metrics reporter

[Marcel Reutegger (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger updated SLING-7055:

Attachment: SLING-7055.patch

Yet another update of the patch incorporating Carsten's hint.

Thanks for all the feedback so far.

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: SLING-7055.patch, SLING-7055.patch, SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7060) Allow running a test only if a certain bundle is present at a certain version

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-7060:
--

 Summary: Allow running a test only if a certain bundle is present 
at a certain version
 Key: SLING-7060
 URL: https://issues.apache.org/jira/browse/SLING-7060
 Project: Sling
  Issue Type: New Feature
  Components: Testing
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Commons Testing 2.1.2


Now that the launchpad is working with releases only, integration tests for 
yet-unreleased versions should not run, as they would cause a test failure.

We should add support to HttpTestBase for skipping tests based on the BSN and 
version.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7055) RRD4J metrics reporter

[Marcel Reutegger (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130637#comment-16130637
 ] 

Marcel Reutegger commented on SLING-7055:
-

bq. However I hope that an absolute path works as well

Nope, it doesn't but that's a good point. I'll update the patch accordingly.

> RRD4J metrics reporter
> --
>
> Key: SLING-7055
> URL: https://issues.apache.org/jira/browse/SLING-7055
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Marcel Reutegger
>Assignee: Robert Munteanu
>Priority: Minor
> Attachments: SLING-7055.patch, SLING-7055.patch
>
>
> SLING-4080 introduced metrics in Sling. The proposal in this issue adds a new 
> commons module which writes those metrics to a time series database on the 
> local filesystem. The primary purpose is tracking metrics for diagnostics.
> The bundle uses [RRD4J|https://github.com/rrd4j/rrd4j] as the time series 
> database implementation. The library is Apache License, Version 2.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

esx ScriptEngine + react.js

[Henry Saginor]

Hi,

I would like to run some server side react.js components in Sling. I was 
experimenting with the esx engine [1]  which works like a NodeJs loader and 
allows you to load any valid Node module.
I am able to run the demo examples that come with that bundle. So, I installed 
react npm module and it’s dependencies under /libs/esx/node_modules. But when I 
try to load react based script in sling I get an exception at [2].
I see “process” properties declared in SlingBabel.js and when I debug I see 
that the transpile step works for my initial script (one sling:resourceType 
points to).

I know this esx engine is considered experimental according to JIRA ticket [3]. 
But I was still curious if anyone else has tried this or can help out.

If I can successfully load react I would like to work on some tests suggested 
in JIRA and see if I can contribute to this module. Therefor I thought it 
appropriate to send this to dev list. 
I apologize in advance for spam if that’s not correct.  

Regards, 

Henry

[1] https://github.com/apache/sling/tree/trunk/contrib/scripting/esx 


[2] jdk.nashorn.internal.runtime.ECMAException: ReferenceError: "process" is 
not defined
at jdk.nashorn.internal.runtime.ECMAErrors.error(ECMAErrors.java:57)
at 
jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:319)
at 
jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:291)
at 
jdk.nashorn.internal.objects.Global.__noSuchProperty__(Global.java:1441)
at 
jdk.nashorn.internal.scripts.Script$Recompilation$39714$173AA$warning.L:2(/libs/esx/node_modules/fbjs/lib/warning.js:25)
at 
java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627)
at 
jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:651)
at 
jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:494)
at 
jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:393)
at 
jdk.nashorn.api.scripting.ScriptObjectMirror.call(ScriptObjectMirror.java:117)
at org.apache.sling.scripting.esx.Module.runScript(Module.java:249)
at org.apache.sling.scripting.esx.Module.require(Module.java:670)
at 
jdk.nashorn.internal.scripts.Script$Recompilation$39711$349A$ReactNoopUpdateQueue.L:2#require(/libs/esx/node_modules/react/lib/ReactNoopUpdateQueue.js:2)
at 
jdk.nashorn.internal.scripts.Script$Recompilation$39710$187AA$ReactNoopUpdateQueue.L:2(/libs/esx/node_modules/react/lib/ReactNoopUpdateQueue.js:14)
at 
java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627)
at 
jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:651)
at 
jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:494)
at 
jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:393)
at 
jdk.nashorn.api.scripting.ScriptObjectMirror.call(ScriptObjectMirror.java:117)
at org.apache.sling.scripting.esx.Module.runScript(Module.java:249)
at org.apache.sling.scripting.esx.Module.require(Module.java:670)
at 
jdk.nashorn.internal.scripts.Script$Recompilation$39704$345A$ReactBaseClasses.L:2#require(/libs/esx/node_modules/react/lib/ReactBaseClasses.js:2)
at 
jdk.nashorn.internal.scripts.Script$Recompilation$39703$183AA$ReactBaseClasses.L:2(/libs/esx/node_modules/react/lib/ReactBaseClasses.js:17)
at 
java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627)
at 
jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:651)
at 
jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:494)
at 
jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:393)
at 
jdk.nashorn.api.scripting.ScriptObjectMirror.call(ScriptObjectMirror.java:117)
at org.apache.sling.scripting.esx.Module.runScript(Module.java:249)
at org.apache.sling.scripting.esx.Module.require(Module.java:670)
at 
jdk.nashorn.internal.scripts.Script$Recompilation$39696$334A$React.L:2#require(/libs/esx/node_modules/react/lib/React.js:2)
at 
jdk.nashorn.internal.scripts.Script$Recompilation$39695$172AA$React.L:2(/libs/esx/node_modules/react/lib/React.js:16)

[3] https://issues.apache.org/jira/browse/SLING-6680