[jira] [Comment Edited] (SLING-8243) Content Loader - support merge of properties and child nodes
[ https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049550#comment-17049550 ] Jason E Bailey edited comment on SLING-8243 at 3/2/20 6:50 PM: --- [~sseifert] yes, I'll take care of that. I just need to refresh my memory. It's been a while. was (Author: jebailey): [~sseifert] yes, I'll take care of that. > Content Loader - support merge of properties and child nodes > > > Key: SLING-8243 > URL: https://issues.apache.org/jira/browse/SLING-8243 > Project: Sling > Issue Type: New Feature >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR ContentLoader 2.4.0 > > > Currently the Content Loader doesn't support a merge feature, a merge feature > would provide the ability for the an import to update existing properties and > nodes, and additionally delete the specific properties and nodes that aren't > imported. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8243) Content Loader - support merge of properties and child nodes
[ https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049550#comment-17049550 ] Jason E Bailey commented on SLING-8243: --- [~sseifert] yes, I'll take care of that. > Content Loader - support merge of properties and child nodes > > > Key: SLING-8243 > URL: https://issues.apache.org/jira/browse/SLING-8243 > Project: Sling > Issue Type: New Feature >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR ContentLoader 2.4.0 > > > Currently the Content Loader doesn't support a merge feature, a merge feature > would provide the ability for the an import to update existing properties and > nodes, and additionally delete the specific properties and nodes that aren't > imported. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-7760) Sling Main Servlet - Change header configuration to a service
[ https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027709#comment-17027709 ] Jason E Bailey commented on SLING-7760: --- [~bdelacretaz] My thought process for this is that I wanted to be as careful as possible so as to not impact the performance of the Main servlet and not to provide an avenue for someone to put in more functionality than needed. I could certainly change the request path to a resource object. When I said returning headers, I was thinking a List of headers to be mapped into the Response headers. I wouldn't want to pass something like the response object directly as we could end up with situations where people could create an implementation of the interface that returned content or did all sorts of odd stuff at the wrong level. > Sling Main Servlet - Change header configuration to a service > - > > Key: SLING-7760 > URL: https://issues.apache.org/jira/browse/SLING-7760 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > The ability to set headers must be done prior to any writing that occurs the > output stream. This is the reason why the headers are set to be configured in > the Sling Main Servlet. > With Sling being used to maintain multiple sites, having a single set of > response headers creates problems where the header provides a non tailored > response. One site may have a conflicting set of requirements then another > site. > If the setting of headers was moved from being a configuration to being a > service used by the Main Servlet, this would allow the following: > * Headers set on a per site basis > * Headers based on selected resource > * Ability to modify the headers without causing the restart of the Sling > Main Servlet > ** Which if you're dealing with CSP headers can be a constant pain > * Ability to create a CSP configuration Service that eases the use of CSP > creation > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (SLING-7760) Sling Main Servlet - Change header configuration to a service
[ https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027587#comment-17027587 ] Jason E Bailey edited comment on SLING-7760 at 1/31/20 3:38 PM: [~cziegeler] I've been considering this a lot. It's true that I could write a REQUEST Filter would be able to apply for my personal needs. What I was looking for, is a way to incorporate a feature within Sling that would support headers being applied when needed. The reason that I feel a header feature is appropriate is that headers have to be applied prior to any writes that occur. Sling is a framework that supports many different models of development. Including working with other peoples frameworks and adding other peoples "plugins" to provide new features. I then start down a rabbit hole where, if I use a filter, I have no guarantee that it will be the first one called. The only place that you can guarantee that headers will always be applied appropriately is in the Main Servlet. Which, I believe, is the same reason that the static headers are there. How about this proposal. I'm going back to the services approach. Leave the static headers alone. Additionally, create a service interface that takes the request path and returns a list of headers that applies to that request. Whether the service that implements the interface then performs a context aware lookup, or it does pattern matching, or whatever, would then be left up to the individuals implementing the application. That way an implementer can be assured that their feature they are adding will not have any downstream conflicts. I'm pretty sure that I can do this in such a way as to have a minimal impact to the code and not change the current flow. By doing it the same way as the current static headers are applied except use a a static concurrent mapping of services. was (Author: jebailey): I've been considering this a lot. It's true that I could write a REQUEST Filter would be able to apply for my personal needs. What I was looking for, is a way to incorporate a feature within Sling that would support headers being applied when needed. The reason that I feel a header feature is appropriate is that headers have to be applied prior to any writes that occur. Sling is a framework that supports many different models of development. Including working with other peoples frameworks and adding other peoples "plugins" to provide new features. I then start down a rabbit hole where, if I use a filter, I have no guarantee that it will be the first one called. The only place that you can guarantee that headers will always be applied appropriately is in the Main Servlet. Which, I believe, is the same reason that the static headers are there. How about this proposal. I'm going back to the services approach. Leave the static headers alone. Additionally, create a service interface that takes the request path and returns a list of headers that applies to that request. Whether the service that implements the interface then performs a context aware lookup, or it does pattern matching, or whatever, would then be left up to the individuals implementing the application. That way an implementer can be assured that their feature they are adding will not have any downstream conflicts. I'm pretty sure that I can do this in such a way as to have a minimal impact to the code and not change the current flow. By doing it the same way as the current static headers are applied except use a a static concurrent mapping of services. > Sling Main Servlet - Change header configuration to a service > - > > Key: SLING-7760 > URL: https://issues.apache.org/jira/browse/SLING-7760 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > The ability to set headers must be done prior to any writing that occurs the > output stream. This is the reason why the headers are set to be configured in > the Sling Main Servlet. > With Sling being used to maintain multiple sites, having a single set of > response headers creates problems where the header provides a non tailored > response. One site may have a conflicting set of requirements then another > site. > If the setting of headers was moved from being a configuration to being a > service used by the Main Servlet, this would allow the following: > * Headers set on a per site basis > * Headers based on selected resource > * Ability to modify the headers without causing the restart of the Sling > Main Servlet > ** Which if you're dealing with CSP headers can be a constant pain > * Ability to create a CSP configuration Service that eases the use of CSP > creation > > --
[jira] [Commented] (SLING-7760) Sling Main Servlet - Change header configuration to a service
[ https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027587#comment-17027587 ] Jason E Bailey commented on SLING-7760: --- I've been considering this a lot. It's true that I could write a REQUEST Filter would be able to apply for my personal needs. What I was looking for, is a way to incorporate a feature within Sling that would support headers being applied when needed. The reason that I feel a header feature is appropriate is that headers have to be applied prior to any writes that occur. Sling is a framework that supports many different models of development. Including working with other peoples frameworks and adding other peoples "plugins" to provide new features. I then start down a rabbit hole where, if I use a filter, I have no guarantee that it will be the first one called. The only place that you can guarantee that headers will always be applied appropriately is in the Main Servlet. Which, I believe, is the same reason that the static headers are there. How about this proposal. I'm going back to the services approach. Leave the static headers alone. Additionally, create a service interface that takes the request path and returns a list of headers that applies to that request. Whether the service that implements the interface then performs a context aware lookup, or it does pattern matching, or whatever, would then be left up to the individuals implementing the application. That way an implementer can be assured that their feature they are adding will not have any downstream conflicts. I'm pretty sure that I can do this in such a way as to have a minimal impact to the code and not change the current flow. By doing it the same way as the current static headers are applied except use a a static concurrent mapping of services. > Sling Main Servlet - Change header configuration to a service > - > > Key: SLING-7760 > URL: https://issues.apache.org/jira/browse/SLING-7760 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > The ability to set headers must be done prior to any writing that occurs the > output stream. This is the reason why the headers are set to be configured in > the Sling Main Servlet. > With Sling being used to maintain multiple sites, having a single set of > response headers creates problems where the header provides a non tailored > response. One site may have a conflicting set of requirements then another > site. > If the setting of headers was moved from being a configuration to being a > service used by the Main Servlet, this would allow the following: > * Headers set on a per site basis > * Headers based on selected resource > * Ability to modify the headers without causing the restart of the Sling > Main Servlet > ** Which if you're dealing with CSP headers can be a constant pain > * Ability to create a CSP configuration Service that eases the use of CSP > creation > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9044) Use traversal to count items in resource based distribution queue
[
https://issues.apache.org/jira/browse/SLING-9044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027504#comment-17027504
]
Jason E Bailey commented on SLING-9044:
---
As a note, we have a traversal library that's part of the core Sling bundles
https://github.com/apache/sling-org-apache-sling-resource-filter
> Use traversal to count items in resource based distribution queue
> -
>
> Key: SLING-9044
> URL: https://issues.apache.org/jira/browse/SLING-9044
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Mohit Arora
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.4.2
>
>
> [ResourceQueueUtils#
> getResourceCount()|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/impl/resource/ResourceQueueUtils.java#L320]
> function is responsible for triggering an xpath query to get the resource
> queue items. This query tries to find all the {{nt:unstructured}} nodes under
> a resource queue's path. This query is currently not backed by any index
> definition. This leads to a warning like below being logged when a request is
> made to list the items of resource queue -
> {code}11.12.2019 14:15:46.926 *WARN* [0:0:0:0:0:0:0:1 [1576053946802] GET
> /libs/granite/distribution/content/distribution-agent.html HTTP/1.1]
> org.apache.jackrabbit.oak.query.QueryImpl Traversal query (query without
> index): select [jcr:path], [jcr:score], * from [nt:unstructured] as a where
> isdescendantnode(a,
> '/var/sling/distribution/queues/bpqatest0/error-endpoint-bpqatest0') /*
> xpath:
> /jcr:root/var/sling/distribution/queues/bpqatest0/error-endpoint-bpqatest0//element(*,nt:unstructured)
> */; consider creating an index
> {code}
> Switching to traversal here would be as efficient as writing an index for
> this query.
> Further, since a resource queue can also be an {{active}} queue and the items
> will come and go, the indexer will have to do extra work of indexing the
> transient items.
> cc - [~marett], [~ashishc]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-7760) Sling Main Servlet - Change header configuration to a service
[ https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018079#comment-17018079 ] Jason E Bailey commented on SLING-7760: --- This depends on why the response headers are set where they are currently set. My initial attempt at this would be to to remove the setting of the headers from the initialization of SlingHttpServletResponseImpl and create a new method in RequestData called initHeaders(ResourceResolver) which I would call after calling initResource in the doProcessRequest step of SlingRequestProcessorImpl I haven't worked with CA Configurations before so this is an educated guess. > Sling Main Servlet - Change header configuration to a service > - > > Key: SLING-7760 > URL: https://issues.apache.org/jira/browse/SLING-7760 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > The ability to set headers must be done prior to any writing that occurs the > output stream. This is the reason why the headers are set to be configured in > the Sling Main Servlet. > With Sling being used to maintain multiple sites, having a single set of > response headers creates problems where the header provides a non tailored > response. One site may have a conflicting set of requirements then another > site. > If the setting of headers was moved from being a configuration to being a > service used by the Main Servlet, this would allow the following: > * Headers set on a per site basis > * Headers based on selected resource > * Ability to modify the headers without causing the restart of the Sling > Main Servlet > ** Which if you're dealing with CSP headers can be a constant pain > * Ability to create a CSP configuration Service that eases the use of CSP > creation > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-7760) Sling Main Servlet - Change header configuration to a service
[ https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015169#comment-17015169 ] Jason E Bailey commented on SLING-7760: --- [~cziegeler] Here's a some of the headers that we currently have. Note that the Content-Security-Policy is huge because we have 5 separate domains that we serve out of our instances. So any one domain has permissions to source data from a domain it doesn't actually interact with because another one of our domains requires it. X-Content-Type-Options: nosniff X-XSS-Protection: 1;mode=block X-Frame-Options: sameorigin Content-Security-Policy: default-src * 'self' data: 'unsafe-inline' blob:;script-src * 'self' blob: data: 'unsafe-inline' 'unsafe-eval' *.trustarc.com *.doubleclick.net *.liveperson.net *.sas.com assets.adobedtm.com ssl.google-analytics.com accdn.lpsnmedia.net www.googletagmanager.com www.google-analytics.com bat.bing.com benchtag.co front.facetz.net *.facebook.net *.facebook.com www.googleadservices.com tb.juiceadv.com *.linkedin.com pixel.mathtag.com pixel.quantserve.com *.quora.com analytics.twitter.com tagmanager.google.com mc.yandex.ru static.ads-twitter.com snap.licdn.com *.bizographics.com dev.visualwebsiteoptimizer.com scripts.demandbase.com consent.truste.com s.yimg.com ssl.gstatic.com api.company-target.com script.crazyegg.com platform.twitter.com sp.analytics.yahoo.com x.bidswitch.net s7.addthis.com ad4.adfarm1.adition.com livestream.co *.brightcove.net track.adform.net insight.adsrvr.org www.vintom.com b92.yahoo.co.jp cdn.appdynamics.com execution-dscvrtraffic.cidev.sas.us *.brightcove.com *.mrpfd.com d3js.org *.d3.org;img-src * 'self' data: *.google-analytics.com *.doubleclick.net www.google.com *.sas.com front.facetz.net *.facebook.com www.googleadservices.com tb.juiceadv.com ext.ligatus.com bcp.crwdcntrl.net pixel.mathtag.com *.quora.com cdn.taboola.com analytics.twitter.com d.company-target.com mc.yandex.ru t.co px.ads.linkedin.com *.bizographics.com insight.adsrvr.org assets.adobedtm.com *.brightcove.com;font-src * 'self' data: *.sas.com fast.fonts.net;connect-src * 'self' *.sas.com *.brightcove.com ma156-r.analytics.edgekey.net api.company-target.com livestream.com www.vintom.com *.doubleclick.net assets.adobedtm.com;frame-src 'self' assets.adobedtm.com lpcdn.lpsnmedia.net *.liveperson.net www.youtube.com s7.addthis.com *.twitter.com *.sas.com pixel.mathtag.com livestream.com ad4.adfarm1.adition.com www.vintom.com *.doubleclick.net *.facebook.net *.twitter.com *.trustarc.com *.facebook.com *.linkedin.com;frame-ancestors *.ci360.sas.com *.gatheriq.analytics *.curriculumpathways.com Cache-Control: max-age=3600 As you can see the Content-Security-Policy is the problem child and could do with some sort of tool to assist in it's creation in it's own right. > Sling Main Servlet - Change header configuration to a service > - > > Key: SLING-7760 > URL: https://issues.apache.org/jira/browse/SLING-7760 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > The ability to set headers must be done prior to any writing that occurs the > output stream. This is the reason why the headers are set to be configured in > the Sling Main Servlet. > With Sling being used to maintain multiple sites, having a single set of > response headers creates problems where the header provides a non tailored > response. One site may have a conflicting set of requirements then another > site. > If the setting of headers was moved from being a configuration to being a > service used by the Main Servlet, this would allow the following: > * Headers set on a per site basis > * Headers based on selected resource > * Ability to modify the headers without causing the restart of the Sling > Main Servlet > ** Which if you're dealing with CSP headers can be a constant pain > * Ability to create a CSP configuration Service that eases the use of CSP > creation > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-7760) Sling Main Servlet - Change header configuration to a service
[ https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014357#comment-17014357 ] Jason E Bailey commented on SLING-7760: --- [~cziegeler]I don't need a plugin model. What I need is: # Ability to set a header on a per site basis # Ability to change the headers without causing a restart of the Application ## This was handled by SLING-8991 Thanks! And potentially being able to set headers based on the resource. This would be convenient for setting expiration dates on assets. etc. My problem when I was working with this is that once you write to the output stream you're no longer able to modify the headers. On a per application basis I could configure a filter and make sure it would work. But for a feature of the product I couldn't come up with a better solution then to have the headers set in the Main Servlet. > Sling Main Servlet - Change header configuration to a service > - > > Key: SLING-7760 > URL: https://issues.apache.org/jira/browse/SLING-7760 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > The ability to set headers must be done prior to any writing that occurs the > output stream. This is the reason why the headers are set to be configured in > the Sling Main Servlet. > With Sling being used to maintain multiple sites, having a single set of > response headers creates problems where the header provides a non tailored > response. One site may have a conflicting set of requirements then another > site. > If the setting of headers was moved from being a configuration to being a > service used by the Main Servlet, this would allow the following: > * Headers set on a per site basis > * Headers based on selected resource > * Ability to modify the headers without causing the restart of the Sling > Main Servlet > ** Which if you're dealing with CSP headers can be a constant pain > * Ability to create a CSP configuration Service that eases the use of CSP > creation > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-8750) commons html - make it easier to add elements in a stream
[ https://issues.apache.org/jira/browse/SLING-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-8750: - Assignee: Jason E Bailey > commons html - make it easier to add elements in a stream > -- > > Key: SLING-8750 > URL: https://issues.apache.org/jira/browse/SLING-8750 > Project: Sling > Issue Type: Bug >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Commons HTML 1.2.0 > > > Add element factory as a utility to support creations of a specific type of > element -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8750) commons html - make it easier to add elements in a stream
[ https://issues.apache.org/jira/browse/SLING-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-8750: -- Fix Version/s: Commons HTML 1.2.0 > commons html - make it easier to add elements in a stream > -- > > Key: SLING-8750 > URL: https://issues.apache.org/jira/browse/SLING-8750 > Project: Sling > Issue Type: Bug >Reporter: Jason E Bailey >Priority: Major > Fix For: Commons HTML 1.2.0 > > > Add element factory as a utility to support creations of a specific type of > element -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-8750) commons html - make it easier to add elements in a stream
Jason E Bailey created SLING-8750: - Summary: commons html - make it easier to add elements in a stream Key: SLING-8750 URL: https://issues.apache.org/jira/browse/SLING-8750 Project: Sling Issue Type: Bug Reporter: Jason E Bailey Add element factory as a utility to support creations of a specific type of element -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8564) commons html - Make HTML5 parser default
[ https://issues.apache.org/jira/browse/SLING-8564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-8564: -- Fix Version/s: (was: Commons HTML 1.2.0) > commons html - Make HTML5 parser default > > > Key: SLING-8564 > URL: https://issues.apache.org/jira/browse/SLING-8564 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > > Currently two parsers are available, an HTML4 parser and an HTML5 parser. To > use of the HTML5 parser the HTML4 needs to be disabled. HTML5 should be the > priority unless the HTML4 is specifically needed. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8564) commons html - Make HTML5 parser default
[ https://issues.apache.org/jira/browse/SLING-8564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-8564. - > commons html - Make HTML5 parser default > > > Key: SLING-8564 > URL: https://issues.apache.org/jira/browse/SLING-8564 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > Fix For: Commons HTML 1.1.2 > > > Currently two parsers are available, an HTML4 parser and an HTML5 parser. To > use of the HTML5 parser the HTML4 needs to be disabled. HTML5 should be the > priority unless the HTML4 is specifically needed. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8566) commons html - document creation fails with tag stream on certain input
[ https://issues.apache.org/jira/browse/SLING-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-8566. - > commons html - document creation fails with tag stream on certain input > --- > > Key: SLING-8566 > URL: https://issues.apache.org/jira/browse/SLING-8566 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons HTML 1.1.0 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > This occurred due to a conflict between an HTML parser and a need to support > an XML interface. In HTML a processing instruction is merely an undefined > tag. Which in the SAX parser needs to be handled as a processing instruction, > except for the case where the instruction is '?xml' > Additionally the EOF tag may not be generated, so I explicitly call the end > of document for the handlers. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8566) commons html - document creation fails with tag stream on certain input
[ https://issues.apache.org/jira/browse/SLING-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-8566. --- Resolution: Won't Fix > commons html - document creation fails with tag stream on certain input > --- > > Key: SLING-8566 > URL: https://issues.apache.org/jira/browse/SLING-8566 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons HTML 1.1.0 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > This occurred due to a conflict between an HTML parser and a need to support > an XML interface. In HTML a processing instruction is merely an undefined > tag. Which in the SAX parser needs to be handled as a processing instruction, > except for the case where the instruction is '?xml' > Additionally the EOF tag may not be generated, so I explicitly call the end > of document for the handlers. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8566) commons html - document creation fails with tag stream on certain input
[ https://issues.apache.org/jira/browse/SLING-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941018#comment-16941018 ] Jason E Bailey commented on SLING-8566: --- This is only necessary if you are attempting to replace all the implementations of the HTML4 parser with the HTML5 parser which is not a workable end goal. As their are some fundamental differences between the two with Document structure. > commons html - document creation fails with tag stream on certain input > --- > > Key: SLING-8566 > URL: https://issues.apache.org/jira/browse/SLING-8566 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons HTML 1.1.0 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > This occurred due to a conflict between an HTML parser and a need to support > an XML interface. In HTML a processing instruction is merely an undefined > tag. Which in the SAX parser needs to be handled as a processing instruction, > except for the case where the instruction is '?xml' > Additionally the EOF tag may not be generated, so I explicitly call the end > of document for the handlers. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8566) commons html - document creation fails with tag stream on certain input
[ https://issues.apache.org/jira/browse/SLING-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-8566: -- Fix Version/s: (was: Commons HTML 1.1.2) > commons html - document creation fails with tag stream on certain input > --- > > Key: SLING-8566 > URL: https://issues.apache.org/jira/browse/SLING-8566 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons HTML 1.1.0 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > This occurred due to a conflict between an HTML parser and a need to support > an XML interface. In HTML a processing instruction is merely an undefined > tag. Which in the SAX parser needs to be handled as a processing instruction, > except for the case where the instruction is '?xml' > Additionally the EOF tag may not be generated, so I explicitly call the end > of document for the handlers. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Deleted] (SLING-8242) commons html - restructure internal packages
[ https://issues.apache.org/jira/browse/SLING-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey deleted SLING-8242: -- > commons html - restructure internal packages > > > Key: SLING-8242 > URL: https://issues.apache.org/jira/browse/SLING-8242 > Project: Sling > Issue Type: Bug >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > currently has two different directory structures that are not meant to be > exposed, although this doesn't cause a problem, it's potentially unclear and > should be consolidated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8242) commons html - restructure internal packages
[ https://issues.apache.org/jira/browse/SLING-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-8242: -- > commons html - restructure internal packages > > > Key: SLING-8242 > URL: https://issues.apache.org/jira/browse/SLING-8242 > Project: Sling > Issue Type: Bug >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > currently has two different directory structures that are not meant to be > exposed, although this doesn't cause a problem, it's potentially unclear and > should be consolidated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8564) commons html - Make HTML5 parser default
[ https://issues.apache.org/jira/browse/SLING-8564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-8564. --- Assignee: Jason E Bailey Resolution: Won't Fix Because of the difference between the HTML5 and HTML4 parser. The HTML4 parser is unable to create an end state Document structure. Rather it creates a Document structure that reflects the actual node structure that was passed in. Attempting to complete one with the other is unworkable. > commons html - Make HTML5 parser default > > > Key: SLING-8564 > URL: https://issues.apache.org/jira/browse/SLING-8564 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > Fix For: Commons HTML 1.1.2 > > > Currently two parsers are available, an HTML4 parser and an HTML5 parser. To > use of the HTML5 parser the HTML4 needs to be disabled. HTML5 should be the > priority unless the HTML4 is specifically needed. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8654) commons html - html5 parser doesn't handle doctype correctly
[ https://issues.apache.org/jira/browse/SLING-8654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-8654. --- Resolution: Fixed > commons html - html5 parser doesn't handle doctype correctly > - > > Key: SLING-8654 > URL: https://issues.apache.org/jira/browse/SLING-8654 > Project: Sling > Issue Type: Bug >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Commons HTML 1.1.2 > > > doctype is not handled correctly by the parser due to a regression when the > parser was refactored, it's handling the doctype like a start tag instead of > declaration. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8654) commons html - html5 parser doesn't handle doctype correctly
[ https://issues.apache.org/jira/browse/SLING-8654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-8654: -- Fix Version/s: Commons HTML 1.1.2 > commons html - html5 parser doesn't handle doctype correctly > - > > Key: SLING-8654 > URL: https://issues.apache.org/jira/browse/SLING-8654 > Project: Sling > Issue Type: Bug >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Commons HTML 1.1.2 > > > doctype is not handled correctly by the parser due to a regression when the > parser was refactored, it's handling the doctype like a start tag instead of > declaration. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-8654) commons html - html5 parser doesn't handle doctype correctly
Jason E Bailey created SLING-8654: - Summary: commons html - html5 parser doesn't handle doctype correctly Key: SLING-8654 URL: https://issues.apache.org/jira/browse/SLING-8654 Project: Sling Issue Type: Bug Reporter: Jason E Bailey Assignee: Jason E Bailey doctype is not handled correctly by the parser due to a regression when the parser was refactored, it's handling the doctype like a start tag instead of declaration. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SLING-7927) JSON Content Loading errors out import on malformed json
[ https://issues.apache.org/jira/browse/SLING-7927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902083#comment-16902083 ] Jason E Bailey commented on SLING-7927: --- [~edn] you're absolutely right, there are situations where we want to fail and then there's situations where we want it to log and proceed. So a good solution would be to come up with a way of handling both scenarios. May a `load(content)` versus a 'loadQuietly(content)` > JSON Content Loading errors out import on malformed json > > > Key: SLING-7927 > URL: https://issues.apache.org/jira/browse/SLING-7927 > Project: Sling > Issue Type: Bug >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR ContentLoader 2.3.2 > > > Current Behaviour: > During the importing of json content from a bundle. If one of the files > contains malformed json the load process is discontinued and exits. This > stops the loading of any other, correctly formatted, data. > > Expected Behaviour: > If a single file contains malformed content, that specific file should > discontinue, the error logged and then the process continues to import the > rest of the provided content. > As it is right now, it's possible to load the bundle and have the application > in an unworkable state. preventing the ability to trouble shoot and > investigate the root cause. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (SLING-7927) JSON Content Loading errors out import on malformed json
[ https://issues.apache.org/jira/browse/SLING-7927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901326#comment-16901326 ] Jason E Bailey commented on SLING-7927: --- This is definitely an issue with the Content Loader. Because this happened in AEM land. BTW the Content Loader does not use the Content Parser in the way that you would think. It embeds one or two specific files into the Content Loader bundle. > JSON Content Loading errors out import on malformed json > > > Key: SLING-7927 > URL: https://issues.apache.org/jira/browse/SLING-7927 > Project: Sling > Issue Type: Bug >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR ContentLoader 2.3.2 > > > Current Behaviour: > During the importing of json content from a bundle. If one of the files > contains malformed json the load process is discontinued and exits. This > stops the loading of any other, correctly formatted, data. > > Expected Behaviour: > If a single file contains malformed content, that specific file should > discontinue, the error logged and then the process continues to import the > rest of the provided content. > As it is right now, it's possible to load the bundle and have the application > in an unworkable state. preventing the ability to trouble shoot and > investigate the root cause. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (SLING-8588) sling site: replace css with a css framework
[ https://issues.apache.org/jira/browse/SLING-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-8588. --- Resolution: Fixed > sling site: replace css with a css framework > > > Key: SLING-8588 > URL: https://issues.apache.org/jira/browse/SLING-8588 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > Attachments: Screenshot 2019-07-22 at 16.12.39.jpg, > image-2019-07-26-08-42-45-981.png > > > Updating the sling site with a css framework. Leading to a re-design. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Closed] (SLING-8588) sling site: replace css with a css framework
[ https://issues.apache.org/jira/browse/SLING-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-8588. - merged and live > sling site: replace css with a css framework > > > Key: SLING-8588 > URL: https://issues.apache.org/jira/browse/SLING-8588 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > Attachments: Screenshot 2019-07-22 at 16.12.39.jpg, > image-2019-07-26-08-42-45-981.png > > > Updating the sling site with a css framework. Leading to a re-design. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (SLING-8588) sling site: replace css with a css framework
[ https://issues.apache.org/jira/browse/SLING-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-8588: - Assignee: Jason E Bailey > sling site: replace css with a css framework > > > Key: SLING-8588 > URL: https://issues.apache.org/jira/browse/SLING-8588 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > Attachments: Screenshot 2019-07-22 at 16.12.39.jpg, > image-2019-07-26-08-42-45-981.png > > > Updating the sling site with a css framework. Leading to a re-design. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (SLING-8588) sling site: replace css with a css framework
[ https://issues.apache.org/jira/browse/SLING-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893801#comment-16893801 ] Jason E Bailey commented on SLING-8588: --- !image-2019-07-26-08-42-45-981.png! > sling site: replace css with a css framework > > > Key: SLING-8588 > URL: https://issues.apache.org/jira/browse/SLING-8588 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Minor > Attachments: Screenshot 2019-07-22 at 16.12.39.jpg, > image-2019-07-26-08-42-45-981.png > > > Updating the sling site with a css framework. Leading to a re-design. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (SLING-8588) sling site: replace css with a css framework
[ https://issues.apache.org/jira/browse/SLING-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-8588: -- Attachment: image-2019-07-26-08-42-45-981.png > sling site: replace css with a css framework > > > Key: SLING-8588 > URL: https://issues.apache.org/jira/browse/SLING-8588 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Minor > Attachments: Screenshot 2019-07-22 at 16.12.39.jpg, > image-2019-07-26-08-42-45-981.png > > > Updating the sling site with a css framework. Leading to a re-design. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (SLING-7927) JSON Content Loading errors out import on malformed json
[ https://issues.apache.org/jira/browse/SLING-7927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891975#comment-16891975 ] Jason E Bailey commented on SLING-7927: --- I'll review and correct, the line at times between the two are odd. > JSON Content Loading errors out import on malformed json > > > Key: SLING-7927 > URL: https://issues.apache.org/jira/browse/SLING-7927 > Project: Sling > Issue Type: Bug >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR Content Parser 1.2.8 > > > Current Behaviour: > During the importing of json content from a bundle. If one of the files > contains malformed json the load process is discontinued and exits. This > stops the loading of any other, correctly formatted, data. > > Expected Behaviour: > If a single file contains malformed content, that specific file should > discontinue, the error logged and then the process continues to import the > rest of the provided content. > As it is right now, it's possible to load the bundle and have the application > in an unworkable state. preventing the ability to trouble shoot and > investigate the root cause. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (SLING-7926) JSON Content Parser should support namespace mangling
[ https://issues.apache.org/jira/browse/SLING-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7926: -- Summary: JSON Content Parser should support namespace mangling (was: JSON Content Loading should support namespace mangling) > JSON Content Parser should support namespace mangling > - > > Key: SLING-7926 > URL: https://issues.apache.org/jira/browse/SLING-7926 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR Content Parser 1.2.8 > > > Currently it's possible to define a json file with a name that matches a > mangled namespace. Which then makes the file unable to be accessed from the > ResourceResolver > i.e. importing a file `_jcr_content.json` will create the node `_jcr_content` > which cannot then be resolved as the resource resolver will attempt to > convert `_jcr_content` to `jcr:content` supporting namespace mangling will > additionally provide a cleaner `colon` support then the current > recommendation of a url mangled colon of `%3A` > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (SLING-7926) JSON Content Loading should support namespace mangling
[ https://issues.apache.org/jira/browse/SLING-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891974#comment-16891974 ] Jason E Bailey commented on SLING-7926: --- You're correct, I was looking at both of them at that time and switched names. I'll Update > JSON Content Loading should support namespace mangling > -- > > Key: SLING-7926 > URL: https://issues.apache.org/jira/browse/SLING-7926 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR Content Parser 1.2.8 > > > Currently it's possible to define a json file with a name that matches a > mangled namespace. Which then makes the file unable to be accessed from the > ResourceResolver > i.e. importing a file `_jcr_content.json` will create the node `_jcr_content` > which cannot then be resolved as the resource resolver will attempt to > convert `_jcr_content` to `jcr:content` supporting namespace mangling will > additionally provide a cleaner `colon` support then the current > recommendation of a url mangled colon of `%3A` > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (SLING-8588) sling site: replace css with a css framework
[ https://issues.apache.org/jira/browse/SLING-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890209#comment-16890209 ] Jason E Bailey commented on SLING-8588: --- Agreed. I'll get that updated. > sling site: replace css with a css framework > > > Key: SLING-8588 > URL: https://issues.apache.org/jira/browse/SLING-8588 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Minor > Attachments: Screenshot 2019-07-22 at 16.12.39.jpg > > > Updating the sling site with a css framework. Leading to a re-design. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (SLING-8588) sling site: replace css with a css framework
[ https://issues.apache.org/jira/browse/SLING-8588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888342#comment-16888342 ] Jason E Bailey commented on SLING-8588: --- replacing with the home built css with [https://bulma.io/] since I'm familiar with it now. > sling site: replace css with a css framework > > > Key: SLING-8588 > URL: https://issues.apache.org/jira/browse/SLING-8588 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Minor > > Updating the sling site with a css framework. Leading to a re-design. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (SLING-8588) sling site: replace css with a css framework
Jason E Bailey created SLING-8588: - Summary: sling site: replace css with a css framework Key: SLING-8588 URL: https://issues.apache.org/jira/browse/SLING-8588 Project: Sling Issue Type: Improvement Reporter: Jason E Bailey Updating the sling site with a css framework. Leading to a re-design. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (SLING-8271) Improve AbstractResourceVisitor to allow to stop visiting child resources
[
https://issues.apache.org/jira/browse/SLING-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883178#comment-16883178
]
Jason E Bailey commented on SLING-8271:
---
Before pulling this, I think this is a bit limited in scope and could be
improved with a Predicate object to determine the ability to descend. In a
similar way to
[https://github.com/apache/sling-org-apache-sling-resource-filter/blob/master/src/main/java/org/apache/sling/resource/filter/ResourceStream.java]
You could just extend it to accept(visitor, predicate) and that would allow you
to define a predicate inline in your source
> Improve AbstractResourceVisitor to allow to stop visiting child resources
> -
>
> Key: SLING-8271
> URL: https://issues.apache.org/jira/browse/SLING-8271
> Project: Sling
> Issue Type: Improvement
> Components: API
>Affects Versions: API 2.20.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: API 2.20.2
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently the AbstractResourceVisitor
> (https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/AbstractResourceVisitor.java)
> completely decouples the {{visit}} method from the actual resource
> traversal. That means it is currently rather hard to programmatically add a
> break condition which should lead to no further descending into child
> resources.
> I propose to extend {{AbstractResourceVisitor}} by an additional visit method
> which is supposed to return a boolean value. Only if {{true}} is returned it
> will further descend into the children of the current resource. The default
> implementation should just return {{true}} to make this change backwards
> compatible.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (SLING-8566) commons html - document creation fails with tag stream on certain input
Jason E Bailey created SLING-8566: - Summary: commons html - document creation fails with tag stream on certain input Key: SLING-8566 URL: https://issues.apache.org/jira/browse/SLING-8566 Project: Sling Issue Type: Bug Components: Commons Affects Versions: Commons HTML 1.1.0 Reporter: Jason E Bailey Assignee: Jason E Bailey Fix For: Commons HTML 1.1.2 This occurred due to a conflict between an HTML parser and a need to support an XML interface. In HTML a processing instruction is merely an undefined tag. Which in the SAX parser needs to be handled as a processing instruction, except for the case where the instruction is '?xml' Additionally the EOF tag may not be generated, so I explicitly call the end of document for the handlers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8564) commons html - Make HTML5 parser default
[ https://issues.apache.org/jira/browse/SLING-8564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879332#comment-16879332 ] Jason E Bailey commented on SLING-8564: --- Plan is to make the HTML4 parser require an OSGi Configuration. Currently testing solution in a production environment. > commons html - Make HTML5 parser default > > > Key: SLING-8564 > URL: https://issues.apache.org/jira/browse/SLING-8564 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Minor > Fix For: Commons HTML 1.1.2 > > > Currently two parsers are available, an HTML4 parser and an HTML5 parser. To > use of the HTML5 parser the HTML4 needs to be disabled. HTML5 should be the > priority unless the HTML4 is specifically needed. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8564) commons html - Make HTML5 parser default
[ https://issues.apache.org/jira/browse/SLING-8564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-8564: -- Fix Version/s: Commons HTML 1.1.2 > commons html - Make HTML5 parser default > > > Key: SLING-8564 > URL: https://issues.apache.org/jira/browse/SLING-8564 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Minor > Fix For: Commons HTML 1.1.2 > > > Currently two parsers are available, an HTML4 parser and an HTML5 parser. To > use of the HTML5 parser the HTML4 needs to be disabled. HTML5 should be the > priority unless the HTML4 is specifically needed. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8564) commons html - Make HTML5 parser default
Jason E Bailey created SLING-8564: - Summary: commons html - Make HTML5 parser default Key: SLING-8564 URL: https://issues.apache.org/jira/browse/SLING-8564 Project: Sling Issue Type: Improvement Reporter: Jason E Bailey Currently two parsers are available, an HTML4 parser and an HTML5 parser. To use of the HTML5 parser the HTML4 needs to be disabled. HTML5 should be the priority unless the HTML4 is specifically needed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8243) Content Loader - support merge of properties and child nodes
[ https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-8243. --- Resolution: Fixed > Content Loader - support merge of properties and child nodes > > > Key: SLING-8243 > URL: https://issues.apache.org/jira/browse/SLING-8243 > Project: Sling > Issue Type: New Feature >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR ContentLoader 2.3.2 > > > Currently the Content Loader doesn't support a merge feature, a merge feature > would provide the ability for the an import to update existing properties and > nodes, and additionally delete the specific properties and nodes that aren't > imported. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837247#comment-16837247 ] Jason E Bailey commented on SLING-8407: --- [~tmueller] Allow me to provide a thought exercise. Which is faster? To run a query to find the children of a specific node, or to call node.getChildren()? From all of my experience and testing it's the getChildren() function. There is no doubt that if you don't know where the data is, that running a properly tuned indexed search is the fast and efficient way to go. However if you all the nodes are in one place or in one specific tree structure. Then you're not really gaining anything. For jobs, at least the implementation I have, everything is under /var/eventing/jobs. > I assume with "oak traversal" you mean "tree traversal within the query > engine", and with "tree traversal" you mean traversing a tree using the JCR > API (getNodes,...). I'll admit I haven't had the time to dive into oak as much as I'd like. I've seen a lot of strange things come out of oak as a result. I've had my whole system go down once because it was returning a result set, but every time I asked for the next item in the result set it was actually performing the query again. So I'll take your word on this. In a real world scenario, I use [https://github.com/apache/sling-org-apache-sling-resource-filter] ,which I wrote, in multiple production environments and the teams I've worked with have found that using this has had no negative impact on performance. Which brings me back to this bundle, if there is an issue where the index may not be available and you can do it efficiently without an index. Don't use an index. > JobManagerImpl.findJobs should prevent traversal > > > Key: SLING-8407 > URL: https://issues.apache.org/jira/browse/SLING-8407 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Thomas Mueller >Priority: Major > > The method > [JobManagerImpl.findJobs|https://github.com/apache/sling-org-apache-sling-event/blob/master/src/main/java/org/apache/sling/event/impl/jobs/JobManagerImpl.java#L373] > runs a JCR query to find all jobs for a topic. > It is possible that such a query is running while the repository isn't > initialized yet, meaning while the index isn't available yet. What is > happening in this case is that the query is traversing all nodes below that > path, triggering a warning that the query doesn't use an index. It is > sometimes happening when a health check is running before the repository is > initialized (ReplicationQueueHealthCheck and DistributionQueueHealthCheck). > It doesn't make sense that the query traverses the nodes. It should use an > index. If the index isn't available yet, it should fail. Therefore, the query > should use "option(traversal fail)". That would result in an exception that > can be caught. I will log a related issue to change the health checks to > process this exception and return HEALTH_CHECK_ERROR for this case. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836568#comment-16836568 ] Jason E Bailey commented on SLING-8407: --- If I remember correctly, jobs are stored in a specific location. I don't think this is a case where a query is even needed. We have utilities to filter and select child nodes from a path which utilizes a tree traversal, which is not the same as an oak traversal. Implementing a filter like that would prevent this issue and also make it independent of the type of repository that underlies the data store. Without sacrificing speed or efficiency. > JobManagerImpl.findJobs should prevent traversal > > > Key: SLING-8407 > URL: https://issues.apache.org/jira/browse/SLING-8407 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Thomas Mueller >Priority: Major > > The method > [JobManagerImpl.findJobs|https://github.com/apache/sling-org-apache-sling-event/blob/master/src/main/java/org/apache/sling/event/impl/jobs/JobManagerImpl.java#L373] > runs a JCR query to find all jobs for a topic. > It is possible that such a query is running while the repository isn't > initialized yet, meaning while the index isn't available yet. What is > happening in this case is that the query is traversing all nodes below that > path, triggering a warning that the query doesn't use an index. It is > sometimes happening when a health check is running before the repository is > initialized (ReplicationQueueHealthCheck and DistributionQueueHealthCheck). > It doesn't make sense that the query traverses the nodes. It should use an > index. If the index isn't available yet, it should fail. Therefore, the query > should use "option(traversal fail)". That would result in an exception that > can be caught. I will log a related issue to change the health checks to > process this exception and return HEALTH_CHECK_ERROR for this case. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8276) Improve the HtmlResponse template
[ https://issues.apache.org/jira/browse/SLING-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769319#comment-16769319 ] Jason E Bailey commented on SLING-8276: --- That was a rather quick won't fix > Improve the HtmlResponse template > - > > Key: SLING-8276 > URL: https://issues.apache.org/jira/browse/SLING-8276 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Antonio Sanso >Assignee: Antonio Sanso >Priority: Minor > > it would be good to improve the HtmlResponse template -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8243) Content Loader - support merge of properties and child nodes
Jason E Bailey created SLING-8243: - Summary: Content Loader - support merge of properties and child nodes Key: SLING-8243 URL: https://issues.apache.org/jira/browse/SLING-8243 Project: Sling Issue Type: New Feature Reporter: Jason E Bailey Assignee: Jason E Bailey Fix For: JCR ContentLoader 2.3.2 Currently the Content Loader doesn't support a merge feature, a merge feature would provide the ability for the an import to update existing properties and nodes, and additionally delete the specific properties and nodes that aren't imported. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8242) commons html - restructure internal packages
Jason E Bailey created SLING-8242: - Summary: commons html - restructure internal packages Key: SLING-8242 URL: https://issues.apache.org/jira/browse/SLING-8242 Project: Sling Issue Type: Bug Reporter: Jason E Bailey Assignee: Jason E Bailey Fix For: Commons HTML 1.1.2 currently has two different directory structures that are not meant to be exposed, although this doesn't cause a problem, it's potentially unclear and should be consolidated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7751) Commons Html - Underlying parser implementation may use system charset
[ https://issues.apache.org/jira/browse/SLING-7751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7751: -- Summary: Commons Html - Underlying parser implementation may use system charset (was: Commons Html - Underlying parser implementation uses system charset) > Commons Html - Underlying parser implementation may use system charset > -- > > Key: SLING-7751 > URL: https://issues.apache.org/jira/browse/SLING-7751 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > Fix For: Commons HTML 1.0.4 > > > While re-writing the underlying tagsoup library I discovered that, by > default, the internal InputStreamReader is created with the system default > charset. > This can be overridden with a custom AutoDetector. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-3270) html-generator to support html5
[ https://issues.apache.org/jira/browse/SLING-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-3270. --- Resolution: Fixed > html-generator to support html5 > --- > > Key: SLING-3270 > URL: https://issues.apache.org/jira/browse/SLING-3270 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Rewriter 1.0.2 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Commons HTML 1.0.4 > > Attachments: 218.patch > > > Given the following fragment of HTML > > This is invalid html4 and valid html5, as html5 allows anchor tags to contain > block elements. > The current html-generator corrects the bad html4 and produces the following > output > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7663) convert site to HTML5 specification
[ https://issues.apache.org/jira/browse/SLING-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726800#comment-16726800 ] Jason E Bailey commented on SLING-7663: --- one of the items that currently fails in the HTML5 validation tests are anchors that use the name attribute rather than the id attribute. This is a result of the markdown processor that is fixed in the latest version of JBake. Once the upgrade to the newest version occurs, this item will be resolved. > convert site to HTML5 specification > --- > > Key: SLING-7663 > URL: https://issues.apache.org/jira/browse/SLING-7663 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > > Utilizing validation tools such as > [https://validator.w3.org|https://validator.w3.org/] validate that the site > is providing HTML correctly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8190) App CMS - Update Rava JS
[ https://issues.apache.org/jira/browse/SLING-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-8190. --- Resolution: Fixed Update is completed > App CMS - Update Rava JS > > > Key: SLING-8190 > URL: https://issues.apache.org/jira/browse/SLING-8190 > Project: Sling > Issue Type: Improvement > Components: App CMS >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > Fix For: Version App CMS 0.11.4 > > > Update to the newest Rava implementation, update API accordingly -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8190) App CMS - Update Rava JS
Jason E Bailey created SLING-8190: - Summary: App CMS - Update Rava JS Key: SLING-8190 URL: https://issues.apache.org/jira/browse/SLING-8190 Project: Sling Issue Type: Improvement Components: App CMS Reporter: Jason E Bailey Assignee: Jason E Bailey Fix For: Version App CMS 0.11.4 Update to the newest Rava implementation, update API accordingly -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8175) Site - Modify side bar navigation
[ https://issues.apache.org/jira/browse/SLING-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723040#comment-16723040 ] Jason E Bailey commented on SLING-8175: --- [~bdelacretaz] could you look again? I checked locally and saw the same problem. However I changed the css to fix this when I did the initial release, it then appeared to have reverted for some reason.. github had my correct settings but there was a different set of CSS being pulled to the site. Now, without me appearing to do anything, it looks correct again. > Site - Modify side bar navigation > - > > Key: SLING-8175 > URL: https://issues.apache.org/jira/browse/SLING-8175 > Project: Sling > Issue Type: Improvement > Components: Site >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > Attachments: firefox-macosx.jpg > > > Current navigation bar does not provide visual guidance as to what is a link > and what is a title of a series of links. This creates confusion and hinders > navigation. Additional navigation bar should be using the nav element to > provide context for navigation with electronic assistance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8175) Site - Modify side bar navigation
[ https://issues.apache.org/jira/browse/SLING-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723031#comment-16723031 ] Jason E Bailey commented on SLING-8175: --- Fascinating. Thanks for pointing this out. I'll try to determine why that is showing up differently then expected and fix that. > Site - Modify side bar navigation > - > > Key: SLING-8175 > URL: https://issues.apache.org/jira/browse/SLING-8175 > Project: Sling > Issue Type: Improvement > Components: Site >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > Attachments: firefox-macosx.jpg > > > Current navigation bar does not provide visual guidance as to what is a link > and what is a title of a series of links. This creates confusion and hinders > navigation. Additional navigation bar should be using the nav element to > provide context for navigation with electronic assistance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8175) Site - Modify side bar navigation
[ https://issues.apache.org/jira/browse/SLING-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-8175. --- Resolution: Fixed > Site - Modify side bar navigation > - > > Key: SLING-8175 > URL: https://issues.apache.org/jira/browse/SLING-8175 > Project: Sling > Issue Type: Improvement > Components: Site >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > > Current navigation bar does not provide visual guidance as to what is a link > and what is a title of a series of links. This creates confusion and hinders > navigation. Additional navigation bar should be using the nav element to > provide context for navigation with electronic assistance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-8175) Site - Modify side bar navigation
[ https://issues.apache.org/jira/browse/SLING-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-8175. - > Site - Modify side bar navigation > - > > Key: SLING-8175 > URL: https://issues.apache.org/jira/browse/SLING-8175 > Project: Sling > Issue Type: Improvement > Components: Site >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > > Current navigation bar does not provide visual guidance as to what is a link > and what is a title of a series of links. This creates confusion and hinders > navigation. Additional navigation bar should be using the nav element to > provide context for navigation with electronic assistance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8175) Site - Modify side bar navigation
Jason E Bailey created SLING-8175: - Summary: Site - Modify side bar navigation Key: SLING-8175 URL: https://issues.apache.org/jira/browse/SLING-8175 Project: Sling Issue Type: Improvement Components: Site Reporter: Jason E Bailey Assignee: Jason E Bailey Current navigation bar does not provide visual guidance as to what is a link and what is a title of a series of links. This creates confusion and hinders navigation. Additional navigation bar should be using the nav element to provide context for navigation with electronic assistance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-8155) AuthRequestLoginTest and SlingSessionInfoTest fail with org.mozilla.javascript.EvaluatorException: syntax error
[
https://issues.apache.org/jira/browse/SLING-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason E Bailey closed SLING-8155.
-
> AuthRequestLoginTest and SlingSessionInfoTest fail with
> org.mozilla.javascript.EvaluatorException: syntax error
> ---
>
> Key: SLING-8155
> URL: https://issues.apache.org/jira/browse/SLING-8155
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.40
>
>
> Sometimes after Sling 11 we started getting IT failures does to JS errors
> when evaluated on the client side, in the ITs:
> {noformat}[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 0.007 s <<< FAILURE! - in
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest
> [ERROR]
> testForcedLogin(org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest)
> Time elapsed: 0.007 s <<< ERROR!
> java.io.IOException: While executing
> [out.println(data.userID)]:org.mozilla.javascript.EvaluatorException: syntax
> error (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.testForcedLogin(AuthRequestLoginTest.java:41)
> Caused by: org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.testForcedLogin(AuthRequestLoginTest.java:41)
> [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.006
> s <<< FAILURE! - in
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest
> [ERROR]
> testSessionInfo(org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest)
> Time elapsed: 0.001 s <<< ERROR!
> java.io.IOException: While executing [out.println(data.userID + '.' + typeof
> data.authType)]:org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest.testSessionInfo(SlingSessionInfoTest.java:35)
> Caused by: org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest.testSessionInfo(SlingSessionInfoTest.java:35)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8155) AuthRequestLoginTest and SlingSessionInfoTest fail with org.mozilla.javascript.EvaluatorException: syntax error
[
https://issues.apache.org/jira/browse/SLING-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason E Bailey resolved SLING-8155.
---
Resolution: Fixed
> AuthRequestLoginTest and SlingSessionInfoTest fail with
> org.mozilla.javascript.EvaluatorException: syntax error
> ---
>
> Key: SLING-8155
> URL: https://issues.apache.org/jira/browse/SLING-8155
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.40
>
>
> Sometimes after Sling 11 we started getting IT failures does to JS errors
> when evaluated on the client side, in the ITs:
> {noformat}[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 0.007 s <<< FAILURE! - in
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest
> [ERROR]
> testForcedLogin(org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest)
> Time elapsed: 0.007 s <<< ERROR!
> java.io.IOException: While executing
> [out.println(data.userID)]:org.mozilla.javascript.EvaluatorException: syntax
> error (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.testForcedLogin(AuthRequestLoginTest.java:41)
> Caused by: org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.testForcedLogin(AuthRequestLoginTest.java:41)
> [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.006
> s <<< FAILURE! - in
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest
> [ERROR]
> testSessionInfo(org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest)
> Time elapsed: 0.001 s <<< ERROR!
> java.io.IOException: While executing [out.println(data.userID + '.' + typeof
> data.authType)]:org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest.testSessionInfo(SlingSessionInfoTest.java:35)
> Caused by: org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest.testSessionInfo(SlingSessionInfoTest.java:35)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (SLING-8155) AuthRequestLoginTest and SlingSessionInfoTest fail with org.mozilla.javascript.EvaluatorException: syntax error
[
https://issues.apache.org/jira/browse/SLING-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason E Bailey reassigned SLING-8155:
-
Assignee: Jason E Bailey (was: Radu Cotescu)
> AuthRequestLoginTest and SlingSessionInfoTest fail with
> org.mozilla.javascript.EvaluatorException: syntax error
> ---
>
> Key: SLING-8155
> URL: https://issues.apache.org/jira/browse/SLING-8155
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
>
> Sometimes after Sling 11 we started getting IT failures does to JS errors
> when evaluated on the client side, in the ITs:
> {noformat}[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 0.007 s <<< FAILURE! - in
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest
> [ERROR]
> testForcedLogin(org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest)
> Time elapsed: 0.007 s <<< ERROR!
> java.io.IOException: While executing
> [out.println(data.userID)]:org.mozilla.javascript.EvaluatorException: syntax
> error (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.testForcedLogin(AuthRequestLoginTest.java:41)
> Caused by: org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.testForcedLogin(AuthRequestLoginTest.java:41)
> [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.006
> s <<< FAILURE! - in
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest
> [ERROR]
> testSessionInfo(org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest)
> Time elapsed: 0.001 s <<< ERROR!
> java.io.IOException: While executing [out.println(data.userID + '.' + typeof
> data.authType)]:org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest.testSessionInfo(SlingSessionInfoTest.java:35)
> Caused by: org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest.testSessionInfo(SlingSessionInfoTest.java:35)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8155) AuthRequestLoginTest and SlingSessionInfoTest fail with org.mozilla.javascript.EvaluatorException: syntax error
[
https://issues.apache.org/jira/browse/SLING-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707656#comment-16707656
]
Jason E Bailey commented on SLING-8155:
---
The issue with the info.sessionInfo.json has to do with the use of the
JsonGenerator that I switched too.
When I initially implemented this, I closed the JsonGenerator when I finished.
This created a problem where it closed the underlying response writer, which
was then attempted to be closed later. So I changed the code to leave the
JsonGenerator unclosed so that it wouldn't close the response writer.
This then has created an issue, where the JsonGenerator isn't flushing it's
buffer to the response writer and that's why there's no response being written.
Note that this is at the JsonGenerator implementation level. If I flush the
underlying response writer, it doesn't help.
Still working on best solution for this.
> AuthRequestLoginTest and SlingSessionInfoTest fail with
> org.mozilla.javascript.EvaluatorException: syntax error
> ---
>
> Key: SLING-8155
> URL: https://issues.apache.org/jira/browse/SLING-8155
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Reporter: Robert Munteanu
>Assignee: Radu Cotescu
>Priority: Major
>
> Sometimes after Sling 11 we started getting IT failures does to JS errors
> when evaluated on the client side, in the ITs:
> {noformat}[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 0.007 s <<< FAILURE! - in
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest
> [ERROR]
> testForcedLogin(org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest)
> Time elapsed: 0.007 s <<< ERROR!
> java.io.IOException: While executing
> [out.println(data.userID)]:org.mozilla.javascript.EvaluatorException: syntax
> error (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.testForcedLogin(AuthRequestLoginTest.java:41)
> Caused by: org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.testForcedLogin(AuthRequestLoginTest.java:41)
> [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.006
> s <<< FAILURE! - in
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest
> [ERROR]
> testSessionInfo(org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest)
> Time elapsed: 0.001 s <<< ERROR!
> java.io.IOException: While executing [out.println(data.userID + '.' + typeof
> data.authType)]:org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest.testSessionInfo(SlingSessionInfoTest.java:35)
> Caused by: org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest.testSessionInfo(SlingSessionInfoTest.java:35)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8155) AuthRequestLoginTest and SlingSessionInfoTest fail with org.mozilla.javascript.EvaluatorException: syntax error
[
https://issues.apache.org/jira/browse/SLING-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707659#comment-16707659
]
Jason E Bailey commented on SLING-8155:
---
This same issue is what's causing the CreateUserTest to fail
> AuthRequestLoginTest and SlingSessionInfoTest fail with
> org.mozilla.javascript.EvaluatorException: syntax error
> ---
>
> Key: SLING-8155
> URL: https://issues.apache.org/jira/browse/SLING-8155
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Reporter: Robert Munteanu
>Assignee: Radu Cotescu
>Priority: Major
>
> Sometimes after Sling 11 we started getting IT failures does to JS errors
> when evaluated on the client side, in the ITs:
> {noformat}[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time
> elapsed: 0.007 s <<< FAILURE! - in
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest
> [ERROR]
> testForcedLogin(org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest)
> Time elapsed: 0.007 s <<< ERROR!
> java.io.IOException: While executing
> [out.println(data.userID)]:org.mozilla.javascript.EvaluatorException: syntax
> error (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.testForcedLogin(AuthRequestLoginTest.java:41)
> Caused by: org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.testForcedLogin(AuthRequestLoginTest.java:41)
> [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.006
> s <<< FAILURE! - in
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest
> [ERROR]
> testSessionInfo(org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest)
> Time elapsed: 0.001 s <<< ERROR!
> java.io.IOException: While executing [out.println(data.userID + '.' + typeof
> data.authType)]:org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest.testSessionInfo(SlingSessionInfoTest.java:35)
> Caused by: org.mozilla.javascript.EvaluatorException: syntax error
> (JavascriptEngine#1)
> at
> org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest.testSessionInfo(SlingSessionInfoTest.java:35)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-3270) html-generator to support html5
[ https://issues.apache.org/jira/browse/SLING-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703361#comment-16703361 ] Jason E Bailey commented on SLING-3270: --- Adding a new HTML5 parser implementation the commons bundle > html-generator to support html5 > --- > > Key: SLING-3270 > URL: https://issues.apache.org/jira/browse/SLING-3270 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Rewriter 1.0.2 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Commons HTML 1.0.4 > > Attachments: 218.patch > > > Given the following fragment of HTML > > This is invalid html4 and valid html5, as html5 allows anchor tags to contain > block elements. > The current html-generator corrects the bad html4 and produces the following > output > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-3270) html-generator to support html5
[ https://issues.apache.org/jira/browse/SLING-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-3270: -- Fix Version/s: Commons HTML 1.0.4 > html-generator to support html5 > --- > > Key: SLING-3270 > URL: https://issues.apache.org/jira/browse/SLING-3270 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Rewriter 1.0.2 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: Commons HTML 1.0.4 > > Attachments: 218.patch > > > Given the following fragment of HTML > > This is invalid html4 and valid html5, as html5 allows anchor tags to contain > block elements. > The current html-generator corrects the bad html4 and produces the following > output > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8116) ValueMap - implement default methods using OSGI Converter
[ https://issues.apache.org/jira/browse/SLING-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-8116: -- Fix Version/s: API 2.18.6 > ValueMap - implement default methods using OSGI Converter > - > > Key: SLING-8116 > URL: https://issues.apache.org/jira/browse/SLING-8116 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: API 2.18.6 > > Time Spent: 20m > Remaining Estimate: 0h > > Implement default methods in the ValueMap interface that leverages the OSGi > Converter > see > [https://osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html] > Once this is implemented, custom implementations of the ValueMap interface > can start being removed, where appropriate, so that a consistent and > comprehensive conversion of properties occur. We can then add new Rules to > the Converter to allow features to be populated to all ValueMap > implementations. > > To implement this, the following will also need to happen > * The Converter bundle will need to be added as a required bundle > ** Various scripts that define the minimum needed set of bundles will need > to be updated > * Communication on the difference in behaviour between the current ValueMap > and the ValueMap with Converter > * Although not within the Maven definition. org.osgi.util.Function needs to > be available as well for the Converter to initiate correctly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-8116) ValueMap - implement default methods using OSGI Converter
[ https://issues.apache.org/jira/browse/SLING-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-8116: - Assignee: Jason E Bailey > ValueMap - implement default methods using OSGI Converter > - > > Key: SLING-8116 > URL: https://issues.apache.org/jira/browse/SLING-8116 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Implement default methods in the ValueMap interface that leverages the OSGi > Converter > see > [https://osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html] > Once this is implemented, custom implementations of the ValueMap interface > can start being removed, where appropriate, so that a consistent and > comprehensive conversion of properties occur. We can then add new Rules to > the Converter to allow features to be populated to all ValueMap > implementations. > > To implement this, the following will also need to happen > * The Converter bundle will need to be added as a required bundle > ** Various scripts that define the minimum needed set of bundles will need > to be updated > * Communication on the difference in behaviour between the current ValueMap > and the ValueMap with Converter > * Although not within the Maven definition. org.osgi.util.Function needs to > be available as well for the Converter to initiate correctly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7934) Add the ability for a resource to adapt to a JSONObject
[ https://issues.apache.org/jira/browse/SLING-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey closed SLING-7934. - > Add the ability for a resource to adapt to a JSONObject > --- > > Key: SLING-7934 > URL: https://issues.apache.org/jira/browse/SLING-7934 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > There are multiple implementations all doing the same process of converting a > resource to a JSONObject. If it's that common we should just add the ability > to adapt the resource and centralize the implementation so that it's > consistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7934) Add the ability for a resource to adapt to a JSONObject
[ https://issues.apache.org/jira/browse/SLING-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-7934. --- Resolution: Won't Fix Based on feedback, the eventual goal that would be cleaner is to allow the ValueMap to retreive properties as a JSONValue which would be an extension on the OSGI Converter, closing this story. > Add the ability for a resource to adapt to a JSONObject > --- > > Key: SLING-7934 > URL: https://issues.apache.org/jira/browse/SLING-7934 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > There are multiple implementations all doing the same process of converting a > resource to a JSONObject. If it's that common we should just add the ability > to adapt the resource and centralize the implementation so that it's > consistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8116) ValueMap - implement default methods using OSGI Converter
[ https://issues.apache.org/jira/browse/SLING-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-8116: -- Description: Implement default methods in the ValueMap interface that leverages the OSGi Converter see [https://osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html] Once this is implemented, custom implementations of the ValueMap interface can start being removed, where appropriate, so that a consistent and comprehensive conversion of properties occur. We can then add new Rules to the Converter to allow features to be populated to all ValueMap implementations. To implement this, the following will also need to happen * The Converter bundle will need to be added as a required bundle ** Various scripts that define the minimum needed set of bundles will need to be updated * Communication on the difference in behaviour between the current ValueMap and the ValueMap with Converter * Although not within the Maven definition. org.osgi.util.Function needs to be available as well for the Converter to initiate correctly. was: Implement default methods in the ValueMap interface that leverages the OSGi Converter see [https://osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html] Once this is implemented, custom implementations of the ValueMap interface can start being removed, where appropriate, so that a consistent and comprehensive conversion of properties occur. We can then add new Rules to the Converter to allow features to be populated to all ValueMap implementations. To implement this, the following will also need to happen * The Converter bundle will need to be added as a required bundle ** Various scripts that define the minimum needed set of bundles will need to be updated * Communication on the difference in behaviour between the current ValueMap and the ValueMap with Converter > ValueMap - implement default methods using OSGI Converter > - > > Key: SLING-8116 > URL: https://issues.apache.org/jira/browse/SLING-8116 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Major > > Implement default methods in the ValueMap interface that leverages the OSGi > Converter > see > [https://osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html] > Once this is implemented, custom implementations of the ValueMap interface > can start being removed, where appropriate, so that a consistent and > comprehensive conversion of properties occur. We can then add new Rules to > the Converter to allow features to be populated to all ValueMap > implementations. > > To implement this, the following will also need to happen > * The Converter bundle will need to be added as a required bundle > ** Various scripts that define the minimum needed set of bundles will need > to be updated > * Communication on the difference in behaviour between the current ValueMap > and the ValueMap with Converter > * Although not within the Maven definition. org.osgi.util.Function needs to > be available as well for the Converter to initiate correctly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8116) ValueMap - implement default methods using OSGI Converter
[ https://issues.apache.org/jira/browse/SLING-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691968#comment-16691968 ] Jason E Bailey commented on SLING-8116: --- Changes that are occurring Will return null when converting an existing array to an unsupported Type. Support the autoboxing to primitive arrays during conversion Will return a null when converting a missing property to an array Will return true for a conversion of a char or number that is not '0' to a Boolean Will return false for any value that can not be converted to Boolean.TRUE Will return false for a null property > ValueMap - implement default methods using OSGI Converter > - > > Key: SLING-8116 > URL: https://issues.apache.org/jira/browse/SLING-8116 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Major > > Implement default methods in the ValueMap interface that leverages the OSGi > Converter > see > [https://osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html] > Once this is implemented, custom implementations of the ValueMap interface > can start being removed, where appropriate, so that a consistent and > comprehensive conversion of properties occur. We can then add new Rules to > the Converter to allow features to be populated to all ValueMap > implementations. > > To implement this, the following will also need to happen > * The Converter bundle will need to be added as a required bundle > ** Various scripts that define the minimum needed set of bundles will need > to be updated > * Communication on the difference in behaviour between the current ValueMap > and the ValueMap with Converter > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-8116) ValueMap - implement default methods using OSGI Converter
[ https://issues.apache.org/jira/browse/SLING-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-8116: -- Summary: ValueMap - implement default methods using OSGI Converter (was: ValueMap - implement default methods using Osgi Converter) > ValueMap - implement default methods using OSGI Converter > - > > Key: SLING-8116 > URL: https://issues.apache.org/jira/browse/SLING-8116 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Major > > Implement default methods in the ValueMap interface that leverages the OSGi > Converter > see > [https://osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html] > Once this is implemented, custom implementations of the ValueMap interface > can start being removed, where appropriate, so that a consistent and > comprehensive conversion of properties occur. We can then add new Rules to > the Converter to allow features to be populated to all ValueMap > implementations. > > To implement this, the following will also need to happen > * The Converter bundle will need to be added as a required bundle > ** Various scripts that define the minimum needed set of bundles will need > to be updated > * Communication on the difference in behaviour between the current ValueMap > and the ValueMap with Converter > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8116) ValueMap - implement default methods using Osgi Converter
Jason E Bailey created SLING-8116: - Summary: ValueMap - implement default methods using Osgi Converter Key: SLING-8116 URL: https://issues.apache.org/jira/browse/SLING-8116 Project: Sling Issue Type: Improvement Reporter: Jason E Bailey Implement default methods in the ValueMap interface that leverages the OSGi Converter see [https://osgi.org/specification/osgi.cmpn/7.0.0/util.converter.html] Once this is implemented, custom implementations of the ValueMap interface can start being removed, where appropriate, so that a consistent and comprehensive conversion of properties occur. We can then add new Rules to the Converter to allow features to be populated to all ValueMap implementations. To implement this, the following will also need to happen * The Converter bundle will need to be added as a required bundle ** Various scripts that define the minimum needed set of bundles will need to be updated * Communication on the difference in behaviour between the current ValueMap and the ValueMap with Converter -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7934) Add the ability for a resource to adapt to a JSONObject
[ https://issues.apache.org/jira/browse/SLING-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688051#comment-16688051 ] Jason E Bailey commented on SLING-7934: --- By converting the get(string,class) method to a default method in the interface? One that uses the converter. Then we modify the implementations where we can to use the default method. We couldn't stop people overwriting that but it becomes less likely. > Add the ability for a resource to adapt to a JSONObject > --- > > Key: SLING-7934 > URL: https://issues.apache.org/jira/browse/SLING-7934 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > There are multiple implementations all doing the same process of converting a > resource to a JSONObject. If it's that common we should just add the ability > to adapt the resource and centralize the implementation so that it's > consistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7934) Add the ability for a resource to adapt to a JSONObject
[ https://issues.apache.org/jira/browse/SLING-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686926#comment-16686926 ] Jason E Bailey commented on SLING-7934: --- I tend to have long conversations in my head and then come out with a statement that has a fully reasoned path that no one else follows. That's relevant here and I'm working on it. I wouldn't go with the .getJSONType() Because it's too specific to JSON and there's a part of me that bulks at doing a double lookup in a map, one to find the object and then another to get it's type. The problem comes back to is that a Map is really wider then what we use or need. From a resource perspective the value is either a String, Number, Boolean, or an Instant/Calendar object with array support. So my own stupid proposal would be, that if I had to change the ValueMap object I would rather change it to a Map which most people would never notice, because they are requesting a specific class type when they do their get. The change, however, would be really useful to anyone who needs to introspect the value type during processing. You could then do things such as ResourceValue.isArray() ResourceValue.getType() <- prefer an enum here ResourceValue.getOriginalType() ResourceValue.getValue() Though that could be implemented as part of existing interface as a supported type that internal conversions handle. meaning that it stays but you could just do a .get(mykey, ResourceValue.class). Of course now I just typed all of this and I just had this moment of "woah" cause we could probably do .get(myKey,JsonValue.class) as well and then you would have to go through half the work that you otherwise would need to,. > Add the ability for a resource to adapt to a JSONObject > --- > > Key: SLING-7934 > URL: https://issues.apache.org/jira/browse/SLING-7934 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > There are multiple implementations all doing the same process of converting a > resource to a JSONObject. If it's that common we should just add the ability > to adapt the resource and centralize the implementation so that it's > consistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7934) Add the ability for a resource to adapt to a JSONObject
[ https://issues.apache.org/jira/browse/SLING-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686583#comment-16686583 ] Jason E Bailey commented on SLING-7934: --- So here is a real world scenario that I currently deal with. * I have form submissions that come in and get stored as resources * I then process those resources through a workflow. * One of the final steps of the workflow is to take the content of the resource as it is and send it as json object to an internal message queue. With your input, which I really appreciate, I don't think the adaptTo solution would work. However I feel the current process of converting a resource to JSON is to cumbersome. We have an explicit set of possible value types that we work with in a map. I feel there should be a solution somewhere, maybe a utility, that takes a generic Map and converts it to JSON. > Add the ability for a resource to adapt to a JSONObject > --- > > Key: SLING-7934 > URL: https://issues.apache.org/jira/browse/SLING-7934 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > There are multiple implementations all doing the same process of converting a > resource to a JSONObject. If it's that common we should just add the ability > to adapt the resource and centralize the implementation so that it's > consistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7934) Add the ability for a resource to adapt to a JSONObject
[ https://issues.apache.org/jira/browse/SLING-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684342#comment-16684342 ] Jason E Bailey commented on SLING-7934: --- I'm not sure what you're definition of easily done is in this case. There's a whole class, org.apache.sling.servlets.get.impl.util.JsonObjectCreator, which was created to convert a resource to a JsonObject via a ValueMap and that is an internal class. If someone would like to do the same thing they would need to copy this class over or write their own. > Add the ability for a resource to adapt to a JSONObject > --- > > Key: SLING-7934 > URL: https://issues.apache.org/jira/browse/SLING-7934 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > There are multiple implementations all doing the same process of converting a > resource to a JSONObject. If it's that common we should just add the ability > to adapt the resource and centralize the implementation so that it's > consistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-8011) Accessing the info.sessionInfo.json endpoint always logs an error: Writer has already been closed
[
https://issues.apache.org/jira/browse/SLING-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason E Bailey resolved SLING-8011.
---
Resolution: Fixed
> Accessing the info.sessionInfo.json endpoint always logs an error: Writer has
> already been closed
> -
>
> Key: SLING-8011
> URL: https://issues.apache.org/jira/browse/SLING-8011
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.38
>
>
> I noticed that the Sling starter logs are full of errors regarding an already
> closed writer. Taking a closer look, I think the root cause is the fix for
> SLING-7795 - now the response writer is being and then a flush call is issues.
> {noformat}13.10.2018 01:02:12.584 *ERROR* [0:0:0:0:0:0:0:1 [1539381732583]
> GET /system/sling/info.sessionInfo.json HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl Writer has already
> been closed.
> org.apache.sling.engine.impl.SlingHttpServletResponseImpl$WriterAlreadyClosedException:
> null
> at
> org.apache.sling.engine.impl.SlingHttpServletResponseImpl$1.checkClosed(SlingHttpServletResponseImpl.java:190)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingHttpServletResponseImpl$1.flush(SlingHttpServletResponseImpl.java:227)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.servlets.get.impl.SlingInfoServlet.renderJson(SlingInfoServlet.java:122)
> [org.apache.sling.servlets.get:2.1.36]
> at
> org.apache.sling.servlets.get.impl.SlingInfoServlet.doGet(SlingInfoServlet.java:96)
> [org.apache.sling.servlets.get:2.1.36]
> at
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
> [org.apache.sling.api:2.18.4]
> at
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
> [org.apache.sling.api:2.18.4]
> at
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
> [org.apache.sling.api:2.18.4]
> at
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
> [org.apache.sling.engine:2.6.14]
> at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
> [org.apache.sling.i18n:2.5.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
> [org.apache.felix.http.jetty:4.0.6]
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
> [org.apache.felix.http.jetty:4.0.6]
> at
> org.apache.felix.http.sslfilter.internal.SslFilter.doFilter(SslFilter.java:96)
> [org.apache.felix.http.sslfilter:1.2.4]
> at
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> [org.apache.felix.http.jetty:4.0.6]
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
> [org.apache.felix.http.jetty:4.0.6]
> at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>
[jira] [Resolved] (SLING-8062) CMS - UI move modal structure to resource
[ https://issues.apache.org/jira/browse/SLING-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-8062. --- Resolution: Fixed > CMS - UI move modal structure to resource > - > > Key: SLING-8062 > URL: https://issues.apache.org/jira/browse/SLING-8062 > Project: Sling > Issue Type: Improvement > Components: App CMS >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Minor > Fix For: App CMS 0.10.2 > > > Currently requests for a modal page is wrapped with the html to structure the > modal from the client side. a new modal page template has been created, and > the modal structure can be placed in that, reducing javascript. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8063) CMS - UI restructure action resources
Jason E Bailey created SLING-8063: - Summary: CMS - UI restructure action resources Key: SLING-8063 URL: https://issues.apache.org/jira/browse/SLING-8063 Project: Sling Issue Type: Improvement Components: App CMS Reporter: Jason E Bailey Assignee: Jason E Bailey Fix For: App CMS 0.10.2 Currently modals which represent actions are individually located under specific views. By separating these out to a structure which represents all the actions allows us to create a single location where we can view all potential actions and cognitively separates them from a view. Making the actions independent end points. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-8062) CMS - UI move modal structure to resource
Jason E Bailey created SLING-8062: - Summary: CMS - UI move modal structure to resource Key: SLING-8062 URL: https://issues.apache.org/jira/browse/SLING-8062 Project: Sling Issue Type: Improvement Components: App CMS Reporter: Jason E Bailey Assignee: Jason E Bailey Fix For: App CMS 0.10.2 Currently requests for a modal page is wrapped with the html to structure the modal from the client side. a new modal page template has been created, and the modal structure can be placed in that, reducing javascript. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8047) Rendered/exported JSON requested via SlingRequestProcessor is not written to output stream
[
https://issues.apache.org/jira/browse/SLING-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664263#comment-16664263
]
Jason E Bailey commented on SLING-8047:
---
Thank you for raising this issue! I see you also created a pull request against
the models. Could you do one for the default get servlets as well?
> Rendered/exported JSON requested via SlingRequestProcessor is not written to
> output stream
> --
>
> Key: SLING-8047
> URL: https://issues.apache.org/jira/browse/SLING-8047
> Project: Sling
> Issue Type: Bug
> Components: Feature Model, Servlets
>Reporter: Philip Mundt
>Assignee: Jason E Bailey
>Priority: Major
> Attachments:
> SLING-8047-DefaultGetServlet-does-not-write-to-output-stream.patch,
> SLING-8047-ExportServlet-does-not-write-to-output-stream.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While trying to facilitate the {{SlingRequestProcessor}} to get a rendered or
> exported JSON representation of a resource, we ran into the problem of the
> response always being empty. The HTML rendering worked without any issue.
> (See example code of [Get the rendered HTML for an AEM resource, component or
> page|http://www.nateyolles.com/blog/2015/10/get-rendered-html-for-an-aem-resource-or-component]
> or [https://stackoverflow.com/a/34218708])
> Main, observed difference seem to be the method calls to print writer:
> h4. JsonRenderer
> {{org.apache.sling.servlets.get.impl.helpers.JsonRenderer#render}} uses
> {{#write}} method of response's print writer.
> h4. ExportServlet (via JacksonExporter)
> {{org.apache.sling.models.impl.ExportServlet#doGet}} uses {{#write}} method
> of response's print writer.
> h4. HTMLRenderer
> {{org.apache.sling.servlets.get.impl.helpers.HtmlRenderer#render}} uses
> {{#print}} and {{#println}} methods of response's print writer.
> h3. Further observations
> When the print writer's {{autoFlush}} property is set to true and one uses
> the {{#println}} method instead of {{#write}}, the {{JsonRenderer}} will
> flush the print writer's buffer to the output stream. Due to wrapping the
> response in
> {{org.apache.sling.scripting.core.impl.helper.OnDemandWriterResponse}} (where
> {{autoFlush=false}}) this does not work for the {{ExportServlet}}.
> When adding implicit {{#flush()}} calls to both classes, both request
> scenarios will work. According to the servlet specification, it should not be
> necessary to flush the print writer, as the container must immediately flush
> all remaining content to the client upon "termination of the service method
> of the servlet".
> Please find two test cases for (where implicit {{#flush()}} calls were added):
> * JsonRenderer ({{sling-org-apache-sling-servlets-get}}):
> [^SLING-8047-DefaultGetServlet-does-not-write-to-output-stream.patch]
> * ExportServlet ({{sling-org-apache-sling-models-impl}}):
> [^SLING-8047-ExportServlet-does-not-write-to-output-stream.patch]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (SLING-8047) Rendered/exported JSON requested via SlingRequestProcessor is not written to output stream
[
https://issues.apache.org/jira/browse/SLING-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason E Bailey reassigned SLING-8047:
-
Assignee: Jason E Bailey
> Rendered/exported JSON requested via SlingRequestProcessor is not written to
> output stream
> --
>
> Key: SLING-8047
> URL: https://issues.apache.org/jira/browse/SLING-8047
> Project: Sling
> Issue Type: Bug
> Components: Feature Model, Servlets
>Reporter: Philip Mundt
>Assignee: Jason E Bailey
>Priority: Major
> Attachments:
> SLING-8047-DefaultGetServlet-does-not-write-to-output-stream.patch,
> SLING-8047-ExportServlet-does-not-write-to-output-stream.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While trying to facilitate the {{SlingRequestProcessor}} to get a rendered or
> exported JSON representation of a resource, we ran into the problem of the
> response always being empty. The HTML rendering worked without any issue.
> (See example code of [Get the rendered HTML for an AEM resource, component or
> page|http://www.nateyolles.com/blog/2015/10/get-rendered-html-for-an-aem-resource-or-component]
> or [https://stackoverflow.com/a/34218708])
> Main, observed difference seem to be the method calls to print writer:
> h4. JsonRenderer
> {{org.apache.sling.servlets.get.impl.helpers.JsonRenderer#render}} uses
> {{#write}} method of response's print writer.
> h4. ExportServlet (via JacksonExporter)
> {{org.apache.sling.models.impl.ExportServlet#doGet}} uses {{#write}} method
> of response's print writer.
> h4. HTMLRenderer
> {{org.apache.sling.servlets.get.impl.helpers.HtmlRenderer#render}} uses
> {{#print}} and {{#println}} methods of response's print writer.
> h3. Further observations
> When the print writer's {{autoFlush}} property is set to true and one uses
> the {{#println}} method instead of {{#write}}, the {{JsonRenderer}} will
> flush the print writer's buffer to the output stream. Due to wrapping the
> response in
> {{org.apache.sling.scripting.core.impl.helper.OnDemandWriterResponse}} (where
> {{autoFlush=false}}) this does not work for the {{ExportServlet}}.
> When adding implicit {{#flush()}} calls to both classes, both request
> scenarios will work. According to the servlet specification, it should not be
> necessary to flush the print writer, as the container must immediately flush
> all remaining content to the client upon "termination of the service method
> of the servlet".
> Please find two test cases for (where implicit {{#flush()}} calls were added):
> * JsonRenderer ({{sling-org-apache-sling-servlets-get}}):
> [^SLING-8047-DefaultGetServlet-does-not-write-to-output-stream.patch]
> * ExportServlet ({{sling-org-apache-sling-models-impl}}):
> [^SLING-8047-ExportServlet-does-not-write-to-output-stream.patch]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-8000) CMS - Convert modal dialog pages to a modal base
[ https://issues.apache.org/jira/browse/SLING-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-8000. --- Resolution: Fixed updated > CMS - Convert modal dialog pages to a modal base > > > Key: SLING-8000 > URL: https://issues.apache.org/jira/browse/SLING-8000 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: App CMS 0.10.2 > > > currently the request for dialogs is returning the full page with a > subsection to be pulled out for the modal dialog. > create a new base page of modal and convert the pages to be a subtype of this > page type where appropriate. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7986) CMS - introduce new js lib to decorate elems on dom insertion
[ https://issues.apache.org/jira/browse/SLING-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-7986. --- Resolution: Fixed new nomnom.js has been introduced to handle element decoration > CMS - introduce new js lib to decorate elems on dom insertion > - > > Key: SLING-7986 > URL: https://issues.apache.org/jira/browse/SLING-7986 > Project: Sling > Issue Type: Improvement > Components: App CMS >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: App CMS 0.10.2 > > > added a new js lib and broke out several of the old decorators into new files > and re-wrote them to fit the new lib. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7950) Fix ITs with Oak 1.8
[
https://issues.apache.org/jira/browse/SLING-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650530#comment-16650530
]
Jason E Bailey commented on SLING-7950:
---
[~rombert] I pushed a fix for the null pointer exception that was occurring
after the session information was written out. That may resolve this
> Fix ITs with Oak 1.8
>
>
> Key: SLING-7950
> URL: https://issues.apache.org/jira/browse/SLING-7950
> Project: Sling
> Issue Type: Sub-task
> Components: Launchpad, Oak, Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 11
>
>
> Updating to Oak 1.8.7 results in the following failures:
> {noformat}[ERROR] Failures:
> [ERROR] AnonymousAccessTest.testAnonymousContent:99->assertContent:85
> Expected status 200 for
> http://localhost:41000/ANON_CAN_READ/AnonymousAccessTest/789235c4-d3b2-43b3-a163-aadb95cdd56b/test_text_789235c4_d.txt
> (content=) expected:<200> but was:<401>
> [ERROR] AnonymousAccessTest.testAnonymousContent:101 Expecting status 404
> when testing outside of anonymous access subtree expected:<404> but was:<401>
> [ERROR]
> AuthRequestLoginTest.testForcedLogin:40->HttpTestBase.getContent:419->HttpTestBase.getContent:424->HttpTestBase.getContent:432->HttpTestBase.getContent:457
> Expected status 200 for
> http://localhost:41000/system/sling/info.sessionInfo.json (content=)
> expected:<200> but was:<401>
> [ERROR] RedirectOnLogoutTest.testRedirectToResourceAfterLogout:70 Expected
> redirect expected:<302> but was:<401>
> [ERROR] Errors:
> [ERROR] DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 »
> NoClassDefFound or...
> [ERROR] DavExDisabledAnonAccessTest>DavExIntegrationTest.setUp:47 »
> NoClassDefFound or...
> [ERROR] DavExIntegrationTest.setUp:47 » NoClassDefFound
> org/apache/jackrabbit/webdav/c...
> [ERROR] DavExIntegrationTest.setUp:47 » NoClassDefFound
> org/apache/jackrabbit/webdav/c...
> [INFO]
> [ERROR] Tests run: 655, Failures: 4, Errors: 4, Skipped: 1{noformat}
> The changes that support this are at
> https://github.com/apache/sling-org-apache-sling-starter/tree/feature/oak-1.8
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8011) Accessing the info.sessionInfo.json endpoint always logs an error: Writer has already been closed
[
https://issues.apache.org/jira/browse/SLING-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648689#comment-16648689
]
Jason E Bailey commented on SLING-8011:
---
Yep, I'll fix it.
> Accessing the info.sessionInfo.json endpoint always logs an error: Writer has
> already been closed
> -
>
> Key: SLING-8011
> URL: https://issues.apache.org/jira/browse/SLING-8011
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.38
>
>
> I noticed that the Sling starter logs are full of errors regarding an already
> closed writer. Taking a closer look, I think the root cause is the fix for
> SLING-7795 - now the response writer is being and then a flush call is issues.
> {noformat}13.10.2018 01:02:12.584 *ERROR* [0:0:0:0:0:0:0:1 [1539381732583]
> GET /system/sling/info.sessionInfo.json HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl Writer has already
> been closed.
> org.apache.sling.engine.impl.SlingHttpServletResponseImpl$WriterAlreadyClosedException:
> null
> at
> org.apache.sling.engine.impl.SlingHttpServletResponseImpl$1.checkClosed(SlingHttpServletResponseImpl.java:190)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingHttpServletResponseImpl$1.flush(SlingHttpServletResponseImpl.java:227)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.servlets.get.impl.SlingInfoServlet.renderJson(SlingInfoServlet.java:122)
> [org.apache.sling.servlets.get:2.1.36]
> at
> org.apache.sling.servlets.get.impl.SlingInfoServlet.doGet(SlingInfoServlet.java:96)
> [org.apache.sling.servlets.get:2.1.36]
> at
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
> [org.apache.sling.api:2.18.4]
> at
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
> [org.apache.sling.api:2.18.4]
> at
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
> [org.apache.sling.api:2.18.4]
> at
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
> [org.apache.sling.engine:2.6.14]
> at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
> [org.apache.sling.i18n:2.5.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
> [org.apache.felix.http.jetty:4.0.6]
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
> [org.apache.felix.http.jetty:4.0.6]
> at
> org.apache.felix.http.sslfilter.internal.SslFilter.doFilter(SslFilter.java:96)
> [org.apache.felix.http.sslfilter:1.2.4]
> at
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> [org.apache.felix.http.jetty:4.0.6]
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
> [org.apache.felix.http.jetty:4.0.6]
> at
[jira] [Assigned] (SLING-8011) Accessing the info.sessionInfo.json endpoint always logs an error: Writer has already been closed
[
https://issues.apache.org/jira/browse/SLING-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason E Bailey reassigned SLING-8011:
-
Assignee: Jason E Bailey
> Accessing the info.sessionInfo.json endpoint always logs an error: Writer has
> already been closed
> -
>
> Key: SLING-8011
> URL: https://issues.apache.org/jira/browse/SLING-8011
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.38
>
>
> I noticed that the Sling starter logs are full of errors regarding an already
> closed writer. Taking a closer look, I think the root cause is the fix for
> SLING-7795 - now the response writer is being and then a flush call is issues.
> {noformat}13.10.2018 01:02:12.584 *ERROR* [0:0:0:0:0:0:0:1 [1539381732583]
> GET /system/sling/info.sessionInfo.json HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl Writer has already
> been closed.
> org.apache.sling.engine.impl.SlingHttpServletResponseImpl$WriterAlreadyClosedException:
> null
> at
> org.apache.sling.engine.impl.SlingHttpServletResponseImpl$1.checkClosed(SlingHttpServletResponseImpl.java:190)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingHttpServletResponseImpl$1.flush(SlingHttpServletResponseImpl.java:227)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.servlets.get.impl.SlingInfoServlet.renderJson(SlingInfoServlet.java:122)
> [org.apache.sling.servlets.get:2.1.36]
> at
> org.apache.sling.servlets.get.impl.SlingInfoServlet.doGet(SlingInfoServlet.java:96)
> [org.apache.sling.servlets.get:2.1.36]
> at
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
> [org.apache.sling.api:2.18.4]
> at
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
> [org.apache.sling.api:2.18.4]
> at
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
> [org.apache.sling.api:2.18.4]
> at
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
> [org.apache.sling.engine:2.6.14]
> at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
> [org.apache.sling.i18n:2.5.14]
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
> [org.apache.sling.engine:2.6.14]
> at
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
> [org.apache.felix.http.jetty:4.0.6]
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
> [org.apache.felix.http.jetty:4.0.6]
> at
> org.apache.felix.http.sslfilter.internal.SslFilter.doFilter(SslFilter.java:96)
> [org.apache.felix.http.sslfilter:1.2.4]
> at
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
> [org.apache.felix.http.jetty:4.0.6]
> at
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
> [org.apache.felix.http.jetty:4.0.6]
> at
[jira] [Created] (SLING-8000) CMS - Convert modal dialog pages to a modal base
Jason E Bailey created SLING-8000: - Summary: CMS - Convert modal dialog pages to a modal base Key: SLING-8000 URL: https://issues.apache.org/jira/browse/SLING-8000 Project: Sling Issue Type: Improvement Reporter: Jason E Bailey Assignee: Jason E Bailey Fix For: App CMS 0.10.2 currently the request for dialogs is returning the full page with a subsection to be pulled out for the modal dialog. create a new base page of modal and convert the pages to be a subtype of this page type where appropriate. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7989) Sling Resource Provider implementation
Jason E Bailey created SLING-7989: - Summary: Sling Resource Provider implementation Key: SLING-7989 URL: https://issues.apache.org/jira/browse/SLING-7989 Project: Sling Issue Type: Improvement Reporter: Jason E Bailey Assignee: Jason E Bailey Create a new resource provider implementation that is self contained. I.e. does not require an external data store. Resource Provider must # Implement all Resource Provider interfaces. # Requires minimal configuration # Support a Query Language -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-3270) html-generator to support html5
[ https://issues.apache.org/jira/browse/SLING-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-3270: - Assignee: Jason E Bailey > html-generator to support html5 > --- > > Key: SLING-3270 > URL: https://issues.apache.org/jira/browse/SLING-3270 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Rewriter 1.0.2 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Attachments: 218.patch > > > Given the following fragment of HTML > > This is invalid html4 and valid html5, as html5 allows anchor tags to contain > block elements. > The current html-generator corrects the bad html4 and produces the following > output > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7927) JSON Content Loading errors out import on malformed json
[ https://issues.apache.org/jira/browse/SLING-7927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-7927: - Assignee: Jason E Bailey > JSON Content Loading errors out import on malformed json > > > Key: SLING-7927 > URL: https://issues.apache.org/jira/browse/SLING-7927 > Project: Sling > Issue Type: Bug >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR Content Parser 1.2.8 > > > Current Behaviour: > During the importing of json content from a bundle. If one of the files > contains malformed json the load process is discontinued and exits. This > stops the loading of any other, correctly formatted, data. > > Expected Behaviour: > If a single file contains malformed content, that specific file should > discontinue, the error logged and then the process continues to import the > rest of the provided content. > As it is right now, it's possible to load the bundle and have the application > in an unworkable state. preventing the ability to trouble shoot and > investigate the root cause. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7760) Contextual Additional Response Headers
[ https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-7760: - Assignee: Jason E Bailey > Contextual Additional Response Headers > -- > > Key: SLING-7760 > URL: https://issues.apache.org/jira/browse/SLING-7760 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > Currently, for us to set the global response headers we need to add these to > the Sling Main Servlet. > The problem with this is > * Any changes to the Sling Main Servlet ends up with the service restarting. > This has a negative overall effect to the environment > * We run multiple domains out of a single instance. For a > Content-Security-Header we end up putting in exemptions that should apply to > one site for all sites. This is problematic from a security perspective > Ideally we would be able to configure headers based on the domain that's > being requested -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7926) JSON Content Loading should support namespace mangling
[ https://issues.apache.org/jira/browse/SLING-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-7926: - Assignee: Jason E Bailey > JSON Content Loading should support namespace mangling > -- > > Key: SLING-7926 > URL: https://issues.apache.org/jira/browse/SLING-7926 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: JCR Content Parser 1.2.8 > > > Currently it's possible to define a json file with a name that matches a > mangled namespace. Which then makes the file unable to be accessed from the > ResourceResolver > i.e. importing a file `_jcr_content.json` will create the node `_jcr_content` > which cannot then be resolved as the resource resolver will attempt to > convert `_jcr_content` to `jcr:content` supporting namespace mangling will > additionally provide a cleaner `colon` support then the current > recommendation of a url mangled colon of `%3A` > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7934) Add the ability for a resource to adapt to a JSONObject
[ https://issues.apache.org/jira/browse/SLING-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-7934: - Assignee: Jason E Bailey > Add the ability for a resource to adapt to a JSONObject > --- > > Key: SLING-7934 > URL: https://issues.apache.org/jira/browse/SLING-7934 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > There are multiple implementations all doing the same process of converting a > resource to a JSONObject. If it's that common we should just add the ability > to adapt the resource and centralize the implementation so that it's > consistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7934) Add the ability for a resource to adapt to a JSONObject
[ https://issues.apache.org/jira/browse/SLING-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642282#comment-16642282 ] Jason E Bailey commented on SLING-7934: --- [~karlpauls] I'm honestly fine with either of those suggestions, however I'm not sure of the validity of that argument since it would be valid with any use of adaptTo which is used throughout the framework > Add the ability for a resource to adapt to a JSONObject > --- > > Key: SLING-7934 > URL: https://issues.apache.org/jira/browse/SLING-7934 > Project: Sling > Issue Type: Improvement >Reporter: Jason E Bailey >Priority: Major > > There are multiple implementations all doing the same process of converting a > resource to a JSONObject. If it's that common we should just add the ability > to adapt the resource and centralize the implementation so that it's > consistent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7986) CMS - introduce new js lib to decorate elems on dom insertion
[ https://issues.apache.org/jira/browse/SLING-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7986: -- Affects Version/s: (was: App CMS 0.10.2) > CMS - introduce new js lib to decorate elems on dom insertion > - > > Key: SLING-7986 > URL: https://issues.apache.org/jira/browse/SLING-7986 > Project: Sling > Issue Type: Improvement > Components: App CMS >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: App CMS 0.10.2 > > > added a new js lib and broke out several of the old decorators into new files > and re-wrote them to fit the new lib. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7986) CMS - introduce new js lib to decorate elems on dom insertion
[ https://issues.apache.org/jira/browse/SLING-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey updated SLING-7986: -- Fix Version/s: App CMS 0.10.2 > CMS - introduce new js lib to decorate elems on dom insertion > - > > Key: SLING-7986 > URL: https://issues.apache.org/jira/browse/SLING-7986 > Project: Sling > Issue Type: Improvement > Components: App CMS >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > Fix For: App CMS 0.10.2 > > > added a new js lib and broke out several of the old decorators into new files > and re-wrote them to fit the new lib. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7986) CMS - introduce new js lib to decorate elems on dom insertion
[ https://issues.apache.org/jira/browse/SLING-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey reassigned SLING-7986: - Assignee: Jason E Bailey > CMS - introduce new js lib to decorate elems on dom insertion > - > > Key: SLING-7986 > URL: https://issues.apache.org/jira/browse/SLING-7986 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 0.10.2 >Reporter: Jason E Bailey >Assignee: Jason E Bailey >Priority: Major > > added a new js lib and broke out several of the old decorators into new files > and re-wrote them to fit the new lib. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7986) CMS - introduce new js lib to decorate elems on dom insertion
Jason E Bailey created SLING-7986: - Summary: CMS - introduce new js lib to decorate elems on dom insertion Key: SLING-7986 URL: https://issues.apache.org/jira/browse/SLING-7986 Project: Sling Issue Type: Improvement Components: App CMS Affects Versions: App CMS 0.10.2 Reporter: Jason E Bailey added a new js lib and broke out several of the old decorators into new files and re-wrote them to fit the new lib. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
