Re: [s2] Roadmap for the core taglib

2007-11-04 Thread Don Brown
Even though I argued for it initially, I'm still not 100% sure we want to pull out the tags. Not only is it more confusing to users, but it makes tag extension harder, since plugins can't provide plugin points to other plugins. That means we'd have to keep the majority of the tag infrastructure

Re: svn commit: r591942 - in /struts/struts2/trunk/apps/portlet: ./ src/main/java/org/apache/struts2/portlet/example/ src/main/resources/ src/main/resources/org/apache/struts2/portlet/example/ src/mai

2007-11-05 Thread Don Brown
the integration test is running under is taken...obviously (of course I had to pick one of the most commonly used) Which port can I use? Nils-H On Nov 5, 2007 12:50 PM, Don Brown [EMAIL PROTECTED] wrote: Nils, you broke the build: http://opensource.bamboo.atlassian.com/browse/STRUTS Don

Re: svn commit: r591942 - in /struts/struts2/trunk/apps/portlet: ./ src/main/java/org/apache/struts2/portlet/example/ src/main/resources/ src/main/resources/org/apache/struts2/portlet/example/ src/mai

2007-11-05 Thread Don Brown
Oh, and thanks for fixing it so quick :) Don On 11/5/07, Don Brown [EMAIL PROTECTED] wrote: The Bamboo messages to go [EMAIL PROTECTED], which you may not be on. As for the port, just pick one, say 8887. Don On 11/5/07, Nils-Helge Garli Hegvik [EMAIL PROTECTED] wrote: Indeed so it seems

Re: [PROPOSAL] Merge Able/Code Behind/Zero-Config/SmartURLs into view-behind specification

2007-11-06 Thread Don Brown
Ah, another good reason not to kill the codebehind plugin as it currently exists. I'm still not convinced we need drastic changes here, more like just filling out functionality. Don On 11/7/07, Ian Roughley [EMAIL PROTECTED] wrote: If it were me, I'd finish the book using struts.xml, and

Re: [s2] extras-lib (was JUEL plugin (was Roadmap for the core taglib))

2007-11-06 Thread Don Brown
On 11/7/07, Tom Schneider [EMAIL PROTECTED] wrote: Ian brings up a good point in that we'll have to decide how to handle some things like I18N/type conversion/method invocation. Not all EL's are created equal and OGNL probably is a little more flexible and powerful than most. Then even if we

Re: Struts 2 Plugin for Grails?

2007-11-07 Thread Don Brown
On 11/8/07, Matt Raible [EMAIL PROTECTED] wrote: What I'd like is to use Grails to develop my application, but have it use Struts 2 under-the-covers instead of Spring MVC. As far as code differences between writing a Spring MVC Grails Controller and a Struts 2 Grails Controller - I don't think

[VOTE] Release struts2-archetype-plugin and struts2-archetype-starter version 2.0.11

2007-11-12 Thread Don Brown
I've created test builds titled 2.0.11 for the following archetypes: * struts2-archetype-plugin - Creates a Struts 2 plugin * struts2-archetype-starter - Creates a starter Struts 2 app Since they are both pretty simple, I'm combining their votes, so: [ ] +1 - Release them to the wild [ ] +/-

Re: [VOTE] Release struts2-archetype-plugin and struts2-archetype-starter version 2.0.11

2007-11-12 Thread Don Brown
+1 On 11/13/07, Don Brown [EMAIL PROTECTED] wrote: I've created test builds titled 2.0.11 for the following archetypes: * struts2-archetype-plugin - Creates a Struts 2 plugin * struts2-archetype-starter - Creates a starter Struts 2 app Since they are both pretty simple, I'm combining

Re: Confluence Rate Plugin for the Plugin Registry

2007-11-14 Thread Don Brown
Done. Unfortunately, the latest version requires a newer version of Confluence, so I installed an older version. I placed the macro on each plugin page, but found a couple of issues: * Anyone can reset the ratings * The table report doesn't seem to work right, so I didn't put that report on

Re: Confluence Rate Plugin for the Plugin Registry

2007-11-14 Thread Don Brown
, 2007 4:17 PM, Don Brown [EMAIL PROTECTED] wrote: Done. Unfortunately, the latest version requires a newer version of Confluence, so I installed an older version. I placed the macro on each plugin page, but found a couple of issues: * Anyone can reset the ratings * The table report

Re: Confluence Rate Plugin for the Plugin Registry

2007-11-14 Thread Don Brown
PM, Don Brown [EMAIL PROTECTED] wrote: Done. Unfortunately, the latest version requires a newer version of Confluence, so I installed an older version. I placed the macro on each plugin page, but found a couple of issues: * Anyone can reset the ratings * The table report doesn't seem

Re: Struts 2 CodeBehind/SmartURLs (was Re: Struts 2 Plugin for Grails?)

2007-11-20 Thread Don Brown
On 11/20/07, Brian Pontarelli [EMAIL PROTECTED] wrote: Here are my thoughts: AFAICT, the questions then become * Which Result annotation syntax to support? ** CB uses a .class reference, SU uses a string setting that corresponds to the Result name. ** CB uses value where SU

Re: Struts 2 CodeBehind/SmartURLs (was Re: Struts 2 Plugin for Grails?)

2007-11-20 Thread Don Brown
On 11/20/07, Dave Newton [EMAIL PROTECTED] wrote: I'd think that package-level annotations should go in the package-info.java; that's what it's for, more or less. Perfect! I didn't know about that class, hence my hacky workarounds. Let's definitely use it. Don d.

Re: REST Plugin and auto-generated XHTML Views

2007-12-02 Thread Don Brown
The problem with working off XML rather than Java is you lose the type information. In order to build a useful form, for example, you need to know that the 'age' field is a number or that 'created' is a date. XStream puts some data type information into the markup, but not enough to really be

Re: REST Plugin and auto-generated XHTML Views

2007-12-02 Thread Don Brown
On 12/2/07, Jeromy Evans [EMAIL PROTECTED] wrote: I thought I'd just add that I've been thinking along the same line as Matt, but rather than client-side XSTL I've been desperate for a good quality javascript templating library. You mean something like this?

Re: shall I open a ticket for these?

2007-12-02 Thread Don Brown
Yes, please do and patches are always appreciated. Thanks! Don On 12/2/07, Giovanni Azua [EMAIL PROTECTED] wrote: hi, I am using 2.1.1 built from trunk and I am very happy to see how well it works. I found couple of really minor issues though and wanted to ask before openning JIRA

Re: REST Plugin and auto-generated XHTML Views

2007-12-02 Thread Don Brown
Completely agree with Martin. Once you get XSLT and functional programming in general, XSLT is actually pretty cool. I've deployed an application using XSLT and the aforementioned STXX and it went pretty well. Debugging was really easy, and even the performance was very good. You can even do

Re: JSP EL in struts2 tags

2007-12-02 Thread Don Brown
On 12/3/07, Ing. Andrea Vettori [EMAIL PROTECTED] wrote: I'm happy to know that a complete solution is being planned/developed. I just say that if the security problem is caused only by bad programming practice, removing EL evaluation into S2 tld is causing upgrading problems to many

[s2] Allowed methods

2007-12-05 Thread Don Brown
I'm about to commit a fairly large patch that, among other things, adds built-in support for limiting what methods can be invoked on an Action. My motivation was actually to improve the ability for the REST plugin to introspect what HTTP methods are supported (automatic HTTP OPTIONS and WADL

Re: SmartURLs port

2007-12-06 Thread Don Brown
Could you commit your version as a development branch, rather than to trunk? I'm using/improving Codebehind right now in some of the new features both in core and the rest plugin. I'd also like a chance to fully review the changes before we dump the old. On 12/6/07, Brian Pontarelli [EMAIL

[s2] Allowed methods next step

2007-12-09 Thread Don Brown
Since the commit for this feature involved a rather large XWork change (properly immutable configuration objects [1]), I decided to commit what I have and discuss the next steps. First, due the aforementioned fix [1], Brian, your SmartURL's migration work will probably be most affected. I

Re: [s2] Allowed methods next step

2007-12-11 Thread Don Brown
On 12/11/07, Brian Pontarelli [EMAIL PROTECTED] wrote: At first I thought this might be a problem because SmartURLs was sub-classing the ActionConfig object in order to add some additional information for performance reasons. However, I have a feeling that I can remove the sub-class. All the

[s2] Build changes

2007-12-16 Thread Don Brown
FYI, I'm working on the XWork and Struts 2 builds, trying to do a few things: * Automatic deployment of xwork and struts 2 snapshots (by Bamboo) * Automatic deployment of struts 2 assemblies (by Bamboo) * One step creation of assemblies, including j4 backport jars One of the stumbling points

Re: [s2] Build changes

2007-12-16 Thread Don Brown
- From: Don Brown [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Date: Sun, 16 Dec 2007 22:18:14 +1100 Subject: [s2] Build changes FYI, I'm working on the XWork and Struts 2 builds, trying to do a few things: * Automatic deployment of xwork and struts 2 snapshots (by Bamboo

Re: svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl

2007-12-16 Thread Don Brown
Don't forget to put the ticket number in the commit, cause that will usually be the bit that has the link to the thread. Don On 12/17/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: davenewton Date: Sun Dec 16 15:14:16 2007 New Revision: 604737 URL:

Re: svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl

2007-12-16 Thread Don Brown
Heh, that was the no-so-subtle hint :) Don On 12/17/07, Dave Newton [EMAIL PROTECTED] wrote: Oh; didn't know there was a ticket, sorry. d. --- Don Brown [EMAIL PROTECTED] wrote: Don't forget to put the ticket number in the commit, cause that will usually be the bit that has the link

Re: [s2] Build changes

2007-12-16 Thread Don Brown
, 2007 6:52 PM, Antonio Petrelli [EMAIL PROTECTED] wrote: 2007/12/16, Don Brown [EMAIL PROTECTED]: * One step creation of assemblies, including j4 backport jars This might interest you, I noticed it was not applied: http://jira.opensymphony.com/browse/XW-585 One of the stumbling points

Re: [s2] Build changes

2007-12-17 Thread Don Brown
assembly mvn assembly:assembly Don On 12/17/07, Don Brown [EMAIL PROTECTED] wrote: On 12/17/07, Martin Gilday [EMAIL PROTECTED] wrote: Does this include getting artifacts published to a snapshot Struts 2 Maven repo (i.e. not central)? Yep, and as I mentioned, I'm hoping to get the full

Re: svn commit: r604801 - in /struts/struts2/trunk/assembly: pom.xml src/main/assembly/all.xml src/main/assembly/lib-backport.xml src/main/assembly/lib-jdk14.xml src/main/assembly/lib.xml

2007-12-17 Thread Don Brown
On 12/17/07, Antonio Petrelli [EMAIL PROTECTED] wrote: Don, Why did you remove so many dependencies? I think that your commit broke the assemblies instead of fixing them... Most of those were not used anymore, but I'm sure I'll have to put back in. I'd rather know exactly what needs to go

Re: svn commit: r604801 - in /struts/struts2/trunk/assembly: pom.xml src/main/assembly/all.xml src/main/assembly/lib-backport.xml src/main/assembly/lib-jdk14.xml src/main/assembly/lib.xml

2007-12-17 Thread Don Brown
On 12/17/07, Antonio Petrelli [EMAIL PROTECTED] wrote: Mmm I think that you removed Tiles for no good reason Nope, I just checked - Tiles is still there in -all, -lib, and -lib-jdk14. You don't need to specify the jar explicitly, as it is pulled in via the tiles plugin. One of the

[s2] Assembly build (was svn commit: r604801 )

2007-12-17 Thread Don Brown
On 12/17/07, Antonio Petrelli [EMAIL PROTECTED] wrote: The Struts 2/Tiles 2 plugin does not depend on tiles-jsp, so I suppose that it isn't there... Hmm...this is kinda a bigger issue - should our assembly contain all the files for the frameworks that the plugin provides support for? We don't

Re: [s2] Assembly build (was svn commit: r604801 )

2007-12-17 Thread Don Brown
On 12/17/07, Antonio Petrelli [EMAIL PROTECTED] wrote: 2007/12/17, Don Brown [EMAIL PROTECTED]: Hmm...this is kinda a bigger issue - should our assembly contain all the files for the frameworks that the plugin provides support for? We don't include every Spring jar or a JSF framework

Re: XWork project

2008-01-02 Thread Don Brown
On Jan 3, 2008 5:44 AM, Brian Pontarelli [EMAIL PROTECTED] wrote: What is the policy for Struts committers getting access to XWork? While updating the convention plugin I had to change a few things in XWork and I want to make sure that they get committed to trunk before I start using the

Re: XWork project

2008-01-02 Thread Don Brown
, so perhaps we could get away with embedding a version of StringTemplate or something. Don On 1/3/08, Chris Pratt [EMAIL PROTECTED] wrote: On Jan 2, 2008 2:26 PM, Don Brown [EMAIL PROTECTED] wrote: At this point, our plan is to leave them where they are. I'd like to get rid of OGNL through

Re: [S2] Libraries in JDK 1.4 distribution

2008-01-11 Thread Don Brown
Personally, I'm leaning more and more to not shipping dependencies by default, so I'd prefer the 1.4 distro to not have them. Our download sizes are way too big already. Don On 1/12/08, Antonio Petrelli [EMAIL PROTECTED] wrote: Hi all, Currently in the JDK 1.4 distribution, that contains

Re: Sandbox

2008-01-16 Thread Don Brown
On 1/16/08, Antonio Petrelli [EMAIL PROTECTED] wrote: 2008/1/16, Nils-Helge Garli Hegvik [EMAIL PROTECTED]: I've started playing with JSR286 portlet support in Struts 2. Is the sandbox an appropriate place to put this code (probably a new plugin), or is the sandbox reserved for other

Re: [S2.1] Does struts2-core include Dojo code?

2008-01-18 Thread Don Brown
It shouldn't... Don On 1/18/08, Antonio Petrelli [EMAIL PROTECTED] wrote: Hi all, I wish to know if the struts2-core, in Struts 2.1, contains Dojo in any form, since I have to resolve some license issues and probably I have to move it to the Dojo plugin. Thanks Antonio

Re: svn commit: r614488 - in /struts/struts2/trunk: core/pom.xml plugins/dojo/pom.xml

2008-01-23 Thread Don Brown
Don't forget to deploy the snapshot before updating the pom. Also, when I deployed the struts-annotations snapshot, I noticed it had a unique snapshot version, so I changed the poms to use it, and kicked off the build again, which just passed. Don On 1/23/08, [EMAIL PROTECTED] [EMAIL PROTECTED]

Re: [OSS Bamboo] Struts 2 SVN - Main Build build 685 has FAILED (0 tests failed). Change made by husted

2008-01-24 Thread Don Brown
Yeah, passes for me too. That is a really weird Maven error: INFO] [ERROR] BUILD ERROR [INFO] [INFO] Failed to resolve artifact. No versions are

[s2] Tiles plugin build error?

2008-02-15 Thread Don Brown
Is anyone else seeing this problem with the Tiles plugin? Downloading: http://people.apache.org/repo/m2-snapshot-repository/org/apache/tiles/tiles-master/1/tiles-master-1.pom Downloading:

Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java

2008-02-16 Thread Don Brown
I explicitly removed the 2.4 servlet jar that was leaking in, but that only seemed to fix the method not found exception I was seeing. I even tried including jstl but that didn't seem to help. Don On 2/17/08, Nils-Helge Garli Hegvik [EMAIL PROTECTED] wrote: I don't know why the test have

[s2] Let's get out Struts 2.1.1

2008-02-16 Thread Don Brown
I've cleared all but a couple issues out of Struts 2.1.1, so I think we are ready for a release. The only kinda blocking issue is the portlet tests failing, but that seems to have something to do with the setup, not our portlet code, so we could even punt that one. Any objections to rolling a

Re: svn commit: r628298 - /struts/struts2/trunk/apps/portlet/src/test/java/org/apache/struts2/portlet/test/Struts2PortletTest.java

2008-02-16 Thread Don Brown
no reason it suddenly should fail. Nils-H On Feb 16, 2008 3:08 PM, Don Brown [EMAIL PROTECTED] wrote: I explicitly removed the 2.4 servlet jar that was leaking in, but that only seemed to fix the method not found exception I was seeing. I even tried including jstl but that didn't seem

[VOTE] Publish Struts Annotations 1.0.3

2008-02-17 Thread Don Brown
The test build of Struts Annotations 1.0.3 is available. Maven 2 staging repository: * http://people.apache.org/builds/struts/struts-annotations/1.0.3/m2-staging-repository/ Once you have had a chance to review the test build, please respond with a vote on whether to publish it or not: [

Re: [s2] Let's get out Struts 2.1.1

2008-02-17 Thread Don Brown
release out? If you are busy, I can stumble through that release as well. Don On 2/17/08, Don Brown [EMAIL PROTECTED] wrote: I've cleared all but a couple issues out of Struts 2.1.1, so I think we are ready for a release. The only kinda blocking issue is the portlet tests failing

Re: The Closer award -[OT] slow down Don!

2008-02-17 Thread Don Brown
You gotta be faster than that :) Really, don't stress about your first commit; it is like stressing over your first kiss. Just get the damn thing out of the way and get on to more interesting things :) Don On 2/17/08, Jeromy Evans [EMAIL PROTECTED] wrote: Dave Newton wrote: --- Don Brown

Re: [s2] Tiles plugin build error?

2008-02-17 Thread Don Brown
Nm, working fine now. Don On 2/16/08, Antonio Petrelli [EMAIL PROTECTED] wrote: 2008/2/16, Don Brown [EMAIL PROTECTED]: Is anyone else seeing this problem with the Tiles plugin? For me the build went fine. What version of Maven are you using? For me it's 2.0.7. Antonio

Re: [VOTE] Publish Struts Annotations 1.0.3

2008-02-17 Thread Don Brown
+1 On Feb 17, 2008 7:34 PM, Don Brown [EMAIL PROTECTED] wrote: The test build of Struts Annotations 1.0.3 is available. Maven 2 staging repository: * http://people.apache.org/builds/struts/struts-annotations/1.0.3/m2-staging-repository/ Once you have had a chance to review the test

Re: Access to WW space at cwiki

2008-02-18 Thread Don Brown
Done. On 2/18/08, Jeromy Evans [EMAIL PROTECTED] wrote: Thanks Don. Sorry, the confluence username is jeromyevans (with an o) Don Brown wrote: I tried, but I don't see your account. Could it be under something else? Don On 2/18/08, Jeromy Evans [EMAIL PROTECTED] wrote: Can

Re: [s2] Let's get out Struts 2.1.1

2008-02-19 Thread Don Brown
on a date of Feb 24 Australia time so Feb 23 for the US. I've closed out all but one ticket in XWork 2.1.1, which I may bump as well. Rainer, any chance on getting an XWork 2.1.1 release out? If you are busy, I can stumble through that release as well. Don On 2/17/08, Don Brown [EMAIL

Re: [s2] Let's get out Struts 2.1.1

2008-02-19 Thread Don Brown
Oh, I know how to release Struts; I was referring to the XWork release. IIRC, this will be the first release with the Maven 2 build, so we'll see how it goes... Don On 2/20/08, Wendy Smoak [EMAIL PROTECTED] wrote: On Feb 19, 2008 6:01 AM, Don Brown [EMAIL PROTECTED] wrote: Are there any

Re: [s2] Let's get out Struts 2.1.1

2008-02-20 Thread Don Brown
Here's the thing - I'm going to create the 2.1.1 test build on Sunday, hopefully followed by test builds every couple weeks or so. Whatever you can get into the code by those dates will be included in the subsequent release. Honestly, I don't expect 2.1.1 to be GA, but am aiming for a Beta vote.

Re: API Compatibility

2008-02-20 Thread Don Brown
Yeah, the way Struts does versions kinda breaks this. You could see very major changes between 2.1.0 and 2.1.1 because neither made GA. Once a GA release has been made in a series, however, the normal rules apply. It is beating a dead horse to say I never liked the Struts versioning system, so

Re: API Compatibility

2008-02-21 Thread Don Brown
in the configuration files and renaming methods or ids is not a compatible change. These types of changes seem to be the largest issue with the versioning of Struts 2. -bp Don Brown wrote: Yeah, the way Struts does versions kinda breaks this. You could see very major changes between

Re: StrutsStatics...

2008-02-21 Thread Don Brown
On 2/22/08, Brian Pontarelli [EMAIL PROTECTED] wrote: Hehe. The changes from 2.0 to 2.1 are completely incompatible, so this change is minor in comparison. I disagree with that statement. For Struts 2 users, the changes are only minor. I think you feel them more because you are working on

Re: API Compatibility

2008-02-21 Thread Don Brown
On 2/22/08, Brian Pontarelli [EMAIL PROTECTED] wrote: Here's an example... The XWork configuration API changed to the builder pattern. This is probably a good thing, but required any plugin using it to make significant changes and re-compile. This change wasn't compatible and there are

Re: StrutsStatics...

2008-02-21 Thread Don Brown
just don't enough justification for the statement that 2.1 changes are completely incompatible, especially from the standpoint of a Struts application developer. Don On 2/22/08, Brian Pontarelli [EMAIL PROTECTED] wrote: Don Brown wrote: On 2/22/08, Brian Pontarelli [EMAIL PROTECTED] wrote

Re: API Compatibility

2008-02-21 Thread Don Brown
On 2/22/08, Paul Benedict [EMAIL PROTECTED] wrote: I would strongly suggest that Struts 2.1 refactor itself, if necessary, to separate out the public and internal API and produce two distrinct javadocs and source bundles based on these. Since 2.1 is already incompatible for plugins, I

Re: API Compatibility

2008-02-21 Thread Don Brown
Well said, and I completely agree. My original point is your point #1 just isn't possible with the current versioning scheme. Because every release gets its own patch number, regardless of quality or API changes, it can't be counted on, and really, I don't see any solution other than creating a

Re: API Compatibility

2008-02-21 Thread Don Brown
in the projects I work on, so I don't see how Struts is unique here. Don On 2/22/08, Brian Pontarelli [EMAIL PROTECTED] wrote: Don Brown wrote: Well said, and I completely agree. My original point is your point #1 just isn't possible with the current versioning scheme. Because every release

Re: API Compatibility

2008-02-21 Thread Don Brown
On 2/22/08, Brian Pontarelli [EMAIL PROTECTED] wrote: These two points, put together, will necessarily result in a 2.1.0 release that is drastically different than 2.1.1. I just don't see any way around that. Tooling can solve this issue. How? As I said, it is not possible for

Re: API Compatibility

2008-02-23 Thread Don Brown
It doesn't help your argument to use Maven as an example :) I think it is pretty straight forward - all plugins have versions, only the bundled plugins are versioned/released along with the rest of Struts to make it simpler. If we gave each plugin its own version, which we did with Struts 1, it

[s2] Struts 2.1.1 delayed

2008-02-24 Thread Don Brown
Unfortunately, my computer is experiencing severe stability problems, so the Struts 2.1.1 build will be delayed. I'm hoping to give it a shot next weekend. Of course, anyone is free to give it a go in the meantime... Don - To

Re: svn commit: r630822 - in /struts/sandbox/trunk/struts2-osgi-plugin: ./ admin-bundle/ admin-bundle/src/ admin-bundle/src/main/ admin-bundle/src/main/java/ admin-bundle/src/main/java/org/ admin-bund

2008-02-25 Thread Don Brown
Cool, I just took whatever the Spring osgi archetype gave me. Glad to see activity as I came across at least one bug that'll hopefully be fixed in the next version :) Don On 2/25/08, Niall Pemberton [EMAIL PROTECTED] wrote: Don, just a FYI - the latest release of felix's bundle plugin is

Re: [VOTE] Struts 2.0.11.1 Quality (fast track) - PROPOSED ANNOUNCEMENT

2008-03-03 Thread Don Brown
Looks good. Thanks for creating a security bulletin as well. Don On 3/4/08, Rene Gielen [EMAIL PROTECTED] wrote: The release has been submitted for mirroring. Here's a draft announcement that we could post tomorrow morning, including a link to a corresponding security bulletin announcement

Re: [VOTE] Struts 2.0.11.1 Quality (fast track) - PROPOSED ANNOUNCEMENT

2008-03-03 Thread Don Brown
it is useful to draw attention to the vulnerability. Don Brown wrote: Looks good. Thanks for creating a security bulletin as well. Don On 3/4/08, Rene Gielen [EMAIL PROTECTED] wrote: The release has been submitted for mirroring. Here's a draft announcement that we could post

Re: [VOTE] Struts 2.0.11.1 Quality (fast track) - PROPOSED ANNOUNCEMENT

2008-03-04 Thread Don Brown
grateful :) Don On 3/4/08, Rene Gielen [EMAIL PROTECTED] wrote: Agreed. How should we put it better? Don Brown schrieb: Good point. This pales in comparison to, say, the OGNL remote code exploit. XSS exploits, while important, just aren't anywhere near as big of deal. Don

Re: [VOTE] Struts 2.0.11.1 Quality (fast track) - PROPOSED ANNOUNCEMENT

2008-03-04 Thread Don Brown
to admit :) - just copied from 001, what would be a fitting rating here? Don Brown schrieb: What about: * All developers are strongly advised to update Struts 2 applications to Struts 2.0.11.1 to prevent XSS attacks through Struts 2 tags. In this way, we aren't quite so

[s2] Leverage Spring's namespace support for s2 configuration

2008-03-09 Thread Don Brown
I've put down some thoughts as to how we could leverage Spring's XML schema support to merge the Struts and Spring XML into one file. For Struts apps, this might be a nice way to leverage all the XML loading advantages of Spring and remove yet another configuration file, however my main

Re: 2.1 build

2008-04-06 Thread Don Brown
FWIW, Struts Annotations 1.0.3 has been released and approved, but I haven't had time to finish it off by signing the jar and moving it to the official repo. I'll try to find some time in the next few days if no one beats me to it. Don On Fri, Apr 4, 2008 at 8:59 PM, Ted Husted [EMAIL

[s2] Get rid of optional dependencies

2008-04-07 Thread Don Brown
In an effort to make Struts 2 more OSGi friendly, I noticed we have a number of optional dependencies that confuse the bnd plugin. I'd like to take the next step and resolve these: * DWR - Create a struts2-dwr-plugin * Velocity - Create a struts2-velocity-plugin * Commons File Upload - Change

Re: Feature sponsorship proposal

2008-04-07 Thread Don Brown
companies have different implementations, which is a great place to be in. Do we need to think this far ahead or using Agile methods do we not want to over design this process initially ? -Rob Don Brown wrote: As more and more companies start using open

Re: [s2] Get rid of optional dependencies

2008-04-07 Thread Don Brown
in there too. Same process to solve the TestNG dependency only there, we don't even need it in src/test/java. Don On Mon, Apr 7, 2008 at 11:43 PM, Antonio Petrelli [EMAIL PROTECTED] wrote: 2008/4/7, Don Brown [EMAIL PROTECTED]: * JUnit - Create struts2-junit-plugin (we'd probably have to copy

Re: Feature sponsorship proposal

2008-04-08 Thread Don Brown
Exactly - I'm not suggesting we change how we accept contributions at all and of course, we would try to give credit to individuals where desired, but look at it this way: if IBM donated a server to us, would we credit the person who processed the order or the company that purchased the computer?

Re: Are Struts JARs OSGi Aware?

2008-04-08 Thread Don Brown
All it means is we'd ensure certain values are in our MANIFEST.MF file. There is this nice m2 plugin that does all the work for you. This is something I'm working on for Struts 2 (hence trying to remove optional dependencies). Don On Wed, Apr 9, 2008 at 6:12 AM, Paul Benedict [EMAIL PROTECTED]

Re: 2.1 build

2008-04-08 Thread Don Brown
*sigh* is this all necessary? I mean, by using the Maven release plugin, the binaries are created off the tag. A quick SVN command can confirm the tag hasn't been modified, so I don't see any problem with Jeromy building new binaries and finishing the release. The vote had passed with the

Re: 2.1 build

2008-04-09 Thread Don Brown
Actually, it did. If you just add up the +1's, they are much more than the single -1, and even that was given under the assumption that as soon as there were signatures, it would turn into a +1. My reading of the bylaws shows it only needed a majority vote after a 72 hour window, so yes, it did

Re: i18n/TextProvider issues

2008-04-10 Thread Don Brown
Sounds good. Are there any performance implications? Don On Fri, Apr 11, 2008 at 3:48 PM, Jeromy Evans [EMAIL PROTECTED] wrote: I've been investigating some i18n issues in the 2.1.x branch and found that the search algorithm used by the Text tag differs from that of UIBean. The Text tag

Re: i18n/TextProvider issues

2008-04-11 Thread Don Brown
Neat, hard to argue with that. Don On Fri, Apr 11, 2008 at 4:13 PM, Jeromy Evans [EMAIL PROTECTED] wrote: Don Brown wrote: Sounds good. Are there any performance implications? Don According to https://issues.apache.org/struts/browse/WW-1681 the performance implications

Re: [s2] Get rid of optional dependencies

2008-04-12 Thread Don Brown
wonder if it is even used. So anyways, I wasn't able to get rid of all the optionals, but it is looking better. The last major refactoring I've been contemplating is moving tags out into their own plugin, but I'm still not 100% sure it is a good idea. Don On Tue, Apr 8, 2008 at 1:04 PM, Don Brown

Re: S2 trunk broken build

2008-04-14 Thread Don Brown
Should be fixed. Don On Mon, Apr 14, 2008 at 6:27 PM, Giovanni Azua [EMAIL PROTECTED] wrote: hi, I get the Maven failure below while trying to build the latest S2 trunk (rev 647691). The following plugin is not found: -DgroupId=org.apache.myfaces.tobago -DartifactId=maven-apt-plugin

Re: 2.1 build

2008-04-16 Thread Don Brown
Ok, Struts Annotations 1.0.3 has been signed and released to the ibiblio sync'ed repository. If anyone was itching to jump in and get Struts 2.1.1 out, this would be the time. Don On Sun, Apr 6, 2008 at 10:28 PM, Don Brown [EMAIL PROTECTED] wrote: FWIW, Struts Annotations 1.0.3 has been

Re: 2.1 build

2008-04-17 Thread Don Brown
I'm in the process of creating that build right now. Soon, I will announce the build to this list and ask for testing. The Struts community will then vote as to its quality, and it may turn into a beta or GA release, or remain a test build. Personally, I'm aiming for a beta release and expect

Re: svn commit: r649024 - /struts/struts2/trunk/pom.xml

2008-04-17 Thread Don Brown
The fact that it was reporting hundreds of errors leads me to believe the problem is probably a combination of its configuration and the code, but regardless, getting through the release process is more important than running down this issue to me. I hope to investigate it further after the build

Re: 2.1 build

2008-04-17 Thread Don Brown
test drive today and tomorrow. Thanks On Thu, Apr 17, 2008 at 10:27 AM, Don Brown [EMAIL PROTECTED] wrote: I'm in the process of creating that build right now. Soon, I will announce the build to this list and ask for testing. The Struts community will then vote as to its quality

[s2] Test build of 2.1.1 available

2008-04-17 Thread Don Brown
The test build of Struts 2.1.1 is available. No determination as to the quality ('alpha,' 'beta,' or 'GA') of Struts 2.1.1 has been made, and at this time it is simply a test build. We welcome any comments you may have, and will take all feedback into account if a quality vote is called for this

Re: [s2] Test build of 2.1.1 available

2008-04-18 Thread Don Brown
Whoops, that should be: http://struts.apache.org/2.x/docs/version-notes-211.html Don On Sat, Apr 19, 2008 at 12:07 PM, Jeromy Evans [EMAIL PROTECTED] wrote: Don Brown wrote: The test build of Struts 2.1.1 is available. Release notes: * http://struts.apache.org/2.0.11.1/docs

[s2] A thought - next generation OSGi-based?

2008-04-24 Thread Don Brown
As I learn more and more about OSGi, I wonder if it might be the solution to several big problems we seem to have at the moment: poor reloadability and the lack of a solid API. With OSGi, you can drop bundles in and out of the system at runtime, even running multiple versions of the same bundle

Re: [OT] Sanity-check trunk pom version num

2008-04-24 Thread Don Brown
2.1.2-SNAPSHOT Don On Fri, Apr 25, 2008 at 12:22 PM, Dave Newton [EMAIL PROTECTED] wrote: Can someone tell me if I'm nuts and/or my Eclipse/Maven thing is going crazy? What should I get as a plugin snapshot version number in trunk, 2.1.1 or 2.1.2, when building via Maven? Thanks, and

Re: [s2] A thought - next generation OSGi-based?

2008-04-25 Thread Don Brown
, 3.2, etc are all compatible. Then when Struts4 start wanting to break compatibility, you branch Struts3, and start breaking away on Trunk. -bp Don Brown wrote: As I learn more and more about OSGi, I wonder if it might be the solution to several big

[s2] Struts 2.1.2 build target

2008-04-26 Thread Don Brown
I'd like to roll the 2.1.2 test build this Friday. The updated release plan is here: http://struts.apache.org/2.x/docs/version-notes-212.html Please ensure the build stays green, and make any major changes, like bringing in the Conventions plugin, in the next day or two, and not any later. The

Re: [s2] A thought - next generation OSGi-based?

2008-04-27 Thread Don Brown
a good appreciation of what *actually exists* in this area. I'd take care to ensure Struts2 continues to target entry-level containers though (ie. Tomcat rather than Glassfish). Don Brown wrote: As I learn more and more about OSGi, I wonder if it might be the solution to several big

Re: [s2] Struts 2.1.2 build target

2008-04-27 Thread Don Brown
[EMAIL PROTECTED]: 2008/4/27 Don Brown [EMAIL PROTECTED]: Missing license headers: * https://issues.apache.org/struts/browse/WW-2147 The fix is almost ready, but I need to finish the RAT plugin configuration. Done :-) Antonio

Re: [s2] A thought - next generation OSGi-based?

2008-04-28 Thread Don Brown
to be completely overhauled? Move it to the ASF? Or do we drop XW altogether for something else? Is there enough here with this proposal for an Action Framework JSR? On Sun, Apr 27, 2008 at 6:49 AM, Don Brown [EMAIL PROTECTED] wrote: Ok, I promised a more detailed proposal, so here

Re: missing DWRValidator in struts 2.1.1

2008-04-30 Thread Don Brown
The DWR class in question has been moved to the DWR Plugin. Drop that jar into your WEB-INF/lib to install. Don On Wed, Apr 30, 2008 at 10:40 PM, Pedro Herrera [EMAIL PROTECTED] wrote: I´m migrating a system created with struts 2.0.11 to struts 2.1.1. dwr.xml has configurated a

[VOTE] Struts 2.1.2 test build

2008-05-01 Thread Don Brown
The Struts 2.1.2 test build is now available. Release notes: * http://struts.apache.org/2.x/docs/version-notes-212.html Distribution: * http://people.apache.org/builds/struts/2.1.2/ Maven 2 staging repository: * http://people.apache.org/builds/struts/2.1.2/m2-staging-repository/ Once you have

[s2] Release feedback

2008-05-02 Thread Don Brown
Ok, so this time, it took probably two hours to generate the release all told. The guide is now pretty accurate, but the steps themselves can take quite a while. This time, I copied my keys, m2 config, etc. over to a server in the US and ran the release from there, and boy, what a difference

Re: [VOTE] Struts 2.1.2 test build

2008-05-02 Thread Don Brown
On Fri, May 2, 2008 at 3:12 PM, Don Brown [EMAIL PROTECTED] wrote: [ ] Leave at test build [ ] Alpha [X] Beta [ ] General Availability (GA) I don't think it is stable enough for a GA (and there are apparent licensing issues I guess), but I think it is good enough to be BETA and to get

Re: [VOTE] Struts 2.1.2 test build

2008-05-02 Thread Don Brown
Petrelli [EMAIL PROTECTED] wrote: 2008/5/2 Don Brown [EMAIL PROTECTED]: [X] Alpha (+0) I vote +0 to Alpha because, from the License point of view, there are minor problems, but I did not test the build as a software artifact. Antonio

Re: [VOTE] Struts 2.1.2 test build

2008-05-02 Thread Don Brown
Yep, and it won't. This is basically what the GA release will look like minus the bugs (hopefully). No more API changes. Don On Fri, May 2, 2008 at 5:27 PM, Antonio Petrelli [EMAIL PROTECTED] wrote: 2008/5/2 Don Brown [EMAIL PROTECTED]: Remember, beta means it is feature complete

<    4   5   6   7   8   9   10   11   12   13   >