Re: Incoming refactoring

2016-12-14 Thread Mark Thomas
On 14/12/2016 09:33, Rémy Maucherat wrote: > 2016-12-14 10:07 GMT+01:00 Mark Thomas : > >> On 14/12/2016 08:54, Rémy Maucherat wrote: >>> 2016-12-14 9:50 GMT+01:00 Mark Thomas : >>> The failure happens on current trunk too so I don't think this is

Re: Incoming refactoring

2016-12-14 Thread Rémy Maucherat
2016-12-14 10:07 GMT+01:00 Mark Thomas : > On 14/12/2016 08:54, Rémy Maucherat wrote: > > 2016-12-14 9:50 GMT+01:00 Mark Thomas : > > > >> The failure happens on current trunk too so I don't think this is > >> related to the refactoring. However, I am going to

Re: Incoming refactoring

2016-12-14 Thread Mark Thomas
On 14/12/2016 08:54, Rémy Maucherat wrote: > 2016-12-14 9:50 GMT+01:00 Mark Thomas : > >> The failure happens on current trunk too so I don't think this is >> related to the refactoring. However, I am going to investigate this >> failure first - before I apply the refactoring.

Re: Incoming refactoring

2016-12-14 Thread Rémy Maucherat
2016-12-14 9:50 GMT+01:00 Mark Thomas : > The failure happens on current trunk too so I don't think this is > related to the refactoring. However, I am going to investigate this > failure first - before I apply the refactoring. > > What is the intermittent failure ?

Re: Incoming refactoring

2016-12-14 Thread Mark Thomas
On 13/12/2016 21:14, Mark Thomas wrote: > On 13/12/2016 15:21, Mark Thomas wrote: >> On 13/12/2016 15:09, Christopher Schultz wrote: >>> Mark, >>> >>> On 12/13/16 6:24 AM, Mark Thomas wrote: Hi, Just a heads up that - assuming the currently running tests pass - I'll be

Re: Incoming refactoring

2016-12-13 Thread Mark Thomas
On 13/12/2016 15:21, Mark Thomas wrote: > On 13/12/2016 15:09, Christopher Schultz wrote: >> Mark, >> >> On 12/13/16 6:24 AM, Mark Thomas wrote: >>> Hi, >>> >>> Just a heads up that - assuming the currently running tests pass - I'll >>> be committing a batch of connector refactoring changes. The

Re: Incoming refactoring

2016-12-13 Thread Mark Thomas
On 13/12/2016 15:09, Christopher Schultz wrote: > Mark, > > On 12/13/16 6:24 AM, Mark Thomas wrote: >> Hi, >> >> Just a heads up that - assuming the currently running tests pass - I'll >> be committing a batch of connector refactoring changes. The general aim >> of these changes is: >> >> -

Re: Incoming refactoring

2016-12-13 Thread Christopher Schultz
Mark, On 12/13/16 6:24 AM, Mark Thomas wrote: > Hi, > > Just a heads up that - assuming the currently running tests pass - I'll > be committing a batch of connector refactoring changes. The general aim > of these changes is: > > - Reduce the duplication of configuration between Protocol and