svn commit: r1777724 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java webapps/docs/changelog.xml

Author: markt Date: Fri Jan 6 22:02:29 2017 New Revision: 124 URL: http://svn.apache.org/viewvc?rev=124=rev Log: Ensure UpgradeProcessor instances associated with closed connections are removed from the map of current connections to Processors. Modified: tomcat/tc8.5.x/trunk/

svn commit: r1777723 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/AbstractProtocol.java java/org/apache/coyote/LocalStrings.properties

Author: markt Date: Fri Jan 6 22:01:49 2017 New Revision: 123 URL: http://svn.apache.org/viewvc?rev=123=rev Log: Improve debug logging for tracking Processor usage Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java

svn commit: r1777722 - in /tomcat/trunk: java/org/apache/tomcat/util/net/AprEndpoint.java webapps/docs/changelog.xml

Author: markt Date: Fri Jan 6 22:00:28 2017 New Revision: 122 URL: http://svn.apache.org/viewvc?rev=122=rev Log: Ensure UpgradeProcessor instances associated with closed connections are removed from the map of current connections to Processors. Modified:

svn commit: r1777721 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocol.java LocalStrings.properties

Author: markt Date: Fri Jan 6 21:54:14 2017 New Revision: 121 URL: http://svn.apache.org/viewvc?rev=121=rev Log: Improve debug logging for tracking Processor usage Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java

Re: Wrong type of the value of javax.servlet.error.exception_type

Martin, On 1/6/17 8:23 AM, Martin Grigorov wrote: > I've just upgraded my local/development Tomcat to 8.5.10 and I've hit a > problem in Apache Wicket: > > java.lang.ClassCastException: java.lang.String cannot be cast to > java.lang.Class > at >

Re: svn commit: r1777619 - in /tomcat/trunk: java/org/apache/tomcat/websocket/server/WsFrameServer.java webapps/docs/changelog.xml

On 06/01/2017 20:22, Violeta Georgieva wrote: > 2017-01-06 21:29 GMT+02:00 Mark Thomas : >> >> On 06/01/2017 15:57, Mark Thomas wrote: >>> On 06/01/2017 14:45, ma...@apache.org wrote: Author: markt Date: Fri Jan 6 14:45:03 2017 New Revision: 1777619 URL:

Re: svn commit: r1777619 - in /tomcat/trunk: java/org/apache/tomcat/websocket/server/WsFrameServer.java webapps/docs/changelog.xml

2017-01-06 21:29 GMT+02:00 Mark Thomas : > > On 06/01/2017 15:57, Mark Thomas wrote: > > On 06/01/2017 14:45, ma...@apache.org wrote: > >> Author: markt > >> Date: Fri Jan 6 14:45:03 2017 > >> New Revision: 1777619 > >> > >> URL: http://svn.apache.org/viewvc?rev=1777619=rev > >>

Re: svn commit: r1777619 - in /tomcat/trunk: java/org/apache/tomcat/websocket/server/WsFrameServer.java webapps/docs/changelog.xml

On 06/01/2017 15:57, Mark Thomas wrote: > On 06/01/2017 14:45, ma...@apache.org wrote: >> Author: markt >> Date: Fri Jan 6 14:45:03 2017 >> New Revision: 1777619 >> >> URL: http://svn.apache.org/viewvc?rev=1777619=rev >> Log: >> Partial revert of r1534619. >> The caller has to be able to

Re: svn commit: r1777647 - in /tomcat/trunk: java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

2017-01-06 17:55 GMT+01:00 Violeta Georgieva : > 2017-01-06 18:50 GMT+02:00 : > > > > Author: remm > > Date: Fri Jan 6 16:50:50 2017 > > New Revision: 1777647 > > > > URL: http://svn.apache.org/viewvc?rev=1777647=rev > > Log: > > Revert try/finally for simple

svn commit: r1777652 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

Author: remm Date: Fri Jan 6 16:56:29 2017 New Revision: 1777652 URL: http://svn.apache.org/viewvc?rev=1777652=rev Log: Revert try/finally for simple tags. Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java

Re: svn commit: r1777647 - in /tomcat/trunk: java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

2017-01-06 18:50 GMT+02:00 : > > Author: remm > Date: Fri Jan 6 16:50:50 2017 > New Revision: 1777647 > > URL: http://svn.apache.org/viewvc?rev=1777647=rev > Log: > Revert try/finally for simple tags. I just succeeded to extract a test case. Can you look at the patch below and

svn commit: r1777651 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

Author: remm Date: Fri Jan 6 16:54:09 2017 New Revision: 1777651 URL: http://svn.apache.org/viewvc?rev=1777651=rev Log: Revert try/finally for simple tags. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Generator.java

svn commit: r1777650 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

Author: remm Date: Fri Jan 6 16:53:34 2017 New Revision: 1777650 URL: http://svn.apache.org/viewvc?rev=1777650=rev Log: Revert try/finally for simple tags. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/jasper/compiler/Generator.java

svn commit: r1777648 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

Author: remm Date: Fri Jan 6 16:52:13 2017 New Revision: 1777648 URL: http://svn.apache.org/viewvc?rev=1777648=rev Log: Revert try/finally for simple tags. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/jasper/compiler/Generator.java

svn commit: r1777647 - in /tomcat/trunk: java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

Author: remm Date: Fri Jan 6 16:50:50 2017 New Revision: 1777647 URL: http://svn.apache.org/viewvc?rev=1777647=rev Log: Revert try/finally for simple tags. Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java tomcat/trunk/webapps/docs/changelog.xml Modified:

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 16:52 GMT+01:00 Violeta Georgieva : > With r1775598 changes, the declaration of the scripting variable now is in > try/finally block and it is not visible outside this block. > > http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/a >

Re: svn commit: r1777619 - in /tomcat/trunk: java/org/apache/tomcat/websocket/server/WsFrameServer.java webapps/docs/changelog.xml

On 06/01/2017 14:45, ma...@apache.org wrote: > Author: markt > Date: Fri Jan 6 14:45:03 2017 > New Revision: 1777619 > > URL: http://svn.apache.org/viewvc?rev=1777619=rev > Log: > Partial revert of r1534619. > The caller has to be able to differentiate between no data and EOF. While this fixed

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 16:57 GMT+02:00 Violeta Georgieva : > > > > 2017-01-06 15:44 GMT+02:00 Violeta Georgieva : > > > > > > > > 2017-01-06 15:24 GMT+02:00 Rémy Maucherat : > > > > > > 2017-01-06 13:58 GMT+01:00 Violeta Georgieva :

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 15:44 GMT+02:00 Violeta Georgieva : > > > > 2017-01-06 15:24 GMT+02:00 Rémy Maucherat : > > > > 2017-01-06 13:58 GMT+01:00 Violeta Georgieva : > > > > > I'm observing the exception below: > > > > > > > Maybe but I fail to see the

svn commit: r1777620 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/websocket/server/WsFrameServer.java webapps/docs/changelog.xml

Author: markt Date: Fri Jan 6 14:47:17 2017 New Revision: 1777620 URL: http://svn.apache.org/viewvc?rev=1777620=rev Log: Partial revert of r1534619. The caller has to be able to differentiate between no data and EOF. Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1777619 - in /tomcat/trunk: java/org/apache/tomcat/websocket/server/WsFrameServer.java webapps/docs/changelog.xml

Author: markt Date: Fri Jan 6 14:45:03 2017 New Revision: 1777619 URL: http://svn.apache.org/viewvc?rev=1777619=rev Log: Partial revert of r1534619. The caller has to be able to differentiate between no data and EOF. Modified:

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 14:44 GMT+01:00 Violeta Georgieva : > 2017-01-06 15:24 GMT+02:00 Rémy Maucherat : > > > > 2017-01-06 13:58 GMT+01:00 Violeta Georgieva : > > > > > I'm observing the exception below: > > > > > > > Maybe but I fail to see the

svn commit: r1777609 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

Author: remm Date: Fri Jan 6 13:47:21 2017 New Revision: 1777609 URL: http://svn.apache.org/viewvc?rev=1777609=rev Log: 60497: Follow up fix using a better variable name for the tag reuse flag. Modified: tomcat/tc6.0.x/trunk/ (props changed)

svn commit: r1777608 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

Author: remm Date: Fri Jan 6 13:45:42 2017 New Revision: 1777608 URL: http://svn.apache.org/viewvc?rev=1777608=rev Log: 60497: Follow up fix using a better variable name for the tag reuse flag. Modified: tomcat/tc7.0.x/trunk/ (props changed)

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 15:24 GMT+02:00 Rémy Maucherat : > > 2017-01-06 13:58 GMT+01:00 Violeta Georgieva : > > > I'm observing the exception below: > > > > Maybe but I fail to see the actual problem in the generated code, and it's > not normal anyway that it makes a

svn commit: r1777607 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

Author: remm Date: Fri Jan 6 13:44:05 2017 New Revision: 1777607 URL: http://svn.apache.org/viewvc?rev=1777607=rev Log: 60497: Follow up fix using a better variable name for the tag reuse flag. Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1777606 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

Author: remm Date: Fri Jan 6 13:42:09 2017 New Revision: 1777606 URL: http://svn.apache.org/viewvc?rev=1777606=rev Log: 60497: Follow up fix using a better variable name for the tag reuse flag. Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1777605 - in /tomcat/trunk: java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

Author: remm Date: Fri Jan 6 13:28:40 2017 New Revision: 1777605 URL: http://svn.apache.org/viewvc?rev=1777605=rev Log: Follow up for 60497: use the tag variable as the base for the reused flag. Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

Wrong type of the value of javax.servlet.error.exception_type

Hi, I've just upgraded my local/development Tomcat to 8.5.10 and I've hit a problem in Apache Wicket: java.lang.ClassCastException: java.lang.String cannot be cast to java.lang.Class at org.apache.wicket.protocol.http.servlet.ErrorAttributes.of(ErrorAttributes.java:152) line 152 is: Class type

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 13:58 GMT+01:00 Violeta Georgieva : > I'm observing the exception below: > Maybe but I fail to see the actual problem in the generated code, and it's not normal anyway that it makes a difference when the change is to replace with . However, I should have used

svn commit: r1777602 - /tomcat/trunk/webapps/docs/changelog.xml

Author: markt Date: Fri Jan 6 13:13:46 2017 New Revision: 1777602 URL: http://svn.apache.org/viewvc?rev=1777602=rev Log: Fix typo Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL:

svn commit: r1777603 - /tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Author: markt Date: Fri Jan 6 13:14:19 2017 New Revision: 1777603 URL: http://svn.apache.org/viewvc?rev=1777603=rev Log: Fix typo Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml URL:

Re: [VOTE] Release Apache Tomcat 8.5.10

On 06/01/2017 12:58, Violeta Georgieva wrote: > Hi, > > 2017-01-06 1:38 GMT+02:00 Mark Thomas : >> >> The proposed Apache Tomcat 8.5.10 release is now available for voting. >> >> The major changes compared to the 8.5.9 release are: >> >> - HTTP/2 fixes and improvements >> >> -

Re: [VOTE] Release Apache Tomcat 8.5.10

Hi, 2017-01-06 1:38 GMT+02:00 Mark Thomas : > > The proposed Apache Tomcat 8.5.10 release is now available for voting. > > The major changes compared to the 8.5.9 release are: > > - HTTP/2 fixes and improvements > > - Simpler JSP file encoding detector that delegates XML prolog

Re: [VOTE] Release Apache Tomcat 8.5.10

[ X ] Stable - go ahead and release as 8.5.10 Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Jan 6, 2017 at 12:38 AM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.10 release is now available for voting. > > The major changes

[Bug 60555] run by ssl and port:443 close_wait

https://bz.apache.org/bugzilla/show_bug.cgi?id=60555 --- Comment #3 from hiki --- (In reply to Mark Thomas from comment #1) > > *** This bug has been marked as a duplicate of bug 60035 *** Thanks ,the problem is solved, but I don't think the relationship with r1746551 is

buildbot success in on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2015 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1777579 - /tomcat/trunk/java/org/apache/juli/AsyncFileHandler.java

Author: markt Date: Fri Jan 6 10:30:15 2017 New Revision: 1777579 URL: http://svn.apache.org/viewvc?rev=1777579=rev Log: Trivial ws change to trigger CI build. Modified: tomcat/trunk/java/org/apache/juli/AsyncFileHandler.java Modified:

Remaining poller thread properties of Nio2Endpoint in tomcat 8

Hi there, I have observed that there are some poller thread properties, e.g. pollerThreadPriority still remaining in org.apache.tomcat.util.net.Nio2Endpoint (line 148-150). I do not see any place that is referring it, and it has been dropped in 8.5.x and 9.x. Any ideas why it is still

Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 0:38 GMT+01:00 Mark Thomas : > The proposed Apache Tomcat 8.5.10 release is now available for voting. > > The major changes compared to the 8.5.9 release are: > > - HTTP/2 fixes and improvements > > - Simpler JSP file encoding detector that delegates XML prolog >

[Bug 60555] run by ssl and port:443 close_wait

https://bz.apache.org/bugzilla/show_bug.cgi?id=60555 hiki changed: What|Removed |Added Resolution|DUPLICATE |FIXED

[Bug 60554] Update language style in whichversion.xml

https://bz.apache.org/bugzilla/show_bug.cgi?id=60554 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1777555 - in /tomcat/site/trunk: docs/whichversion.html xdocs/whichversion.xml

Author: markt Date: Fri Jan 6 09:55:17 2017 New Revision: 1777555 URL: http://svn.apache.org/viewvc?rev=1777555=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60554 Better table headings Based on a patch by Michael Osipov Modified: tomcat/site/trunk/docs/whichversion.html

svn commit: r1777554 - /tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

Author: huxing Date: Fri Jan 6 09:53:38 2017 New Revision: 1777554 URL: http://svn.apache.org/viewvc?rev=1777554=rev Log: Fix javadoc, there is no poller thread in NIO2. Modified: tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified:

svn commit: r1777552 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

Author: huxing Date: Fri Jan 6 09:50:30 2017 New Revision: 1777552 URL: http://svn.apache.org/viewvc?rev=1777552=rev Log: Fix javadoc, there is no poller thread in NIO2. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified:

Re: [VOTE] Release Apache Tomcat 9.0.0.M16

2017-01-06 0:37 GMT+01:00 Mark Thomas : > The proposed Apache Tomcat 9.0.0.M16 release is now available for voting. > > This is a milestone release for the 9.0.x branch. It should be > noted that, as a milestone release: > - Servlet 4.0 is not finalised > - The EGs have not

svn commit: r1777549 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/juli/FileHandler.java

Author: markt Date: Fri Jan 6 09:42:15 2017 New Revision: 1777549 URL: http://svn.apache.org/viewvc?rev=1777549=rev Log: Simplify Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/juli/FileHandler.java Propchange: tomcat/tc7.0.x/trunk/

svn commit: r1777547 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/juli/FileHandler.java

Author: markt Date: Fri Jan 6 09:41:41 2017 New Revision: 1777547 URL: http://svn.apache.org/viewvc?rev=1777547=rev Log: Simplify Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/juli/FileHandler.java Propchange: tomcat/tc8.5.x/trunk/

svn commit: r1777546 - /tomcat/trunk/java/org/apache/juli/FileHandler.java

Author: markt Date: Fri Jan 6 09:40:45 2017 New Revision: 1777546 URL: http://svn.apache.org/viewvc?rev=1777546=rev Log: Simplify Modified: tomcat/trunk/java/org/apache/juli/FileHandler.java Modified: tomcat/trunk/java/org/apache/juli/FileHandler.java URL:

Re: [VOTE] Release Apache Tomcat 8.5.10

Hi, The proposed 8.5.10 release is: [ ] Broken - do not release [ X ] Stable - go ahead and release as 8.5.10 All test cases passed. Test web application works fine. -- From:Mark Thomas Time:2017 Jan 6 (Fri) 07:39