Re: svn commit: r367115 - /tomcat/connectors/trunk/coyote/src/java/org/apache/coyote/Response.java

2006-01-09 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: Author: markt Date: Sun Jan 8 14:48:43 2006 New Revision: 367115 URL: http://svn.apache.org/viewcvs?rev=367115view=rev Log: Fix bug 29214. containsHeader() not working for Content-Length and Content-Type I don't like this fix (to a non issue), but since I have the

Re: svn commit: r367115 - /tomcat/connectors/trunk/coyote/src/java/org/apache/coyote/Response.java

2006-01-09 Thread Mark Thomas
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Fix bug 29214. containsHeader() not working for Content-Length and Content-Type Rather than adding complexity in code which is critical, I would have hacked instead the org.apache.catalina.connector.Response.containsHeader method, which is not

Re: svn commit: r367115 - /tomcat/connectors/trunk/coyote/src/java/org/apache/coyote/Response.java

2006-01-09 Thread Costin Manolache
If you're looking to reduce complexity - one idea would be to check if the redundant fields are actually needed, because that's the actual source of the problem. I can only think of performance benefits - storing the contentLength as an int may be a good way to avoid conversion to and from String

svn commit: r367115 - /tomcat/connectors/trunk/coyote/src/java/org/apache/coyote/Response.java

2006-01-08 Thread markt
Author: markt Date: Sun Jan 8 14:48:43 2006 New Revision: 367115 URL: http://svn.apache.org/viewcvs?rev=367115view=rev Log: Fix bug 29214. containsHeader() not working for Content-Length and Content-Type Modified: tomcat/connectors/trunk/coyote/src/java/org/apache/coyote/Response.java