Re: Commens on VELTOOLS from trunk [1]

2018-06-28 Thread Claude Brisson
Thanks! On 06/28/2018 09:55 PM, Michael Osipov wrote: Am 2018-06-25 um 19:25 schrieb Claude Brisson: On 06/25/2018 06:59 PM, Michael Osipov wrote: Folks, release 3.0 is pending, I took some time to check the current project status. Here are my observations: * STATUS seems obsolete *

Re: Commens on VELTOOLS from trunk [1]

2018-06-28 Thread Michael Osipov
Am 2018-06-25 um 19:25 schrieb Claude Brisson: On 06/25/2018 06:59 PM, Michael Osipov wrote: Folks, release 3.0 is pending, I took some time to check the current project status. Here are my observations: * STATUS seems obsolete * WHY_THREE_JARS.txt seems obsolete * README.txt seems obsolete

Re: Cannot build Tools from trunk

2018-06-28 Thread Claude Brisson
*you* spotted the bug and the entire Cargo variables are /crap/, unusable for policy files. The produce is java.io.File#toString() which does not work for URIs. The output is "file:D:\Projects\veltools...". This is like MNG-6386. There is no way to fix that, but only in Cargo by adding to

Re: Cannot build Tools from trunk

2018-06-28 Thread Michael Osipov
Am 2018-06-28 um 14:34 schrieb Claude Brisson: *you* spotted the bug and the entire Cargo variables are /crap/, unusable for policy files. The produce is java.io.File#toString() which does not work for URIs. The output is "file:D:\Projects\veltools...". This is like MNG-6386. There is no

Comments on VELTOOLS on trunk [2]

2018-06-28 Thread Michael Osipov
As promised a few (non-exhaustive) comments on source and POMs: * Serializable tools don't have a serialVersionUID * A lot of code does not use generics * Boilerplate code which can be replaced with Commons Lang 3, e.g., Verify, ClassUtils, StringUtils. Engine relies on it anyway. * There is