Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-04 Thread Johan Compagner
everybody that is using eclipse 3.3 automatically uses the save actions because its enabled/configured in the project properties and then checked in under the project (.settings dir) do a complete reformat at once is a good idea, we can do that today i don't have a problem with that. johan On

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-04 Thread Jean-Baptiste Quenot
* Johan Compagner: do a complete reformat at once is a good idea, we can do that today i don't have a problem with that. Yes please, so that I can follow you and understand what you do on Wicket :-) Oh and BTW I'm still using Eclipse 3.2 that's why I was not seeing the option. --

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-04 Thread Johan Compagner
fine by me, who is going to do that at that time? On 9/4/07, Frank Bille [EMAIL PROTECTED] wrote: On 9/4/07, Johan Compagner [EMAIL PROTECTED] wrote: Oh and BTW I'm still using Eclipse 3.2 that's why I was not seeing the option. Eclipse 3.2 is ss last year...

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-04 Thread Johan Compagner
But event then if there where a bit active userson IDEA then still it is a good idea that the eclipse users do how we do it now its way better then nothing.. Can IDEA not push it like eclipse? johan On 9/4/07, Gwyn Evans [EMAIL PROTECTED] wrote: On Monday, September 3, 2007, 9:38:50 PM, Eelco

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-04 Thread Gwyn Evans
Not sure what you mean by push it? I wasn't saying that there shouldn't be the Eclipse settings, just that at some stage it might be worth documenting them in a more generic way than just the .pref files. Unfortunately, while I can generate a IDEA 7 project by importing the pom.xml files, I

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-04 Thread Martijn Dashorst
I have tried using IDEA (7) for a while but it Just Didn't Click (tm). I can't seem to get around the various keybindings for overriding, completion and implementation, the fact that it lacks auto compile on save. Martijn On 9/4/07, Gwyn Evans [EMAIL PROTECTED] wrote: Not sure what you mean by

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-04 Thread Gwyn Evans
On Tuesday, September 4, 2007, 9:35:23 PM, Johan [EMAIL PROTECTED] wrote: On 9/4/07,Gwyn Evans[EMAIL PROTECTED] wrote: Not sure what you mean by "push it"? when you open a project project properties page then many things can be configured only for the project itself you can

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-03 Thread Jean-Baptiste Quenot
* [EMAIL PROTECTED]: Author: ehillenius Date: Tue Aug 28 14:19:53 2007 New Revision: 570573 URL: http://svn.apache.org/viewvc?rev=570573view=rev Log: better exception Modified:

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-03 Thread Matej Knopp
Well, for some reason wicket is setup that it reformats source code on every save by default. -Matej On 9/3/07, Jean-Baptiste Quenot [EMAIL PROTECTED] wrote: * [EMAIL PROTECTED]: Author: ehillenius Date: Tue Aug 28 14:19:53 2007 New Revision: 570573 URL:

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-03 Thread Eelco Hillenius
Can you please, please avoid to reformat the classes everytime you make a change? That makes it impossible to review your modification. I typically do that, but like here, I forgot it. If you really want the sources to have consistent formatting, please do it in a separate commit, possibly

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-03 Thread Eelco Hillenius
What I suggest is: disable automatic reformatting, as it may introduce noise in the diff. And once for all reformat the whole Java code using Ctrl-Shift-F on the whole source tree. What I suggest is that everyone formats their code so we don't have this problem in the first place! The more

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-03 Thread Johan Compagner
I like it how it works now and maybe some of us like Eelco don't need it. but as long as some others don't do it as hard wired as he is. The auto cleanup/format of eclipse is great and should be kept on. I am saying from day 1 that this should be a basic CVS/SVN or what ever you use feature. (so

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-03 Thread Eelco Hillenius
On 9/3/07, Johan Compagner [EMAIL PROTECTED] wrote: I like it how it works now and maybe some of us like Eelco don't need it. but as long as some others don't do it as hard wired as he is. The auto cleanup/format of eclipse is great and should be kept on. I am saying from day 1 that this

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-03 Thread Igor Vaynberg
a big +1 from me. i wish we had enough access to svn where we can install a formatter as a pre-checkin filter, but we do not. so i think everyone should upgrade to eclipse 3.3 (if they yhavent already) and enable save-action: code formatting. we should set a date when we would run formatting on