Re: Wicket 1.3 Source Code?

2007-09-03 Thread Eelco Hillenius
On 9/2/07, Martijn Dashorst [EMAIL PROTECTED] wrote: On 9/3/07, Eelco Hillenius [EMAIL PROTECTED] wrote: I am trying to download the source code for wicket but I can't seem to find it. I have searched the forums and the website for the link to no avail. Hmmm. I see that we're not

Re: Wicket 1.3 Source Code?

2007-09-03 Thread Martijn Dashorst
On 9/3/07, Eelco Hillenius [EMAIL PROTECTED] wrote: I did: http://wicketstuff.org/maven/repository/org/apache/wicket/wicket/1.3.0-beta3/ That is not an official maven repo, it is a snapshot repository containing only.. snapshots. As such it is not sync'd with any other repo. And as an

Re: Wicket 1.3 Source Code?

2007-09-03 Thread Martijn Dashorst
Can someone remove those *non-release* jars from the wicketstuff repo? They are not signed, md5'd, etc. And please remove any automated build that deploys them on that server. Martijn On 9/3/07, Martijn Dashorst [EMAIL PROTECTED] wrote: On 9/3/07, Eelco Hillenius [EMAIL PROTECTED] wrote: I

Re: PopupCloseLink broken with REDIRECT_TO_RENDER strategy (WICKET-913): Anyone have a clue?

2007-09-03 Thread Matej Knopp
Well, JIRA looks to be down, so i'll reply here. The problem is, that in onClick we do this: // Remove the popup's page map from the session getPage().getPageMap().remove(); // Web page closes window using javascript code in PopupCloseLink$1.html

Re: ehcache based MarkupCache

2007-09-03 Thread Matej Knopp
Yeah, the apache mailing lists seem to forbit attachments. -Matej On 9/3/07, Jean-Baptiste Quenot [EMAIL PROTECTED] wrote: * Juergen Donnerstag: please find a patch for it attached (including test case) Ermmm sorry but there is nothing attached! Why don't you just file this as a JIRA

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-03 Thread Jean-Baptiste Quenot
* [EMAIL PROTECTED]: Author: ehillenius Date: Tue Aug 28 14:19:53 2007 New Revision: 570573 URL: http://svn.apache.org/viewvc?rev=570573view=rev Log: better exception Modified:

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-03 Thread Matej Knopp
Well, for some reason wicket is setup that it reformats source code on every save by default. -Matej On 9/3/07, Jean-Baptiste Quenot [EMAIL PROTECTED] wrote: * [EMAIL PROTECTED]: Author: ehillenius Date: Tue Aug 28 14:19:53 2007 New Revision: 570573 URL:

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-03 Thread Eelco Hillenius
Can you please, please avoid to reformat the classes everytime you make a change? That makes it impossible to review your modification. I typically do that, but like here, I forgot it. If you really want the sources to have consistent formatting, please do it in a separate commit, possibly

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-03 Thread Eelco Hillenius
What I suggest is: disable automatic reformatting, as it may introduce noise in the diff. And once for all reformat the whole Java code using Ctrl-Shift-F on the whole source tree. What I suggest is that everyone formats their code so we don't have this problem in the first place! The more

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-03 Thread Johan Compagner
I like it how it works now and maybe some of us like Eelco don't need it. but as long as some others don't do it as hard wired as he is. The auto cleanup/format of eclipse is great and should be kept on. I am saying from day 1 that this should be a basic CVS/SVN or what ever you use feature. (so

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-03 Thread Eelco Hillenius
On 9/3/07, Johan Compagner [EMAIL PROTECTED] wrote: I like it how it works now and maybe some of us like Eelco don't need it. but as long as some others don't do it as hard wired as he is. The auto cleanup/format of eclipse is great and should be kept on. I am saying from day 1 that this

Re: svn commit: r570573 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/protocol/http/request/WebRequestCodingStrategy.java

2007-09-03 Thread Igor Vaynberg
a big +1 from me. i wish we had enough access to svn where we can install a formatter as a pre-checkin filter, but we do not. so i think everyone should upgrade to eclipse 3.3 (if they yhavent already) and enable save-action: code formatting. we should set a date when we would run formatting on