I've created a release for Wicket 1.4-rc6. Until it is officially
released, you can download from the following locations:
SVN Tag: http://svn.apache.org/repos/asf/wicket/releases/wicket-1.4-rc6/
M2 Repo: http://people.apache.org/~ivaynberg/wicket-1.4-rc6/m2-repo/
Dist folder:
Hi,
I am writing a custom IStringResourceLoader and noticed that
IStringResourceLoader#loadStringResource(Class,String,Locale,String) is not
called from anywhere except from within the implementations themselves.
Shall we remove the method from the interface, or did I miss other uses?
Regards,
It's part of a public interface. You can't just remove it. Maybe the
internal Wicket code doesn't use it, but that doesn't mean that
someone else doesn't. Where are you thinking of removing it from? A
1.4-rcx or 1.5? I'd say you probably need to deprecate it before you
remove it.
On Tue, Jun
Yes, I understand that. However, as you typically register an
implementation of IStringResourceLoader in the Application's init. It
functions therefore only as a callback mechanism for Wicket itself. At
least, that is how I read the intent of the code.
Now I understand you are able to request
On Tue, Jun 30, 2009 at 8:32 AM, Erik van Oostene.vanoos...@grons.nl wrote:
The deprecation route does not work. Current implementation are rightly
using this method and should not get warnings because of that.
So how were you going to remove it?
I am only talking about the declaration on the interface.
Regards,
Erik.
On Tue, 30 Jun 2009 08:42:51 -0400, James Carman
jcar...@carmanconsulting.com wrote:
On Tue, Jun 30, 2009 at 8:32 AM, Erik van Oostene.vanoos...@grons.nl
wrote:
The deprecation route does not work. Current
On Tue, Jun 30, 2009 at 8:50 AM, Erik van Oostene.vanoos...@grons.nl wrote:
I am only talking about the declaration on the interface.
So, if deprecating the method on the interface would cause compiler
warnings, then removing the method on the interface would cause
compiler errors. Right?
No, no warnings, the method is only referred from classes that implement
the interface and therefore continue to work after the declaration has been
removed from the interface. Those classes might have an {...@inheritdoc} on
the method in question, but that's easy to fix.
Erik.
On Tue, 30
Except when you use @override annotation.
On Tuesday, June 30, 2009, Erik van Oosten e.vanoos...@grons.nl wrote:
No, no warnings, the method is only referred from classes that implement
the interface and therefore continue to work after the declaration has been
removed from the interface.
Correct. So its not a thing to do for 1.4 as you will have a compile error
iff you use @Override.
Can we go back to main point now?
Regards,
Erik.
On Tue, 30 Jun 2009 15:03:31 +0200, Martijn Dashorst
martijn.dasho...@gmail.com wrote:
Except when you use @override annotation.
On
On Tue, Jun 30, 2009 at 9:21 AM, Erik van Oostene.vanoos...@grons.nl wrote:
Correct. So its not a thing to do for 1.4 as you will have a compile error
iff you use @Override.
Can we go back to main point now?
We are discussing the main point. You're proposing removing a method
from an
Right, now we are indeed discussing the main point: are there any clients
that are using this method via the interface?
In case there /are/ clients using this method, then we are basically
screwed. You can deprecate the method, but that will (temporarily) hurt the
implementations of the
On Tue, Jun 30, 2009 at 11:04 AM, Erik van Oostene.vanoos...@grons.nl wrote:
Let us assume for a moment /no/ clients are using this method though the
interface. In this case it makes no sense to deprecate the method. We
simply remove the method declaration and fix @Override and {...@inheritdoc}
[X ] Yes release 1.4-rc6
On Tue, Jun 30, 2009 at 09:32, Igor Vaynberg igor.vaynb...@gmail.comwrote:
I've created a release for Wicket 1.4-rc6. Until it is officially
released, you can download from the following locations:
SVN Tag:
[X] Yes release 1.4-rc6
[ ] No, don't release it
--
Jeremy Thomerson
http://www.wickettraining.com
[X] Yes release 1.4-rc6
Juergen
IStringResourceLoader#loadStringResource(Class,String,Locale,String)
exists by purpose since we can not gurantee that we always have a
Component (the other method of the interface). Via this interface you
may look up the property for every class.
Juergen
[X] Yes release 1.4-rc6
[ ] No, don't release it
2009/6/30 Jeremy Thomerson jer...@wickettraining.com:
[X] Yes release 1.4-rc6
[ ] No, don't release it
--
Jeremy Thomerson
http://www.wickettraining.com
18 matches
Mail list logo
