James Carman wrote:
On Tue, Nov 10, 2009 at 12:00 PM, Kenny MacLeod
kenny.macl...@kizoom.com wrote:
I agree that it should be no means be the default setting, but in some cases
you *know* your production environment does not serialize sessions.
For example, we run in a JBoss cluster with
Jeremy Thomerson wrote:
File a JIRA and attach the patch. At least that way they won't get lost.
https://issues.apache.org/jira/browse/WICKET-2572
https://issues.apache.org/jira/browse/WICKET-2573
kenny
Hi,
I just submitted a patch that converts the runtime configuration types
(development, deployment) into a type-safe Enum.
See https://issues.apache.org/jira/browse/WICKET-1945
Hope that helps,
Olivier
I thought the plan for 1.5 was going into the opposite direction:
https://issues.apache.org/jira/browse/WICKET-1847
On Wed, Nov 11, 2009 at 3:34 PM, Olivier Croisier
olivier.crois...@gmail.com wrote:
Hi,
I just submitted a patch that converts the runtime configuration types
(development,
Hi,
WICKET-1847 is more than a year old and has had no activity for more than a
year, whereas the WICKET-1945 was more revent and seemed interesting to me,
so I corrected it.
But in my opinion, even if the former is the target architecture, nothing
prevents from integrating my patch now (in the
On Wed, 2009-11-11 at 15:59 +0100, Olivier Croisier wrote:
Hi,
WICKET-1847 is more than a year old and has had no activity for more than a
year, whereas the WICKET-1945 was more revent and seemed interesting to me,
so I corrected it.
But in my opinion, even if the former is the target
The benefit is that the code doesn't rely on string literal comparison,
which is inherently neither secure nor refactoring-friendly.
Ex: Before my patch, there was at least one == string comparison, which
result may vary depending on whether the strings are intern()-ed or not.
Enums prevent that
Hi,
I just submitted a patch to the very old
WICKET-1157https://issues.apache.org/jira/browse/WICKET-1157JIRA (no
activity for the last 2 years).
It provides a simple and flexible way to internationalize enums :
- An EnumMessageKeyProvided that implements a Strategy pattern to generate
I18N keys
Hi Olivier,
Thanks for explaining!
My opinion is that if j.l.String is used properly then it is sufficient
for this use case. One benefit in your solution is the parsing of the
JVM/web init-param property. Now it warns when unknown value is
provided.
There are few comments about the patch
I vote for EnumChoiceRender instead of full DropDownChoice.
However. EnumChoiceRenderer can render any TYPE so that's why I have
proposed TypeChoiceRenderer. You can directly use it with existing
wicket and no need for specific dropdown.
**
Martin
2009/11/11 Olivier Croisier
Hi,
Thanks for your answer.
I admit the EnumDropDownChoice is more of a convenient class that a real new
feature.
However, it has the benefit of providing its enclosed EnumChoiceRenderer a
base component to call getString() on. A standalone EnumChoiceRenderer would
need to take a Component as a
I admit the EnumDropDownChoice is more of a convenient class that a
real new feature.
It's simply an overkill for the purpose. I loved the idea of a
TypeChoiceModel, though. Maybe it should also be tuned to be non
enum-specific, like the TypeChoiceRenderer.
A standalone EnumChoiceRenderer
The Localizer methods also require a Component as a parameter, so we're back
to square one : we must provide a Component.
Also, it would be helpful if you provided your alternative implementation as
a well-formed patch instead of plain-text code in the Jira comment.
On Wed, Nov 11, 2009 at 8:44
Component is optional so it can be given optionally to the renderer.
I have attached a patch. However, it should still be coupled with
TypeChoiceModel so that they fetch the localized label using the same
method. I uploaded that too.
I also provided factory methods so that it is easier to
14 matches
Mail list logo
