Re: OSGi Version at Package Level

2017-06-20 Thread Gary Gregory
On Jun 20, 2017 3:08 PM, "Simon Spero" wrote: On Tue, Jun 20, 2017 at 10:18 AM, Stefan Bodewig wrote: > > Interesting. This means OSGi only provides a way for consumers to say > which version of an API they want, but not which implementation. This means

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

2017-06-20 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/52 [![Coverage Status](https://:/builds/12061474/badge)](https://:/builds/12061474) Changes Unknown when pulling **242ad5e6cda2cc62be4e1b8fccedd7922ecdc44e on

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

2017-06-20 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/52 @PascalSchumacher This seems nice trick , but somehow didn't worked for me and ended up just pushing latest commit, can you try this once ? I have given you write access for exact this

Re: OSGi Version at Package Level

2017-06-20 Thread Bertrand Delacretaz
Hi Stefan, On Thu, Jun 15, 2017 at 6:53 PM, Stefan Bodewig wrote: > ...We use the default configuration of the bundle plugin, only marking some > imports as optional. So we are exporting all our packages... Ok. In the OSGi world it's only APIs and utility classes that should

Re: OSGi Version at Package Level

2017-06-20 Thread Stefan Bodewig
On 2017-06-20, Bertrand Delacretaz wrote: > On Thu, Jun 15, 2017 at 6:53 PM, Stefan Bodewig wrote: >> ...We use the default configuration of the bundle plugin, only marking some >> imports as optional. So we are exporting all our packages... > Ok. In the OSGi world it's only

Re: Code formatting for COMMONS (was Re: [GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder)

2017-06-20 Thread Stefan Bodewig
On 2017-06-19, Simon Spero wrote: > Is there a set of commons code formatting conventions? More particularly, > is there a machine readable file of same? I use intellij, so native, > checkstyle, or Eclipse is fine. This probably would be something that was decided at the component level and may

[GitHub] commons-compress pull request #36: COMPRESS-410 Remove Non-NIO character set...

2017-06-20 Thread sesuncedu
Github user sesuncedu closed the pull request at: https://github.com/apache/commons-compress/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [compress][all]Fwd: Build failed in Jenkins: Commons-Compress PullRequest Builder #56

2017-06-20 Thread Simon Spero
Hudkins is alive! On Tue, Jun 20, 2017 at 12:49 AM, Dave Fisher wrote: > Check with Infra weird errors are happening. > > Regards, > Dave > > Sent from my iPhone > > > On Jun 19, 2017, at 8:53 PM, Stefan Bodewig wrote: > > > >> On 2017-06-19, Gary

[GitHub] commons-compress issue #37: COMPRESS-410 - cherry picked to fix merging issu...

2017-06-20 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-compress/pull/37 [![Coverage Status](https://:/builds/12055314/badge)](https://:/builds/12055314) Coverage increased (+0.04%) to 84.77% when pulling

Re: OSGi Version at Package Level

2017-06-20 Thread Simon Spero
On Tue, Jun 20, 2017 at 10:18 AM, Stefan Bodewig wrote: > > Interesting. This means OSGi only provides a way for consumers to say > which version of an API they want, but not which implementation. This means > as a consumer you can't say "I want version 1.19 of Compress

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

2017-06-20 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/52 Fixed all the code as suggested, Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

2017-06-20 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/52 [![Coverage Status](https://:/builds/12055561/badge)](https://:/builds/12055561) Changes Unknown when pulling **31a5cd173d118148b2a2d2dfac8c99f2d90a8a06 on

[GitHub] commons-compress issue #38: Testing hudson/jenkins (added contributor line t...

2017-06-20 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-compress/pull/38 [![Coverage Status](https://:/builds/12055144/badge)](https://:/builds/12055144) Coverage increased (+0.2%) to 84.885% when pulling

[GitHub] commons-compress issue #38: Testing hudson/jenkins (added contributor line t...

2017-06-20 Thread sesuncedu
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/38 Hudkins is happy. Happy happy Hudkins. So I will close this. Though I think some of the changes might actually be useful. --- If your project is set up for it, you can reply

[GitHub] commons-compress pull request #38: Testing hudson/jenkins (added contributor...

2017-06-20 Thread sesuncedu
Github user sesuncedu closed the pull request at: https://github.com/apache/commons-compress/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

2017-06-20 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/52 Thanks for splitting the changes. :+1: But please also address the second part: >Please stick to the existing code style for the new tests (no new line at the

[GitHub] commons-compress pull request #37: COMPRESS-410 - cherry picked to fix mergi...

2017-06-20 Thread sesuncedu
Github user sesuncedu closed the pull request at: https://github.com/apache/commons-compress/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-compress pull request #37: COMPRESS-410 - cherry picked to fix mergi...

2017-06-20 Thread sesuncedu
GitHub user sesuncedu reopened a pull request: https://github.com/apache/commons-compress/pull/37 COMPRESS-410 - cherry picked to fix merging issues Remove non-NIO character set encoders. Fixes rebasing related issues in previous PR You can merge this pull request into

[GitHub] commons-compress issue #36: COMPRESS-410 Remove Non-NIO character set encode...

2017-06-20 Thread sesuncedu
Github user sesuncedu commented on the issue: https://github.com/apache/commons-compress/pull/36 reopening just to see if I didn't need to create a new branch and cherry pick --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] commons-compress pull request #36: COMPRESS-410 Remove Non-NIO character set...

2017-06-20 Thread sesuncedu
GitHub user sesuncedu reopened a pull request: https://github.com/apache/commons-compress/pull/36 COMPRESS-410 Remove Non-NIO character set encoders. As a special case, the UTF-8 encoder will replace malformed / unmappable input with '?'. This behavior is required for

Re: Code formatting for COMMONS (was Re: [GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder)

2017-06-20 Thread sebb
On 20 June 2017 at 15:07, Stefan Bodewig wrote: > On 2017-06-19, Simon Spero wrote: > >> Is there a set of commons code formatting conventions? More particularly, >> is there a machine readable file of same? I use intellij, so native, >> checkstyle, or Eclipse is fine. > >