Re: [daemon] moving to git ? and bump java version.

2017-07-17 Thread Simon Spero
On Jul 16, 2017 11:49 AM, "Matt Sicker" wrote: C quality somewhat depends on which version of C you're trying to remain compatible with (I'm guessing C89 due to Windows, though I could be wrong). Valgrind and other tracing tools are typically used. Valgrind is a default

Re: [compress] HasCharset is a bad name

2017-07-10 Thread Simon Spero
Since it's an interface, I could change it to IHasACharset? Or If you prefer I could rename it to YouGiveLove? (Lucky Millenials- you aren't headsonged) The name follows a pattern for interfaces of this sort, which are basically retrofit markers for the presence of property, (with associated

Re: [compress] differences in implementation of Zip ibm vs. oracle?

2017-07-10 Thread Simon Spero
Is this jdk 8 vs. java SDK 8? The oracle code picked up some fairly big changes along the way that aren't present in the IBM library. (jdk 9 is really different from both. I haven't seen what the IBM Java 9 is like yet). I will see if anything looks blatantly obvious. Simon On Jul 10, 2017

Re: [lang][collections] SortedProperties

2017-07-18 Thread Simon Spero
On Jul 18, 2017 2:25 PM, "Rob Tompkins" wrote: I'm stuck in the in-between here with the following thought: HashTable certainly feels like a collection of objects, but it clearly extends Dictionary and isn't in the collections family. But we are in java.util here and not in

Re: [lang][collections] SortedProperties

2017-07-18 Thread Simon Spero
On Jul 18, 2017 11:39 AM, "Gary Gregory" wrote: My use case is to write a Properties object in sorted key order, nothing fancy. The simplest way is to subclass Properties and override keys(). Loading a SortedProperties with a Map is not on my to-do list. Would your

Note on Coveralls and JDK9

2017-07-04 Thread Simon Spero
It doesn't work. :-) More specifically, it doesn't work because coveralls is trying to use JAXB, which is not available by default in JDK9. (It ships. It's just not available without command line arguments.) The coveralls plugin is using JAXB for a single static method, to convert a byte[]

Re: Note on Coveralls and JDK9

2017-07-04 Thread Simon Spero
It was failing when I got here officer On Jul 4, 2017 1:46 PM, "Pascal Schumacher" <pascalschumac...@gmx.net> wrote: > Am 04.07.2017 um 16:17 schrieb Simon Spero: > >> It doesn't work. :-) >> >> More specifically, it doesn't work because cove

Re: Fwd: [jira] [Created] (DISCOVERY-23)

2017-07-05 Thread Simon Spero
The clue is in the issue id. Disco-very. Disco-rdia. Part of commons, they share a common prefix. What is the prefix? Disco. How many letters in that prefix? 5 - 2 + 3 ! Disco →sf-raves →hyperreal →Apache. Coincidence? Then how do you explain the fnords? Or the Twitter? What better way to

Re: [RNG] Generating for [e]nums

2017-08-04 Thread Simon Spero
On Aug 4, 2017 2:11 PM, "Gary Gregory" wrote: For example, I have a enum like: public enum CardinalDirection (NORTH,SOUTH,EAST,WEST) public CardinalDirection nextRandomDirection() { return rng.next(CardinalDirection.class); } This approach may be a bit slow if the

Language level, Class files, MRJARs & versioning (was Re: [collections][proposal] Java 7)

2017-07-30 Thread Simon Spero
Class file format is not treated as a breaking change under most versioning approaches, including the JLS. The checkers I looked at that reported on class file format changes consider it a micro level version change (+0.0.1) The past few major version bumps for projects I've worked happened

Re: Ready for JDK 9 ?

2017-08-08 Thread Simon Spero
Compress HEAD is tested against the equivalent of RC. The main issues were with tests; some types of mocking (especially of concrete classes) don't work. This might have been fixed by now. I believe that the latest jacoco is 9 compatible. [The biggest problem was caused by a bug in the zip code

Re: [CSV] CSVMutableRecord

2017-08-17 Thread Simon Spero
On Aug 15, 2017 8:01 PM, "Gilles" wrote: Saying that making record mutable is "breaking" is a bit unfair when we do > NOT document the mutability of the class in the first place. > I'm stating a fact: class is currently immutable, change would make it mutable; it

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Simon Spero
n 8, 2017 at 9:57 AM, sebb <seb...@gmail.com> wrote: > > > >> On 8 June 2017 at 17:19, Gary Gregory <garydgreg...@gmail.com> wrote: > >> > On Thu, Jun 8, 2017 at 5:38 AM, Simon Spero <sesunc...@gmail.com> > wrote: > >> > > >> >

Re: OSGI Version at Package Level : some more details about the COMPRESS-399 pull request

2017-06-12 Thread Simon Spero
On Mon, Jun 12, 2017 at 10:53 AM, Matt Sicker wrote: > I'd love to have a semantic versioning plugin like that which can suggest > what the version number is for the entire project. Elm (programming > language) has a tool like that, and it works rather well in practice (even >

Re: OSGI Version at Package Level : some more details about the COMPRESS-399 pull request

2017-06-12 Thread Simon Spero
On Sun, Jun 11, 2017 at 7:37 PM, Gary Gregory wrote: > Is one upshot of this is that we should base the version number based on > this OSGi report tool? > There are a few choices so the SEF upshot selector

CharSequence vs. String (was Re: [GitHub] commons-text pull request #46: TEXT-85:Added CaseUtils class with camel case...)

2017-06-19 Thread Simon Spero
On Jun 12, 2017 10:47 AM, "arunvinudss" wrote: Github user arunvinudss commented on a diff in the pull request: I am a bit biased towards using String instead of CharSequence . Yes CharSequence allows us to pass String Buffers and builders and other types as input

Code formatting for COMMONS (was Re: [GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder)

2017-06-19 Thread Simon Spero
Is there a set of commons code formatting conventions? More particularly, is there a machine readable file of same? I use intellij, so native, checkstyle, or Eclipse is fine. I've been having problems where I am doing the pre-commit diff check, and find that I have made unintentional changes to

Re: [all] dev@ traffic

2017-06-19 Thread Simon Spero
(this was prompted by me interrupting a quasi-appropriate JIRA meta-discussion about JIRA workflow & permissions (on an issue I had opened because I encountered it whilst working another issue, and had fixed but not PRed, which Stefan then also fixed) to further apologize to Stefan for not

Re: [all] dev@ traffic

2017-06-19 Thread Simon Spero
On Jun 19, 2017 9:56 AM, "Stefan Bodewig" <bode...@apache.org> wrote: On 2017-06-19, Simon Spero wrote: with all parenteses properly nested, wow ;-) No need to apologize, really. (apply #'append '((not) (a problem)))

Re: [compress][all]Fwd: Build failed in Jenkins: Commons-Compress PullRequest Builder #56

2017-06-20 Thread Simon Spero
Hudkins is alive! On Tue, Jun 20, 2017 at 12:49 AM, Dave Fisher wrote: > Check with Infra weird errors are happening. > > Regards, > Dave > > Sent from my iPhone > > > On Jun 19, 2017, at 8:53 PM, Stefan Bodewig wrote: > > > >> On 2017-06-19, Gary

Re: OSGi Version at Package Level

2017-06-20 Thread Simon Spero
On Tue, Jun 20, 2017 at 10:18 AM, Stefan Bodewig wrote: > > Interesting. This means OSGi only provides a way for consumers to say > which version of an API they want, but not which implementation. This means > as a consumer you can't say "I want version 1.19 of Compress

Some ideas for improving Travis build performance improvements:

2017-06-23 Thread Simon Spero
COMPRESS-413 has some examples which include: - Switching to the trusty container, which doesn't require installing as many updates. - Use only two JDKs: openjdk7 and openjdk8. - JDK 7 is obsolete - - Oracle EOL'ed JDK7 over two years ago; openjdk7 occasionally gets

Re: [configuration] checkstyle fails build

2017-06-23 Thread Simon Spero
On Jun 23, 2017 11:03 AM, "Oliver Heger" wrote: However, letting the build fail because of checkstyle error is too restrictive IMHO. My approach is to work through the errors before creating a new release. This has the disadvantage that errors might accumulate; but

Re: [FUNCTOR] Why do we have an API module?

2017-06-26 Thread Simon Spero
On Jun 25, 2017 5:54 AM, "Benedikt Ritter" wrote: Hi, > Am 24.06.2017 um 20:19 schrieb Matt Benson : > > TBH, I don't know that I think there's a reason to do such a library unless it's really a game changer. Currently functor is somehow in limbo

Things in a POM file that are not probably incorrect

2017-06-26 Thread Simon Spero
1.5 1.5 org.apache.commons.functor JDK 9 cannot generate or parse class files compiled with -target 1.5 [1]. Per the JPMS Armistice talks, "Automatic-Module-Name" header should only be added to jars that have been tested under JDK 9 [2]. Also, javac now supports the new

Re: [configuration] checkstyle fails build

2017-06-25 Thread Simon Spero
On Jun 24, 2017 12:31 PM, "Oliver Heger" wrote: Should changes related to the setup and handling of checkstyle then be done for Commons as a whole? (No P.S.) It is the sort of thing fits nearly I a parent. Maven is one example (not sure how much customization is

OSGI Version at Package Level : some more details about the COMPRESS-399 pull request

2017-06-07 Thread Simon Spero
As Bertrand mentioned earlier, the bundle:baseline goal is built in to the maven-bundle-plugin already in use! The pull-request adds that goal to the verify phase of the maven build (and changes the travis config to run 'mvn verify' instead of 'mvn test' ). The baseline goal is set to fail the

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Simon Spero
[A Note, not a vote :) ] 1. Clirr is generally considered obsolete, as it hadn't been worked on for about ten years. japicmp is a good replacement, especially for report generation, and is used in other commons projects. 2. Are the "changes" to the values in CharEncoding really necessary[1]

Testing enhanced @Deprecation vs. jdk 8

2017-06-09 Thread Simon Spero
On Thu, Jun 8, 2017 at 12:19 PM, Gary Gregory wrote: > > 3. JDK9 adds some extra parameters to the Deprecated annotation (most > notably forRemoval=true, which is used to indicate that the annotated item > is really really deprecated.) It's not needed in this case,

Re: OSGI Version at Package Level : some more details about the COMPRESS-399 pull request

2017-06-13 Thread Simon Spero
code. Simon ¹ OK, I made the changes, created the issue, then submitted the pull-request. On Mon, Jun 12, 2017 at 10:18 AM, Simon Spero <sesunc...@gmail.com> wrote: > On Mon, Jun 12, 2017 at 10:53 AM, Matt Sicker <boa...@gmail.com> wrote: > > > I'd love to have a semantic vers

Re: OSGI Version at Package Level : some more details about the COMPRESS-399 pull request

2017-06-11 Thread Simon Spero
On Sun, Jun 11, 2017 at 3:16 PM, Gary Gregory wrote: > My POV is that I only see a possible use cases for this in multi-module > components where one module defines an API and others different > implementation. Our release process is enough of a pain. Asking everyone > to

Re: OSGI Version at Package Level : some more details about the COMPRESS-399 pull request

2017-06-11 Thread Simon Spero
Hell's coming with me, you hear? **Jar Hell's coming with me!* Simon On Wed, Jun 7, 2017 at 5:02 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > On Wed, Jun 7, 2017 at 10:28 AM, Simon Spero <sesunc...@gmail.com> wrote: > > > As Bertrand mentioned earlier, the bundle

Re: Testing enhanced @Deprecation vs. jdk 8

2017-06-09 Thread Simon Spero
il.com> wrote: > That would require that the animal sniffer plugin be setup for components > that do want to go that way. Doable if there is a sig file for the right > Java version for that component. > > Gary > > On Jun 9, 2017 8:13 AM, "Simon Spero" <sesunc...@gmail

[CLI] Please review CLI-277

2017-06-14 Thread Simon Spero
On Jun 14, 2017 4:28 AM, "Benedikt Ritter" wrote: I’d like to have feedback for CLI-277 [1], especially whether it will affect BC. Clirr is happy with this changes, to I suppose it is fine to merge this? [1] https://github.com/apache/commons-cli/pull/13 <

Re: [CLI] Please review CLI-277

2017-06-14 Thread Simon Spero
Oops -I missed that the method was already generic. Need bigger tablet/more coffee / bigger caffeine tablet On Jun 14, 2017 8:46 AM, "Simon Spero" <sesunc...@gmail.com> wrote: On Jun 14, 2017 4:28 AM, "Benedikt Ritter" <brit...@apache.org> wrote: I’d like

Re: [CLI] Please review CLI-277

2017-06-14 Thread Simon Spero
But BC, per initial response. I said I needed more coffee :) On Wed, Jun 14, 2017 at 8:55 AM, Simon Spero <sesunc...@gmail.com> wrote: > Oops -I missed that the method was already generic. Need bigger > tablet/more coffee / bigger caffeine tablet > > > On Jun 14, 2017

Re: [Math][Numbers] Move Field, etc. to numbers?

2017-09-16 Thread Simon Spero
On Sep 15, 2017 5:30 PM, "Raymond DeCampo" wrote: Re terminology a field is an abstract system of numbers so I don't see an issue there. Let E = {Dunhill, Camel}, Let Dunhill * Dunhill = Dunhill, Dunhill * Camel = Dunhill, Camel * Dunhill = Dunhill,

Re: Java 8 curiousity

2017-10-10 Thread Simon Spero
Could be gc, could be hotspot compiler, or could be library There was a massive improvement in the performance of the G1 GC in u60 when dealing with "humongous" objects; however I assume you wouldn't have been using G1 before u60 for anything real (that was when it first became usable. If you

Re: [LANG] Add module-info.java?

2017-10-16 Thread Simon Spero
[In regards to original question, -0.0 (harmless, but pointless, since applications should not use lang as a jpms module. To be usable as a jpms module, EVERY release that has ANY api change must use new module and package names).[1] ] Since all dependencies have to be shad(e|ow)ed (and not

Re: [compress] cut 1.16.1 very soon?

2018-02-09 Thread Simon Spero
Writing tests for osgi modules is painless... the second time :-P The key to making tests easy is to use pax-exam, which handles most of the tedious container setup and junit / test-NG test execution. https://ops4j1.jira.com/wiki/spaces/PAXEXAM4/pages/54263870/Documentation I can implement this