[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/52 Thanks Amey. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

Github user kinow commented on the issue: https://github.com/apache/commons-text/pull/52 Looking good! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/52 Cool, seems clean now :+1: thanks Pascal. Trick will be certainly beneficial in future to me 😉 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/52 Thanks. I was not as easy as I expected (I had to merge). I followed these steps: `git rebase -i head~5` Edit the rebase-todo-to to contain: ``` drop

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/52 [](https://:/builds/12062509) Coverage increased (+0.4%) to 97.317% when pulling **eb25d61ca6bd845815bb30feb2ba0cf9f6e106ff on

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/52 @PascalSchumacher This seems nice trick , but somehow didn't worked for me and ended up just pushing latest commit, can you try this once ? I have given you write access for exact this

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/52 [](https://:/builds/12061474) Changes Unknown when pulling **242ad5e6cda2cc62be4e1b8fccedd7922ecdc44e on

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/52 Thanks for splitting the changes. :+1: But please also address the second part: >Please stick to the existing code style for the new tests (no new line at the

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/52 [](https://:/builds/12055561) Changes Unknown when pulling **31a5cd173d118148b2a2d2dfac8c99f2d90a8a06 on

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/52 Fixed all the code as suggested, Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: Code formatting for COMMONS (was Re: [GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder)

On 20 June 2017 at 15:07, Stefan Bodewig wrote: > On 2017-06-19, Simon Spero wrote: > >> Is there a set of commons code formatting conventions? More particularly, >> is there a machine readable file of same? I use intellij, so native, >> checkstyle, or Eclipse is fine. > >

Re: Code formatting for COMMONS (was Re: [GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder)

On 2017-06-19, Simon Spero wrote: > Is there a set of commons code formatting conventions? More particularly, > is there a machine readable file of same? I use intellij, so native, > checkstyle, or Eclipse is fine. This probably would be something that was decided at the component level and may

Code formatting for COMMONS (was Re: [GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder)

Is there a set of commons code formatting conventions? More particularly, is there a machine readable file of same? I use intellij, so native, checkstyle, or Eclipse is fine. I've been having problems where I am doing the pre-commit diff check, and find that I have made unintentional changes to

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/52 Agreed with Pascal here, just for semantics on commit history. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder

Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/52 Thanks! Please separate the formatting fixes and the test additions into different commits. Please stick to the existing code style for the new tests (no new line at