that's great indeed, thanks for taking care! :)
I just added a comment as well, looking forward to hear from you!
all the best,
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Mon, Mar 26, 2012 at
Hi Simone,
On 25/03/2012 22:46, Simone Tripodi wrote:
Hi Graphers,
I was trying to code the ELO algorithm using a BSF algo and got in
trouble with the boolean return value of the visit handler methods - I
think that we could improve it a little, adopting a similar approach
of the
if I get it right you are saying that two values (true/false) are too
limiting for some of the current methods. Do you have a specific example, to
get a clearer idea of the improvement?
nope, I am saying that the boolean flag is less intuitive - I had to
take a (short, of course) while to
Hi,
My proposal is switching to a more expressive values, kind of
VisitState.(ABORT|CONTINUE) enumeration that is free of any
misunderstanding. Thoughts?
ok so something like:
* if ( handler.finishEdge( prevHead, e, v ).equals( VisitState.ABORT )
) ..
Looks good to me, +1 :)
Ciao,
* if ( handler.finishEdge( prevHead, e, v ).equals( VisitState.ABORT )
) ..
even better:
VisitState.ABORT == handler.finishEdge( prevHead, e, v )
Looks good to me, +1 :)
great, I am going to change it - then sleeping to cheat the new TZ :P
best,
-Simo
just had an idea of a possible new state: SKIP,that would mean
skipping the children/subtrees... thoughts? :P
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Sun, Mar 25, 2012 at 11:22 PM, Simone
Hi,
On 25/03/2012 23:27, Simone Tripodi wrote:
just had an idea of a possible new state: SKIP,that would mean
skipping the children/subtrees... thoughts? :P
+1.
Of course we still need to document the whole thing in the javadoc (as
we did already with boolean values), but the readability of
just filled SANDBOX-416 and committed the
org.apache.commons.graph.visit.VisitState enum, now I am too sleepy to
continue - feel free to finalize it if you want/can/have spare
time/...
all the best and thanks for discussing,
-Simo
http://people.apache.org/~simonetripodi/
Hi,
On 25/03/2012 23:45, Simone Tripodi wrote:
just filled SANDBOX-416 and committed the
org.apache.commons.graph.visit.VisitState enum, now I am too sleepy to
continue - feel free to finalize it if you want/can/have spare
time/...
I did that, see the comment on SANDBOX-416 :)
Ciao,
Claudio
