Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
Copying the `it-parent` POM over to the output directory as part of
[MavenLauncher.simpleExtractResources](https://github.com/apache/maven-surefire/blob/master/surefire-integration-tests
Github user owenfarrell closed the pull request at:
https://github.com/apache/maven-surefire/pull/157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
And I got busy with other work as well. I think I found a solution that
doesn't completely violate the pattern used by integration tests.
Long story short, the IT for SUREFIRE
GitHub user owenfarrell reopened a pull request:
https://github.com/apache/maven-surefire/pull/157
SUREFIRE-1383 dependenciesToScan Does Not Leverage Classpath Elements
Added logic to prefer output directories of projects built as part of the
current session.
You can merge
GitHub user owenfarrell opened a pull request:
https://github.com/apache/maven-surefire/pull/157
SUREFIRE-1383 dependenciesToScan Does Not Leverage Classpath Elements
Added logic to prefer output directories of projects built as part of the
current session.
You can merge this pull
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@Tibor17 - done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
I don't follow. When I run an install from any level, the
`org.apache.maven.surefire:it-parent:1.0:pom` artifact
(surefire-integration-tests/src/test/resources/pom.xml) does not get
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
I've put together an integration test that can validate the execution of
[SUREFIRE-1383](https://issues.apache.org/jira/browse/SUREFIRE-1383). And all
is good on that front
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
Looking at it a bit deeper, looks like the root cause is that the
`it-parent` POM is not installed in the IT repo. The issue isn't the dependency
itself.
---
If your project is set up
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
One workaround for this would be to install the missing `it-parent` POM as
part of my first lifecycle (i.e. mid-test). But this seems kind of hacky.
```
surefire-569
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@Tibor17 - Have you had a chance to review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@Tibor17 - thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@Tibor17 - any updates?
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@Tibor17 - IT569 does not **fail** when introducing my changes. But since
the test was written as a single lifecycle, it inadvertently uses the code I've
introduced in this PR ([see
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@Tibor17 I see what you're going for, that makes sense.
I've update my PR to just include IT contents now, with an improved IT that
emulates a scenario where working copy changes
Github user owenfarrell commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r135778722
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,31 @@ private
GitHub user owenfarrell opened a pull request:
https://github.com/apache/maven-surefire/pull/164
SUREFIRE-1383: Split IT569 in to multiple lifecycles
@Tibor17 - Based on [your
comment](https://github.com/apache/maven-surefire/pull/157#issuecomment-325616922),
is this in line
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/157
I don't think that logic would work for my scenario.
For example:
1. Create multi-module project with a test runner JAR (a la
`org.apache.maven.surefire:surefire-1383
Github user owenfarrell commented on the issue:
https://github.com/apache/maven-surefire/pull/164
@Tibor17 - Is this what you were thinking of when you asked to clean up the
distinct change sets related to #157
19 matches
Mail list logo
