Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
@jdillon Thank you for the contribution anyway!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jdillon commented on the issue:
https://github.com/apache/maven/pull/116
closing,
https://github.com/apache/maven/commit/66fc74d6296ea0a33f8a9712dc5ed5eb3affd529
provides more comprehensive adjustments for JSR-330 annotations
---
If your project is set up for it, you
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
@jdillon Igor merged his PR contained your fix. This PR is obsolete now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
Thanks for the explanation. So it is not a prerequisite directly. I'd still
insist for an JIRA because I need another committer to second this and have
this in our release notes. Do you have a
Github user jdillon commented on the issue:
https://github.com/apache/maven/pull/116
Igor's change is the more correct/ideal change to avoid future mismatch
between plexus-annotation configuration and JSR-330 annotations. The problem
is that plexus @Requirement injects directly to
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
Just to be clear, Igor's change is s prerequisite to your issue? If so, we
need two tickets. The IT assures that nothing will break your fix -- no more,
no less.
---
If your project is set up
Github user jdillon commented on the issue:
https://github.com/apache/maven/pull/116
Igor already created https://issues.apache.org/jira/browse/MNG-6233 but if
you really need another issue I can file one just to fix this specific problem.
Seems a bit odd though that you want
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
@jdillon I'd like to merge this but need a JIRA issue. At best, an IT too.
Can you provide a simple one?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jdillon commented on the issue:
https://github.com/apache/maven/pull/116
Hey folks can we get some movement on this and/or
https://github.com/apache/maven/compare/MNG-6233_maven-resolver-provider-jsr330
ATM its broken, either of these fixes the issue.
---
If
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
@ifedorenko That's the only way w/o INFRA: commit message "This closes
#xy". You cannot manually close via website. That's what I was trying to say.
---
If your project is set up for it, you can
Github user jdillon commented on the issue:
https://github.com/apache/maven/pull/116
@ifedorenko ftr I can close this, so but i'm confused about @michael-o
comment that your change (I think that is what he meant) wasn't suitable for a
patch release.
---
If your project is set up
Github user ifedorenko commented on the issue:
https://github.com/apache/maven/pull/116
Wow. That's backwards. I wonder what will happen if I push my change with
github's magic "fixes 116" pseudo comment. Guess there is one way to find out
:-)
---
If your project is set up for it,
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
@ifedorenko Closing PRs requires a ticket with INFRA on JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ifedorenko commented on the issue:
https://github.com/apache/maven/pull/116
Opened https://issues.apache.org/jira/browse/MNG-6233. If you any concerns
or suggestions, I suggest we continue the discussion there.
@jdillon I can't close this pull request
---
If
Github user michael-o commented on the issue:
https://github.com/apache/maven/pull/116
@jdillon Such a change is not suitable for a patch version in my opinion.
Please file a JIRA issue for your local branch and push a branch for that.
---
If your project is set up for it, you can
Github user jdillon commented on the issue:
https://github.com/apache/maven/pull/116
@ifedorenko can close this if you like, wasn't sure what you mean about "a
JIRA either way". If we close this and go with your changes (which if you have
that mostly done for merge soon is what I
Github user jdillon commented on the issue:
https://github.com/apache/maven/pull/116
@ifedorenko howdy, i'm fine to wait if you are gonna adjust to jsr330 that
will be better generally for the project anyways IMO; i'm just trying to learn
how to use the api and can live with this
Github user ifedorenko commented on the issue:
https://github.com/apache/maven/pull/116
I have a commit on a local branch that fully converts
maven-resolver-provider to jsr330, I can push that to master if you can wait
few days. Either way we'll need a JIRA to track the changes.
Github user jdillon commented on the issue:
https://github.com/apache/maven/pull/116
the plexus @Requirement injection is probably why this works at all in
Maven, though w/o using maven-resolver-provider in a pure guice/sisu
environment, this fails and causes NPE:
```
19 matches
Mail list logo
