Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-28 Thread Stephen Connolly
On 28 March 2017 at 11:56, Igor Fedorenko wrote: > Good point! > > .mvn/maven.config is handled by MavenCli and should not require forked > execution. > > .mvn/jvm.config is handled by mvn shell script and does require forked > execution. Verifier "auto" mode does not

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-28 Thread Igor Fedorenko
Good point! .mvn/maven.config is handled by MavenCli and should not require forked execution. .mvn/jvm.config is handled by mvn shell script and does require forked execution. Verifier "auto" mode does not currently consider presence of .mvn/jvm.config, so we'll either need fix Verifier or force

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-28 Thread Stephen Connolly
Does it force a fork if there is a .mvn/maven.config file to be picked up? On Tue 28 Mar 2017 at 07:07, Hervé BOUTEMY wrote: > ok, no issue found, then embedded mode merged to master > > later switching back to non-embedded is easy if necessary > > Regards, > > Hervé > >

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-28 Thread Hervé BOUTEMY
ok, no issue found, then embedded mode merged to master later switching back to non-embedded is easy if necessary Regards, Hervé Le samedi 25 mars 2017, 17:32:38 CEST Hervé BOUTEMY a écrit : > thanks for the complements > FTR, I checked and added pointers to code > > Regards, > > Hervé > >

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-25 Thread Hervé BOUTEMY
thanks for the complements FTR, I checked and added pointers to code Regards, Hervé Le samedi 25 mars 2017, 07:38:30 CET Igor Fedorenko a écrit : > Good description, Hervé. One small addition. I believe -Pembedded > enables "auto" mode,

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-25 Thread Igor Fedorenko
Good description, Hervé. One small addition. I believe -Pembedded enables "auto" mode, where verifier uses "forked" mode for tests that set environment variables and "embedded" mode for all other cases. Individual ITs can still force forked mode with verifier.setForkJvm, of course. -- Regards,

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-25 Thread Olivier Lamy
Sounds a very good to speed up it execution! On Sat, 25 Mar 2017 at 4:02 pm, Hervé BOUTEMY wrote: > ok, let's share what I know from embedded ITs (sorry, long email, but IMHO > useful to share some details): > > - by default, Verifier forks for every IT and launches Maven

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-24 Thread Hervé BOUTEMY
ok, let's share what I know from embedded ITs (sorry, long email, but IMHO useful to share some details): - by default, Verifier forks for every IT and launches Maven with the shell script through ForkedLauncher [1] - in embedded mode, there is no fork but use of MavenCli.doMain(String[] args,

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-24 Thread Olivier Lamy
sure tempting :-) But is is the same classloader mechanism as a "normal" Maven run? (should be really close but not sure exactly so maybe we can miss some cases) On Fri, 24 Mar 2017 at 6:47 pm, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Have we some of the tests running in both

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-24 Thread Stephen Connolly
Have we some of the tests running in both modes? Specifically at least 4625 as it caught some interesting CLI parsing issues, but there may be a couple more On Fri 24 Mar 2017 at 07:15, Hervé Boutemy wrote: > as you can see, in embedded mode, core ITs can run in 17

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-24 Thread Hervé Boutemy
as you can see, in embedded mode, core ITs can run in 17 minutes, when in classic mode they run in 1h30 any objection to merge this embedded mode into master? Regards, Hervé Le vendredi 24 mars 2017 04:17:49 CET, vous avez écrit : > See