/master/master.cpp
https://reviews.apache.org/r/24576/#comment88172
It this comment still relevant?
- Niklas Nielsen
On Aug. 11, 2014, 4:32 p.m., Ben Mahler wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/execute.cpp
https://reviews.apache.org/r/24808/#comment88803
How about leaving an example? It is the docker:/// format, right?
- Niklas Nielsen
On Aug. 18, 2014, 11:29 a.m., Timothy Chen wrote:
---
This is an automatically generated
+1
make check on
Ubuntu 14.04 gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1) and
Mac OS X clang-503.0.40
Looking so much forward to this release!
Niklas
On 19 August 2014 11:28, Ian Downes idow...@twitter.com.invalid wrote:
+1
make check passes on CentOS 5.5 with 3.4 kernel. Docker tests were
Hi Jason,
I added you to the JIRA Mesos contributor list.
Cheers,
Niklas
On 26 August 2014 14:09, Jason jasonl9...@gmail.com wrote:
Patrick, added you already - can you share the jira handles of the other
folks?
Niklas
On 26 August 2014 14:25, Jason jasonl9...@gmail.com wrote:
Thanks!
On Tue, Aug 26, 2014 at 2:15 PM, Niklas Nielsen nik...@mesosphere.io
wrote:
Hi Jason,
I added you to the JIRA Mesos contributor
Great - just added them.
Niklas
On 26 August 2014 14:49, Patrick Reilly patrick.rei...@gmail.com wrote:
Hello Niklas,
It's jmlvanre, mcypark and cmaloney.
— Patrick
On Tue, Aug 26, 2014 at 2:27 PM, Niklas Nielsen nik...@mesosphere.io
wrote:
Patrick, added you already - can you share
On Aug. 26, 2014, 2:58 p.m., Ben Mahler wrote:
It was done using macro expansion because variadic templates require C++11.
We're not yet able to assume C++11:
https://issues.apache.org/jira/browse/MESOS-750
But as this reduce compile time for folks with C++11 compilers, can we make
On Aug. 26, 2014, 7:36 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [25079]
Failed command: ./support/mesos-style.py
Error:
Checking 506 files using filter
() is written to STDERR
I0827 15:48:12.624887 124162048 main.cpp:115] Connecting to server at
(1)@10.0.0.224:53492...
Thanks,
Niklas Nielsen
, visit:
https://reviews.apache.org/r/25124/#review51716
---
On Aug. 27, 2014, 3:49 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
--server=(1)@10.0.0.224:53492
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0827 15:48:12.624887 124162048 main.cpp:115] Connecting to server at
(1)@10.0.0.224:53492...
Thanks,
Niklas Nielsen
statistics for bytes
sent/received.
Niklas Nielsen wrote:
Good point - we would need to install message handlers accordingly
though. I would categorize it as future work :-) Want a TODO in place?
Dominic Hamon wrote:
sure.
i was also going to suggest using the libprocess
Hmm - don't know what happened here. We didn't touch libcurl - do you
guys have any insight here?
Niklas
On 28 August 2014 15:19, Apache Jenkins Server jenk...@builds.apache.org
wrote:
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2371/changes
Thanks for the prompt response Vinod!
Niklas
On 28 August 2014 15:28, Vinod Kone vinodk...@gmail.com wrote:
libcurl is not installed on some jenkins slaves. i pinged jake farrell on
a separate thread and waiting to hear back.
On Thu, Aug 28, 2014 at 3:26 PM, Niklas Nielsen nik
Client:
$ ./build/src/mesos-net-bench --server=(1)@10.0.0.224:53492
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0827 15:48:12.624887 124162048 main.cpp:115] Connecting to server at
(1)@10.0.0.224:53492...
Thanks,
Niklas Nielsen
are 70:
http://mesos.apache.org/documentation/latest/mesos-c++-style-guide/
src/tests/containerizer.cpp
https://reviews.apache.org/r/25434/#comment91706
Why 3 seconds?
- Niklas Nielsen
On Sept. 9, 2014, 5:54 a.m., Alexander Rukletsov wrote
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25434/
---
(Updated Sept. 9, 2014, 5:54 a.m.)
Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy St
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23708/#review52820
---
Ship it!
Ship It!
- Niklas Nielsen
On Aug. 19, 2014, 5:36 p.m
Hi guys,
We have run into a problem that cause tasks which completes, when a
framework is disconnected and has a fail-over time, to remain in a running
state even though the tasks actually finishes.
Here is a test framework we have been able to reproduce the issue with:
, it looks like the task can't be found when trying to
forward the finish update because the running update never got acknowledged
before the framework disconnected. I may be missing something here.
Niklas
On 10 September 2014 16:09, Niklas Nielsen nik...@mesosphere.io wrote:
Hi guys,
We have run
-
src/tests/master_tests.cpp 3d080b2
Diff: https://reviews.apache.org/r/25588/diff/
Testing
---
make check - however, I haven't been able to provoke the actual fault but
verified that the subsequent offers could occur (by hand).
Thanks,
Niklas Nielsen
minor style nits
(removing a duplicate comment and adding newlines).
- Niklas Nielsen
On Aug. 28, 2014, 9:24 a.m., Patrick Reilly wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25079
How about Till? I can help out too.
Niklas
On Friday, September 12, 2014, Tim St Clair tstcl...@redhat.com wrote:
I would like to, but this next month is going to be crazy for me. Perhaps
the next cycle.
Regards,
Tim
- Original Message -
From: Vinod Kone vinodk...@gmail.com
to discard for
now if you don't have any objections.
- Niklas Nielsen
On June 17, 2014, 11:23 a.m., Yifan Gu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22526
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25042/#review53231
---
Ship it!
Cool! Going to commit this in a bit
- Niklas Nielsen
On Sept. 12, 2014, 3:07 p.m., Niklas Nielsen wrote:
Cool! Going to commit this in a bit
Well, never mind - Adam already got this through. Remember to mark as submitted
:)
- Niklas
---
This is an automatically generated e-mail
/3rdparty/stout/include/stout/version.hpp
https://reviews.apache.org/r/25597/#comment92982
Review bot caught this; would you mind moving the class body 2 spaces left?
We don't indent public, private, etc
- Niklas Nielsen
On Sept. 12, 2014, 5:14 p.m., Kapil Arya wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25614/#review53408
---
Ship it!
Ship It!
- Niklas Nielsen
On Sept. 15, 2014, 1:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25121/#review53410
---
Can you add some context to the background of this RR?
- Niklas
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25614/
---
(Updated Sept. 15, 2014, 1:54 p.m.)
Review request for mesos and Niklas Nielsen.
Bugs: MESOS-1795
https
updates
even in edge cases (failover, network partitions etc).
On Wed, Sep 10, 2014 at 5:35 PM, Niklas Nielsen
nik...@mesosphere.io
wrote:
Hey Vinod - thanks for chiming in!
Is there a particular reason for only having one status in flight?
Or
to
put
Mahler benjamin.mah...@gmail.com
wrote:
On Mon, Sep 15, 2014 at 3:11 PM, Niklas Nielsen nik...@mesosphere.io
wrote:
Thanks for your input Ben! (Comments inlined)
On 15 September 2014 12:35, Benjamin Mahler benjamin.mah...@gmail.com
wrote:
To ensure that the architecture of mesos
on this
process in general and doesn't this deserve to be discussed and consensus
reached (dev@ or private) before putting out a document on it?
I might be missing something here of course; if so, can you point me to the
references?
- Niklas Nielsen
On Sept. 18, 2014, 10:41 a.m., Dominic Hamon
/libprocess/src/help.cpp
https://reviews.apache.org/r/25798/#comment93751
The indentation in the return here (and below) seems to be off.
3rdparty/libprocess/src/help.cpp
https://reviews.apache.org/r/25798/#comment93750
The indentation seem a bit off here.
- Niklas Nielsen
On Sept
+1 (binding)
On Friday, September 19, 2014, Till Toenshoff toensh...@me.com wrote:
+1
make check on OSX 10.9.5, clang 3.5 (Xcode 6)
-all tests passed
On Sep 19, 2014, at 3:03 AM, Vinod Kone vinodk...@gmail.com
javascript:_e(%7B%7D,'cvml','vinodk...@gmail.com'); wrote:
+1 (binding)
Hi everyone,
We have been iterating on a design for pluggable modules in Mesos lately
and wanted to get a last round of feedback before putting out patch sets.
Tim St Clair, Ben Hindman and I started the discussion (and work) on this
subsystem https://issues.apache.org/jira/browse/MESOS-1224 and
-mail. To reply, visit:
https://reviews.apache.org/r/25847/
---
(Updated Sept. 19, 2014, 1:31 p.m.)
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
Description
---
Move class Node out of process.cpp
! :)
We try to use postfix underscore now to avoid clashes,
https://www.gnu.org/software/libc/manual/html_node/Reserved-Names.html
I will leave that up to you whether you want to address it here.
- Niklas Nielsen
On Sept. 19, 2014, 1:31 p.m., Joris Van Remoortere wrote
, but that is the trade-off of implementing a dynamic
loadable module.
On Fri, Sep 19, 2014 at 11:35 AM, Niklas Nielsen nik...@mesosphere.io
wrote:
Hi everyone,
We have been iterating on a design for pluggable modules in Mesos lately
and wanted to get a last round of feedback before putting
)?
- Niklas Nielsen
On Sept. 19, 2014, 1:40 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848
Sent: Saturday, September 20, 2014 9:21:59 AM
Subject: Re: Mesos Modules Design
On Fri, Sep 19, 2014 at 2:43 PM, Niklas Nielsen nik...@mesosphere.io
wrote:
Hi Dominic,
(response inlined)
On 19 September 2014 13:03, Dominic Hamon dha...@twopensource.com
wrote:
I'm
.)
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
Description
---
Move class ProcessReference out of process.cpp and into its own header.
Part of refactoring process.cpp.
Diffs
-
3rdparty/libprocess/include/Makefile.am 542ae1c
3rdparty/libprocess
1543860
Diff: https://reviews.apache.org/r/25911/diff/
Testing
---
Added a new test: FaultToleranceTest.RecoverResourcesDuringSchedulerDisconnect
which exercise the new code path.
make check
Thanks,
Niklas Nielsen
. To reply, visit:
https://reviews.apache.org/r/25911/#review54221
---
On Sept. 22, 2014, 3:30 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit
(Inlined) Thanks for chiming in!
On 23 September 2014 11:59, Vinod Kone vinodk...@gmail.com wrote:
Ok. I finally had a chance to read the design doc, go through the comments
on this thread and glance at the review. Here are my comments.
I like the concept of dynamic loading of libraries when
f5d74ae
src/master/master.cpp e5d30e9
Diff: https://reviews.apache.org/r/25967/diff/
Testing
---
make check
Thanks,
Niklas Nielsen
---
The last step of wiring up reconcileTasks in the python bindings.
Diffs
-
src/python/interface/src/mesos/interface/__init__.py 818f41b
Diff: https://reviews.apache.org/r/25986/diff/
Testing
---
Functional testing
Thanks,
Niklas Nielsen
:
https://reviews.apache.org/r/25848/
---
(Updated Sept. 22, 2014, 9:05 p.m.)
Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen,
and Timothy St. Clair.
Bugs: MESOS-1384
https://issues.apache.org/jira
,
Niklas Nielsen
/25789/#comment94606
Same for 'val' - let's expand it to a full word. Here and below
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp
https://reviews.apache.org/r/25789/#comment94604
should be 4 space indent.
- Niklas Nielsen
On Sept. 23, 2014, 10:30 a.m., Joris Van
.
make check
Thanks,
Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26052/#review54585
---
Ship it!
Ship It!
- Niklas Nielsen
On Sept. 25, 2014, 12:37 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25868/#review54588
---
Ship it!
Ship It!
- Niklas Nielsen
On Sept. 22, 2014, 6:18 p.m
://reviews.apache.org/r/26056/#comment94777
I know it is pretty inconsistent in libprocess, but let's surround the
include guard with '__' and do a scan of the other headers too
- Niklas Nielsen
On Sept. 25, 2014, 2 p.m., Joris Van Remoortere wrote
/__init__.py 818f41b
Diff: https://reviews.apache.org/r/25986/diff/
Testing
---
Functional testing
Thanks,
Niklas Nielsen
., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25986/
---
(Updated Sept. 25, 2014, 2:09 p.m.)
Review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26056/#review54625
---
Ship it!
Ship It!
- Niklas Nielsen
On Sept. 25, 2014, 4:04 p.m
/#comment94856
Missed this one s/HH/HPP/
- Niklas Nielsen
On Sept. 25, 2014, 4:04 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26056
On Sept. 25, 2014, 4:35 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/src/net.hpp, line 232
https://reviews.apache.org/r/26056/diff/2/?file=705786#file705786line232
Missed this one s/HH/HPP/
Fixed it when committing - thanks!
- Niklas
?
- Niklas Nielsen
On Sept. 29, 2014, 2:16 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848
On May 15, 2014, 4:32 p.m., Niklas Nielsen wrote:
Hey Chengwei - sorry for the tardy turnaround time on this review request.
To me, it still seems like we are treating the symptoms of the real issue:
PATH is appended multiple times and the subsequent globbing adds the
available
Will this be shown no matter if the framework announced a framework webui
or not? Can we make it conditional like below?
- Niklas Nielsen
On Sept. 27, 2014, 9:28 p.m., Tobi Knaup wrote:
---
This is an automatically generated e-mail. To reply
On Sept. 19, 2014, 5:24 p.m., Adam B wrote:
I think it's valuable to outline some guidelines for anybody interested in
becoming a committer, but I don't think we should set too many strict rules
and regulations around it. Other thoughts below.
Dominic Hamon wrote:
I think
) docs on the
EC. So I think we should land this asap :-) Tom, do you have cycles to review?
docs/external-containerizer.md
https://reviews.apache.org/r/22169/#comment95357
Worth making the paths relative?
- Niklas Nielsen
On Sept. 5, 2014, 1:48 a.m., Till Toenshoff wrote
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/
---
(Updated Oct. 1, 2014, 4:18 p.m.)
Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26125/#review55229
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 2, 2014, 9:10 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26303/#review55305
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 2, 2014, 5:26 p.m
On Sept. 29, 2014, 2:57 p.m., Niklas Nielsen wrote:
include/mesos/module.hpp.in, lines 46-47
https://reviews.apache.org/r/25848/diff/11/?file=708522#file708522line46
Can we use existing boost helpers for this? Something like
http://www.boost.org/doc/libs/1_56_0/libs/preprocessor
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25434/
---
(Updated Oct. 2, 2014, 12:17 a.m.)
Review request for mesos, Benjamin Hindman, Niklas Nielsen, Till Toenshoff,
and Timothy St
it to
slave_tests.cpp instead?
How about using 'statusMatchesTask' or 'statusHasTaskId'. 'relatedTo' seems
a bit informal/imprecise.
- Niklas Nielsen
On Oct. 2, 2014, 12:17 a.m., Alexander Rukletsov wrote
On Sept. 15, 2014, 2:17 p.m., Jie Yu wrote:
This more looks like a bug somewhere. Let's try to find out the true root
cause first.
Niklas Nielsen wrote:
True - but throwing the result away from await() seems silly/unsafe too
(rather on relying on the await to have completed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25848/#review55823
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 8, 2014, 9:22 a.m
by our set of graced compilers?
- Niklas Nielsen
On Sept. 29, 2014, 2:38 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26150
issue?
- Niklas Nielsen
On Aug. 25, 2014, 5:12 p.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23710
/#comment96244
Just noticed this - shutdown() doesn't describe what you expect the
function to do or how you use it. How about ::clear() or ::unloadAll()?
- Niklas Nielsen
On Oct. 8, 2014, 9:22 a.m., Kapil Arya wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26467/#review55896
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 8, 2014, 4:33 p.m
Fixed in https://reviews.apache.org/r/26467/ - sorry for the noise
Niklas
On 8 October 2014 16:32, Apache Jenkins Server jenk...@builds.apache.org
wrote:
See https://builds.apache.org/job/mesos-reviewbot/1900/
--
[URLTrigger] A change within the
/26508/#comment96372
Or else what? Modules gets overwritten right?
Or maybe just mentioned that you 'must not'?
src/module/manager.hpp
https://reviews.apache.org/r/26508/#comment96373
Is this just a fly-by style fix?
Why include module.hpp here?
- Niklas Nielsen
On Oct. 9
/#comment96383
Let's get the master flags help text solidified and update this accordingly.
- Niklas Nielsen
On Oct. 9, 2014, 10:20 a.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
- Niklas Nielsen
On Oct. 9, 2014, 12:59 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26513/
---
(Updated Oct
const strings if you don't intent to change them
How about hoisting the 'LD_LIBRARY_PATH' string and define it once as a
constant?
- Niklas Nielsen
On Oct. 10, 2014, 8:24 a.m., Kapil Arya wrote
On Oct. 10, 2014, 8:31 a.m., Niklas Nielsen wrote:
src/module/manager.cpp, lines 191-193
https://reviews.apache.org/r/26529/diff/2/?file=717123#file717123line191
Mind mentioning fixing this bug (and adding tests for it) in the RR
description? We try to separate concerns / issues
/#comment96476
Can we include the JSON syntax here instead of '...'?
- Niklas Nielsen
On Oct. 9, 2014, 4:19 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508/#review56183
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 9, 2014, 4:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26529/#review56237
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 10, 2014, 2:32 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26588/#review56268
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 10, 2014, 5:41 p.m
/master/3rdparty/libprocess/include/process/time.hpp
- Niklas Nielsen
On Oct. 13, 2014, 1:38 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26150
still want this
to go in)?
- Niklas Nielsen
On Jan. 29, 2014, 12:51 p.m., Thomas Rampelberg wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17431
On Oct. 14, 2014, 9:38 a.m., Tobi Knaup wrote:
Ship It!
Awesome - will land this today.
- Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17082/#review56538
than magic
encoding :-)
- Niklas Nielsen
On May 9, 2014, 12:05 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21277
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26583/
---
(Updated Oct. 10, 2014, 4:12 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26712/#review56600
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 14, 2014, 4:01 p.m
the libraryExtension constant as with the previous module
patch?
- Niklas Nielsen
On Oct. 15, 2014, 9:52 a.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26071
/slave/status_update_manager.cpp
https://reviews.apache.org/r/26698/#comment97141
Scan of s/ // per new C++11 style
src/slave/status_update_manager.cpp
https://reviews.apache.org/r/26698/#comment97142
Can you use stream-next() instead ?
- Niklas Nielsen
On Oct. 14, 2014, 11 a.m
/#comment97147
What are your guarantees that task_id() is in the states map? Maybe guard
it?
- Niklas Nielsen
On Oct. 14, 2014, 11:03 a.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/#review56800
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 12, 2014, 1:08 p.m
://reviews.apache.org/r/26476/#comment97218
s/t/t != NULL/
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp
https://reviews.apache.org/r/26476/#comment97216
reduce 2 spaces left
- Niklas Nielsen
On Oct. 8, 2014, 6:35 p.m., Joris Van Remoortere wrote
://reviews.apache.org/r/26578/#comment97225
How about the include for unique ptr?
3rdparty/libprocess/include/process/gc.hpp
https://reviews.apache.org/r/26578/#comment97227
Let 'iter' spell out what it is for (and expand to a full word).
- Niklas Nielsen
On Oct. 13, 2014, 10:29 a.m., Joris Van
/#comment97257
s/reset/Reset/
- Niklas Nielsen
On Oct. 13, 2014, 6:24 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26674
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26629/#review56825
---
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 12, 2014, 1:11 p.m
1 - 100 of 1166 matches
Mail list logo
