Re: Useless use of a constant in void context at Makefile.PL line 467

2003-10-28 Thread Carl Brewer 
Stas Bekman wrote:

Carl Brewer wrote:

Stas Bekman wrote:


So the offending line is:

 $string .= Apache::Test::install::nuke_Apache__test_target()
 if APACHE_TEST_INSTALL();
You lost the actual constant that it was complaining about ;) I 
should have looked closer.

Any change if you replace it with:

if (APACHE_TEST_INSTALL()) {
   $string .= Apache::Test::install::nuke_Apache__test_target();
}


Nope, same error.


OK, what happens if you replace that line with:

print APACHE_TEST_INSTALL ? APACHE_TEST_INSTALL : NOT 
APACHE_TEST_INSTALL;
$string .= Apache::Test::install::nuke_Apache__test_target();

does it complain about the print line, or the $string one?
It's complainign abuot the test line :

if (APACHE_TEST_INSTALL()) {


Also what happens if you change

BEGIN {
use constant APACHE_TEST_INSTALL = -e 'Apache-Test';
use lib './Apache-Test';
require 'install-pl' if APACHE_TEST_INSTALL;
}
to:

BEGIN {
use constant APACHE_TEST_INSTALL = -e 'Apache-Test';
I think this is the bit that isn't working.  The constant isn't being
set, so the -e 'Apache-Test' test is failing.
This would be consistant with there being no such directory if you
do a straight CVS checkout, rather than untar'ing a distribution
and then using CVS updates.  Is this something we need to fix in
the CVS tree, or something?



use lib './Apache-Test';
if (APACHE_TEST_INSTALL) {
  warn loading install-pl';
  require 'install-pl';
}
}
does it print loading install-pl?
no

Finally try replacing:

 require 'install-pl';
with
 require './install-pl';
Done, no change

Carl



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Useless use of a constant in void context at Makefile.PL line 467

2003-10-28 Thread Stas Bekman 
Carl Brewer wrote:
[...]
Also what happens if you change

BEGIN {
use constant APACHE_TEST_INSTALL = -e 'Apache-Test';
use lib './Apache-Test';
require 'install-pl' if APACHE_TEST_INSTALL;
}
to:

BEGIN {
use constant APACHE_TEST_INSTALL = -e 'Apache-Test';


I think this is the bit that isn't working.  The constant isn't being
set, so the -e 'Apache-Test' test is failing.
What do you mean by 'the constant not being set? It's either true or false, 
bu it's always set. Does this work for you?

perl -lwe 'use constant A = -e Apache-Test1; print A ? OK : NOT OK;'
NOT OK
perl -lwe 'use constant A = -e Apache-Test; print A ? OK : NOT OK;'
OK
it's fine if Apache-Test is not there. APACHE_TEST_INSTALL should return false.

This would be consistant with there being no such directory if you
do a straight CVS checkout, rather than untar'ing a distribution
and then using CVS updates.  Is this something we need to fix in
the CVS tree, or something?
Actually, it's not. If you do a fresh checkout, you get Apache-Test checked 
out as well. Only if you remove it and do 'cvs up' it won't re-fetch that 
directory.

But now that you told me the circumstances the problem happens at, I'm able to 
reproduce it, after removing 'Apache-Test'. So I'll fix it ;)

__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Useless use of a constant in void context at Makefile.PL line 467

2003-10-28 Thread Stas Bekman 
It's now fixed in cvs. Apparently constants don't seem to work when moved into 
a different namespace. May be a bug in perl, may be that's how it should be. 
In any case, moving to lexical variable solves the problem.

__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Useless use of a constant in void context at Makefile.PL line 467

2003-10-28 Thread Carl Brewer 
Stas Bekman wrote:

It's now fixed in cvs. Apparently constants don't seem to work when 
moved into a different namespace. May be a bug in perl, may be that's 
how it should be. In any case, moving to lexical variable solves the 
problem.
Magic,

thanks Stas :)

Carl



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Useless use of a constant in void context at Makefile.PL line 467

2003-10-17 Thread Stas Bekman 
Carl Brewer wrote:
Stas Bekman wrote:


So the offending line is:

 $string .= Apache::Test::install::nuke_Apache__test_target()
 if APACHE_TEST_INSTALL();
You lost the actual constant that it was complaining about ;) I should 
have looked closer.

Any change if you replace it with:

if (APACHE_TEST_INSTALL()) {
   $string .= Apache::Test::install::nuke_Apache__test_target();
}


Nope, same error.
OK, what happens if you replace that line with:

print APACHE_TEST_INSTALL ? APACHE_TEST_INSTALL : NOT APACHE_TEST_INSTALL;
$string .= Apache::Test::install::nuke_Apache__test_target();
does it complain about the print line, or the $string one?

Also what happens if you change

BEGIN {
use constant APACHE_TEST_INSTALL = -e 'Apache-Test';
use lib './Apache-Test';
require 'install-pl' if APACHE_TEST_INSTALL;
}
to:

BEGIN {
use constant APACHE_TEST_INSTALL = -e 'Apache-Test';
use lib './Apache-Test';
if (APACHE_TEST_INSTALL) {
  warn loading install-pl';
  require 'install-pl';
}
}
does it print loading install-pl?

Finally try replacing:

 require 'install-pl';
with
 require './install-pl';
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Useless use of a constant in void context at Makefile.PL line 467

2003-10-16 Thread Carl Brewer 
Stas Bekman wrote:


So the offending line is:

 $string .= Apache::Test::install::nuke_Apache__test_target()
 if APACHE_TEST_INSTALL();
You lost the actual constant that it was complaining about ;) I should 
have looked closer.

Any change if you replace it with:

if (APACHE_TEST_INSTALL()) {
   $string .= Apache::Test::install::nuke_Apache__test_target();
}
Nope, same error.

cheers

Carl



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Useless use of a constant in void context at Makefile.PL line 467

2003-10-15 Thread Stas Bekman 
Carl Brewer wrote:
Stas Bekman wrote:

Carl Brewer wrote:

current CVS pull (as of this morning)


I just pulled the very latest mp2 CVS down, and am still
seeing this error :


steel1: {167} perl Makefile.PL MP_APXS=/usr/local/apache2/bin/apxs
Useless use of a constant in void context at Makefile.PL line 467.
steel1: {168}
The offending line is :

$string .= Apache::Test::install::nuke_Apache__test_target()

Is this some work in progress or something you need to know about?


Nothing has changed since the 1.99_10 release in the build sw. Do you 
get a different behavior if you try with 1.99_10? Also are you sure 
that the line is reported correctly? Try to verify that the reported 
line is correct:

Index: Makefile.PL
===
RCS file: /home/cvs/modperl-2.0/Makefile.PL,v
retrieving revision 1.125
diff -u -r1.125 Makefile.PL
--- Makefile.PL 21 Sep 2003 03:05:18 -  1.125
+++ Makefile.PL 1 Oct 2003 01:08:05 -
@@ -464,6 +464,7 @@
 EOF

+#line 467
 $string .= Apache::Test::install::nuke_Apache__test_target()
 if APACHE_TEST_INSTALL();


may be something is wrong with older Apache/BuildConfig.pm
  *** using 
/usr/local/perl-5.8.1/lib/site_perl/5.8.1/i386-netbsd/Apache/BuildConfig.pm 

try moving it elsewhere (don't delete it, so we can debug it if it's 
indeed the one that causes the problem) and try again.


I moved it, but the same problem occurs.
So the offending line is:

 $string .= Apache::Test::install::nuke_Apache__test_target()
 if APACHE_TEST_INSTALL();
You lost the actual constant that it was complaining about ;) I should have 
looked closer.

Any change if you replace it with:

if (APACHE_TEST_INSTALL()) {
   $string .= Apache::Test::install::nuke_Apache__test_target();
}
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Useless use of a constant in void context at Makefile.PL line 467

2003-09-30 Thread Carl Brewer 
Stas Bekman wrote:


Nothing has changed since the 1.99_10 release in the build sw. Do you 
get a different behavior if you try with 1.99_10? Also are you sure that 
the line is reported correctly? Try to verify that the reported line is 
correct:
I'll have a play with this tonight when I get home :)

I'll also see what I can do with the IPv6 problems.

Carl



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]