Re: [s2] Allowed methods next step

2007-12-11 Thread Don Brown
On 12/11/07, Brian Pontarelli [EMAIL PROTECTED] wrote: At first I thought this might be a problem because SmartURLs was sub-classing the ActionConfig object in order to add some additional information for performance reasons. However, I have a feeling that I can remove the sub-class. All the

Re: [s2] Allowed methods next step

2007-12-10 Thread Brian Pontarelli
Don Brown wrote: Since the commit for this feature involved a rather large XWork change (properly immutable configuration objects [1]), I decided to commit what I have and discuss the next steps. First, due the aforementioned fix [1], Brian, your SmartURL's migration work will probably be most

[s2] Allowed methods next step

2007-12-09 Thread Don Brown
Since the commit for this feature involved a rather large XWork change (properly immutable configuration objects [1]), I decided to commit what I have and discuss the next steps. First, due the aforementioned fix [1], Brian, your SmartURL's migration work will probably be most affected. I

Re: [s2] Allowed methods next step

2007-12-09 Thread Matt Raible
Is there anything on action that allows restricting roles? I remember this being in S1 and I'm unsure if it exists in S2. If not, it's something I believe we should add as I believe it's useful when using CMA. When using Spring Security, I generally keep all my configuration in my context file,

Re: [s2] Allowed methods next step

2007-12-09 Thread Tom Schneider
CMA = container managed authentication for those who haven't memorized every three letter acronym under the sun. What about using an s2 interceptor to enforce role security? That way you could have an implementation for whatever security mechanism your using and it's not tied to the struts

Re: [s2] Allowed methods next step

2007-12-09 Thread Matt Raible
On Dec 9, 2007 9:44 AM, Tom Schneider [EMAIL PROTECTED] wrote: CMA = container managed authentication for those who haven't memorized every three letter acronym under the sun. What about using an s2 interceptor to enforce role security? This is what I've done in the past. Yes, it works.

Re: [s2] Allowed methods

2007-12-05 Thread Matt Raible
I'm confused - why don't we just allow public methods to be called? Matt On Dec 5, 2007, at 1:06 PM, Don Brown wrote: I'm about to commit a fairly large patch that, among other things, adds built-in support for limiting what methods can be invoked on an Action. My motivation was actually to

Re: [s2] Allowed methods

2007-12-05 Thread Brian Pontarelli
3. A new @ActionMethod annotation for the codebehind plugin that declares a method as callable Does it make sense to collapse the SU ActionNames and ActionName annotations into this new annotation? This annotation could provide additional parameters to control the URLs for the method. If

Re: [struts-dev] [s2] Allowed methods

2007-12-05 Thread Dale Newfield
Don Brown wrote: 1. A new property/constant titled 'struts.restrictToDeclaredMethod' that will instruct the ActionConfig (where the allowedMethods property lives) to only allow the method that is explicitly defined (defaults to 'execute'). If false, all methods will be allowed. 2. A new

[s2] Allowed methods

2007-12-05 Thread Don Brown
I'm about to commit a fairly large patch that, among other things, adds built-in support for limiting what methods can be invoked on an Action. My motivation was actually to improve the ability for the REST plugin to introspect what HTTP methods are supported (automatic HTTP OPTIONS and WADL

Re: [s2] Allowed methods

2007-12-05 Thread Jeromy Evans
Don Brown wrote: 2. A new attribute on the action element called 'allowedMethods', which takes a comma-separated list of method names to allow 3. A new @ActionMethod annotation for the codebehind plugin that declares a method as callable I'm thinking about doing all three, but I'm not sure #2