[dev] [PATCH][blind] alloca #include for BSDs

2018-01-28 Thread Yuri
BSDs use different header for alloca than Linux. It sucks when it only works on Linux. Thanks, Yuri --- src/blind-split.c.orig  2017-05-06 11:27:39 UTC +++ src/blind-split.c @@ -2,7 +2,11 @@  #include "stream.h"  #include "util.h" +#if defined(__FreeBSD__) || defined(__OpenBSD__) ||

Re: [dev] [PATCH][blind] alloca #include for BSDs

2018-01-28 Thread fao_
On 2018-01-28 10:18 pm, Yuri wrote: Additionally, -D_XOPEN_SOURCE=700 causes build failures on FreeBSD. I had to patch it away in both cases. Not sure what it is and why it is there, just reporting this problem. -D_XOPEN_SOURCE=700 is equal to #include _XOPEN_SOURCE 700 It states that the

Re: [dev] [BUG REPORT] blind: clang-40 warning: variable 'frames' is uninitialized when used here

2018-01-28 Thread Mattias Andrée
On Sun, 28 Jan 2018 13:21:12 -0800 Yuri wrote: > src/blind-from-video.c:234:25: warning: variable 'frames' is > uninitialized when used here [-Wuninitialized] >     SPRINTF_HEAD_ZN(head, frames, width, height, "xyza", > ); >  

Re: [dev] [PATCH][blind] alloca #include for BSDs

2018-01-28 Thread Yuri
On 01/28/18 13:29, Mattias Andrée wrote: Thanks again! I will be fixing this, but probably via config.mk. You're welcome! Few more things: You should also change your config.mk files to allow external optimization and other flags. For example: > CFLAGS   = -std=c99 -Wall -pedantic

[dev] [BUG REPORT] blind: clang-40 warning: variable 'frames' is uninitialized when used here

2018-01-28 Thread Yuri
src/blind-from-video.c:234:25: warning: variable 'frames' is uninitialized when used here [-Wuninitialized]     SPRINTF_HEAD_ZN(head, frames, width, height, "xyza", );   ^~ src/stream.h:9:12: note: expanded from macro 'SPRINTF_HEAD_ZN'

Re: [dev] [PATCH][blind] alloca #include for BSDs

2018-01-28 Thread Mattias Andrée
On Sun, 28 Jan 2018 13:24:06 -0800 Yuri wrote: > BSDs use different header for alloca than Linux. > > It sucks when it only works on Linux. > > > Thanks, > > Yuri > > > > --- src/blind-split.c.orig  2017-05-06 11:27:39 UTC > +++ src/blind-split.c > @@ -2,7 +2,11 @@ >