Re: svn commit: r1794651 [1/3] - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/authenticator/ java/org/apache/cat

2017-05-10 Thread Emmanuel Bourg
Le 10/05/2017 à 10:39, Mark Thomas a écrit : > I think you might just have made Chuck's day with this commit. Norris? :) Sorry for the noise, I noticed that you were often removing these parentheses when modifying the code, so I thought it would be a good idea to remove them once and for all.

svn commit: r1794687 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/ha/tcp/ java/org/apache/catalina/loader/ java/org/apache/catalina/

2017-05-10 Thread ebourg
Author: ebourg Date: Wed May 10 08:50:57 2017 New Revision: 1794687 URL: http://svn.apache.org/viewvc?rev=1794687=rev Log: Removed redundant casts Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java

Re: svn commit: r1794651 [1/3] - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/authenticator/ java/org/apache/cat

2017-05-10 Thread Mark Thomas
On 10/05/17 10:32, Emmanuel Bourg wrote: > Le 10/05/2017 à 10:39, Mark Thomas a écrit : > >> I think you might just have made Chuck's day with this commit. > > Norris? :) :) Caldarale > Sorry for the noise, I noticed that you were often removing > these parentheses when modifying the code, so

svn commit: r1794686 - in /tomcat/trunk/java/org/apache/catalina: ant/jmx/JMXAccessorTask.java ha/session/DeltaManager.java ha/tcp/ReplicationValve.java ha/tcp/SimpleTcpCluster.java tribes/transport/n

2017-05-10 Thread ebourg
Author: ebourg Date: Wed May 10 08:38:51 2017 New Revision: 1794686 URL: http://svn.apache.org/viewvc?rev=1794686=rev Log: Use foreach loops instead of for+iterator loops Modified: tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorTask.java

Re: svn commit: r1794651 [1/3] - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/authenticator/ java/org/apache/cat

2017-05-10 Thread Mark Thomas
On 09/05/17 23:23, ebo...@apache.org wrote: > Author: ebourg > Date: Tue May 9 22:22:59 2017 > New Revision: 1794651 > > URL: http://svn.apache.org/viewvc?rev=1794651=rev > Log: > Removed unnecessary parentheses in return statements I think you might just have made Chuck's day with this commit.

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-apr (in module tomcat-7.0.x) failed

2017-05-10 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-apr has an issue affecting its community

svn commit: r1794729 - in /tomcat/trunk: java/javax/servlet/http/ java/org/apache/catalina/connector/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/ha/tcp/ java/org/apache/catalina/loa

2017-05-10 Thread ebourg
Author: ebourg Date: Wed May 10 14:42:57 2017 New Revision: 1794729 URL: http://svn.apache.org/viewvc?rev=1794729=rev Log: Removed unnecessary return statements at the end of void methods Modified: tomcat/trunk/java/javax/servlet/http/HttpServlet.java

svn commit: r1794730 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_78: ./ build.properties.default

2017-05-10 Thread violetagg
Author: violetagg Date: Wed May 10 14:50:11 2017 New Revision: 1794730 URL: http://svn.apache.org/viewvc?rev=1794730=rev Log: Tag 7.0.78 Added: tomcat/tc7.0.x/tags/TOMCAT_7_0_78/ (props changed) - copied from r1794729, tomcat/tc7.0.x/trunk/ Modified:

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

2017-05-10 Thread Bill Barker
/objenesis/main/target/objenesis-2.6-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170510.jar -Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20170510/bin/openssl -Dexecute.test.nio=false

RE: svn commit: r1794651 [1/3] - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/authenticator/ java/org/apache/cat

2017-05-10 Thread Caldarale, Charles R
> From: Mark Thomas [mailto:ma...@apache.org] > Subject: Re: svn commit: r1794651 [1/3] - in /tomcat/trunk: java/org/apache/catalina/ > java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ > java/org/apache/catalina/authenticator/ java/org/apache/catalina/connector/ >

svn commit: r1794713 - in /tomcat/trunk/java/org/apache: catalina/tribes/tipis/ReplicatedMap.java tomcat/util/modeler/Registry.java tomcat/util/scan/StandardJarScanner.java

2017-05-10 Thread ebourg
Author: ebourg Date: Wed May 10 12:16:14 2017 New Revision: 1794713 URL: http://svn.apache.org/viewvc?rev=1794713=rev Log: Removed unused imports Modified: tomcat/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMap.java tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java

Re: svn commit: r1794651 [1/3] - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ant/ java/org/apache/catalina/ant/jmx/ java/org/apache/catalina/authenticator/ java/org/apache/cat

2017-05-10 Thread Emmanuel Bourg
Le 10/05/2017 à 12:04, Mark Thomas a écrit : > No need to apologise. Doing that had been on my wish list for a long > time but I hadn't found an easy way to do it. What it you use? Regexp? I started with a regexp and then switched to the structural search and replace feature of IntelliJ. > I'm

svn commit: r1794718 - in /tomcat/trunk: java/javax/el/ java/org/apache/catalina/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/manager/ java/org/apache/c

2017-05-10 Thread ebourg
Author: ebourg Date: Wed May 10 13:13:47 2017 New Revision: 1794718 URL: http://svn.apache.org/viewvc?rev=1794718=rev Log: Removed more unnecessary parentheses in return statements Modified: tomcat/trunk/java/javax/el/ArrayELResolver.java tomcat/trunk/java/javax/el/ListELResolver.java

svn commit: r1794721 - in /tomcat/trunk/java/org/apache: coyote/http2/ConnectionSettingsBase.java tomcat/util/net/SSLHostConfig.java

2017-05-10 Thread ebourg
Author: ebourg Date: Wed May 10 13:25:26 2017 New Revision: 1794721 URL: http://svn.apache.org/viewvc?rev=1794721=rev Log: Use an EnumMap instead of a HashMap when the key is an enum Modified: tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettingsBase.java

svn commit: r1794726 - in /tomcat/trunk/java: javax/servlet/http/ org/apache/catalina/connector/ org/apache/catalina/core/ org/apache/catalina/valves/rewrite/ org/apache/coyote/http11/ org/apache/jasp

2017-05-10 Thread ebourg
Author: ebourg Date: Wed May 10 14:27:20 2017 New Revision: 1794726 URL: http://svn.apache.org/viewvc?rev=1794726=rev Log: Optimized array copies with Arrays.copyOf() and System.arraycopy() Modified: tomcat/trunk/java/javax/servlet/http/HttpUtils.java

[VOTE] Release Apache Tomcat 7.0.78

2017-05-10 Thread Violeta Georgieva
The proposed Apache Tomcat 7.0.78 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.78/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1135/ The svn tag is:

svn commit: r1794735 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_44: ./ build.properties.default

2017-05-10 Thread violetagg
Author: violetagg Date: Wed May 10 16:17:26 2017 New Revision: 1794735 URL: http://svn.apache.org/viewvc?rev=1794735=rev Log: Tag 8.0.44 Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_44/ (props changed) - copied from r1794734, tomcat/tc8.0.x/trunk/ Modified:

Re: [VOTE] Release Apache Tomcat 8.5.15

2017-05-10 Thread Christopher Schultz
Mark, On 5/5/17 7:38 AM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.15 release is now available for voting. > > The major changes compared to the 8.5.13 release are: > > - Various improvements to the handling of static custom error pages > > - Update to Eclipse JDT Compiler 4.6.3 > >

svn commit: r19607 [2/2] - in /dev/tomcat/tomcat-7/v7.0.78: ./ bin/ bin/embed/ bin/extras/ src/

2017-05-10 Thread violetagg
Added: dev/tomcat/tomcat-7/v7.0.78/bin/extras/catalina-jmx-remote.jar.sha1 == --- dev/tomcat/tomcat-7/v7.0.78/bin/extras/catalina-jmx-remote.jar.sha1 (added) +++

svn commit: r19607 [1/2] - in /dev/tomcat/tomcat-7/v7.0.78: ./ bin/ bin/embed/ bin/extras/ src/

2017-05-10 Thread violetagg
Author: violetagg Date: Wed May 10 15:43:11 2017 New Revision: 19607 Log: Stage 7.0.78 RC Added: dev/tomcat/tomcat-7/v7.0.78/ dev/tomcat/tomcat-7/v7.0.78/KEYS dev/tomcat/tomcat-7/v7.0.78/README.html dev/tomcat/tomcat-7/v7.0.78/RELEASE-NOTES dev/tomcat/tomcat-7/v7.0.78/bin/

svn commit: r1794739 - /tomcat/tc8.0.x/tags/TOMCAT_8_0_44/

2017-05-10 Thread violetagg
Author: violetagg Date: Wed May 10 16:36:25 2017 New Revision: 1794739 URL: http://svn.apache.org/viewvc?rev=1794739=rev Log: Drop the tag - forgot to remove "in development" attr in changelog.xml Removed: tomcat/tc8.0.x/tags/TOMCAT_8_0_44/

Re: Had trouble building libtcnative [openssl]

2017-05-10 Thread Christopher Schultz
Rainer, On 5/8/17 5:00 PM, Rainer Jung wrote: > Hi Chris, > > Am 08.05.2017 um 20:23 schrieb Christopher Schultz: >> I'm trying to do a complete test of 8.5.15 (candidate) and I can't >> seem to build tcnative because of the OpenSSL dependency. >> >> On my system, I've got OpensSSL 1.0.1t

svn commit: r1794740 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_44: ./ build.properties.default webapps/docs/changelog.xml

2017-05-10 Thread violetagg
Author: violetagg Date: Wed May 10 16:41:19 2017 New Revision: 1794740 URL: http://svn.apache.org/viewvc?rev=1794740=rev Log: Tag 8.0.44 Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_44/ (props changed) - copied from r1794734, tomcat/tc8.0.x/trunk/ Modified:

Re: [VOTE] Release Apache Tomcat 8.5.15

2017-05-10 Thread Coty Sutherland
On Fri, May 5, 2017 at 7:38 AM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.15 release is now available for voting. > > The major changes compared to the 8.5.13 release are: > > - Various improvements to the handling of static custom error pages > > - Update to Eclipse

svn commit: r1794733 - in /tomcat/tc7.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

2017-05-10 Thread violetagg
Author: violetagg Date: Wed May 10 15:47:29 2017 New Revision: 1794733 URL: http://svn.apache.org/viewvc?rev=1794733=rev Log: Increment version for next dev cycle Modified: tomcat/tc7.0.x/trunk/build.properties.default tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default

svn commit: r19611 - /dev/tomcat/tomcat-9/v9.0.0.M21/ /release/tomcat/tomcat-9/v9.0.0.M21/

2017-05-10 Thread markt
Author: markt Date: Wed May 10 18:31:09 2017 New Revision: 19611 Log: Release 9.0.0.M21 Added: release/tomcat/tomcat-9/v9.0.0.M21/ - copied from r19610, dev/tomcat/tomcat-9/v9.0.0.M21/ Removed: dev/tomcat/tomcat-9/v9.0.0.M21/

svn commit: r19610 [1/2] - in /dev/tomcat/tomcat-8/v8.0.44: ./ bin/ bin/embed/ bin/extras/ src/

2017-05-10 Thread violetagg
Author: violetagg Date: Wed May 10 18:07:16 2017 New Revision: 19610 Log: Stage 8.0.44 RC Added: dev/tomcat/tomcat-8/v8.0.44/ dev/tomcat/tomcat-8/v8.0.44/KEYS dev/tomcat/tomcat-8/v8.0.44/README.html dev/tomcat/tomcat-8/v8.0.44/RELEASE-NOTES dev/tomcat/tomcat-8/v8.0.44/bin/

svn commit: r19610 [2/2] - in /dev/tomcat/tomcat-8/v8.0.44: ./ bin/ bin/embed/ bin/extras/ src/

2017-05-10 Thread violetagg
Added: dev/tomcat/tomcat-8/v8.0.44/bin/extras/catalina-ws.jar.asc == --- dev/tomcat/tomcat-8/v8.0.44/bin/extras/catalina-ws.jar.asc (added) +++ dev/tomcat/tomcat-8/v8.0.44/bin/extras/catalina-ws.jar.asc Wed May 10

svn commit: r19612 - /dev/tomcat/tomcat-8/v8.5.15/ /release/tomcat/tomcat-8/v8.5.15/

2017-05-10 Thread markt
Author: markt Date: Wed May 10 18:35:24 2017 New Revision: 19612 Log: Release 8.5.15 Added: release/tomcat/tomcat-8/v8.5.15/ - copied from r19611, dev/tomcat/tomcat-8/v8.5.15/ Removed: dev/tomcat/tomcat-8/v8.5.15/

svn commit: r1794745 - in /tomcat/tc8.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

2017-05-10 Thread violetagg
Author: violetagg Date: Wed May 10 18:47:53 2017 New Revision: 1794745 URL: http://svn.apache.org/viewvc?rev=1794745=rev Log: Increment version for next dev cycle Modified: tomcat/tc8.0.x/trunk/build.properties.default tomcat/tc8.0.x/trunk/res/maven/mvn.properties.default

[VOTE][RESULT] Release Apache Tomcat 9.0.0.M21

2017-05-10 Thread Mark Thomas
The following votes were cast: Binding: +1: markt, violetagg, fschumacher, mgrigorov Non-binding: +1: huxing The vote therefore passes. Thank you to everyone who contributed towards this release. Mark - To unsubscribe,

[VOTE][RESULT] Release Apache Tomcat 8.5.15

2017-05-10 Thread Mark Thomas
The following votes were cast: Binding: +1: markt, violetagg, fschumacher, mgrigorov, schultz Non-binding: +1: huxing, ebourg, csutherland The vote therefore passes. Thank you to everyone who contributed to this release. Mark

[VOTE] Release Apache Tomcat 8.0.44

2017-05-10 Thread Violeta Georgieva
The proposed Apache Tomcat 8.0.44 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.44/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1136/ The svn tag is:

svn commit: r1794746 - in /tomcat/trunk/java/javax/el: ArrayELResolver.java ListELResolver.java

2017-05-10 Thread markt
Author: markt Date: Wed May 10 18:52:16 2017 New Revision: 1794746 URL: http://svn.apache.org/viewvc?rev=1794746=rev Log: Fix auto-boxing warnings Modified: tomcat/trunk/java/javax/el/ArrayELResolver.java tomcat/trunk/java/javax/el/ListELResolver.java Modified:

[GitHub] tomcat pull request #55: change the comment

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomcat/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

svn commit: r1794674 - in /tomcat/trunk: java/org/apache/catalina/connector/CoyoteAdapter.java webapps/docs/changelog.xml

2017-05-10 Thread violetagg
Author: violetagg Date: Wed May 10 06:53:37 2017 New Revision: 1794674 URL: http://svn.apache.org/viewvc?rev=1794674=rev Log: Correct javadoc. Patch provided by John Andrew (XUZHOUWANG). This closes #55 Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

svn commit: r1794677 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/connector/CoyoteAdapter.java webapps/docs/changelog.xml

2017-05-10 Thread violetagg
Author: violetagg Date: Wed May 10 07:07:33 2017 New Revision: 1794677 URL: http://svn.apache.org/viewvc?rev=1794677=rev Log: Correct javadoc. Patch provided by John Andrew (XUZHOUWANG). Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1794675 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/connector/CoyoteAdapter.java webapps/docs/changelog.xml

2017-05-10 Thread violetagg
Author: violetagg Date: Wed May 10 07:01:24 2017 New Revision: 1794675 URL: http://svn.apache.org/viewvc?rev=1794675=rev Log: Correct javadoc. Patch provided by John Andrew (XUZHOUWANG). Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1794678 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/CoyoteAdapter.java webapps/docs/changelog.xml

2017-05-10 Thread violetagg
Author: violetagg Date: Wed May 10 07:10:44 2017 New Revision: 1794678 URL: http://svn.apache.org/viewvc?rev=1794678=rev Log: Correct javadoc. Patch provided by John Andrew (XUZHOUWANG). Modified: tomcat/tc7.0.x/trunk/ (props changed)

Tagging Tomcat 7/8.0

2017-05-10 Thread Violeta Georgieva
Hi, I'm going to tag Tomcat 7/8.0 later today. Please reply here if you want to include something in addition to these releases. Regards, Violeta

svn commit: r1794684 [1/2] - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/ha/backend/ java/org/apache/catalina/ha/session/ java/org/apa

2017-05-10 Thread ebourg
Author: ebourg Date: Wed May 10 08:26:05 2017 New Revision: 1794684 URL: http://svn.apache.org/viewvc?rev=1794684=rev Log: Use foreach loops instead of while+iterator loops Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java

svn commit: r1794684 [2/2] - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/ha/backend/ java/org/apache/catalina/ha/session/ java/org/apa

2017-05-10 Thread ebourg
Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java?rev=1794684=1794683=1794684=diff

Re: asyncError() is not valid while in Async state DISPATCHING

2017-05-10 Thread Violeta Georgieva
Hi, 2017-05-02 12:54 GMT+03:00 Violeta Georgieva : > > > 2017-05-02 12:25 GMT+03:00 Mark Thomas : > > > > On 02/05/17 09:52, Violeta Georgieva wrote: > > > Hi, > > > > > > I have a question about Async state DISPATCHING. > > > > > > I have the following

svn commit: r1794752 - in /tomcat/trunk: java/org/apache/jasper/JspC.java java/org/apache/jasper/resources/LocalStrings.properties webapps/docs/changelog.xml

2017-05-10 Thread markt
Author: markt Date: Wed May 10 19:57:33 2017 New Revision: 1794752 URL: http://svn.apache.org/viewvc?rev=1794752=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=53011 When pre-compiling with JspC, report all compilation errors rather than stopping after the first error. A new option

[Bug 53011] Ant Jasper task fails after one error

2017-05-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=53011 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED