Re: [VOTE] 2.0 Release Quality

2016-11-30 Thread Alex Fedotov
One more item that we had to fix is use of exceptions to control flow. Stuff like this: Parser$LookaheadSuccess : if (jj_la == 0 && jj_scanpos == jj_lastpos) throw jj_ls; I think there was something like that in VelocityCharStream as well. When creating exceptions for normal control flow

Re: [VOTE] 2.0 Release Quality

2016-11-30 Thread Claude Brisson
I was delaying my vote for no real reason, but now I'm clearly in favor of pushing out another RC with the following added: - include the Context in event parameters and deprecate ContextAware interface (and all related interfaces and methods) - review ASTStringLiteral implementation to

Re: [VOTE] 2.0 Release Quality

2016-11-18 Thread Nathan Bubna
+1 GA On Wed, Nov 16, 2016 at 7:24 AM, Greg Huber wrote: > Thanks, works great for me. > > [x] General Availability (GA) > > +1 non binding. > > > On 16 November 2016 at 11:51, Claude Brisson wrote: > > > The Velocity Engine 2.0 RC3 test build has been

Re: [VOTE] 2.0 Release Quality

2016-11-16 Thread Greg Huber
Thanks, works great for me. [x] General Availability (GA) +1 non binding. On 16 November 2016 at 11:51, Claude Brisson wrote: > The Velocity Engine 2.0 RC3 test build has been available since the 12th, > and the RC4 (which only contains trivial fixes) has just been