Re: [VOTE] 2.0 Release Quality

2016-11-30 Thread Alex Fedotov 
One more item that we had to fix is use of exceptions to control flow.

Stuff like this:  Parser$LookaheadSuccess : if (jj_la == 0 && jj_scanpos ==
jj_lastpos) throw jj_ls;

I think there was something like that in VelocityCharStream as well.

When creating exceptions for normal control flow "fillInStackTrace" becomes
very expensive.
Most of all it kills performance while debugger is attached.

Alex


On Wed, Nov 30, 2016 at 5:01 AM, Claude Brisson  wrote:

> I was delaying my vote for no real reason, but now I'm clearly in favor of
> pushing out another RC with the following added:
>
>  - include the Context in event parameters and deprecate ContextAware
> interface (and all related interfaces and methods)
>
>  - review ASTStringLiteral implementation to avoid unecessary string
> buffering
>
> So, still
>
> [x] Leave at test build
>
>
>   Claude
>
>
> On 18/11/2016 18:33, Nathan Bubna wrote:
>
>> +1 GA
>>
>> On Wed, Nov 16, 2016 at 7:24 AM, Greg Huber  wrote:
>>
>> Thanks, works great for me.
>>>
>>> [x] General Availability (GA)
>>>
>>> +1 non binding.
>>>
>>>
>>> On 16 November 2016 at 11:51, Claude Brisson  wrote:
>>>
>>> The Velocity Engine 2.0 RC3 test build has been available since the 12th,
 and the RC4 (which only contains trivial fixes) has just been published.

 Release notes:

 * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
 ine/2.0/release-notes.html

 Distribution:

   * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
 ine/2.0/

 Maven 2 staging repository:

   * https://repository.apache.org/content/repositories/orgapache
 velocity-1013

 If you have had a chance to review the test build, please respond with a
 vote on its quality:

   [ ] Leave at test build
   [ ] Alpha
   [ ] Beta
   [ ] General Availability (GA)

 Everyone who has tested the RC3 or the RC4 is invited to vote. Votes by
 PMC members are considered binding. A vote passes if there are at least
 three binding +1s and more +1s than -1s.


Claude


 -
 To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
 For additional commands, e-mail: dev-h...@velocity.apache.org



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [VOTE] 2.0 Release Quality

2016-11-30 Thread Claude Brisson 
I was delaying my vote for no real reason, but now I'm clearly in favor 
of pushing out another RC with the following added:


 - include the Context in event parameters and deprecate ContextAware 
interface (and all related interfaces and methods)


 - review ASTStringLiteral implementation to avoid unecessary string 
buffering


So, still

[x] Leave at test build


  Claude

On 18/11/2016 18:33, Nathan Bubna wrote:

+1 GA

On Wed, Nov 16, 2016 at 7:24 AM, Greg Huber  wrote:


Thanks, works great for me.

[x] General Availability (GA)

+1 non binding.


On 16 November 2016 at 11:51, Claude Brisson  wrote:


The Velocity Engine 2.0 RC3 test build has been available since the 12th,
and the RC4 (which only contains trivial fixes) has just been published.

Release notes:

* https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
ine/2.0/release-notes.html

Distribution:

  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/

Maven 2 staging repository:

  * https://repository.apache.org/content/repositories/orgapache
velocity-1013

If you have had a chance to review the test build, please respond with a
vote on its quality:

  [ ] Leave at test build
  [ ] Alpha
  [ ] Beta
  [ ] General Availability (GA)

Everyone who has tested the RC3 or the RC4 is invited to vote. Votes by
PMC members are considered binding. A vote passes if there are at least
three binding +1s and more +1s than -1s.


   Claude


-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org

Re: [VOTE] 2.0 Release Quality

2016-11-18 Thread Nathan Bubna 
+1 GA

On Wed, Nov 16, 2016 at 7:24 AM, Greg Huber  wrote:

> Thanks, works great for me.
>
> [x] General Availability (GA)
>
> +1 non binding.
>
>
> On 16 November 2016 at 11:51, Claude Brisson  wrote:
>
> > The Velocity Engine 2.0 RC3 test build has been available since the 12th,
> > and the RC4 (which only contains trivial fixes) has just been published.
> >
> > Release notes:
> >
> > * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
> > ine/2.0/release-notes.html
> >
> > Distribution:
> >
> >  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
> >
> > Maven 2 staging repository:
> >
> >  * https://repository.apache.org/content/repositories/orgapache
> > velocity-1013
> >
> > If you have had a chance to review the test build, please respond with a
> > vote on its quality:
> >
> >  [ ] Leave at test build
> >  [ ] Alpha
> >  [ ] Beta
> >  [ ] General Availability (GA)
> >
> > Everyone who has tested the RC3 or the RC4 is invited to vote. Votes by
> > PMC members are considered binding. A vote passes if there are at least
> > three binding +1s and more +1s than -1s.
> >
> >
> >   Claude
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> > For additional commands, e-mail: dev-h...@velocity.apache.org
> >
> >
>

Re: [VOTE] 2.0 Release Quality

2016-11-16 Thread Greg Huber 
Thanks, works great for me.

[x] General Availability (GA)

+1 non binding.


On 16 November 2016 at 11:51, Claude Brisson  wrote:

> The Velocity Engine 2.0 RC3 test build has been available since the 12th,
> and the RC4 (which only contains trivial fixes) has just been published.
>
> Release notes:
>
> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
> ine/2.0/release-notes.html
>
> Distribution:
>
>  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>
> Maven 2 staging repository:
>
>  * https://repository.apache.org/content/repositories/orgapache
> velocity-1013
>
> If you have had a chance to review the test build, please respond with a
> vote on its quality:
>
>  [ ] Leave at test build
>  [ ] Alpha
>  [ ] Beta
>  [ ] General Availability (GA)
>
> Everyone who has tested the RC3 or the RC4 is invited to vote. Votes by
> PMC members are considered binding. A vote passes if there are at least
> three binding +1s and more +1s than -1s.
>
>
>   Claude
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>