smsbox http queue patch request

2009-09-02 Thread Stuart Beck
Hi, We are using the http queueing facility within the smsbox to handle the cases where there might be outages of our internal systems. On testing recently following a loarge outage of one system, I have found some strange behaviour. We had approx 400 messages in the retry queue due to the

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-02 Thread Alexander Malysh
Am 02.09.2009 um 16:07 schrieb Alejandro Guerrieri: Self-answering: From: aguerri...@kannel.org Subject:Re: [PATCH] add support of smsc-id for smpp-tlv group Date: 2 de septiembre de 2009 16:03:20 GMT+02:00 To: devel@kannel.org Reply-To:

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-02 Thread Alejandro Guerrieri
Self-answering: From: aguerri...@kannel.org Subject:Re: [PATCH] add support of smsc-id for smpp-tlv group Date: 2 de septiembre de 2009 16:03:20 GMT+02:00 To: devel@kannel.org Reply-To: devel@kannel.org It must be mailman adding it. M

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-02 Thread Alejandro Guerrieri
Nikos, I've received your email and the headers are: From: nbalka...@gmail.com Subject:Re: [PATCH] add support of smsc-id for smpp-tlv group Date: 2 de septiembre de 2009 15:48:20 GMT+02:00 To: amal...@kannel.org Cc: devel@kannel.org

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-02 Thread Nikos Balkanas
Hi Alex, Your comment at that point could have been more clear: /* The default smsc-id is set to "def;ault" since it is an illegal smsc-id and cannot be configured by a user */ And please reply to my latest mail in the thread, otherwise you are quoting out of context. With respect to lists: >

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-02 Thread Alexander Malysh
ok, fixed and commited to cvs... Thanks, Alex Am 02.09.2009 um 13:35 schrieb Alejandro Guerrieri: Patch looks good (and very welcome!) +1 PS: There's another typo, "can'be" instead of "can't be" on the comment for "def;ault". -- Alejandro Guerrieri aguerri...@kannel.org On 02/09/2009,

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-02 Thread Alejandro Guerrieri
Patch looks good (and very welcome!) +1 PS: There's another typo, "can'be" instead of "can't be" on the comment for "def;ault". -- Alejandro Guerrieri aguerri...@kannel.org On 02/09/2009, at 12:57, Alexander Malysh wrote: Am 02.09.2009 um 12:33 schrieb Nikos Balkanas: Yes, but octstr_

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-02 Thread Alexander Malysh
Am 02.09.2009 um 12:33 schrieb Nikos Balkanas: Yes, but octstr_split can return a single member list, same way it would handle single smsc-ids configured by the user. I have no reading problems, and your comment doesn't explain why you have to use a list of smscs as your default, just that

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-02 Thread Nikos Balkanas
Please disregard. Now I get it. You want to protect against the case that someone actually names his smsc as "default" in his configuration. Looks good. +1. Nikos - Original Message - From: Nikos Balkanas To: Alexander Malysh Cc: de...@vm1.kannel.org Sent: Wednesday, Septemb

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-02 Thread Nikos Balkanas
Yes, but octstr_split can return a single member list, same way it would handle single smsc-ids configured by the user. I have no reading problems, and your comment doesn't explain why you have to use a list of smscs as your default, just that ';' can be used as list seperator since it is not al

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-02 Thread Alexander Malysh
Hi, Am 02.09.2009 um 10:13 schrieb Nikos Balkanas: Hi Alex, Looks good. Some typos: Userguide: string <-> stringr ...this TLV valid <-> ...this TLV is valid(twice). fixed in my version... gw/smsc/smpp_pdu.c: 69 +#define DEFAULT_SMSC_ID "def;ault" Is this right? Did you mean "default"?

Re: [PATCH] add support of smsc-id for smpp-tlv group

2009-09-02 Thread Nikos Balkanas
Hi Alex, Looks good. Some typos: Userguide: string <-> stringr ...this TLV valid <-> ...this TLV is valid(twice). gw/smsc/smpp_pdu.c: 69 +#define DEFAULT_SMSC_ID "def;ault" Is this right? Did you mean "default"? BR, Nikos - Original Message - From: "Alexander Malysh" To: "Develo