Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alejandro Guerrieri
Ok, here's a new version of my patch to add support for custom MO parameters on the generic http-smsc. New features: 1. Support for setting the numeric response code for successful and failed requests (as it is now, it always returns 202 HTTP_ACCEPTED). 2. Support for setting the text

LMT extensions

2009-06-09 Thread V
Hello, Any have some experience with connection to LMT operator in Latvia with proprietary SMPP extensions for DLR and billing reports? I found previous thread about it, but with no decisions..:( Kind regards, Martynas - Hi,

Re: ota_compiler.c patch

2009-06-09 Thread Alexander Malysh
Hi, if I look through the code, Niko is right. Stipe could you .confirm this? Thanks, Alex Am 08.06.2009 um 22:09 schrieb Nikos Balkanas: Dear Stipe, On 2008/10/22 Rev 1.16 you reordered the INLINE attributes in ota_compiler.c. That broke the code in ota_compiler.c that relied on

Re: LMT extensions

2009-06-09 Thread Alexander Malysh
Hi, without their Spec is this impossible to say if Kannel can handle this... Please provide Spec. Thanks, Alex Am 09.06.2009 um 10:11 schrieb V: Hello, Any have some experience with connection to LMT operator in Latvia with proprietary SMPP extensions for DLR and billing reports? I

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alexander Malysh
Hi, Seems you don't handle charset at all. Do you assume to receive UTF-8 in any case? I don't think it's applicable to generic interface. At least alt-charset should be taken in account... some comments to patch below... why is dlrurl required for DLR? We have dlrurl stored in DLR

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alejandro Guerrieri
Alex, Commenting inline below. Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 09/06/2009, at 10:44, Alexander Malysh wrote: Hi, Seems you don't handle charset at all. Do you assume to receive UTF-8 in any case? I don't think it's applicable to generic interface. At least

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alexander Malysh
Am 09.06.2009 um 11:05 schrieb Alejandro Guerrieri: Alex, Commenting inline below. Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 09/06/2009, at 10:44, Alexander Malysh wrote: Hi, Seems you don't handle charset at all. Do you assume to receive UTF-8 in any case? I don't

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alejandro Guerrieri
Alex, Regarding the charsets, I agree it's better to tackle it now that leave it for later (aka, never ;) ). I'm fixing the charset issue and the dlr bugs and resending later. Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 09/06/2009, at 11:17, Alexander Malysh wrote: Am

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alexander Malysh
Am 09.06.2009 um 11:23 schrieb Alejandro Guerrieri: Alex, Regarding the charsets, I agree it's better to tackle it now that leave it for later (aka, never ;) ). I'm fixing the charset issue and the dlr bugs and resending later. thanks alex! Regards, -- Alejandro Guerrieri

Re: LMT extensions

2009-06-09 Thread Illimar Reinbusch
Hi, LMT uses SMPP meta-data optional parameters, its easy to implement it using meta-data build. LMT additionally uses two specific PDU's (LMT_REPORT and LMT_REPORT_RESP) what must be programmed directly into Kannel (those are actually LMT specific DLR PDU's and can be mapped to DLR requests

Re: LMT extensions

2009-06-09 Thread Alexander Malysh
Am 09.06.2009 um 11:32 schrieb Illimar Reinbusch: Hi, LMT uses SMPP meta-data optional parameters, its easy to implement it using meta-data build. LMT additionally uses two specific PDU's (LMT_REPORT and LMT_REPORT_RESP) what must be programmed directly into Kannel (those are actually LMT

Re: LMT extensions

2009-06-09 Thread V
Hello, Yes, we already run kannel with meta-data/tlv support (cvs branch). But, it's strange, why LMT use some PDU, that are non standart. On what conditions we could get that patch? regards, Martynas Hi, LMT uses SMPP meta-data optional parameters, its easy to implement it using meta-data

Re: ota_compiler.c patch

2009-06-09 Thread Julien Buratto
Hi, I've applied the patch on my cvs env, tested sendota and had same behaviour as i had with 1.4.1, so it's basically a works for me. Thank you Nikos last word to Stipe Julien 2009/6/9 Alexander Malysh amal...@kannel.org: Hi, if I look through the code, Niko is right. Stipe could you

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alejandro Guerrieri
Ok, done! http://www.blogalex.com/wp-content/uploads/2009/06/kannel-http-mo-params1.patch I've fixed the dlr-url bug _only_ on the generic part. If no objections, I'm doing a second patch to fix it on the kannel smsc (since it's in fact a separate issue). I've also fixed a small glitch on

Re: ota_compiler.c patch

2009-06-09 Thread Nikos Balkanas
Thanx, What about setting text to an external xml file, as is in manual. Any interest in that? BR, Nikos - Original Message - From: Julien Buratto julien.bura...@gmail.com To: Alexander Malysh amal...@kannel.org Cc: kannel_dev_mailinglist Devel devel@kannel.org Sent: Tuesday, June

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alexander Malysh
only one last thing: +msg-sms.account = octstr_duplicate(account); +msg-sms.binfo = octstr_duplicate(binfo); +if (ret == -1) { +retmsg = octstr_create(Not accepted); +retstatus = fm-status_error; +} else { +retmsg =

Re: ota_compiler.c patch

2009-06-09 Thread Alexander Malysh
Hi again, patch commited to cvs. Thanks, Alex P.S. @Niko: could you point me to related bug reports in redmine? Am 09.06.2009 um 14:33 schrieb Nikos Balkanas: Thanx, What about setting text to an external xml file, as is in manual. Any interest in that? BR, Nikos - Original Message

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alejandro Guerrieri
Yes, I have to move that afterwards, otherwise the urltrans_fill_escape_codes call would panic: 2009-06-09 12:46:13 [15580] [6] PANIC: gwlib/octstr.c:2488: seems_valid_real: Assertion `ostr-len = 0' failed. (Called from gwlib/octstr.c:1552:octstr_split_words.) ... 2009-06-09 12:46:13

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alejandro Guerrieri
Oh, yes, sorry :D I'd rather duplicate the msg... -- Alejandro Guerrieri aguerri...@kannel.org On 09/06/2009, at 15:38, Alejandro Guerrieri wrote: Yes, I have to move that afterwards, otherwise the urltrans_fill_escape_codes call would panic: 2009-06-09 12:46:13 [15580] [6] PANIC:

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alejandro Guerrieri
ups fixed :D http://www.blogalex.com/wp-content/uploads/2009/06/kannel-http-mo-params2.patch Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 09/06/2009, at 15:40, Alejandro Guerrieri wrote: Oh, yes, sorry :D I'd rather duplicate the msg... -- Alejandro Guerrieri

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alexander Malysh
now it's perfect ;) would you like to commit or should I commit it? Thanks, Alex Am 09.06.2009 um 16:06 schrieb Alejandro Guerrieri: ups fixed :D http://www.blogalex.com/wp-content/uploads/2009/06/kannel-http-mo-params2.patch Regards, -- Alejandro Guerrieri aguerri...@kannel.org On

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alejandro Guerrieri
I'll do it, no problem. Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 09/06/2009, at 16:30, Alexander Malysh wrote: now it's perfect ;) would you like to commit or should I commit it? Thanks, Alex Am 09.06.2009 um 16:06 schrieb Alejandro Guerrieri: ups fixed :D

RE: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Franck LAMASUTA
Hi Alejandro , I work with Hervé who posted to this list the 25th of May (Claro http communication). It seems the patch you've done on the generic part could be very useful for us to manage our communications with Claro. It could be better than a specific implementation for Claro. However, I

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alejandro Guerrieri
Franck, The dlr part is inherited from the kannel smsc format. In the actual implementation there's no way to grab the remote message id from a request, and it'd make a lot of sense to be able to do it. I can try adding it, but don't refrain to do it so yourself if you feel the urge

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alexander Malysh
Am 09.06.2009 um 17:55 schrieb Alejandro Guerrieri: Franck, The dlr part is inherited from the kannel smsc format. In the actual implementation there's no way to grab the remote message id from a request, and it'd make a lot of sense to be able to do it. I can try adding it, but don't

Re: [PATCH] custom MO Parameters for smsc-http

2009-06-09 Thread Alejandro Guerrieri
Commited to CVS. Regards, -- Alejandro Guerrieri aguerri...@kannel.org On 09/06/2009, at 16:30, Alexander Malysh wrote: now it's perfect ;) would you like to commit or should I commit it? Thanks, Alex Am 09.06.2009 um 16:06 schrieb Alejandro Guerrieri: ups fixed :D

Re: Kannel not load balancing after restart and messages get stuck inqueue

2009-06-09 Thread Nikos Balkanas
Dear Alvaro, I just managed to finish with my responsibilities, not on April 10, as I was hoping. Meanwhile, I haven't heard from you in a while, and I hope you are enjoying your vacations. Here is a patch to gw/bearerbox.c and gw/bb_smscconn.c, that doesn't start the sms_router, until all

[PATCH] utils/mtabatch.c

2009-06-09 Thread Nikos Balkanas
Hi, This is a simple patch to mtbatch, that if left as is should core dump. BR, Nikos mtbatch.diff Description: Binary data

[PATCH] [SQLBOX] Allow building with sqlite3 3.5

2009-06-09 Thread Damián Viano
Hi, first message to the list, first patch :) It's a simple one, it turns out sqlite3 has sqlite3_prepare_v2 in versions = 3.5 (if google didn't lie to me) so, this patch only use it if available. It's against the lastest stable. Hope to help. Damián Viano(Des). ---

[PATCH] [SQLBOX] Implement batch processing

2009-06-09 Thread Damián Viano
Hi: Another one for sqlbox. This is based on http://www.magicom-bcn.net/kannel/sqlbox-standalone-multi-20080227.patch by Alejandro Guerrieri, but avoiding the situation where if we die in the middle of a batch we lose messages. In this implementation worst case scenario we repeat a message. I've

[PATCH] Guaranteed throughput smsc-independent

2009-06-09 Thread Damián Viano
Hi list: I've seen kannel not respect throughput at all, at least with the fakesmsc and looking around find the following bug: http://redmine.kannel.org/issues/show/332 With the following patch attached: http://redmine.kannel.org/attachments/104/332-emi_patch_ack_v3.txt Inspired

Re: [PATCH] Guaranteed throughput smsc-independent

2009-06-09 Thread Donald Jackson
I will review in more detail when I get a moment, my concern here is that you are now sleeping at the bearerbox layer which could effect delivery to other SMSC's. The current throughput limits although the logic is per-smsc, they sleep within their own threads as to not delay any others. Have

Re: [PATCH] Guaranteed throughput smsc-independent

2009-06-09 Thread Donald Jackson
Ignore my last mail! I see these will be called per thread :) 2009/6/9 Donald Jackson donaldjs...@gmail.com I will review in more detail when I get a moment, my concern here is that you are now sleeping at the bearerbox layer which could effect delivery to other SMSC's. The current

Re: Kannel not load balancing after restart and messages get stuck inqueue

2009-06-09 Thread Alan McNatty
Hi Nikos, Sorry I haven't reviewed this whole thread in detail but was caught by .. bearerbox will not start unless all smscs are available. .. this worried me a bit. I'm concerned that in a DR scenario if 1 connection is down (and not coming up just yet) then I would like to be able to

Re: Kannel not load balancing after restart and messages get stuck inqueue

2009-06-09 Thread Nikos Balkanas
Hi Alan, If even 1 SMSc in configuration file fails to start, bearerbox will panic. There are several states to any SMSc, like connecting, going down, etc. Bearerbox expects all SMScs to be available on startup. The operative word is available. If a configured modem is not connected, that's a

Re: Kannel not load balancing after restart and messages get stuck inqueue

2009-06-09 Thread Alan McNatty
Hi Nikos, OK, yeah I'm not about failure at start-up time. If an SMSC is off-line (SMPP timeout/retry during bind) kannel will start (simply config a bogus IP address for SMPP to test this out). An example is lets say we have 2 connections for load balancing. Now consider 1 smsc being taken

Re: Kannel not load balancing after restart and messages get stuck inqueue

2009-06-09 Thread Alvaro Cornejo
Hi Nikos I'm still around here... I've been busy this lasts days... I wish I was on vacations ;-) Regarding this patch, -I didn't had time to test it- but seems to solve the issue making kannel hold the queue assignment until all smsc's are online. However I do agree with Alan in the fact that