On 20/09/12 15:13, gschr...@beyondelectronics.us wrote:
We are currently attempting to write a validation suite for the
vme_ca91cx42 driver (Tundra Universe currently in staging) and are looking
for starting points. I have found a significant amount of code and
documentation, but am unsure
On Sat, Sep 22, 2012 at 02:18:44PM -0700, Dan Magenheimer wrote:
From: Mel Gorman [mailto:mgor...@suse.de]
Subject: Re: [RFC] mm: add support for zsmalloc and zcache
On Fri, Sep 21, 2012 at 01:35:15PM -0700, Dan Magenheimer wrote:
From: Seth Jennings
On Mon, Sep 24, 2012 at 04:44:43PM +0600, Gorskin Ilya wrote:
This is a patch to the Bcmchar.c file that fixes up a coding style
warning found by the checkpatch.pl tool
The right way to fix this is to choose better variable names and to
get rid of the bogus BCM_DEBUG_PRINT() macro. It's
On Sun, Sep 23, 2012 at 11:07:12PM -0400, Kevin McKinney wrote:
- pstAddIndication = kmalloc(sizeof(*pstAddIndication), GFP_KERNEL);
+ pstAddIndication = kmalloc(sizeof(struct bcm_add_indication),
GFP_KERNEL);
Don't resend, but the style was still better in the original.
regards,
dan
On Sun, Sep 23, 2012 at 11:07:17PM -0400, Kevin McKinney wrote:
This patch removes typedef for
_stCPacketClassificationRuleSI, changes the
name of the struct to bcm_packet_class_rules,
and updates the comments appropriately . In
addition, any calls to typedefs
CCPacketClassificationRuleSI,
On Mon, 24 Sep 2012 11:00:17 +0100, Martyn Welch martyn.we...@ge.com
wrote:
On 20/09/12 15:13, gschr...@beyondelectronics.us wrote:
snip
Hi George,
There is an in-kernel API. This is documented in the vme_api.txt file
found in
Documentation/ (or drivers/staging/vme for older kernels,
Some patches from the v1 sequence of 9 patches that were nothing to do
with mixing __user and kernel pointers have already been applied by
Greg, leaving 4 patches unapplied. For v2, I've combined 2 of those 4
patches, reordered them, slightly modified one of them and changed the
commit messages.
This reverts staging: comedi: comedi.h: remove __user tag from
chanlist by H Hartley Sweeten on 2012-09-18 (committed by Greg
Kroah-Hartman on Wed Sep 19 09:36:44 2012 +0100), and also removes a
couple of `__user` casts that are now unnecessary and a couple of
`__force` casts that are now wrong.
On Mon, Sep 24, 2012 at 01:34:11PM +0100, Ian Abbott wrote:
Some patches from the v1 sequence of 9 patches that were nothing to do
with mixing __user and kernel pointers have already been applied by
Greg, leaving 4 patches unapplied. For v2, I've combined 2 of those 4
patches, reordered them,
On Mon, Sep 24, 2012 at 6:57 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Sun, Sep 23, 2012 at 11:07:12PM -0400, Kevin McKinney wrote:
- pstAddIndication = kmalloc(sizeof(*pstAddIndication), GFP_KERNEL);
+ pstAddIndication = kmalloc(sizeof(struct bcm_add_indication),
On Mon, Sep 24, 2012 at 09:46:05AM -0400, Kevin McKinney wrote:
On Mon, Sep 24, 2012 at 6:57 AM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Sun, Sep 23, 2012 at 11:07:12PM -0400, Kevin McKinney wrote:
- pstAddIndication = kmalloc(sizeof(*pstAddIndication), GFP_KERNEL);
+
Tag pointers to remapped I/O memory with `__iomem` and remove the
`volatile` qualifiers. Fix the single place in `jr3_pci_attach()` where
an I/O memory pointer is being dereferenced directly to use the
appropriate I/O memory access function.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
This module does not export any symbols so declare all the functions as
`static`. Some of them are currently unused but might get used in the
future, so tag them as `__maybe_unused` for now to get rid of compiler
warnings.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
`ni_ai_poll()` currently acquires (and later releases) the comedi
device's spin-lock iff `in_interrupt()` returns 0. However, it is only
called during processing of a `COMEDI_POLL` ioctl so `in_interrupt()`
will always return 0 in this case. Remove this test and acquire/release
the spin-lock
On Mon, Sep 24, 2012 at 10:16 AM, Dan Carpenter
dan.carpen...@oracle.com wrote:
On Mon, Sep 24, 2012 at 09:46:05AM -0400, Kevin McKinney wrote:
On Mon, Sep 24, 2012 at 6:57 AM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Sun, Sep 23, 2012 at 11:07:12PM -0400, Kevin McKinney wrote:
-
From: Justin P. Mattock justinmatt...@gmail.com
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
The below patch fixes typos found while reading through staging wlan-ng
drivers/staging/wlan-ng/cfg80211.c |4 ++--
drivers/staging/wlan-ng/p80211netdev.c |2 +-
`s626_enc_insn_config()` is the `insn_config()` handler for a counter
subdevice. The `data[0]` value is supposed to be one of the
`INSN_CONFIG_...` constants defined in comedi.h indicating the type of
configuration instruction, but this function seems to be using it as a
variable value to preload
`s626_enc_insn_config()` is incorrectly dereferencing `insn-data` which
is a pointer to user memory. It should be dereferencing the separate
`data` parameter that points to a copy of the data in kernel memory.
Cc: sta...@vger.kernel.org
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
On 2012-09-24 17:38, H Hartley Sweeten wrote:
On Monday, September 24, 2012 7:20 AM, Ian Abbott wrote:
Tag pointers to remapped I/O memory with `__iomem` and remove the
`volatile` qualifiers. Fix the single place in `jr3_pci_attach()` where
an I/O memory pointer is being dereferenced directly
On 09/21/2012 03:35 PM, Dan Magenheimer wrote:
From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com]
Subject: Re: [RFC] mm: add support for zsmalloc and zcache
On 09/21/2012 01:02 PM, Konrad Rzeszutek Wilk wrote:
On Fri, Sep 21, 2012 at 05:12:52PM +0100, Mel Gorman wrote:
On Tue, Sep 04,
Hi Bill,
I have a concern about the following code:
drivers/staging/dgrp/dgrp_net_ops.c:3159 dgrp_receive()
3128 plen = get_unaligned_be16(b + 2);
3129
3130 if (plen 4 || plen 1000) {
From: sli sli@SLI-V420.(none)
Signed-off-by: sli sli@SLI-V420.(none)
---
drivers/staging/tidspbridge/core/dsp-clock.c |3 ++
drivers/staging/tidspbridge/core/tiomap3430.c |4 ++
drivers/staging/tidspbridge/core/wdt.c |2 +-
I have a concern about the following code:
drivers/staging/dgrp/dgrp_net_ops.c:3159 dgrp_receive()
3128 plen = get_unaligned_be16(b + 2);
3129
3130 if (plen 4 || plen 1000) {
From: James Bottomley [mailto:james.bottom...@hansenpartnership.com]
Subject: Re: [RFC] mm: add support for zsmalloc and zcache
On Sat, 2012-09-22 at 02:07 +0100, Mel Gorman wrote:
The two proposals:
A) Recreate all the work done for zcache2 as a proper sequence of
independent
Start cleaning up this driver by reworking the board attach to use
the comedi PCI auto config mechanism and cleanup all the attach code.
H Hartley Sweeten (20):
staging: comedi: s626: remove boardinfo
staging: comedi: s626: use attach_pci callback
staging: comedi: s626: store the pci_dev in
This driver only supports one board type. Move the used board info
out of the boardinfo struct and remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/s626.c
Convert this PCI driver to use the comedi PCI auto config attach
mechanism by adding an 'attach_pci' callback function. Since the
driver does not require any external configuration options, and
the legacy 'attach' callback is not optional, remove it.
Signed-off-by: H Hartley Sweeten
Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Instead of the literal string s626, use the dev-board_name for
the resource name when enabling the PCI device and requesting the
irq.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The 'result' variable is only used to check the return from
comedi_pci_enable(). Just reuse the 'ret' variable.
Also, remove the kernel noise and use the error code from
comedi_pci_enable() instead of returning -ENODEV.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
This variable is only used as a flag to indicate that the pci device
has been enabled and needs to be disabled in the detach. Use the
comedi_device 'iobase' for this and remove the private data variable.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
The local variable 'resourceStart' is only used in the ioremap()
to hold the PCI bar 0 base address. Just use the pci_resource_start()
directly in the ioremap().
Also, instead of assuming the resource size for the ioremap, use
pci_resource_len() to get the actual size.
Remove the kernel noise
To make the attach a bit cleaner, factor the dma buffer allocation
out of attach_pci() into a new function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/s626.c |
'devpriv-base_addr' is valid from this point on in the attach_pci()
function. Remove the unnecessary checks.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/s626.c
Only set dev-irq if request_irq is successfull.
Remove the kernel message noise.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/s626.c | 23
To make the attach a bit cleaner, factor the board init code
out of attach_pci() into a new function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/s626.c | 246
The private data is kzalloc'ed. All the variables in it are
initially '0'.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/s626.c | 3 ---
1 file changed, 3
From: Mel Gorman [mailto:mgor...@suse.de]
Subject: Re: [RFC] mm: add support for zsmalloc and zcache
On Sat, Sep 22, 2012 at 02:18:44PM -0700, Dan Magenheimer wrote:
From: Mel Gorman [mailto:mgor...@suse.de]
Subject: Re: [RFC] mm: add support for zsmalloc and zcache
On Fri, Sep
Add a simple dev_info() message after a successfull attach.
Change the final return to '0' to indicate success.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This variable is only used to count the number of dma buffers
allocated during the attach. If an allocation fails, the attach
function exits with -ENOMEM. When this variable is checked later
it will always be == 2. Just remove the variable and the check.
This allows bringing the code back an
Until it's determined if this workaround can be removed, block
out the code with an #if 0/#endif and remove the individual
comments on each line.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
IsBoardRevA is not defined in the driver. Remove the comment
about it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/s626.c | 25 ++---
1 file
This variable is never used in the driver. Just remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/s626.c | 7 ---
1 file changed, 7 deletions(-)
diff
The private data is kzalloc'ed. There is no need to set any
of the initial data to '0'.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/s626.c | 6 --
1 file
Cleanup the comments to follow the coding style of the kernel.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/s626.c | 169 ++
1
On Saturday, September 22, 2012 6:11 AM, Dan Carpenter wrote:
On Wed, Sep 19, 2012 at 03:12:54PM -0700, H Hartley Sweeten wrote:
+case INSN_CONFIG_GPCT_PULSE_TRAIN_GENERATOR:
/* data[0] contains the PULSE_WIDTH
data[1] contains the PULSE_PERIOD
In dgrp_receive() there is:
desclen = ((plen - 12) MAX_DESC_LEN) ? MAX_DESC_LEN :
plen - 12;
strncpy(nd-nd_ps_desc, b + 12, desclen);
However, it's possible for plen to be = 12 here so we'd be passing a
negative number into the strncpy(). Fix this to not make
On Monday, September 24, 2012 7:48 AM, Ian Abbott wrote:
This module does not export any symbols so declare all the functions as
`static`. Some of them are currently unused but might get used in the
future, so tag them as `__maybe_unused` for now to get rid of compiler
warnings.
This if() check was flipped from a test for valid data params
to a test for invalid params.
As pointed out by Dan Carpenter, the orignal test was:
if ((data[1] data[0]) (data[0] 0)) {
the flipped test should be:
if (data[1] = data[0]) ...
Add the missing '='.
On Monday, September 24, 2012 8:28 AM, Ian Abbott wrote:
`ni_ai_poll()` currently acquires (and later releases) the comedi
device's spin-lock iff `in_interrupt()` returns 0. However, it is only
called during processing of a `COMEDI_POLL` ioctl so `in_interrupt()`
will always return 0 in this
On Monday, September 24, 2012 9:21 AM, Ian Abbott wrote:
`s626_enc_insn_config()` is incorrectly dereferencing `insn-data` which
is a pointer to user memory. It should be dereferencing the separate
`data` parameter that points to a copy of the data in kernel memory.
Cc:
On Monday, September 24, 2012 9:47 AM, Ian Abbott wrote:
On 2012-09-24 17:38, H Hartley Sweeten wrote:
On Monday, September 24, 2012 7:20 AM, Ian Abbott wrote:
Tag pointers to remapped I/O memory with `__iomem` and remove the
`volatile` qualifiers. Fix the single place in
Hi,
On Mon, Sep 24, 2012 at 1:54 PM, selso selso.liber...@gmail.com wrote:
From: sli sli@SLI-V420.(none)
Signed-off-by: sli sli@SLI-V420.(none)
---
drivers/staging/tidspbridge/core/dsp-clock.c |3 ++
drivers/staging/tidspbridge/core/tiomap3430.c |4 ++
This is a patch to the InterfaceIdleMode.c, InterfaceDld.c files that
fixes up a coding style errors found by the checkpatch.pl tool
Signed-off-by: Ilya Gorskin reven...@gmail.com
---
drivers/staging/bcm/InterfaceDld.c | 16 +--
drivers/staging/bcm/InterfaceIdleMode.c | 219
This is a patch to the InterfaceIsr.c file that
fixes up a coding style issues found by the checkpatch.pl tool
Signed-off-by: Ilya Gorskin reven...@gmail.com
---
drivers/staging/bcm/InterfaceIsr.c | 178 +
1 file changed, 102 insertions(+), 76 deletions(-)
This is a patch to the InterfaceIsr.c file that
fixes up a coding style issues found by the checkpatch.pl tool
Signed-off-by: Ilya Gorskin reven...@gmail.com
---
drivers/staging/bcm/InterfaceIsr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
56 matches
Mail list logo
