Re: [RFC] driver-core: Add device node pointer to struct device

2010-02-24 Thread Greg KH
On Wed, Feb 24, 2010 at 03:09:24PM -0700, Grant Likely wrote: On Wed, Feb 24, 2010 at 2:44 PM, Greg KH gre...@suse.de wrote: On Wed, Feb 24, 2010 at 02:10:30PM -0700, Grant Likely wrote: Greg and Kay, This is a patch from a larger series of OF related cleanup patches.  This one adds

Re: [PATCH 12/37] drivers/usb: use .dev.of_node instead of .node in struct of_device

2010-03-11 Thread Greg KH
On Thu, Mar 11, 2010 at 11:04:54AM -0700, Grant Likely wrote: .node is being removed Signed-off-by: Grant Likely grant.lik...@secretlab.ca Acked-by: Greg Kroah-Hartman gre...@suse.de ___ devicetree-discuss mailing list

Re: [PATCH] of/usb: fix build error due to of_node pointer move

2010-06-02 Thread Greg KH
On Wed, Jun 02, 2010 at 01:47:16PM -0600, Grant Likely wrote: Fix driver to use new location of of_node pointer (introduced by commit use new location of of_node pointer (introduced by commit 61c7a080a5a061c976988fd4b844dfb468dda255; of: Always use 'struct device.of_node' to get device node

[039/111] irq: Add new IRQ flag IRQF_NO_SUSPEND

2010-08-11 Thread Greg KH
2.6.32-stable review patch. If anyone has any objections, please let us know. -- From: Ian Campbell ian.campb...@citrix.com commit 685fd0b4ea3f0f1d5385610b0d5b57775a8d5842 upstream. A small number of users of IRQF_TIMER are using it for the implied no suspend behaviour on

[48/54] irq: Add new IRQ flag IRQF_NO_SUSPEND

2010-08-11 Thread Greg KH
2.6.34-stable review patch. If anyone has any objections, please let us know. -- From: Ian Campbell ian.campb...@citrix.com commit 685fd0b4ea3f0f1d5385610b0d5b57775a8d5842 upstream. A small number of users of IRQF_TIMER are using it for the implied no suspend behaviour on

[64/67] irq: Add new IRQ flag IRQF_NO_SUSPEND

2010-08-11 Thread Greg KH
2.6.35-stable review patch. If anyone has any objections, please let us know. -- From: Ian Campbell ian.campb...@citrix.com commit 685fd0b4ea3f0f1d5385610b0d5b57775a8d5842 upstream. A small number of users of IRQF_TIMER are using it for the implied no suspend behaviour on

Re: of_match_table on non-DT builds

2010-11-09 Thread Greg KH
On Tue, Nov 09, 2010 at 09:01:17AM -0700, Grant Likely wrote: On Tue, Nov 9, 2010 at 8:27 AM, Rob Herring robherri...@gmail.com wrote: Grant, With the of_match_table pointer only enabled with CONFIG_OF in struct device_driver, all drivers will have to have #ifdefs around their

Re: [PATCH] driver-core: remove conditionals around devicetree pointers

2011-01-25 Thread Greg KH
On Tue, Jan 25, 2011 at 07:02:02PM -0700, Grant Likely wrote: Having conditional around the of_match_table and the of_node pointers turns out to make driver code use ugly #ifdef blocks. Drop the conditionals and remove the #ifdef blocks from the affected drivers. Also tidy up minor

Re: [PATCH] of: Add missing of_address.h to xilinx ehci driver

2011-02-14 Thread Greg KH
On Mon, Feb 14, 2011 at 06:54:08AM -0700, Grant Likely wrote: On Mon, Feb 14, 2011 at 3:40 AM, Michal Simek mon...@monstr.eu wrote: Build log: In file included from drivers/usb/host/ehci-hcd.c:1208: drivers/usb/host/ehci-xilinx-of.c: In function 'ehci_hcd_xilinx_of_probe':

Re: [PATCH] dt: add a match table pointer to struct device

2011-02-25 Thread Greg KH
On Fri, Feb 25, 2011 at 08:46:52AM -0700, Grant Likely wrote: Greg, any thoughts on this change? I'd like to take it via my tree so I can finally dump the last vestiges of of_platform_bus_type. Sorry, I didn't realize you just wanted my review, and not me to take it directly. If you want to

Re: [PATCH 3/4 v3] tty: serial: altera_uart: Add devicetree support

2011-02-25 Thread Greg KH
On Fri, Feb 18, 2011 at 11:35:32AM +0100, Tobias Klauser wrote: With the recent switch of the (currently still out-of-tree) Nios2 Linux port to devicetree we want to be able to retreive the resources and properties from dts. The old method to retreive resources and properties from platform

Re: [PATCH v4] hwmon: Add support for Texas Instruments ADS1015

2011-03-03 Thread Greg KH
On Thu, Mar 03, 2011 at 10:50:50AM -0700, Grant Likely wrote: + i2c_set_clientdata(client, data); + mutex_init(data-update_lock); + + /* build sysfs attribute group */ + data-attr_group.attrs = data-attr_table; + exported_channels = ads1015_get_exported_channels(client); +

Re: RFC: Platform data for onboard USB assets

2011-03-17 Thread Greg KH
On Thu, Mar 17, 2011 at 11:33:01PM +0100, Arnd Bergmann wrote: On Thursday 17 March 2011 22:47:36 Greg KH wrote: Patches to fix this, for this specific PandaBoard controller are gladly accepted. What's odd is this is explicitly a Linux development board, so you would think

Re: RFC: Platform data for onboard USB assets

2011-03-17 Thread Greg KH
On Thu, Mar 17, 2011 at 11:18:41PM +, Andy Green wrote: On 03/17/2011 10:53 PM, Somebody in the thread at some point said: Not tested! Signed-off-by: Arnd Bergmannarnd.bergm...@linaro.org snip Very nice. Andy and Mark, would this patch work for you? You do realize this

Re: [PATCH 2/2] drivercore: revert addition of of_match to struct device

2011-05-18 Thread Greg KH
On Wed, May 18, 2011 at 01:21:05PM -0600, Grant Likely wrote: Commit b826291c, drivercore/dt: add a match table pointer to struct device added an of_match pointer to struct device to cache the of_match_table entry discovered at driver match time. This was unsafe because matching is not an

Re: [PATCH v5] uio/pdrv_genirq: Add OF support

2011-05-24 Thread Greg KH
On Tue, May 24, 2011 at 01:27:11PM +0200, Michal Simek wrote: Hi Greg, can you please add it to your tree? I see you have sent pull request. It's too late for the merge window for this, sorry. I needed to have this before it opened up, and in the linux-next tree for a week or so before that.

Re: [PATCH v5] uio/pdrv_genirq: Add OF support

2011-05-24 Thread Greg KH
On Tue, May 24, 2011 at 05:02:16PM +0200, Hans J. Koch wrote: On Tue, May 24, 2011 at 05:36:25AM -0700, Greg KH wrote: On Tue, May 24, 2011 at 01:27:11PM +0200, Michal Simek wrote: Hi Greg, can you please add it to your tree? I see you have sent pull request. It's too late

Re: [PATCH v5] uio/pdrv_genirq: Add OF support

2011-05-24 Thread Greg KH
On Wed, May 25, 2011 at 12:04:08AM +0200, Hans J. Koch wrote: On Tue, May 24, 2011 at 08:14:13AM -0700, Greg KH wrote: On Tue, May 24, 2011 at 05:02:16PM +0200, Hans J. Koch wrote: On Tue, May 24, 2011 at 05:36:25AM -0700, Greg KH wrote: On Tue, May 24, 2011 at 01:27:11PM +0200, Michal

Re: [PATCH] tty/serial: tegra: Use engineering names in DT compatible property

2011-07-08 Thread Greg KH
On Tue, Jul 05, 2011 at 02:07:41PM -0600, Stephen Warren wrote: Engineering names are more stable than marketing names. Hence, use them for Device Tree compatible properties instead. Signed-off-by: Stephen Warren swar...@nvidia.com --- Greg, This builds on patches Grant has (or has said he

Re: [PATCH] tty: add a DesignWare 8250 driver

2011-08-26 Thread Greg KH
On Fri, Aug 26, 2011 at 05:20:21PM +0100, Jamie Iles wrote: On Fri, Aug 26, 2011 at 06:04:02PM +0200, Arnd Bergmann wrote: On Friday 26 August 2011, Jamie Iles wrote: The Synopsys DesignWare 8250 is an 8250 that has an extra interrupt that gets raised when writing to the LCR when busy.

Re: [PATCH v2 0/9] serial: samsung: rework clock lookup and add device tree support

2011-10-24 Thread Greg KH
100644 drivers/tty/serial/s3c2410.c delete mode 100644 drivers/tty/serial/s3c2412.c delete mode 100644 drivers/tty/serial/s3c2440.c delete mode 100644 drivers/tty/serial/s3c6400.c delete mode 100644 drivers/tty/serial/s5pv210.c (Cc'ed Greg KH) Looks good for me, and I need to get

Re: [PATCH] tty/serial: atmel_serial: fix compilation

2011-10-28 Thread Greg KH
On Fri, Oct 28, 2011 at 02:38:09PM +0200, Nicolas Ferre wrote: On 10/28/2011 01:33 PM, Sven Schnelle : If CONFIG_OF is disabled, compilation fails with: drivers/tty/serial/atmel_serial.c: In function 'atmel_serial_probe': drivers/tty/serial/atmel_serial.c:1788: error: implicit

Re: [PATCH 8/8] staging: octeon_ethernet: Convert to use device tree.

2011-11-27 Thread Greg KH
On Thu, Nov 10, 2011 at 06:22:04PM -0800, ddaney.c...@gmail.com wrote: From: David Daney david.da...@cavium.com Get MAC address and PHY connection from the device tree. Cc: David S. Miller da...@davemloft.net Cc: net...@vger.kernel.org Cc: Greg Kroah-Hartman gre...@suse.de Acked-by: Greg

Re: [PATCH v2 0/4] OMAP serial device tree support

2011-11-27 Thread Greg KH
On Tue, Nov 22, 2011 at 07:14:12PM +0530, Rajendra Nayak wrote: v2 is based on the latest omap-serial runtime patches, which can be found here[1] The series passes minimal data that allows serial console boot, with UART's initialised from device tree. However some of low power support for

Re: [PATCH v2 0/4] OMAP serial device tree support

2011-11-27 Thread Greg KH
On Mon, Nov 28, 2011 at 11:36:56AM +0530, Rajendra Nayak wrote: On Sunday 27 November 2011 09:06 AM, Greg KH wrote: On Tue, Nov 22, 2011 at 07:14:12PM +0530, Rajendra Nayak wrote: v2 is based on the latest omap-serial runtime patches, which can be found here[1] The series passes minimal

Re: [PATCH v3 0/4] OMAP serial device tree support

2011-12-14 Thread Greg KH
On Wed, Dec 14, 2011 at 05:18:43PM +, Alan Cox wrote: On Wed, 14 Dec 2011 07:20:13 -0800 Kevin Hilman khil...@ti.com wrote: Greg, Alan, Rajendra Nayak rna...@ti.com writes: v3 is rebased on top of the latest serial runtime patches[1] and boot tested with/without DT on OMAP4

Re: [PATCH v3] serial/efm32: add new driver

2012-01-24 Thread Greg KH
On Mon, Jan 09, 2012 at 05:44:07PM +0100, Uwe Kleine-König wrote: Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- Hello, changes since v2: - use {read,write}l_relaxed - rename driver to efm32-uart as USARTs and UARTs can be handled both with it - disable TX in

Re: [PATCH v4] serial/efm32: add new driver

2012-01-25 Thread Greg KH
on v3.3-rc1 Hello Greg, On Tue, Jan 24, 2012 at 02:05:22PM -0800, Greg KH wrote: On Mon, Jan 09, 2012 at 05:44:07PM +0100, Uwe Kleine-König wrote: Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- Hello, changes since v2: - use {read,write}l_relaxed

Re: [PATCH 1/4] ARM: at91: usb ohci add dt support

2012-02-14 Thread Greg KH
On Tue, Feb 14, 2012 at 04:58:26PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Nicolas Ferre nicolas.fe...@atmel.com Cc: devicetree-discuss@lists.ozlabs.org Cc: linux-...@vger.kernel.org --- Hi Greg, I you

Re: [PATCH 5/9] USB: at91: Device udc add dt support

2012-03-08 Thread Greg KH
On Wed, Mar 07, 2012 at 10:15:42AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: Allow to compile it if AT91 is enable. Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Nicolas Ferre nicolas.fe...@atmel.com Cc: linux-...@vger.kernel.org --- Hi Greg if

Re: [PATCH] USB: Add DT probing support to ehci-spear and ohci-spear

2012-04-13 Thread Greg KH
On Fri, Apr 13, 2012 at 09:29:10AM +0530, Viresh Kumar wrote: On 3/22/2012 9:20 PM, Stefan Roese wrote: This patch adds support to configure the SPEAr EHCI OHCI driver via device-tree instead of platform_data. Signed-off-by: Stefan Roese s...@denx.de Cc: Viresh Kumar

Re: [PATCH V2 2/4] staging: iio: light: of: Fix vendor prefix of isl29018/isl29028

2012-04-23 Thread Greg KH
On Mon, Apr 23, 2012 at 11:17:19AM -0600, Stephen Warren wrote: On 04/23/2012 06:11 AM, Laxman Dewangan wrote: ISL29018/ISL29028 is from Intersil Corporation and making the vendor prefix for this part as isil for OF compatibity. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com I

Re: [PATCH V2 2/4] staging: iio: light: of: Fix vendor prefix of isl29018/isl29028

2012-04-23 Thread Greg KH
On Mon, Apr 23, 2012 at 11:43:55AM -0600, Stephen Warren wrote: On 04/23/2012 11:28 AM, Greg KH wrote: On Mon, Apr 23, 2012 at 11:17:19AM -0600, Stephen Warren wrote: On 04/23/2012 06:11 AM, Laxman Dewangan wrote: ISL29018/ISL29028 is from Intersil Corporation and making the vendor prefix

Re: [PATCH v8 0/5] USB: LPC32xx device tree related OHCI and UDC patch series

2012-05-01 Thread Greg KH
On Sun, Apr 29, 2012 at 04:47:01PM +0200, Roland Stigge wrote: This series collects the pending LPC32xx patches in one series and forward ports it onto git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next There are no other changes since last post. All applied, thanks for

Re: [PATCH v2 01/12] usb: otg: add notify_connect_change callback

2012-05-21 Thread Greg KH
On Mon, May 21, 2012 at 12:38:41PM +0300, Felipe Balbi wrote: On Mon, May 21, 2012 at 05:36:16PM +0800, Richard Zhao wrote: On Mon, May 21, 2012 at 12:26:36PM +0300, Felipe Balbi wrote: On Mon, May 21, 2012 at 05:23:46PM +0800, Richard Zhao wrote: This let usb phy driver has a chance to

Re: [PATCH v2 01/12] usb: otg: add notify_connect_change callback

2012-05-21 Thread Greg KH
On Mon, May 21, 2012 at 05:23:46PM +0800, Richard Zhao wrote: This let usb phy driver has a chance to change hw settings when connect status change. Signed-off-by: Richard Zhao richard.z...@freescale.com --- include/linux/usb/otg.h | 13 + 1 files changed, 13 insertions(+),

Re: [PATCH v2 01/12] usb: otg: add notify_connect_change callback

2012-05-21 Thread Greg KH
On Mon, May 21, 2012 at 07:36:40PM +0200, Marek Vasut wrote: Dear Greg KH, On Mon, May 21, 2012 at 05:23:46PM +0800, Richard Zhao wrote: This let usb phy driver has a chance to change hw settings when connect status change. Signed-off-by: Richard Zhao richard.z...@freescale.com

Re: [PATCH v2 01/12] usb: otg: add notify_connect_change callback

2012-05-21 Thread Greg KH
On Mon, May 21, 2012 at 08:32:21PM +0200, Marek Vasut wrote: Dear Greg KH, On Mon, May 21, 2012 at 07:36:40PM +0200, Marek Vasut wrote: Dear Greg KH, On Mon, May 21, 2012 at 05:23:46PM +0800, Richard Zhao wrote: This let usb phy driver has a chance to change hw settings when

Re: [PATCH v4] usb: chipidea: permit driver bindings pass phy pointer

2012-06-12 Thread Greg KH
On Fri, Jun 08, 2012 at 08:37:06PM +0800, Richard Zhao wrote: Sometimes, the driver bindings may know what phy they use. For example, when using device tree, the usb controller may have a phandler pointing to usb phy. Signed-off-by: Richard Zhao richard.z...@freescale.com Reviewed-by: Marek

Re: [PATCH v4] usb: chipidea: permit driver bindings pass phy pointer

2012-06-14 Thread Greg KH
On Thu, Jun 14, 2012 at 10:52:57AM +0300, Alexander Shishkin wrote: Greg KH gre...@linuxfoundation.org writes: On Fri, Jun 08, 2012 at 08:37:06PM +0800, Richard Zhao wrote: Sometimes, the driver bindings may know what phy they use. For example, when using device tree, the usb controller

Re: [RFC PATCH v2 1/2] drivers: misc: omap: add a new driver for ocp2scp

2012-06-22 Thread Greg KH
On Fri, Jun 22, 2012 at 06:45:41PM +0530, Kishon Vijay Abraham I wrote: Adds a new driver _ocp2scp_. That's not what you called this driver in the patch below :( This driver takes the responsibility of creating all the devices that is connected to OCP2SCP. In the case of OMAP4, USB2PHY is

Re: [PATCH v7 01/14] usb: chipidea: remove unneeded NULL check

2012-06-26 Thread Greg KH
On Mon, Jun 25, 2012 at 02:56:18PM +0800, Richard Zhao wrote: From: Alexander Shishkin alexander.shish...@linux.intel.com As reported by Dan Carpenter, there is a NULL check in udc_start() that follows a dereference of the pointer that's being checked. However, at that point udc pointer

Re: [PATCH v9 00/14] add imx usb driver based on Greg next tree

2012-07-04 Thread Greg KH
On Wed, Jul 04, 2012 at 05:20:51PM +0800, Richard Zhao wrote: On Fri, Jun 29, 2012 at 06:52:54PM +0800, Richard Zhao wrote: It is v9. Sorry for mistake. Hi Greg, It looks like no more comments. Could you pick it up? Ok, I will look at these next week when I return from vacation. greg k-h

Re: [PATCH V3 5/6] Avoid duplicate probe for of platform devices

2012-07-05 Thread Greg KH
On Fri, Jul 06, 2012 at 02:05:05AM +, Jia Hongtao-B38951 wrote: Hi Rob and Greg KH, Do you have any better idea to avoid duplication probe warning? I have no idea what the problem is that you are trying to solve. On 06/08/2012 04:43 AM, Jia Hongtao wrote: We changed the pcie

Re: [PATCH V3 5/6] Avoid duplicate probe for of platform devices

2012-07-06 Thread Greg KH
On Fri, Jul 06, 2012 at 06:07:43AM +, Jia Hongtao-B38951 wrote: -Original Message- From: Greg KH [mailto:g...@kroah.com] Sent: Friday, July 06, 2012 12:26 PM To: Jia Hongtao-B38951 Cc: Rob Herring; devicetree-discuss@lists.ozlabs.org; linux- ker...@vger.kernel.org; Li

Re: [PATCH v8 06/14] USB: Chipidea: rename struct ci13xxx variables from udc to ci

2012-07-06 Thread Greg KH
On Fri, Jun 29, 2012 at 05:48:54PM +0800, Richard Zhao wrote: struct ci13xxx represent the controller, which may be device or host, so name its variables as ci. Signed-off-by: Richard Zhao richard.z...@freescale.com Reviewed-by: Felipe Balbi ba...@ti.com Signed-off-by: Alexander Shishkin

Re: [PATCH V3 5/6] Avoid duplicate probe for of platform devices

2012-07-09 Thread Greg KH
On Mon, Jul 09, 2012 at 03:46:59AM +, Li Yang-R58472 wrote: I don't understand, why is this just showing up now? What changed to cause this? Couldn't that be the real problem here? The issue is showing up because we now probe devices twice. Previously, we just probe devices

Re: [PATCH 0/3 v3] USB: host: Add Device tree support for ohci-exynos ehci-s5p

2012-07-16 Thread Greg KH
On Mon, Jul 16, 2012 at 11:25:35AM +0530, Vivek Gautam wrote: Changes from v1: 1) Moved struct of_device_id exynos_ehci_match[] to the next of struct dev_pm_ops s5p_ehci_pm_ops in ehci-s5p.c. 2) Rebased on 'usb-next' branch. I've applied the first 2 patches here, please rework the third one.

Re: patch misc/at25, dt: Improve at25 SPI eeprom device tree bindings. added to char-misc tree

2012-09-05 Thread Greg KH
On Wed, Sep 05, 2012 at 02:33:58PM -0700, David Daney wrote: On 09/05/2012 02:10 PM, gre...@linuxfoundation.org wrote: This is a note to let you know that I've just added the patch titled misc/at25, dt: Improve at25 SPI eeprom device tree bindings. It is perhaps obvious that I think

Re: [PATCH] drivers: phy: add generic PHY framework

2012-09-26 Thread Greg KH
On Wed, Sep 26, 2012 at 08:31:15PM +0530, Kishon Vijay Abraham I wrote: The PHY framework provides a set of API's for the PHY drivers to create/destroy a PHY and API's for the PHY users to obtain a reference to the PHY with or without using phandle. To obtain a reference to the PHY without

Re: [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support

2012-09-26 Thread Greg KH
On Mon, Sep 17, 2012 at 12:53:18PM +0530, AnilKumar Ch wrote: Adds device tree support to lis3lv02d_i2c driver. Along with this DT init is moved from core driver to individual drivers, with the current implementation some pdata is missing in lis3lv02d_i2c driver. Also adds platform data for

Re: [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support

2012-09-26 Thread Greg KH
On Wed, Sep 26, 2012 at 01:34:50PM -0700, Andrew Morton wrote: On Wed, 26 Sep 2012 13:24:00 -0700 Greg KH gre...@linuxfoundation.org wrote: On Mon, Sep 17, 2012 at 12:53:18PM +0530, AnilKumar Ch wrote: Adds device tree support to lis3lv02d_i2c driver. Along with this DT init is moved

Re: [PATCH v3 0/4] lis3: lis3lv02d_i2c: Add device tree support

2012-09-26 Thread Greg KH
On Wed, Sep 26, 2012 at 01:54:12PM -0700, Andrew Morton wrote: On Wed, 26 Sep 2012 13:44:03 -0700 Greg KH gre...@linuxfoundation.org wrote: On Wed, Sep 26, 2012 at 01:34:50PM -0700, Andrew Morton wrote: On Wed, 26 Sep 2012 13:24:00 -0700 Greg KH gre...@linuxfoundation.org wrote

Re: [RESEND PATCH v3 1/2] i2c: change id to let i2c-gpio work

2012-10-16 Thread Greg KH
On Tue, Oct 16, 2012 at 01:17:47PM +0800, Bo Shen wrote: From: voice voice.s...@atmel.com The i2c core driver will turn the platform device ID to busnum When using platfrom device ID as -1, it means dynamically assigned the busnum. When writing code, we need to make sure the busnum, and

Re: [RESEND PATCH v3 2/2] i2c: change id to let i2c-at91 work

2012-10-16 Thread Greg KH
On Tue, Oct 16, 2012 at 01:17:48PM +0800, Bo Shen wrote: From: voice voice.s...@atmel.com The i2c core driver will turn the platform device ID to busnum When using platfrom device ID as -1, it means dynamically assigned the busnum. When writing code, we need to make sure the busnum, and

Re: [PATCH -next] tty: of_serial: fix return value check in of_platform_serial_setup()

2012-11-15 Thread Greg KH
On Thu, Nov 15, 2012 at 12:08:11PM +, Grant Likely wrote: On Thu, 1 Nov 2012 13:27:34 +0800, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function clk_get() returns ERR_PTR() and never returns NULL. The NULL test in the

Re: [PATCH 1/9] usb: chipidea: pci: mark platformdata as static and __devinitdata

2012-11-16 Thread Greg KH
On Fri, Nov 16, 2012 at 12:06:57PM +0200, Alexander Shishkin wrote: Michael Grzeschik m.grzesc...@pengutronix.de writes: From: Marc Kleine-Budde m...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de static

Re: [PATCH] of/address: sparc: Declare of_iomap as an extern function for sparc again

2012-11-23 Thread Greg KH
On Fri, Nov 23, 2012 at 11:34:20PM +, Grant Likely wrote: Cc'ing stable since this should go into previous kernels too. formletter This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this

Re: [PATCH 1/2] arm: tegra: Add new DT property to USB node.

2012-12-17 Thread Greg KH
On Mon, Dec 17, 2012 at 02:07:59PM -0700, Stephen Warren wrote: On 12/13/2012 11:59 PM, Venu Byravarasu wrote: As Tegra USB host driver is using instance number for resetting PORT0 twice, adding a new DT property for handling this. Alan, Greg, Felip,e This series looks fine to me.

Re: [PATCH 1/2] arm: tegra: Add new DT property to USB node.

2013-01-11 Thread Greg KH
On Mon, Dec 17, 2012 at 05:04:41PM -0500, Alan Stern wrote: On Mon, 17 Dec 2012, Stephen Warren wrote: On 12/13/2012 11:59 PM, Venu Byravarasu wrote: As Tegra USB host driver is using instance number for resetting PORT0 twice, adding a new DT property for handling this. Alan, Greg,

Re: [PATCH -next] serial: xilinx_uartps: fix return value check in xuartps_probe()

2013-01-15 Thread Greg KH
On Sun, Dec 02, 2012 at 05:12:43AM -0500, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, function of_clk_get() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei

Re: [PATCH v2 2/2] usb: dwc3-exynos: Fix compatible strings for the device

2013-01-24 Thread Greg KH
On Thu, Jan 24, 2013 at 07:15:30PM +0530, Vivek Gautam wrote: Using specific chip in compatible strings. Newer SOCs can claim device by using older string in the compatible list. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Grant Likely grant.lik...@secretlab.ca

Re: section mismatch in drivers/w1/masters/w1-gpio.c

2013-01-27 Thread Greg KH
On Sun, Jan 27, 2013 at 08:36:00PM +0100, Hauke Mehrtens wrote: Hi, when building 3.8-rc5 I get the following section mismatch: WARNING: drivers/w1/masters/w1-gpio.o(.data+0x188): Section mismatch in reference from the variable w1_gpio_driver to the function .init.text:w1_gpio_probe()

Re: [PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

2013-03-25 Thread Greg KH
On Mon, Mar 25, 2013 at 05:29:31PM +0100, Michael Grzeschik wrote: Hi Alexander, Fabio, Greg, On Mon, Mar 25, 2013 at 10:11:15AM -0300, Fabio Estevam wrote: Hi Alexander, On Thu, Jan 24, 2013 at 7:42 AM, Alexander Shishkin alexander.shish...@linux.intel.com wrote: Peter Chen

Re: [PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

2013-03-29 Thread Greg KH
On Fri, Mar 29, 2013 at 06:00:36PM +0200, Alexander Shishkin wrote: Greg KH gre...@linuxfoundation.org writes: If I don't hear back from you by Wednesday this week, with a specific plan for how to get all of these fixes to me by the end of this week, I'm going to assume that you

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Greg KH
On Wed, May 08, 2013 at 04:34:43PM +0200, Arnd Bergmann wrote: +#define ASC_MAJOR 204 +#define ASC_MINOR_START40 I don't know what the current policy is on allocating major/minor numbers, but I'm sure you cannot just reuse one that is already used. I agree, why are

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Greg KH
On Wed, May 08, 2013 at 05:40:57PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: On 08:34 Wed 08 May , Greg KH wrote: On Wed, May 08, 2013 at 04:34:43PM +0200, Arnd Bergmann wrote: +#define ASC_MAJOR 204 +#define ASC_MINOR_START40 I don't know

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Greg KH
On Thu, May 09, 2013 at 12:03:05AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: On May 8, 2013, at 11:53 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, May 08, 2013 at 05:40:57PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: On 08:34 Wed 08 May , Greg KH wrote: On Wed

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-08 Thread Greg KH
On Wed, May 08, 2013 at 06:31:48PM +0200, Arnd Bergmann wrote: On Wednesday 08 May 2013, Greg KH wrote: just mention there is not hardware reason to not use the generic ttySx in place of ttyAS as we have only one IP that handle serial on this family of SoC personally I'll switch

Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

2013-05-10 Thread Greg KH
On Fri, May 10, 2013 at 04:45:15PM +0200, Ben Dooks wrote: On 08/05/13 17:34, Greg KH wrote: On Wed, May 08, 2013 at 04:34:43PM +0200, Arnd Bergmann wrote: +#define ASC_MAJOR 204 +#define ASC_MINOR_START 40 I don't know what the current policy is on allocating major/minor

Re: [PATCH 1/1] USB: ehci-omap: Reset dma_mask pointer on probe

2013-06-03 Thread Greg KH
On Thu, May 23, 2013 at 05:46:44PM +0300, Roger Quadros wrote: On 05/23/2013 05:11 PM, Alan Stern wrote: On Thu, 23 May 2013, Roger Quadros wrote: Device tree probed devices don't get dma_mask set. Previously we were setting the dma_mask pointer only if it was NULL. However, the

Re: getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-05 Thread Greg KH
On Wed, Jun 05, 2013 at 11:56:43PM +0100, Luke Kenneth Casson Leighton wrote: so there's a lot of factors which i believe the linux kernel developers are not aware of, and haven't taken into account, and to place blame onto the SoC vendors for not working with *you* when *you* haven't made an

Re: [Ksummit-2013-discuss] [ATTEND] Handling of devicetree bindings

2013-07-15 Thread Greg KH
On Sun, Jul 14, 2013 at 01:46:45AM +0200, Linus Walleij wrote: On Sat, Jul 13, 2013 at 10:49 PM, Guenter Roeck li...@roeck-us.net wrote: On Sat, Jul 13, 2013 at 08:26:47PM +0100, Wolfram Sang wrote: I think the KS would be a good opportunity to present the status quo, show some rules of

Re: [Ksummit-2013-discuss] [ATTEND] Handling of devicetree bindings

2013-07-15 Thread Greg KH
On Mon, Jul 15, 2013 at 06:06:00PM +0100, Mark Brown wrote: On Mon, Jul 15, 2013 at 09:56:20AM -0700, Greg KH wrote: How about a hint for subsystem maintainers as to what exactly we should be looking for with these bindings? I for one have no idea what is right vs. wrong with them, so

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

2013-07-17 Thread Greg KH
On Wed, Jun 26, 2013 at 05:17:29PM +0530, Kishon Vijay Abraham I wrote: +menuconfig GENERIC_PHY + tristate PHY Subsystem + help + Generic PHY support. + + This framework is designed to provide a generic interface for PHY + devices present in the kernel. This layer

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

2013-07-17 Thread Greg KH
On Wed, Jul 17, 2013 at 03:02:59PM +0530, Kishon Vijay Abraham I wrote: Hi, On Wednesday 17 July 2013 11:59 AM, Greg KH wrote: On Wed, Jun 26, 2013 at 05:17:29PM +0530, Kishon Vijay Abraham I wrote: +menuconfig GENERIC_PHY + tristate PHY Subsystem + help +Generic PHY support

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 11:33:17AM +0530, Kishon Vijay Abraham I wrote: Wanted to group all the PHY drivers to be used by different subsystems (SATA/USB/PCIE/HDMI/VIDEO) into a single entity. There were some comments in my initial version [3] on using a bus_type instead of class but then

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 12:16:10PM +0530, Kishon Vijay Abraham I wrote: +struct phy_provider *__of_phy_provider_register(struct device *dev, + struct module *owner, struct phy * (*of_xlate)(struct device *dev, + struct of_phandle_args *args)); +struct phy_provider

Re: [PATCH 02/15] usb: phy: omap-usb2: use the new generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 12:16:11PM +0530, Kishon Vijay Abraham I wrote: Used the generic PHY framework API to create the PHY. Now the power off and power on are done in omap_usb_power_off and omap_usb_power_on respectively. However using the old USB PHY library cannot be completely removed

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 02:29:52PM +0530, Kishon Vijay Abraham I wrote: Hi, On Thursday 18 July 2013 12:50 PM, Greg KH wrote: On Thu, Jul 18, 2013 at 12:16:10PM +0530, Kishon Vijay Abraham I wrote: +struct phy_provider *__of_phy_provider_register(struct device *dev, + struct module

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: +ret = dev_set_name(phy-dev, %s.%d, dev_name(dev), id); Your naming is odd, no phy anywhere in it? You rely on the sender to never send a duplicate name.id pair? Why not create your own ids based on the

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Greg KH
On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: + ret = dev_set_name(phy-dev, %s.%d, dev_name(dev), id); Your naming is odd, no phy

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Greg KH
On Fri, Jul 19, 2013 at 12:06:01PM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:07:10AM

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-20 Thread Greg KH
On Sat, Jul 20, 2013 at 08:49:32AM +0530, Kishon Vijay Abraham I wrote: Hi, On Saturday 20 July 2013 05:20 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 12:06:01PM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-20 Thread Greg KH
On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't pass strings around, pass pointers. If you have platform data you can get to, then put the pointer there, don't use a name

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 01:12:07PM +0200, Tomasz Figa wrote: On Sunday 21 of July 2013 16:37:33 Kishon Vijay Abraham I wrote: Hi, On Sunday 21 July 2013 04:01 PM, Tomasz Figa wrote: Hi, On Saturday 20 of July 2013 19:59:10 Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 12:22:48PM +0200, Sascha Hauer wrote: On Sat, Jul 20, 2013 at 07:59:10PM -0700, Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't