Re: Add request object as optional input to BaseForm class

2022-05-26 Thread Douglas Mumme
Hey Adam, yeah I figured it was most likely a design decision to not incorporate request in forms. Thanks for the feedback! On Tuesday, May 24, 2022 at 3:12:04 AM UTC-5 Adam Johnson wrote: > I don't think this is a good idea, it couples forms too tightly to > requests. The idea of a form is to

Re: Add request object as optional input to BaseForm class

2022-05-24 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
I don't think this is a good idea, it couples forms too tightly to requests. The idea of a form is to take dictionaries of form inputs, and validate those. It shouldn't need the request. If I write a form class that needs extra things from the request, I write my form class to take just that

Add request object as optional input to BaseForm class

2022-05-23 Thread Douglas Mumme
Hey all, I've recently made a ticket to add the request object as an optional input to the BaseForm class so that it will easily input for any form if it's needed. I found out that something like this has been requested before and resolved as a "won't fix", but I think adding it as an