Re: Feedback on PR "Add warning when inspectdb find multi-columns primary keys"

2020-12-01 Thread Damien
I agree it can be too much details but it can be useful to know which part of inspectdb failed. Le mar. 1 déc. 2020 à 16:46, Tim Graham a écrit : > What value does the traceback add for you? I'd think that most users don't > care about the inner workings of inspectdb. > > On Tuesday, December

Re: Feedback on PR "Add warning when inspectdb find multi-columns primary keys"

2020-12-01 Thread Tim Graham
What value does the traceback add for you? I'd think that most users don't care about the inner workings of inspectdb. On Tuesday, December 1, 2020 at 10:25:54 AM UTC-5 damio wrote: > Since the warning is to stderr, it doesn't break the main usecase of doing > "python manage.py inspectdb >

Re: Feedback on PR "Add warning when inspectdb find multi-columns primary keys"

2020-12-01 Thread Damien
Since the warning is to stderr, it doesn't break the main usecase of doing "python manage.py inspectdb > models.py" Django use comment to tell that there was an error when the table introspection failed, but it should be a with a detailed traceback in my opinion. But it looks like it's me who

Re: Feedback on PR "Add warning when inspectdb find multi-columns primary keys"

2020-12-01 Thread Tim Graham
Please try to make it easy to understand the issue without looking at tickets and pull requests. Even after I did that, I couldn't find why you believe it should be a warning and not a comment. Why is this situation different from all the other places Django uses comments to indicate where