Re: [PATCH] MAINTAINERS: drm: Drop sam as panel reviewer

2024-05-31 Thread Neil Armstrong
Hi Sam, On 30/05/2024 23:14, Sam Ravnborg wrote: Drop myself as reviewer of panel patches, to reflect the reality. Thanks for all your work on panel reviewing! Signed-off-by: Sam Ravnborg Cc: Neil Armstrong --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS

Re: [PATCH v2 0/3] drm/panel: sitronix-st7789v: fixes for jt240mhqs_hwt_ek_e3 panel

2024-05-30 Thread Neil Armstrong
Hi, On Wed, 29 May 2024 16:42:44 +0200, Gerald Loacker wrote: > At the jt240mhqs_hwt_ek_e3 panel, noticeable flickering occurs. This is > addressed by patch 1, which adjusts the vertical timing. Patch 2 and 3 are > two more minor fixes for timing and dimension. > > Thanks, Applied to

Re: [PATCH v5 0/6] Add DSC support to DSI video panel

2024-05-28 Thread neil . armstrong
: e6428bcb611f6c164856a41fc5a1ae8471a9b5a9 change-id: 20240524-msm-drm-dsc-dsi-video-upstream-4-22e2266fbe89 Best regards, Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK with https://lore.kernel.org/all/20230728012623.22991-1-quic_parel

Re: [PATCH 0/8] drm/panel: Some very minor err handling fixes + more _multi

2024-05-23 Thread Neil Armstrong
Hi, On Fri, 17 May 2024 14:36:35 -0700, Douglas Anderson wrote: > This series is pretty much just addressing a few minor error handling > bugs that I noticed recently while reviewing some panel patches. For > the most part these are all old issues. > > This also adjusts the new himax-hx83102 in

Re: [PATCH] dt-bindings: display: Reorganize legacy eDP panel bindings

2024-05-23 Thread Neil Armstrong
Hi, On Mon, 20 May 2024 15:38:17 -0700, Douglas Anderson wrote: > Back in the day, we used to need to list the exact panel in dts for > eDP panels. This led to all sorts of problems including a large number > of cases where people listed a bogus panel in their device tree > because of the needs

Re: [PATCH RFC] drm/panel-edp: add fat warning against adding new panel compatibles

2024-05-23 Thread Neil Armstrong
nels in a proper way. +*/ + { .compatible = "auo,b101ean01", .data = _b101ean01, }, { --- base-commit: 8314289a8d50a4e05d8ece1ae0445a3b57bb4d3b change-id: 20240523-edp-panel-drop-00aa239b3c6b Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH v3 2/3] drm/panel/lg-sw43408: select CONFIG_DRM_DISPLAY_DP_HELPER

2024-05-22 Thread Neil Armstrong
select DRM_DISPLAY_HELPER help Say Y here if you want to enable support for LG sw43408 panel. The panel has a 1080x2160@60Hz resolution and uses 24 bit RGB per Reviewed-by: Neil Armstrong

Re: [PATCH v3 3/3] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-05-22 Thread Neil Armstrong
On 22/05/2024 08:25, Dmitry Baryshkov wrote: Fix sparse warning regarding symbol 'sw43408_backlight_ops' not being declared. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404200739.hbwzvohr-...@intel.com/ Reviewed-by: Neil Armstrong Fixes: 069a6c0e94f9 (&quo

Re: [PATCH] dt-bindings: display: synopsys, dw-hdmi: Mark ddc-i2c-bus as deprecated

2024-05-21 Thread Neil Armstrong
Hajda Cc: Conor Dooley Cc: Daniel Vetter Cc: David Airlie Cc: Fabio Estevam Cc: Jernej Skrabec Cc: Jonas Karlman Cc: Krzysztof Kozlowski Cc: Laurent Pinchart Cc: Liu Ying Cc: Maarten Lankhorst Cc: Mark Yao Cc: Maxime Ripard Cc: Neil Armstrong Cc: Pengutronix Kernel Team Cc: Philipp

Re: [PATCH v2 5/5] drm/tiny: panel-mipi-dbi: Support the pixel format property

2024-05-21 Thread Neil Armstrong
if (ret) return ret; Reviewed-by: Neil Armstrong

Re: [PATCH v2 0/7] drm/mipi-dsi: simplify MIPI DSI init/cleanup even more

2024-05-17 Thread Neil Armstrong
Hi, On Sun, 12 May 2024 02:00:17 +0300, Dmitry Baryshkov wrote: > Follow the example of mipi_dsi_generic_write_multi(), > mipi_dsi_dcs_write_buffer_multi(), mipi_dsi_generic_write_seq_multi() > and mipi_dsi_dcs_write_seq_multi(). Define _multi variants for several > other common MIPI DSI

Re: [PATCH v2 2/7] drm/mipi-dsi: wrap more functions for streamline handling

2024-05-17 Thread Neil Armstrong
ct mipi_dsi_multi_context *ctx); +void mipi_dsi_dcs_set_tear_on_multi(struct mipi_dsi_multi_context *ctx, + enum mipi_dsi_dcs_tear_mode mode); + /** * mipi_dsi_generic_write_seq - transmit data using a generic write packet * The mipi_dsi_msleep() seems a little bit over-enginerred for me, but it serves the purpose so: Reviewed-by: Neil Armstrong Thanks, Neil

Re: [PATCH v8 0/6] Break out as separate driver and add BOE nv110wum-l60 IVO t109nw41 MIPI-DSI panel

2024-05-17 Thread Neil Armstrong
Hi, On Thu, 16 May 2024 15:20:33 +0800, Cong Yang wrote: > Discussion with Doug and Linus in V1, we need a > separate driver to enable the hx83102 controller. > > So this series this series mainly Break out as separate driver > for Starry-himax83102-j02 panels from boe tv101wum driver. > > Then

Re: (subset) [PATCH v7 0/7] Break out as separate driver and add BOE nv110wum-l60 IVO t109nw41 MIPI-DSI panel

2024-05-17 Thread Neil Armstrong
Hi, On Wed, 15 May 2024 09:46:36 +0800, Cong Yang wrote: > Discussion with Doug and Linus in V1, we need a > separate driver to enable the hx83102 controller. > > So this series this series mainly Break out as separate driver > for Starry-himax83102-j02 panels from boe tv101wum driver. > > Then

Re: [PATCH v8 0/6] Break out as separate driver and add BOE nv110wum-l60 IVO t109nw41 MIPI-DSI panel

2024-05-17 Thread neil . armstrong
On 16/05/2024 15:31, Doug Anderson wrote: Hi, On Thu, May 16, 2024 at 12:21 AM Cong Yang wrote: Discussion with Doug and Linus in V1, we need a separate driver to enable the hx83102 controller. So this series this series mainly Break out as separate driver for Starry-himax83102-j02 panels

Re: [PATCH v3 3/6] dt-bindings: display: simple: Add Microtips & Lincolntech Dual-LVDS Panels

2024-05-16 Thread Neil Armstrong
On 16/05/2024 13:06, Aradhya Bhatia wrote: Hi Liu, Thanks for reviewing the patch. On 16/05/24 07:49, Liu Ying wrote: On 5/15/24 17:51, Aradhya Bhatia wrote: Add the Microtips Technology USA's MF-101HIEBCAF0 10.1"[0] panel, MF-103HIEB0GA0 10.25"[1] panel, and Lincoln Technology Solutions'

Re: [v7 3/7] arm64: defconfig: Enable HIMAX_HX83102 panel

2024-05-16 Thread neil . armstrong
On 16/05/2024 08:43, cong yang wrote: Hi: If it is determined that a separately patch needs to be sent, then I will remove this patch in V8 series? Doug Anderson 于2024年5月16日周四 05:28写道: Hi, On Wed, May 15, 2024 at 2:16 PM wrote: Hi, On 15/05/2024 03:46, Cong Yang wrote:

Re: [PATCH v3 0/6] drm/panel: simple: Add Panels and Panel Vendors

2024-05-15 Thread Neil Armstrong
Hi, On Wed, 15 May 2024 15:21:27 +0530, Aradhya Bhatia wrote: > Picking up this long-standing series which added support for Microtips' > and LincolnTech's dual-lvds panels. > > Microtips Technology Solutions USA, and Lincoln Technology Solutions are > 2 display panel vendors, and the patches

Re: [PATCH v3 6/6] drm/panel: simple: Add Microtips Technology MF-103HIEB0GA0 panel

2024-05-15 Thread Neil Armstrong
t;, + .data = _mf_103hieb0ga0, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = _aa070mc01, Reviewed-by: Neil Armstrong

Re: [PATCH v3 5/6] drm/panel: simple: Add Microtips Technology 13-101HIEBCAF0-C panel

2024-05-15 Thread Neil Armstrong
t;, + .data = _mf_101hiebcaf0_c, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = _aa070mc01, Reviewed-by: Neil Armstrong

Re: [PATCH v3 4/6] drm/panel: simple: Add Lincoln Tech Sol LCD185-101CT panel

2024-05-15 Thread Neil Armstrong
olntech,lcd185-101ct", + .data = _lcd185_101ct, }, { .compatible = "logicpd,type28", .data = _type_28, Reviewed-by: Neil Armstrong

Re: [v7 3/7] arm64: defconfig: Enable HIMAX_HX83102 panel

2024-05-15 Thread neil . armstrong
Hi, On 15/05/2024 03:46, Cong Yang wrote: DRM_PANEL_HIMAX_HX83102 is being split out from DRM_PANEL_BOE_TV101WUM_NL6. Since the arm64 defconfig had the BOE panel driver enabled, let's also enable the himax driver. Signed-off-by: Cong Yang Reviewed-by: Douglas Anderson ---

Re: [PATCH 0/3] dt-bindings: display: panel: constrain 'reg'

2024-05-15 Thread neil . armstrong
On 14/05/2024 11:07, Krzysztof Kozlowski wrote: On 14/05/2024 10:44, Neil Armstrong wrote: On 13/05/2024 18:41, Dmitry Baryshkov wrote: On Mon, 13 May 2024 at 16:17, Rob Herring wrote: On Thu, May 09, 2024 at 11:42:50AM +0200, Krzysztof Kozlowski wrote: Hi, Cleanups for display panel

Re: [PATCH v5 0/9] drm/mipi-dsi: Reduce bloat and add funcs for cleaner init seqs

2024-05-15 Thread Neil Armstrong
Hi, On Tue, 14 May 2024 10:20:50 -0700, Douglas Anderson wrote: > The consensus of many DRM folks is that we want to move away from DSI > drivers defining tables of init commands. Instead, we want to move to > init functions that can use common DRM functions. The issue thus far > has been that

Re: [PATCH 0/3] dt-bindings: display: panel: constrain 'reg'

2024-05-14 Thread Neil Armstrong
On 13/05/2024 18:41, Dmitry Baryshkov wrote: On Mon, 13 May 2024 at 16:17, Rob Herring wrote: On Thu, May 09, 2024 at 11:42:50AM +0200, Krzysztof Kozlowski wrote: Hi, Cleanups for display panel bindings. Rob, maybe you could take entire set if it applies? I based it on linux-next, so letl

Re: [PATCH v2 2/2] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-05-13 Thread Neil Armstrong
= { .update_status = sw43408_backlight_update_status, }; Reviewed-by: Neil Armstrong

Re: [PATCH 0/2] drm/meson: fix hdmi auxiliary system operation without display

2024-05-03 Thread Neil Armstrong
Hi, On Fri, 26 Apr 2024 18:02:52 +0200, Jerome Brunet wrote: > CEC and ARC should work even when HDMI is not actively used for the > display but it is not the case with Amlogic HDMI. > > This is important for devices such as sound bars which may use DSI > to display a UI and HDMI for CEC/ARC. A

Re: [PATCH 2/2] drm/meson: dw-hdmi: add bandgap setting for g12

2024-05-03 Thread Neil Armstrong
ta }, { .compatible = "amlogic,meson-gxl-dw-hdmi", - .data = _dw_hdmi_gx_data }, + .data = _dw_hdmi_gxl_data }, { .compatible = "amlogic,meson-gxm-dw-hdmi", - .data = _dw_hdmi_gx_data }, + .data = _dw_hdmi_gxl_data }, { .compatible = "amlogic,meson-g12a-dw-hdmi", .data = _dw_hdmi_g12a_data }, { } Reviewed-by: Neil Armstrong

Re: [PATCH 1/2] drm/meson: dw-hdmi: power up phy on device init

2024-05-03 Thread Neil Armstrong
HY_CNTL1, + BIT(17), BIT(17)); + /* Enable HDMI-TX Interrupt */ meson_dw_hdmi->data->top_write(meson_dw_hdmi, HDMITX_TOP_INTR_STAT_CLR, HDMITX_TOP_INTR_CORE); Reviewed-by: Neil Armstrong

Re: [PATCH v3 0/9] drm/mipi-dsi: Reduce bloat and add funcs for cleaner init seqs

2024-05-02 Thread neil . armstrong
On 02/05/2024 16:27, Doug Anderson wrote: Hi, On Thu, May 2, 2024 at 12:48 AM Neil Armstrong wrote: Hi, On 01/05/2024 17:41, Douglas Anderson wrote: The consensus of many DRM folks is that we want to move away from DSI drivers defining tables of init commands. Instead, we want to move

Re: [PATCH v2] drm/panel: ili9341: Remove a superfluous else after return

2024-05-02 Thread Neil Armstrong
Hi, On Wed, 01 May 2024 13:24:02 +0800, Sui Jingfeng wrote: > Because the else clause after the return clause is not useful, remove it > to get a better look. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm/panel: ili9341: Remove a

Re: [PATCH v3 0/9] drm/mipi-dsi: Reduce bloat and add funcs for cleaner init seqs

2024-05-02 Thread Neil Armstrong
Hi, On 01/05/2024 17:41, Douglas Anderson wrote: The consensus of many DRM folks is that we want to move away from DSI drivers defining tables of init commands. Instead, we want to move to init functions that can use common DRM functions. The issue thus far has been that using the macros

Re: [PATCH v1 0/3] drm/panel: ili9341: Obvious fixes

2024-05-02 Thread Neil Armstrong
Hi, On Thu, 25 Apr 2024 17:26:16 +0300, Andy Shevchenko wrote: > A few obvious fixes to the driver. > > Andy Shevchenko (3): > drm/panel: ili9341: Correct use of device property APIs > drm/panel: ili9341: Respect deferred probe > drm/panel: ili9341: Use predefined error codes > > [...]

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-05-02 Thread Neil Armstrong
On 30/04/2024 11:34, Maxime Ripard wrote: On Tue, Apr 30, 2024 at 12:54:39AM +0800, Sui Jingfeng wrote: On 2024/4/29 19:55, Maxime Ripard wrote: On Sat, Apr 27, 2024 at 01:57:46PM +0800, Sui Jingfeng wrote: On 2024/4/26 14:23, Maxime Ripard wrote: On Fri, Apr 26, 2024 at 04:43:18AM +0800,

Re: [PATCH v3 5/9] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-05-02 Thread Neil Armstrong
\ + static const u8 d[] = { cmd, seq }; \ + mipi_dsi_dcs_write_buffer_multi(ctx, d, ARRAY_SIZE(d)); \ + } while (0) + /** * struct mipi_dsi_driver - DSI driver * @driver: device driver model driver Reviewed-by: Neil Armstrong

Re: [PATCH v3 4/9] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-05-02 Thread Neil Armstrong
tatic const u8 d[] = { cmd, seq };\ + int ret; \ + ret = mipi_dsi_dcs_write_buffer_chatty(dsi, d, ARRAY_SIZE(d)); \ + if (ret < 0) \ + return ret; \ } while (0) /** Reviewed-by: Neil Armstrong

Re: [PATCH v3 3/9] drm/mipi-dsi: mipi_dsi_*_write functions don't need to ratelimit prints

2024-05-02 Thread Neil Armstrong
x failed: %zd\n", \ cmd, ret); \ return ret; \ } \ Reviewed-by: Neil Armstrong

Re: [PATCH v3 2/9] drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_generic_write_seq()

2024-05-02 Thread Neil Armstrong
\ + dev_err_ratelimited(dev, "transmit data failed: %zd\n", \ + ret); \ + return ret; \ + } \ } while (0) /** Reviewed-by: Neil Armstrong

Re: [PATCH v3 1/9] drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_dcs_write_seq()

2024-05-02 Thread Neil Armstrong
cmd, ret); \ + return ret; \ + } \ } while (0) /** Reviewed-by: Neil Armstrong

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-04-29 Thread Neil Armstrong
Hello Mister Anderson, On 27/04/2024 01:58, Douglas Anderson wrote: The current mipi_dsi_*_write_seq() macros are non-intutitive because they contain a hidden "return" statement that will return out of the _caller_ of the macro. Let's mark them as deprecated and instead introduce some new

Re: [PATCH v1 3/3] drm/panel: ili9341: Use predefined error codes

2024-04-25 Thread Neil Armstrong
return ili9341_dbi_probe(spi, dc, reset); - return -1; + return -ENODEV; } static void ili9341_remove(struct spi_device *spi) Reviewed-by: Neil Armstrong

Re: [PATCH v1 2/3] drm/panel: ili9341: Respect deferred probe

2024-04-25 Thread Neil Armstrong
od_get_optional(dev, "dc", GPIOD_OUT_LOW); if (IS_ERR(dc)) - dev_err(dev, "Failed to get gpio 'dc'\n"); + return dev_err_probe(dev, PTR_ERR(dc), "Failed to get gpio 'dc'\n"); if (!strcmp(id->name, "sf-tc240t-9370-t&quo

Re: [PATCH v1 1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Neil Armstrong
unique * data entry for the system in this driver. */ - ili->conf = of_device_get_match_data(dev); + ili->conf = device_get_match_data(dev); if (!ili->conf) { dev_err(dev, "missing device configuration\n"); return -ENODEV; Reviewed-by: Neil Armstrong

Re: [PATCH 02/10] pwm: Add SI-EN SN3112 PWM support

2024-04-25 Thread Neil Armstrong
On 25/04/2024 02:57, Junhao Xie wrote: On 2024/4/25 03:37, Konrad Dybcio wrote: On 4/24/24 17:29, Xilin Wu via B4 Relay wrote: From: Junhao Xie Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller. Signed-off-by: Junhao Xie --- [...] +    return

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-25 Thread Neil Armstrong
On 25/04/2024 02:20, Douglas Anderson wrote: The consensus of many DRM folks is that we want to move away from DSI drivers defining tables of init commands. Instead, we want to move to init functions that can use common DRM functions. The issue thus far has been that using the macros

Re: [PATCH 1/2] drm/bridge: chipone-icn6211: drop driver owner assignment

2024-04-25 Thread Neil Armstrong
Hi Dmitry, On 24/04/2024 11:12, Dmitry Baryshkov wrote: On Sat, Mar 30, 2024 at 09:27:40PM +0100, Krzysztof Kozlowski wrote: Core in mipi_dsi_driver_register() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski ---

Re: [PATCH] drm/panel: jdi-fhd-r63452: make use of prepare_prev_first

2024-04-24 Thread Neil Armstrong
Hi, On Tue, 23 Apr 2024 22:54:33 +0200, Barnabás Czémán wrote: > The DSI host must be enabled for the panel to be initialized in > prepare(). Set the prepare_prev_first flag to guarantee this. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1]

Re: [PATCH v2] drm/bridge: adv7511: make it honour next bridge in DT

2024-04-24 Thread Neil Armstrong
Hi, On Sun, 31 Mar 2024 23:45:48 +0300, Dmitry Baryshkov wrote: > DT bindings for adv7511 and adv7533 bridges specify HDMI output to be > present at the port@1. This allows board DT to add e.g. HDMI connector > nodes or any other next chained bridge. Make adv7511 driver discover > that bridge and

Re: (subset) [PATCH 0/6] drm/panel: small fixes for visionox and novatek panel drivers

2024-04-24 Thread Neil Armstrong
Hi, On Thu, 04 Apr 2024 13:07:58 +0300, Dmitry Baryshkov wrote: > While taking a glance at the novatek-nt36672e driver I stumbled upon a > call to unregister the DSI device for the panel, although it was not the > panel driver that registered the device. > > Remove this call and a similar call

Re: [PATCH 2/2] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-04-24 Thread Neil Armstrong
sw43408_backlight_ops = { .update_status = sw43408_backlight_update_status, }; Reviewed-by: Neil Armstrong

Re: [PATCH 1/2] drm/panel/lg-sw43408: depends on CONFIG_DRM_DISPLAY_DP_HELPER

2024-04-24 Thread Neil Armstrong
@60Hz resolution and uses 24 bit RGB per Reviewed-by: Neil Armstrong

Re: [PATCH 6/6] drm/panel: visionox-rm69299: stop calling regulator_set_load manually

2024-04-24 Thread Neil Armstrong
dev_err(dev, "regulator set load failed for vdd3p3 supply ret = %d\n", ret); - goto err_set_load; - } - return 0; -err_set_load: - mipi_dsi_detach(dsi); err_dsi_attach: drm_panel_remove(>panel); return ret; Reviewed-by: Neil Armstrong

Re: [PATCH 5/6] drm/panel: novatek-nt36672a: stop calling regulator_set_load manually

2024-04-24 Thread Neil Armstrong
return dev_err_probe(dev, ret, "failed to set regulator enable loads\n"); - } - pinfo->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(pinfo->reset_gpio)) return dev_err_probe(dev, PTR_ERR(pinfo->reset_gpio), Reviewed-by: Neil Armstrong

Re: [PATCH 3/6] drm/panel: novatek-nt36672e: stop setting register load before disable

2024-04-24 Thread Neil Armstrong
ctx->supplies[i].supply, ret); - return ret; - } - } - ret = regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); if (ret) dev_err(>dev, "regulator bulk disable failed: %d\n", ret); Reviewed-by: Neil Armstrong

Re: [PATCH] drm/panel: jdi-fhd-r63452: make use of prepare_prev_first

2024-04-24 Thread Neil Armstrong
se-commit: a59668a9397e7245b26e9be85d23f242ff757ae8 change-id: 20240423-jdi-fix-986a796a3101 Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH v2] drm/bridge: adv7511: make it honour next bridge in DT

2024-04-24 Thread Neil Armstrong
_config); else --- base-commit: 1843e16d2df9d98427ef8045589571749d627cf7 change-id: 20240309-adv7511-next-bridge-10d8bbe0544e Best regards, Indeed looks safer. Reviewed-by: Neil Armstrong Neil

Re: [PATCH] drm/bridge: adv7511: make it honour next bridge in DT

2024-04-24 Thread Neil Armstrong
_dt(dev->of_node, _config); else --- base-commit: 1843e16d2df9d98427ef8045589571749d627cf7 change-id: 20240309-adv7511-next-bridge-10d8bbe0544e Best regards, Reviewed-by: Neil Armstrong Looks fine, I check most of the DT using this bridge and the port@1 seems correctly defined. LGTM. Neil

Re: (subset) [PATCH v8 0/4] LVDS Controller Support for SAM9X75 SoC

2024-04-23 Thread Neil Armstrong
Hi, On Sun, 21 Apr 2024 06:40:46 +0530, Dharma Balasubiramani wrote: > This patch series introduces LVDS controller support for the SAM9X75 SoC. The > LVDS controller is designed to work with Microchip's sam9x7 series > System-on-Chip (SoC) devices, providing Low Voltage Differential Signaling >

Re: (subset) [PATCH v12 0/7] drm/meson: add support for MIPI DSI Display

2024-04-22 Thread Neil Armstrong
Hi, On Wed, 03 Apr 2024 09:46:31 +0200, Neil Armstrong wrote: > The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver > (ver 1.21a), > with a custom glue managing the IP resets, clock and data input similar to > the DW-HDMI > glue on th

Re: [PATCH v12 4/7] drm/meson: gate px_clk when setting rate

2024-04-22 Thread Neil Armstrong
Hi Martin, On 10/04/2024 21:34, Martin Blumenstingl wrote: Hi Neil, On Wed, Apr 3, 2024 at 9:46 AM Neil Armstrong wrote: Disable the px_clk when setting the rate to recover a fully configured and correctly reset VCLK clock tree after the rate is set. Fixes: 77d9e1e6b846 ("drm/meson

Re: [PATCH v4 0/2] Add driver for Raydium RM69380-based DSI panels

2024-04-22 Thread Neil Armstrong
Hi, On Wed, 17 Apr 2024 18:29:32 +0200, David Wronek wrote: > This patch adds support the 2560x1600@90Hz dual DSI command mode panel by > EDO in combination with a Raydium RM69380 driver IC. > > This driver IC can be found in the following devices: > * Lenovo Xiaoxin Pad Pro 2021 (TB-J716F)

Re: [PATCH v3 0/2] drm/panel: add Khadas TS050 V2 panel support

2024-04-22 Thread Neil Armstrong
Hi, On Fri, 19 Apr 2024 09:48:50 +0800, Jacobe Zang wrote: > Khadas has update its TS050 panel, the only different between the newer and > older is timing squence. In patches, add new TS050 panel named "ts050v2" as > make it compatible with the old one. > Thanks, Applied to

Re: [PATCH v2 0/2] drm/panel: add Khadas TS050 V2 panel support

2024-04-22 Thread Neil Armstrong
Hi, On Mon, 15 Apr 2024 11:14:06 +0800, Jacobe Zang wrote: > Changes from v1 at [1]: > - Fix name from "newts050" to "ts050v2" > - Add specific description about controller change > > [1]https://patchwork.kernel.org/project/linux-amlogic/list/?series=842707 > > Jacobe Zang (2): > dt-bindings:

Re: [PATCH v2 2/2] drm/panel: add Khadas TS050 V2 panel support

2024-04-16 Thread neil . armstrong
probe(struct mipi_dsi_device *dsi) if (!khadas_ts050) return -ENOMEM; + khadas_ts050->panel_data = (struct khadas_ts050_panel_data *)data; mipi_dsi_set_drvdata(dsi, khadas_ts050); khadas_ts050->link = dsi; Reviewed-by: Neil Armstrong

Re: [PATCH v3 8/9] drm/panel: novatek-nt35950: Don't log an error when DSI host can't be found

2024-04-16 Thread Neil Armstrong
return -EPROBE_DEFER; - } + if (!dsi_r_host) + return dev_err_probe(dev, -EPROBE_DEFER, "Cannot get secondary DSI host\n"); nt->dsi[1] = mipi_dsi_device_register_full(dsi_r_host, info); if (!n

Re: [PATCH 03/15] drm/panel-edp: switch to struct drm_edid

2024-04-16 Thread Neil Armstrong
On 16/04/2024 15:22, Jani Nikula wrote: Prefer struct drm_edid based functions over struct edid. Signed-off-by: Jani Nikula --- Cc: Douglas Anderson Cc: Neil Armstrong Cc: Jessica Zhang Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-edp.c | 17 ++--- 1 file changed, 10

Re: [PATCH 02/15] drm/panel-samsung-atna33xc20: switch to struct drm_edid

2024-04-16 Thread Neil Armstrong
On 16/04/2024 15:22, Jani Nikula wrote: Prefer struct drm_edid based functions over struct edid. Signed-off-by: Jani Nikula --- Cc: Neil Armstrong Cc: Jessica Zhang Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 13 - 1 file changed, 8 insertions

Re: [PATCH 01/15] drm/panel: simple: switch to struct drm_edid

2024-04-16 Thread Neil Armstrong
On 16/04/2024 15:22, Jani Nikula wrote: Prefer struct drm_edid based functions over struct edid. Signed-off-by: Jani Nikula --- Cc: Neil Armstrong Cc: Jessica Zhang Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-simple.c | 15 --- 1 file changed, 8 insertions(+), 7

Re: [PATCH v12 4/7] drm/meson: gate px_clk when setting rate

2024-04-12 Thread Neil Armstrong
On 10/04/2024 21:34, Martin Blumenstingl wrote: Hi Neil, On Wed, Apr 3, 2024 at 9:46 AM Neil Armstrong wrote: Disable the px_clk when setting the rate to recover a fully configured and correctly reset VCLK clock tree after the rate is set. Fixes: 77d9e1e6b846 ("drm/meson: add su

Re: [PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS

2024-04-10 Thread Neil Armstrong
-1-krzysztof.kozlow...@linaro.org/ Cc: Dmitry Baryshkov Cc: Neil Armstrong --- drivers/gpu/drm/armada/armada_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c index e51ecc4f7ef4..f48e2cf8de43 100644 --- a/drivers

Re: [PATCH RESEND] drm: use capital "OR" for multiple licenses in SPDX

2024-04-10 Thread Neil Armstrong
end... Cc: Dmitry Baryshkov Cc: Neil Armstrong --- drivers/gpu/drm/drm_client.c| 2 +- drivers/gpu/drm/drm_format_helper.c | 2 +- include/drm/drm_client.h| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/dr

Re: [PATCH v11 0/7] drm/meson: add support for MIPI DSI Display

2024-04-10 Thread Neil Armstrong
Hi, On Mon, 25 Mar 2024 12:09:46 +0100, Neil Armstrong wrote: > The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver > (ver 1.21a), > with a custom glue managing the IP resets, clock and data input similar to > the DW-HDMI > glue on th

Re: (subset) [PATCH v12 0/7] drm/meson: add support for MIPI DSI Display

2024-04-10 Thread Neil Armstrong
Hi, On Wed, 03 Apr 2024 09:46:31 +0200, Neil Armstrong wrote: > The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver > (ver 1.21a), > with a custom glue managing the IP resets, clock and data input similar to > the DW-HDMI > glue on th

Re: [PATCH 2/2] drm/panel: add New TS050 panel support

2024-04-09 Thread neil . armstrong
Hi Jacobe, On 09/04/2024 10:29, Jacobe Zang wrote: This add New TS050 Panel and make it compatible with old one. Signed-off-by: Jacobe Zang --- drivers/gpu/drm/panel/panel-khadas-ts050.c | 1112 +++- 1 file changed, 590 insertions(+), 522 deletions(-) diff --git

Re: Khadas VIM3/3L New TS050 support patch

2024-04-08 Thread neil . armstrong
Hi Jacobe, On 08/04/2024 15:16, Jacobe Zang wrote: Subject: [PATCH] drm/panel: add New TS050 Panel support Hello all, I have made some changes to the panel-khadas-ts050.c. Here is a brief overview of what has been done: - Add dt-bindings in document. - Add New TS050 Panel timing sequence. -

Re: [PATCH v12 2/7] clk: meson: add vclk driver

2024-04-08 Thread neil . armstrong
On 05/04/2024 09:00, Jerome Brunet wrote: On Thu 04 Apr 2024 at 18:59, Neil Armstrong wrote: On 04/04/2024 10:13, Jerome Brunet wrote: On Wed 03 Apr 2024 at 09:46, Neil Armstrong wrote: The VCLK and VCLK_DIV clocks have supplementary bits. The VCLK gate has a "SOFT RESET" bit

Re: [PATCH v12 2/7] clk: meson: add vclk driver

2024-04-04 Thread Neil Armstrong
On 04/04/2024 10:13, Jerome Brunet wrote: On Wed 03 Apr 2024 at 09:46, Neil Armstrong wrote: The VCLK and VCLK_DIV clocks have supplementary bits. The VCLK gate has a "SOFT RESET" bit to toggle after the whole VCLK sub-tree rate has been set, this is implemented in the gate enabl

[PATCH v12 7/7] arm64: dts: amlogic: meson-g12b-bananapi-cm4: add support for MNT Reform2 with CM4 adaper

2024-04-03 Thread Neil Armstrong
This adds a basic devicetree for the MNT Reform2 DIY laptop when using a CM4 adapter and a BPI-CM4 module. Co-developed-by: Lukas F. Hartmann Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/Makefile | 1 + .../meson-g12b-bananapi-cm4-mnt-reform2.dts| 384

[PATCH v12 4/7] drm/meson: gate px_clk when setting rate

2024-04-03 Thread Neil Armstrong
Disable the px_clk when setting the rate to recover a fully configured and correctly reset VCLK clock tree after the rate is set. Fixes: 77d9e1e6b846 ("drm/meson: add support for MIPI-DSI transceiver") Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 7

[PATCH v12 5/7] arm64: meson: g12-common: add the MIPI DSI nodes

2024-04-03 Thread Neil Armstrong
Add the MIPI DSI Analog & Digital PHY nodes and the DSI control nodes with proper port endpoint to the VPU. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 70 +++ 1 file changed, 70 insertions(+) diff --git a/arch/arm64/boot

[PATCH v12 6/7] arm64: meson: khadas-vim3l: add TS050 DSI panel overlay

2024-04-03 Thread Neil Armstrong
This add dtbo overlay to support the Khadas TS050 panel on the Khadas VIM3 & VIM3L boards. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/Makefile | 4 + .../boot/dts/amlogic/meson-khadas-vim3-ts050.dtso | 108 + 2 files changed,

[PATCH v12 3/7] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF

2024-04-03 Thread Neil Armstrong
_encl endpoint. Signed-off-by: Neil Armstrong --- drivers/clk/meson/Kconfig | 1 + drivers/clk/meson/g12a.c | 76 ++- 2 files changed, 57 insertions(+), 20 deletions(-) diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig inde

[PATCH v12 2/7] clk: meson: add vclk driver

2024-04-03 Thread Neil Armstrong
associated with CLK_SET_RATE_GATE it ensures the rate is set while the divider is disabled and in reset mode. The VCLK_DIV enable bit isn't implemented as a gate since it's part of the divider logic and vendor does this exact sequence to ensure the divider is correctly set. Signed-off-by: Neil

[PATCH v12 1/7] dt-bindings: arm: amlogic: Document the MNT Reform 2 CM4 adapter with a BPI-CM4 Module

2024-04-03 Thread Neil Armstrong
The MNT Reform 2 CM4 adapter can be populated with any Raspberry Pi CM4 compatible module such as a BPI-CM4 Module, document that. Acked-by: Conor Dooley Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v12 0/7] drm/meson: add support for MIPI DSI Display

2024-04-03 Thread Neil Armstrong
I. The change from v5 is that now we use a "VCLK" driver instead of notifier and rely on CLK_SET_RATE_GATE to ensure the VCLK gate operation are called. Signed-off-by: Neil Armstrong --- Changes in v12: - fix parameters alignment in patch 2 - update g12a_mipi_dsi_pxclk_div_table comment

Re: [PATCH] drm/meson: vclk: fix calculation of 59.94 fractional rates

2024-03-29 Thread Neil Armstrong
Hi, On Tue, 09 Jan 2024 23:07:04 +, Christian Hewitt wrote: > Playing 4K media with 59.94 fractional rate (typically VP9) causes the screen > to lose > sync with the following error reported in the system log: > > [ 89.610280] Fatal Error, invalid HDMI vclk freq 593406 > > Modetest shows

Re: (subset) [PATCH 0/5] Add Support for RK3326 GameForce Chi

2024-03-29 Thread Neil Armstrong
Hi, On Mon, 25 Mar 2024 08:49:54 -0500, Chris Morgan wrote: > From: Chris Morgan > > Add support for the GameForce Chi [1]. > > The GameForce Chi has the following hardware: > Tested: > - 3.5" dual lane 640x480 DSI display. > - 15 GPIO based face buttons. > - 2 ADC based face buttons. > -

Re: [PATCH v11 2/7] clk: meson: add vclk driver

2024-03-29 Thread Neil Armstrong
On 29/03/2024 13:33, Jerome Brunet wrote: On Mon 25 Mar 2024 at 12:09, Neil Armstrong wrote: The VCLK and VCLK_DIV clocks have supplementary bits. The VCLK gate has a "SOFT RESET" bit to toggle after the whole VCLK sub-tree rate has been set, this is implemented in the gate enabl

Re: [PATCH v11 3/7] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF

2024-03-29 Thread Neil Armstrong
On 29/03/2024 13:35, Jerome Brunet wrote: On Mon 25 Mar 2024 at 12:09, Neil Armstrong wrote: In order to setup the DSI clock, let's make the unused VCLK2 clock path configuration via CCF. The nocache option is removed from following clocks: - vclk2_sel - vclk2_input - vclk2_div - vclk2

Re: [PATCH] drm/meson: vclk: fix calculation of 59.94 fractional rates

2024-03-29 Thread Neil Armstrong
mp; (vclk_freq == params[freq].vclk_freq || vclk_freq == FREQ_1000_1001(params[freq].vclk_freq))) { if (vclk_freq != params[freq].vclk_freq) Reviewed-by: Neil Armstrong

[PATCH v11 1/7] dt-bindings: arm: amlogic: Document the MNT Reform 2 CM4 adapter with a BPI-CM4 Module

2024-03-25 Thread Neil Armstrong
The MNT Reform 2 CM4 adapter can be populated with any Raspberry Pi CM4 compatible module such as a BPI-CM4 Module, document that. Acked-by: Conor Dooley Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v11 2/7] clk: meson: add vclk driver

2024-03-25 Thread Neil Armstrong
associated with CLK_SET_RATE_GATE it ensures the rate is set while the divider is disabled and in reset mode. The VCLK_DIV enable bit isn't implemented as a gate since it's part of the divider logic and vendor does this exact sequence to ensure the divider is correctly set. Signed-off-by: Neil

[PATCH v11 7/7] arm64: dts: amlogic: meson-g12b-bananapi-cm4: add support for MNT Reform2 with CM4 adaper

2024-03-25 Thread Neil Armstrong
This adds a basic devicetree for the MNT Reform2 DIY laptop when using a CM4 adapter and a BPI-CM4 module. Co-developed-by: Lukas F. Hartmann Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/Makefile | 1 + .../meson-g12b-bananapi-cm4-mnt-reform2.dts| 384

[PATCH v11 5/7] arm64: meson: g12-common: add the MIPI DSI nodes

2024-03-25 Thread Neil Armstrong
Add the MIPI DSI Analog & Digital PHY nodes and the DSI control nodes with proper port endpoint to the VPU. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 70 +++ 1 file changed, 70 insertions(+) diff --git a/arch/arm64/boot

[PATCH v11 6/7] arm64: meson: khadas-vim3l: add TS050 DSI panel overlay

2024-03-25 Thread Neil Armstrong
This add dtbo overlay to support the Khadas TS050 panel on the Khadas VIM3 & VIM3L boards. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/Makefile | 4 + .../boot/dts/amlogic/meson-khadas-vim3-ts050.dtso | 108 + 2 files changed,

[PATCH v11 4/7] drm/meson: gate px_clk when setting rate

2024-03-25 Thread Neil Armstrong
Disable the px_clk when setting the rate to recover a fully configured and correctly reset VCLK clock tree after the rate is set. Fixes: 77d9e1e6b846 ("drm/meson: add support for MIPI-DSI transceiver") Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 7

[PATCH v11 3/7] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF

2024-03-25 Thread Neil Armstrong
_encl endpoint. Signed-off-by: Neil Armstrong --- drivers/clk/meson/Kconfig | 1 + drivers/clk/meson/g12a.c | 72 ++- 2 files changed, 53 insertions(+), 20 deletions(-) diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig inde

[PATCH v11 0/7] drm/meson: add support for MIPI DSI Display

2024-03-25 Thread Neil Armstrong
I. The change from v5 is that now we use a "VCLK" driver instead of notifier and rely on CLK_SET_RATE_GATE to ensure the VCLK gate operation are called. Signed-off-by: Neil Armstrong --- Changes in v11: - Rebased on v6.9-rc1 - Fixed overlay handling/creation - Link to v10: https://lo

Re: [RESEND PATCH] dt-bindings: display: sony, td4353-jdi: allow width-mm and height-mm

2024-03-25 Thread Neil Armstrong
Hi, On Mon, 25 Mar 2024 11:32:27 +0100, Krzysztof Kozlowski wrote: > Allow width and height properties from panel-common.yaml, already used > on some boards: > > sdm845-sony-xperia-tama-apollo.dtb: panel@0: 'height-mm', 'width-mm' do not > match any of the regexes: 'pinctrl-[0-9]+' > >

Re: [RESEND PATCH v4 1/3] dt-bindings: display: panel: add common dual-link schema

2024-03-25 Thread Neil Armstrong
Hi, On Mon, 25 Mar 2024 11:36:09 +0100, Krzysztof Kozlowski wrote: > Add schema with common properties shared among dual-link panel ICs. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/3] dt-bindings: display: panel: add common dual-link schema

  1   2   3   4   5   6   7   8   9   10   >